kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
28,089 Commits 41 Branches 6 Tags
4b3735e4d96c4e8a03bf795eafa56fd9219dfa04
Commit Graph

21856 Commits

Author SHA1 Message Date
Uwe
4b3735e4d9 [Part] Section Cut: respect App::Part placement 
if object to be cut are within an App::Part container the container placement needs to be respected

- also fix a performance issue
 2022-03-14 03:32:09 +01:00
Chris Hennes
46cd740269 App: Improve Metadata error handling 
Report XML parse exception details.
 2022-03-13 21:01:47 -05:00
Chris Hennes
4fc8ee56a6 App: Fix Metadata Py constructors 
Also adds unit tests for the corrected Copy and Default constructors.
 2022-03-13 21:01:47 -05:00
Uwe
904bf8fcfe [TD] fix compilation error 2022-03-14 01:13:56 +01:00
Wanderer Fan
37014eb586 [TD]fix unit display to standards 2022-03-13 19:04:42 -04:00
Abdullah Tahiri
ee98a3d87f Sketcher: Some code comments 2022-03-13 19:28:38 +01:00
wmayer
09259451d2 PD: Fix coverity issue: 
* CID 350645: Uncaught exception
 2022-03-13 17:24:07 +01:00
wmayer
d5aa8986f1 Points: Fix several coverity issues: 
* CID 350545: Resource leak
* CID 350553: Resource leak
* CID 350559: Resource leak
* CID 350593: Resource leak
* CID 350604: Resource leak
* CID 350625: Resource leak
* CID 350650: Resource leak
* CID 129019: Division or modulo by float zero (false-positive)
* CID 129020: Division or modulo by float zero (false-positive)
* CID 129021: Division or modulo by float zero (false-positive)
 2022-03-13 16:48:19 +01:00
wmayer
7acdcbd031 PD: Fix several coverity issues: 
* CID 350558: Uninitialized pointer field
* CID 350554: Uninitialized pointer field
* CID 350589: Uninitialized pointer field
* CID 350608: Uninitialized pointer field
* CID 350544: Uncaught exception
* CID 350568: Uncaught exception
* CID 350603: Uncaught exception
* CID 350562: Unchecked dynamic_cast
* CID 350591: Unchecked dynamic_cast
* CID 350583: Unchecked dynamic_cast
* CID 350598: Unchecked dynamic_cast
 2022-03-13 16:32:19 +01:00
wmayer
15ee1fdd4e Part: Fix several coverity issues: 
* CID 350581: Structurally dead code
* CID 350620: Structurally dead code
* CID 350563: Big parameter passed by value
* CID 350552: Uncaught exception
* CID 305193: Uncaught exception
* CID 350556: Uninitialized scalar field
* CID 350579: Uninitialized pointer read
 2022-03-13 16:06:40 +01:00
wmayer
81ea374800 MeshPart: Fix several coverity issues: 
* CID 350570: Uninitialized scalar variable
* CID 350628: Uncaught exception
 2022-03-13 15:50:39 +01:00
wmayer
883012e4b0 TD: Fix several coverity issues: 
* CID 316569: Uninitialized scalar variable
* CID 350651: Unchecked dynamic_cast
* CID 350565: Unchecked dynamic_cast
* CID 350595: Unchecked dynamic_cast
* CID 350638: Unchecked dynamic_cast
* CID 350547: Division or modulo by float zero
 2022-03-13 15:40:49 +01:00
wmayer
69a5bfd6b1 Mesh: Fix several coverity issues: 
* CID 350557: Out-of-bounds read (false-positive)
* CID 316517: Uninitialized scalar variable
* CID 316519: Uninitialized scalar variable
* CID 316547: Uninitialized scalar variable
* CID 316556: Uninitialized scalar variable
* CID 350614: Uncaught exception
* CID 350606: Uncaught exception
* CID 332681: Using invalid iterator
 2022-03-13 14:58:14 +01:00
wmayer
d419b325fb Fem: Fix several coverity issues: 
* make SelectionChangeModes an enum class
* CID 350596: Uninitialized scalar field
* CID 350572: Uncaught exception
* CID 350647: Uncaught exception
 2022-03-13 14:09:04 +01:00
Anders Torger
2e6c4373bf Apply multi-thread configuration for Calculix also when started via task panel 2022-03-13 13:32:30 +01:00
wmayer
5fd93b7d3b Fix several coverity issues: 
* CID 350617: Dereference after null check
* CID 350585: Out-of-bounds read
* CID 350624: Resource leak
* CID 332701: Uncaught exception
* CID 350642: Uninitialized scalar field
* CID 350590: Uninitialized scalar field
* CID 350629: Uninitialized scalar variable
* CID 350602: Uninitialized scalar variable
* CID 350564: Uninitialized scalar variable
* CID 350548: Uninitialized scalar variable
 2022-03-13 12:12:49 +01:00
wmayer
afabaea5cb PD: Fix several coverity issues: 
* CID 350622: Negative array index read
* CID 350613: Negative array index read
* CID 166163: Negative array index read
* refactor Hole::updateDiameterParam()
 2022-03-13 12:10:01 +01:00
Abdullah Tahiri
23f18505f2 Sketcher: Redraw constraints on wheel event 
===========================================

https://forum.freecadweb.org/viewtopic.php?p=577585#p577585
 2022-03-13 11:33:52 +01:00
wmayer
49888175ed Robot: [skip ci] add header with export macros 2022-03-13 08:37:58 +01:00
Ajinkya Dahale
9007662425 [Sketcher] Fix "toggle internal geo" on multi-selection 
Some deleted GeoIds can stay in selection and GeoIds can change as some objects
are deleted.
 2022-03-13 06:58:40 +01:00
sliptonic
73e995a0f7 Merge pull request #6566 from Russ4262/fix/boundary_dressup_begin_safeheight_retraction 
Path: Correct beginning retraction to safe height in Boundary Dressup, issue #6279 [Bug]
 2022-03-12 19:05:39 -06:00
Uwe
25137db5ca [Assembly] fox typos in element names 
all found by the spellchecker CI
 2022-03-13 01:32:27 +01:00
sliptonic
217174d548 Merge pull request #5440 from voneiden/path-array-improvements 
Path: Path Array dressup compatibility
 2022-03-12 18:21:40 -06:00
mwganson
eaf36231eb PartDesign::SubShapeBinder add 2D offsetting 2022-03-12 23:30:09 +01:00
Anders Torger
7d628a6e03 Add General.NumThreads = CPU core count setting to Gmsh 
settings file to enable multi-threaded meshing (much faster
for larger models)
 2022-03-12 23:26:55 +01:00
Matti Eiden
34ed7bc123 PathArray: Support applying PathArray on Dressups 2022-03-12 22:31:16 +02:00
Abdullah Tahiri
bba7c89c2a Sketcher: Coverity 332695 - unlikely array indexing with negative value 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
bcfa246943 Sketcher: Coverity 332679 - logically dead code removed 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
341cf32369 Sketcher: Coverity 332685, 332686, 332696 
=========================================

Detected by coverity as unchanged variable (constant intended).

It was actually an unnecessary variable that prevented correct command committing.
 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
c8a57fb9b4 Sketcher: Coverity 350601 - possible resource leak 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
963cae4a0b Sketcher: Coverity 350637 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
bd84e883cf Sketcher: Coverity 350641 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Russell Johnson
4ae4e7be1a Path: Correct beginning retraction to safe height feed rate, issue #6279 [Bug] 
This commit changes the feed rate of the beginning retraction from G1 at Feed to a G0 Rapid rate.  This initial command is causing a problem with the Tag Dressup due to the first move being a G1 to Safe Height.
 2022-03-12 12:18:09 -06:00
Abdullah Tahiri
7294d4d7a3 Sketcher: move comment to right position 2022-03-12 18:45:16 +01:00
Uwe
c50f2e980c [Assembly] fix typos found by the spellchecker CI 2022-03-12 17:52:33 +01:00
Uwe
931e2a3c17 [Robot] fix some typos found by the spellchecker CI 2022-03-12 17:46:48 +01:00
Abdullah Tahiri
5e88ee99f5 Sketcher: BSpline code review and fix 
=====================================

- Avoid using EditCurve for the double use of storing the pole positions and the last mouse position. Split into individual vector for poles and previous cursor position (with appropriate names).
- Store all pole geoids to better show the intend of the code.
- Avoid indexing when referring the last inserted value of a std::vector, use back() instead.
- Encapsulate code to draw the bspline polygon and the cursor text to the given position. This allow to select the right function for every case, while avoiding unclear names, such as "mousemove()".
- Refactor code to finish command, to avoid calling unclear names such as "releasebutton" to better show the intend of the function call.
- Ensure deleted pole does not appear anymore in the scenograph.
 2022-03-12 15:47:50 +01:00
Uwe
e4777d16f8 [Part] remove unused variable 
MSVC complained about it
 2022-03-12 15:44:27 +01:00
Wanderer Fan
7bef267503 [TD]fix 2 edge angle Dim special case 2022-03-12 08:55:35 -05:00
Chris Hennes
589f074e7d Test: Add first tests for Metadata 2022-03-11 20:15:44 -06:00
Chris Hennes
e7d50f0b13 Addon Manager: Fix window focus issues 2022-03-11 20:07:20 -06:00
mwganson
fc617e1524 Part: 2doffset fix crash by chacking for null shape before adding with builder.Add() 2022-03-12 02:48:22 +01:00
Zheng, Lei
2a28ad5cef PD: add SubShapeBinder 'Refine' property 
Respect setting in BaseApp/Preferences/Mod/PartDesign/RefineModel
 2022-03-12 02:45:13 +01:00
Zheng, Lei
8d6b06bc86 PD: fix SubShapeBinder 'Fuse' function 2022-03-12 02:45:13 +01:00
Uwe
5d798e26cf [Path] fix a typo 2022-03-12 02:24:44 +01:00
Uwe
5dba742beb [Path] 2nd part of the Git fix attempt 
renaming it back
 2022-03-12 02:01:29 +01:00
Uwe
99a0a67867 [Path] next attempt to fix Git error by renaming 
use lowercase letters fro file ending like it is also in the CMake file
 2022-03-12 02:00:40 +01:00
Uwe
76e601a712 [Path] try to silence a git error with a file 
Git has issues with this file telling me it is corrupted and its file ending is wrong (in Git lowercase, in the file uppercase).

The attempt is to just to save save it with FC 0.20.
 2022-03-12 01:55:37 +01:00
wmayer
ec8353ba99 Part: refactor PropertyPartShape::SaveDocFile and PropertyPartShape::RestoreDocFile 
Set exception mask of std::istream::failbit | std::istream::badbit to istream to make sure it raises an exception for corrupted input files.
See: https://forum.freecadweb.org/viewtopic.php?p=536747
 2022-03-11 22:06:38 +01:00
Wanderer Fan
cb5334a98c [TD]fix getScale should be Scale.getValue 2022-03-11 11:59:31 -05:00