Commit Graph

1305 Commits

Author SHA1 Message Date
0penBrain
73f2c1434a Modernize signal/slot connection for real :) 2022-02-08 17:51:36 +01:00
Uwe
91b2b7ce6e [PD] Extrude: modernize SignalSlot connection
as suggested recently by @chennes
2022-02-04 22:20:31 -06:00
Uwe
5d51871373 [PD] Extrude: handle angle edit visibility
- adds missing code to handle the edits for the taper angle
2022-02-05 02:11:14 +01:00
Mark Ganson TheMarkster
abe0c9222a [PartDesign Fillet/Chamfer] add UseAllEdges boolean property (#5340)
- [PartDesign Fillet/Chamfer] add UseAllEdges boolean property
- add UseAllEdges checkbox to fillet and chamfer dialogs
- put UseAllEdges property into Chamfer and Fillet groups, create Fillet group for fillets and put Radius into it, too.
2022-02-05 01:50:51 +01:00
Uwe
12b0e0dd92 [PD] add option to create tapered Pad / Pocket
This PR adds the same functionality as provided by Part Extrude.
The used code parts are sorted out to a new helper function that is used by Part and PartDesign.
2022-02-02 01:04:06 +01:00
Yorik van Havre
d7c5800da2 Merged crowdin translations 2022-02-01 12:59:42 +01:00
wmayer
62734ca415 PD: PrefQuantitySpinBox now requires an explicit entry name for the parameter group 2022-01-31 16:47:08 +01:00
Yorik van Havre
233182dcd6 Merged crowdin translations 2022-01-26 14:15:14 +01:00
Uwe
849751a771 Revert "[PD] uniform default Pad/Pocket lengths"
This reverts commit ab879eff243c3c5ed7f8c250db32522e5aff329c.

Sorry, this should have gone to a PR
2022-01-23 05:06:38 +01:00
Uwe
de3bc18247 [PD] uniform default Pad/Pocket lengths
- the goal of the recent Pad/Pocket code refactoring was to handle Pad and Pocket the same
  default Pad were 10 long, Pocket only 5 -> uniform this to 10
- the initialization of the length were different than the default set in Command.cpp
- it was annoying that the default 2nd length was 10 and 20 times the default for the 1st length -> uniform and take the same than the 1st length
2022-01-23 04:58:58 +01:00
Uwe
874767171a [PD] correct copyright year
both files were created in 2021
2022-01-23 04:45:12 +01:00
0penBrain
015b229162 [PartDesign] Allow single (viewport) click for mapping feature selection
Parameter 'singleClickFeatureSelect' can be used to enable/disable
2022-01-22 16:14:30 +01:00
0penBrain
68e1fc46b6 Display Midplane checkbox with Pocket/ThroughAll
Was enabled but not visible.
Hopefully last time I fix it. :)
2022-01-22 10:34:14 +01:00
wmayer
8db8126dd5 PD: move ReferenceHighlighter to Part module 2022-01-18 18:24:02 +01:00
Ajinkya Dahale
faa6cfa402 [PD] Correct include guard name
Correction in `PartDesignGui::ReferenceHighllighter`
2022-01-18 03:01:20 +01:00
wmayer
be020c8d9d PD: fix crash in thickness dialog when clicking 'Add Face' button 2022-01-16 18:59:26 +01:00
wmayer
b35623e680 App: Bugfix for NULL-Pointer dereference of Property->getName() 2022-01-16 14:30:51 +01:00
Chris Hennes
5e87b15782 Part Design: Missing = 2022-01-14 09:38:45 -06:00
Uwe
1e9ddc5302 [PD] Pad/Pocket: sort out duplicated code
the checkboxes are almost identical and it avoids work to have them in one location
2022-01-14 13:17:25 +01:00
wmayer
13234d7e63 PD: fix small inconsistence, use forwared declaration 2022-01-14 12:22:16 +01:00
Ajinkya Dahale
9c4c40856f [PD] Use buttonToggled signal in PD pipe
Combines other button toggle methods/signals/slots involved.
2022-01-13 22:31:05 -05:00
Ajinkya Dahale
fd0be8bccd [PD] Use Gui::ButtonGroup in TaskDlgPipeParameters 2022-01-13 22:31:05 -05:00
Uwe
26a36f6b75 [PD] sort out more Pad/Pocket code
as suggested in #5349
2022-01-10 14:33:02 +01:00
Yorik van Havre
c24ca51a44 Merged crowdin translations 2022-01-10 11:23:59 +01:00
Uwe
74e36f3e0c [PD] Pad /Pocket: remove unused code 2022-01-08 03:24:09 +01:00
Uwe
c1d3cb5fee [PD] Pad/Pocket: fix reverse behavior
- bring back intended behavior as in FC 0.19:
 - if 2 lengths, then midplane is invisible
 - if reversed checked, then no symmetric and if symmetric then no reverse
- unify the code for Pad and Pocket (reversed is always visible)
- fix a typo in a bool name
2022-01-08 01:15:23 +01:00
Uwe
734bb426bf [PD] Hole: fix angle constraints
- all 3 angles cannot be >= 180°
- also add missing minimum in UI for taper angle
2022-01-07 20:38:05 +01:00
Uwe
b40ab916bc [PD] rename a UI file
Pad and Pocket share the same UI file therefore change the name to make this clear that changes in that file must be handled for Pad and Pocket
2022-01-07 20:36:29 +01:00
Uwe
5f59b5e37f [PD] correct copyright
these files were added by Werner in 2020
2022-01-06 21:56:53 +01:00
Uwe
d660bce346 [PD] Hole: some coding style fixes
all done by MSVC
2022-01-06 16:18:25 +01:00
Uwe
55421ce9cb [PD] add missing hole constraint
- add missing constraint for hole diameter
- add missing sets of angle constraints in the task dialog
2022-01-06 15:39:13 +01:00
mwganson
6be358fdfa [PartDesign] Chamfer and Fillet, select all edges for the user when no subobjects have been selected prior to executing command 2022-01-05 01:40:10 +01:00
Jonas Bähr
ccb03cadd5 PD: helix cleanup: remove unused strings from task panel ui
Since the tool tips are now set from the property descriptions we don't
need them any more in the .ui file. Removing them prevents garbage in
the translation source files.
2022-01-03 11:40:29 +01:00
Jonas Bähr
5266ecf36f PD: Use the helix property docs as tooltip in the task panel
By reusing the property docs as tooltip we avoid maintaining the same
information in two places. The propery descriptions have been made
translatable, too, to ensure a fully translatable UI.
The ground work for this was layed by the work on Issue 0002524, long
time ago: https://tracker.freecadweb.org/view.php?id=0002524
2022-01-03 11:40:29 +01:00
wmayer
7d748d958d PD: [skip ci] remove obsolete TaskPocketParameters.ui 2022-01-01 11:50:43 +01:00
wmayer
1d021345f3 PD: fix bug in TaskDressUpParameters::KeyEvent and simplify code 2021-12-31 17:03:16 +01:00
wmayer
fd8f860223 [skip ci] fix some typos 2021-12-31 14:03:51 +01:00
mwganson
a324b33104 [PartDesign] for chamfer and fillet, add SelectAllEdges option in the context menu while in add or remove mode 2021-12-31 14:01:43 +01:00
Yorik van Havre
91bfb0fbb6 Merged crowdin translations 2021-12-29 12:20:12 +01:00
Zheng, Lei
a349765893 PartDesign: show error on SubShapeBinder CopyOnChange failure
The failure is not obivous as it would have been occurred in a
hidden temporary document.
2021-12-21 21:41:02 -07:00
Zheng, Lei
73d0de60ae PartDesign: expose SubShapeBinderPython 2021-12-21 21:41:02 -07:00
Zheng, Lei
11f9d1c472 PartDesign: support CopyOnChange in SubShapeBinder 2021-12-21 21:41:02 -07:00
Uwe
25558880ce [PD] hole dialog improvements
- no keyboard tracking
- don't disable labels since we don't do this for the other dialog labels
- avoid a doubled word in subsequent labels
- further UI file changes are by Qt's Designer
2021-12-22 02:46:07 +01:00
Uwe
99765c53a8 [PD] fix several hole thread issues
- actually use specified thread depth, fixes issue reported here: https://github.com/FreeCAD/FreeCAD/pull/4274#issuecomment-997787744
- fixes 2 UI enabling issues
- the thread depth cannot be longer than the hole depth
- the hole cannot be deeper than the through-all depth
2021-12-22 01:09:06 +01:00
wmayer
2c8ae49f48 PD: [skip ci] improve readability of argument list 2021-12-19 22:02:08 +01:00
Uwe
b0bf7f5e5f [PD] style improvements for Helix
all done automatically by MSVC
2021-12-19 17:52:33 +01:00
Jonas Bähr
cfb3e7eaf6 PD: Fix assignment of Angle/Growth properties
Depending on the input mode, either `Growth` or `Angle` is used to create
a conical or flat spiral. The respective other can easily be calculated
to give consistent view. This is already done for the other properties,
e.g. `Height` is calculated from `Pitch` and `Turns`.
With this patch, the same is done for `Angle` and `Growth`.
2021-12-19 16:21:51 +01:00
luz paz
1a56a24d07 PD: Adjust header uniformity 2021-12-16 23:55:48 +01:00
wmayer
fb3448536e PD: support of wires in ReferenceHighlighter 2021-12-15 16:25:06 +01:00
wmayer
317e0b11bf PD: do not throw an exception in TaskSketchBasedParameters::make2DLabel as otherwise editing a broken loft/pipe won't be possible 2021-12-15 15:36:36 +01:00