kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
24,368 Commits 41 Branches 6 Tags
4e5c852a9b772a6c082d03777f18e5a84b39775c
Commit Graph

2430 Commits

Author SHA1 Message Date
Yorik van Havre
78ce247a29 Merge pull request #4549 from chennes/lgtmFixDraftLocalizeVectors 
[Draft] Fix localize_vectors double definition
 2021-03-04 12:27:05 +01:00
David Osterberg
c1b3fba031 Beautify xml step 1: These changes do not affect the uic output 2021-03-02 16:29:11 +01:00
Chris Hennes
4ebdff9d9c [Draft] Fix localize_vectors double definition 
LGTM identified an instance where a function was defined twice: in this
case, one version was intended to take a list of items and the second
version just a single item. Because they share the same name and number
of arguments, the second definition overrode the first. This causes no
problems in the current code because the version that takes a list is
never used. However, for consistency with the analogous
"globalize_vectors" and "globalize_vector" functions, the "localize*"
versions are changed to match that pattern. All calls in are
converted to the singular use.
 2021-03-01 09:36:21 -06:00
Chris Hennes
26ce308cf1 [DRAFT] Add call to super().__init__ where missing 
Identified by LGTM. The toplevel superclass does initialize one data
member to an empty array, but this didn't appear to cause any problems.
 2021-02-27 18:21:54 +01:00
Yorik van Havre
fa85db61f9 Merged crowdin translations 2021-02-25 13:27:48 +01:00
Yorik van Havre
5c12afb5b5 Merged crowdin translations 2021-02-24 18:07:59 +01:00
Yorik van Havre
74c280ae40 Merge branch 'master' into Draftutils_BugFixes_01 2021-02-23 11:45:23 +01:00
David Osterberg
a243ce6346 Draft: Fix PathTwistedArray bug 2021-02-22 08:01:34 +01:00
Yorik van Havre
335cc13d48 Draft: Applied patch from nahshon - fixes misc errors from translation fixes 2021-02-15 15:50:45 +01:00
David Osterberg
9dd96ed107 Draft: Fix regressions in Draft array 2021-02-14 01:20:06 +01:00
wmayer
ac6d06dd84 Draft: fix syntax errors 2021-02-13 12:14:12 +01:00
Yorik van Havre
0de8cceb53 Updated ts files 2021-02-12 14:47:37 +01:00
Yorik van Havre
abee35f38a Draft: Fixed broken translations everywhere 2021-02-12 14:44:58 +01:00
paul lee
998511e8f5 [Draft.draftutils.groups] get_windows() to support Links 
FC Forum Discussion - https://forum.freecadweb.org/viewtopic.php?f=23&t=55438
 2021-02-12 09:59:28 +08:00
Chris Hennes
a7522c384e [DRAFT] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
Yorik van Havre
97379e035a merged crowdin translations 2021-02-09 16:12:18 +01:00
Yorik van Havre
5d18625677 Updated master TS files 2021-02-08 16:35:41 +01:00
Yorik van Havre
96dc265f5b Merge pull request #4341 from hyarion/feature-error-handling-get_svg 
[0.19] [Draft] Add better error message in get_svg for direction
 2021-02-08 16:08:18 +01:00
marioalexis
ae4ef332ff Draft: Correct the placement in scale_with_clone - fixes #0004113 2021-02-06 23:42:22 -03:00
Amritpal Singh
7d5ce50fdd Draft: Fix bug in getCubicDimensions function 2021-02-04 22:57:31 +05:30
luz paz
19d0e1123f Draft: fix LGTM 'Testing for None should use the 'is' operator' alerrts 
https://lgtm.com/projects/g/FreeCAD/FreeCAD/alerts/?mode=tree&ruleFocus=7900090
 2021-02-03 21:58:47 +01:00
Yorik van Havre
85f9d82937 Merge pull request #4331 from chennes/openSCADFix 
[Draft] OpenSCAD/DXF error: fix DXF import with no layers
 2021-02-02 14:01:43 +01:00
Benjamin Nauck
ce7856d51f [Draft] Add better error message in get_svg for direction 
An AttributeError is raised when `direction=Vector(0,0,0)` and obj is
an Arch::Space on line: a3fb3cc804/src/Mod/Draft/draftfunctions/svg.py (L799)

This patch checks if early on if the direction vector and raises a
ValueError with a description of what has gone wrong.

A caveat with this solution is that this new behaviour might break old
code which depends on that invalid directions can be used.
 2021-01-31 20:24:59 +01:00
Stefan Tröger
ec5ac30756 Remove ExtensionProxy and rely on default Python proxy for extensions. fixes #0004534 2021-01-30 16:00:48 +01:00
Chris Hennes
cbceb87d95 Fix DXF import with no layers 
As discussed in https://forum.freecadweb.org/viewtopic.php?f=3&t=54842, if OpenSCAD creates a DXF with no layers in it, the code that is supposed to handle that in FreeCAD has a minor type error in it that prevents the import from working.
 2021-01-29 17:01:22 -06:00
Roy-043
b6976b3b23 [Draft] Fix snap to center of faces of solids 
The code would only find a center snap on the face with index=0 of solids.

In V0.19 Part.getShape was introduced (line 399). But not all consequences were not fully implemented.

In the '# we are snapping to an edge' section (line 411) the code could be cleaned up. There is no need to check if the index of the edge is correct for the parent object since we are no longer dealing with a parent object. That portion was effectively dead code.

The '# we are snapping to a face' section (line 429 in the revised code) has been modified accordingly, which fixes the bug.

Forum discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=54747
 2021-01-25 15:33:36 +01:00
marioalexis
875c0d8612 Draft: Prevent Draft_Wire from setting a single-edge wire as closed 2021-01-22 01:16:40 -03:00
Yorik van Havre
7b10771b7c Draft: Don't snap to ImagePlanes 2021-01-12 15:31:55 +01:00
Yorik van Havre
2cf3a15101 Draft: Added import/export buttons to Annotation styles editor dialog 2021-01-05 16:54:06 +01:00
Yorik van Havre
4da2b5b273 Merge pull request #4216 from marioalexis84/draft-draftify 
Draft: Replace Part.getSortedClusters by Part.sortEdges in draftify function
 2021-01-04 12:33:55 +01:00
Yorik van Havre
c7a0eb6724 Merge pull request #4235 from marioalexis84/draft-facebinder 
Draft: Fix multiple crashes when using modification functions - fixes #0004243, #0003971
 2021-01-04 12:30:56 +01:00
carlopav
f97e7aec3c Draft: change in default Draft.makeCopy 
always copy with dependencies when copying App::Part and PartDesign::Body
.
 2021-01-03 15:10:29 +01:00
marioalexis
739daccd8d Draft: Fix multiple crashes when using modification functions - fixes #0004243 2021-01-02 02:15:43 -03:00
marioalexis
045accd3f2 Draft: Replace Part.getSortedClusters by Part.sortEdges in draftify function 2020-12-29 23:21:33 -03:00
luz paz
439bf8960d Fix typos [skip ci] 
Found via `codespell v2.1.dev0`
 2020-12-23 14:32:38 -05:00
Yorik van Havre
bdd9c23af7 Reverting files wrongly committed with 11beceea8 2020-12-23 15:21:43 +01:00
Yorik van Havre
22f7d5f3bc Merged crowdin translations 2020-12-23 15:13:05 +01:00
Yorik van Havre
16effcb2af Updated ts files 2020-12-23 14:51:04 +01:00
Yorik van Havre
ee07d63ef7 Merge pull request #4142 from DinoMesina/master 
Draft: Correct placementFromDXFOCS()
 2020-12-23 14:24:21 +01:00
luz paz
abd502ac53 Fix typo found via Crowdin [skip ci] 
https://crowdin.com/translate/freecad/548/en-eu?filter=basic&value=3#6585264
 2020-12-21 13:18:13 +01:00
Dino del Favero
81af227868 Merge branch 'master' into master 2020-12-15 21:41:59 +01:00
Yorik van Havre
5bccc5c588 Draft: Small layer improvements 
- Added 'Print Line Color' property
- Added 'Add new layer' context menu action to layers group
 2020-12-15 16:43:33 +01:00
Yorik van Havre
1d83dc3007 Draft: Small wording fix 2020-12-15 16:41:35 +01:00
Yorik van Havre
481937f034 Draft: Small fixes to Draft SetStyle panel 2020-12-15 16:40:16 +01:00
Dino del Favero
cabb1f81b4 Merge branch 'master' into master 2020-12-14 22:24:50 +01:00
Yorik van Havre
f54b452327 Draft: Hide undo button from modify operations 2020-12-14 15:21:25 +01:00
Yorik van Havre
d74e4c09d6 Merge pull request #4116 from chennes/fixAirfoilImportNumberRegex 
[Draft] Fix airfoil data detection regex
 2020-12-14 12:29:50 +01:00
Yorik van Havre
578c8f967f Merge pull request #4115 from JAndersM/patch-1 
[Draft] Update task_scale.py
 2020-12-14 12:21:47 +01:00
Yorik van Havre
b168dfaec9 Merge pull request #4100 from marioalexis84/draft-upgrade 
Draft: Improve makeWires in upgrade function
 2020-12-14 11:59:21 +01:00
Chris Hennes
371af865a9 Merge branch 'master' into fixAirfoilImportNumberRegex 2020-12-13 23:02:36 -06:00