Commit Graph

17605 Commits

Author SHA1 Message Date
wmayer
a2926df471 MeshPart: [skip ci] fix segmentation fault in flatmesh when built with boost.python 2020-07-29 13:44:45 +02:00
wandererfan
980ecc87a3 [TD]Dim blocks selection of geometry 2020-07-28 15:09:40 -04:00
sliptonic
4bfa602368 Merge pull request #3700 from etrombly/deletedFaces
[Path] handle makeOffset2D exception in path pocket operation
2020-07-28 11:50:27 -05:00
sliptonic
ed9c94d9b6 Merge pull request #3585 from gwicke/unified_region_experiments
Path: Area based unified projection implementation
2020-07-28 11:48:56 -05:00
J-Dunn
2be614895f Merge branch 'master' into master 2020-07-28 14:47:39 +01:00
wmayer
cd5341001e remove superfluous includes of iostream, use iosfwd instead 2020-07-28 15:22:23 +02:00
J-Dunn
0c3006e77c prevent added paths creating tool crash #4260 #3028
In this path dressup a bogus machine position is used to get an initial edge, this results in a path element which does reflect the input path data and can lead to a tool crash. This PR checks whether X and Y actually come from the input path data and prevent new path elements being added until true machine position has been set. 
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=15&t=42820
2020-07-28 14:12:11 +01:00
felix
4329ccd1ed [TechDraw] Add context to zh_CN README file for description changes
[skip-ci]
2020-07-28 08:39:48 -04:00
felix
0190e8d276 [TechDraw] Add all sizes (landscape/A3/A4 portrait) template PRoC files
Add all landscape template files in landscape directory.
create new directory portrait and put A3/A4 portrait
template files to the directory.
2020-07-28 08:39:48 -04:00
felix
d39b4dfcda [TechDraw] Delete v0.001 of all landscape PRoC template files
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=17&t=48854
2020-07-28 08:39:48 -04:00
Bernd Hahnebach
ebaac63777 Arch IFC import, add simplificated method to get pset properties 2020-07-28 06:00:31 +02:00
sliptonic
c10275b439 Merge pull request #3689 from etrombly/edgesMatchShape
[PATH] fix pocket attribute error if edge cannot be flipped
2020-07-27 12:53:37 -05:00
wmayer
244d7aae41 LGTM: [skip ci] fix: Inconsistent definition of copy constructor and assignment ('Rule of Two') 2020-07-27 14:39:14 +02:00
wmayer
3b0eeb63e8 LGTM: [skip ci] fix: Inconsistent definition of copy constructor and assignment ('Rule of Two')
Remove user-defined copy constructor of Exception classes without assignment operator
2020-07-27 13:47:41 +02:00
wmayer
4dd32ce143 LGTM: [skip ci] fix: Missing header guard 2020-07-27 11:16:41 +02:00
wmayer
44f42a8e2c LGTM: [skip ci] fix: Declaration hides parameter
A local variable hides a parameter. This may be confusing. Consider renaming one of them.
2020-07-27 10:57:34 +02:00
donovaly
e727cd3754 also avoid leading newlines 2020-07-26 19:47:25 -04:00
donovaly
d7ee728be3 assure the translation
- also fix a typo
2020-07-26 19:47:25 -04:00
donovaly
5e6e03b6fa improve coding style 2020-07-26 19:47:25 -04:00
donovaly
2b33e7776d [TD] get rid of trailing newlines
as discussed with luzpaz in https://github.com/FreeCAD/FreeCAD/pull/3735
there shouldn't be trailing newlines in translated strings.

- Moreover fix the logic of the output dialog text
2020-07-26 19:47:25 -04:00
wandererfan
21becb4e7a [TD]remove obsolete QPointF (LGTM) 2020-07-26 19:45:49 -04:00
wandererfan
cb90b6a112 [TD]remove obsolete QGraphicRectItem (LGTM) 2020-07-26 19:45:49 -04:00
wandererfan
04f1842308 [TD]remove obsolete QGraphicsSVGItem (LGTM) 2020-07-26 19:45:49 -04:00
wandererfan
9dac347fc7 [TD]fix Dim selection fails to clear prev selection 2020-07-26 19:45:49 -04:00
Bernd Hahnebach
a6df94e37f FEM: show result, make it possible to use the menu and icon if there is a pure result object in a document. 2020-07-26 23:40:21 +02:00
wmayer
48f9085746 LGTM: [skip ci] fix: Local variable hides global variable
A local variable or parameter that hides a global variable of the same name.
This may be confusing. Consider renaming one of the variables.
2020-07-26 19:30:24 +02:00
donovaly
8dc95874a2 [TD] add 2 shortcuts for dimensions
as discussed here: https://forum.freecadweb.org/viewtopic.php?f=35&t=48980
2020-07-26 11:22:06 -04:00
wmayer
dc65b055e5 LGTM: [skip ci] fix: Empty branch of conditional
An empty block after a conditional can be a sign of an omission and can decrease maintainability of the code.
Such blocks should contain an explanatory comment to aid future maintainers.
2020-07-26 15:49:14 +02:00
wandererfan
8dac7e4666 [TD]fix misaligned PAT hatch on section 2020-07-25 10:30:13 -04:00
wmayer
584a1bf442 LGTM: [skip ci] fix: Resource not released in destructor 2020-07-25 14:48:59 +02:00
wmayer
16edad7afd LGTM: [skip ci] fix: Accidental rethrow 2020-07-24 20:57:14 +02:00
wmayer
d300d148c9 LGTM: [skip ci] fix: Function declared in block 2020-07-24 20:37:17 +02:00
wmayer
9a1a06c94b LGTM: [skip ci] fix: Duplicate include guard 2020-07-24 20:22:00 +02:00
wmayer
47d570716c LGTM: [skip ci] fix: Non-virtual destructor in base class 2020-07-24 19:30:12 +02:00
wmayer
d5d7d65bfc LGTM: [skip ci] fix: Large object passed by value 2020-07-24 18:32:31 +02:00
SurajDadral
75ba0b8a77 Add Mark property to ArchRebar object
As discussed here:
https://forum.freecadweb.org/viewtopic.php?f=23&t=44580&p=418377#p418630
And required for reinforcement drawing/dimensioning.
2020-07-24 13:50:29 +02:00
luz paz
752f84046c Crowdin: Edits based on feedback from translators [skip-ci]
https://crowdin.com/translate/freecad/27911/en-en#6581566  
https://crowdin.com/translate/freecad/6766/en-en#6584432  
https://crowdin.com/translate/freecad/549/en-en#6578092
2020-07-24 13:49:59 +02:00
vocx-fc
3c35504deb Arch: improve import and export IFC preferences pages
Some tooltips are made more readable by adding newlines.

For `IFC import`, better tooltip for the `Number of cores` option;
also the `Replace 'Project'...` option.

For `IFC export`, better tooltip for the `Export type`;
also `IFC file units`.
Also add `General options` in case other options are added.
2020-07-24 13:48:44 +02:00
Yorik van Havre
b06c38a22d Merge branch 'master' of github.com:FreeCAD/FreeCAD 2020-07-23 14:16:47 +02:00
Mark Ganson TheMarkster
0491fa4ab9 coverity issue cid 305102 2020-07-23 13:55:32 +02:00
carlopav
1911453aa1 Arch: touch Axis when key property change
This allow experimental wall to auto align to the new axis position.
2020-07-23 13:54:18 +02:00
luz paz
f20ab1765f Fix Crowdin typos + trim superfluous whitespace [skip-ci]
Some issues that this PR fixes (but not all listed):  
https://crowdin.com/translate/freecad/27911/en-en#6581578  
https://crowdin.com/translate/freecad/27911/en-en#6579080  
https://crowdin.com/translate/freecad/27911/en-en#6581580  
https://crowdin.com/translate/freecad/27911/en-en#6579086
2020-07-23 13:52:44 +02:00
Jean-Marie Verdun
4851947bc0 Remove unnecessary pre-processor directive
Signed-off-by: Jean-Marie Verdun <jmverdun3@gmail.com>
2020-07-23 13:47:21 +02:00
Jean-Marie Verdun
0b1af7c838 Add App::Link support to Cloud module
ONLY enabled if the Cloud Module is compiled into FreeCAD
    ALL files must be saved into a Cloud Based storage
    Add a Signal to the PropertyLink to enable support of external storage
    Put the Assembly Document as active document

Signed-off-by: Jean-Marie Verdun <jmverdun3@gmail.com>
2020-07-23 13:47:21 +02:00
wmayer
cb2099aa6b Part: optimize ViewProviderPartExt::getNormals 2020-07-22 20:33:17 +02:00
Gabriel Wicke
5c6de6dd14 Path: Area based unified projection implementation
Generalize the `extractFaceOffset` method to `getOffsetArea`, which can
handle both face offsetting and projection. Another difference is that
the new method exposes Area's ability to preserve internal holes,
defaulting to preserving. The method is moved to the PathUtils module,
reflecting its generality and fairly wide used across Path.

This method is then used to provide a drop-in alternative to
`FindUnifiedRegions` via a small wrapper in PathSurfaceSupport. The Area
implementation is generally quick, but can fail (throw) in some cases,
so the wrapper is trying the Area method as an optimization first, and
falls back to the full `FindUnifiedRegions` logic if that fails.
2020-07-21 18:34:09 -07:00
Bernd Hahnebach
886d9656f0 FEM: solver frame work, beside dir fix 2020-07-21 22:12:16 +02:00
Bernd Hahnebach
d30862b7ba FEM: unit tests, fix z88 for installed FC 2020-07-21 20:54:30 +02:00
sliptonic
7202749809 Merge pull request #3709 from etrombly/3dSurface
[Path] fix two never ending while loops in PathSurfaceSupport
2020-07-21 10:58:48 -05:00
Bernd Hahnebach
d30e4a5088 Arch: import ifc, use the new layer make command since the dereciated one does not create layers on import 2020-07-21 15:18:41 +02:00