Commit Graph

51 Commits

Author SHA1 Message Date
Bas Ruigrok
8a54dd304d Gui: Fix rotation mode for Gesture style 2024-06-04 21:57:15 +02:00
Bas Ruigrok
98320cc839 Gui: Improve lookAtPoint (#13556)
* Gui: Rename NavigationStyle::pan to setupPanningPlane

* Gui: Replace duplicate code with NavigationStyle::setupPanningPlane

* Gui: Use panning plane when hit point not found in lookAtPoint

Also enables navigation animations when pressing MMB while the mouse is not over an object

* Gui: Remove unused methods
2024-05-06 10:45:14 -05:00
Rexbas
f1fde08b3b Gui: Fix rotation center indicator for Gesture styles 2023-10-09 22:30:05 +02:00
wmayer
6beace8da6 Gui: modernize C++: use default member init 2023-08-23 19:51:44 +02:00
wmayer
888a33917d Gui: modernize C++: use equals default 2023-08-20 18:12:43 +02:00
berniev
ae53c9b0a4 Gui: Use auto and range-based for (#7481)
* On lines where the variable type is obvious from inspection, avoid repeating the type using auto. 
* When possible use a ranged for loop instead of begin() and end() iterators
2022-09-14 13:25:13 -05:00
wmayer
23961706be Gui: modernize C++: replace 'typedef' with 'using' 2022-08-29 14:09:18 +02:00
berniev
3877fc62c3 Gui: Single arg ctors must be explicit (PR #7369) 2022-08-24 15:06:03 +02:00
wmayer
81ce5cb8ce Gui: revert changes of 3fd70d378b for GestureNavigationStyle 2022-08-09 23:50:05 +02:00
berniev
75fa455c5d Gui: Use override etc 2 2022-08-09 12:43:23 +02:00
berniev
2db561561e Gui: use empty 2022-08-06 16:35:45 +02:00
0penBrain
1c16e512db [BUGFIX] Gui: fix mouse Gesture navigation mode
Regression introduced by commit 5ce0bb7
2022-06-24 01:03:53 +02:00
Uwe
0828d769e8 [Gui] remove unnecessary Boolean comparisons 2022-06-19 15:17:01 +02:00
Chris Hennes
5df3dbae6f Gui: PR6497 move return statement to new line 2022-03-29 12:33:50 -05:00
wmayer
b78dc894e1 Core: Fix several coverity issues:
* CID 350582: Big parameter passed by value
* CID 350639: Big parameter passed by value
* CID 305234: Uncaught exception
* CID 316529: Uncaught exception
* CID 350597: Uncaught exception
* CID 350623: Uncaught exception
* CID 332690: Uncaught exception
* CID 332700: Unchecked return value
* CID 350576: Uninitialized scalar field
* CID 350587: Uninitialized scalar variable
* CID 192606: Uninitialized scalar field
* CID 332699: Uninitialized pointer field
* CID 350561: Dereference null return value
* CID 350610: Dereference null return value
* CID 350567: Dereference after null check
2022-03-13 13:53:32 +01:00
Uwe
efa589c7c5 [Gui] Navigation styles: remove unused includes 2022-03-03 02:25:21 +01:00
wmayer
3ba49908d4 Mouse navigation: change unnecesary messages to log messages 2021-12-31 19:09:15 +01:00
Adrian
7f0bc597a5 Mouse navigation: change unnecesary warnings to messages
sent when trying to set rotation center without an object under the cursor and can be annoying if report view is set to show with warnings.
2021-12-30 15:46:38 +01:00
luz paz
6c265d0453 Use correct name spacemouse so it's uniform and searchable in our code
Make all mentions of `spacemouse` in the code a single word (with no whitespace) so we can parse the source code more accurately to find mentions of it if necessary.
2021-12-06 10:31:06 +01:00
wmayer
befd78afd1 Gui: move handling of SoMouseWheelEvent to its own handler function 2021-11-05 21:37:19 +01:00
wmayer
4c1ddafb15 Gui: [skip ci] add method NavigationStyle::syncModifierKeys() to reduce code duplication 2021-11-02 14:52:22 +01:00
wmayer
c14190b918 Gui: avoid code duplication in NavigationStyle and remove superfluous doZoom_wheel method 2020-08-22 18:44:47 +02:00
DeepSOIC
a41a5042ae Gui: use SoMouseWheelEvent in navigation styles 2020-08-22 17:15:02 +02:00
wmayer
983939b32d Coverity: Uninitialized scalar/pointer field 2020-07-20 17:34:30 +02:00
wmayer
794eb3f6f2 Gui: [skip ci] in Gesture style handle release instead of press events for the keys: H, PgUp, PgDown
For more details see: https://forum.freecadweb.org/viewtopic.php?f=8&t=42408&start=10#p361248
2020-01-17 15:06:17 +01:00
wmayer
5746c37b7e fix -Wcatch-value=, fix -Wpedantic 2019-09-18 14:36:23 +02:00
wmayer
9fa56345cf core system
force strict ISO C++ (-Wpedantic)
TODO: still a lot of variadic macros are not valid ISO C++
2019-09-18 01:01:14 +02:00
DeepSOIC
65e5adac42 Gui: Gesture: stop reacting to gestures on Macs
Gesture event processing causes problems on macs. Disabling for now.

https://forum.freecadweb.org/viewtopic.php?f=9&t=36387&start=10#p314575
2019-07-14 00:13:27 +02:00
DeepSOIC
dd25a37b0f Gui: GestureNavigationStyle: logging option
To enable logging, execute:

App.ParamGet("User parameter:BaseApp/Preferences/View").SetBool("NavigationDebug",True)
2019-05-27 19:37:04 +03:00
DeepSOIC
5e63edde31 Revert "Gui: GestureNavigationStyle: remove logging"
This reverts commit 27d1bbfd3de5cf99324262cdc12ce148fe60a64d.
2019-05-27 19:37:04 +03:00
luz.paz
92bf2228d9 Misc. typo fixes
Found via `codespell -q 3 -I ../fc-word-whitelist.txt -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller -L pard,wallthickness,commen,byteorder,alocation`
2019-05-17 13:19:36 +02:00
DeepSOIC
3a22758051 Fix build with boost 1.65.1 on ubuntu 18.04
reported to me privately by @fjullien
2019-05-15 13:10:52 +03:00
DeepSOIC
a0aa8ace52 Gui: GestureNavigationStyle: remove logging 2019-05-14 15:35:50 +02:00
DeepSOIC
fd9630c4a0 Gui: GestureNavigationStyle rewrite
to better work on Qt5
+ new (dormant) feature: button roll gestures
2019-05-14 15:35:50 +02:00
luz.paz
2ce03a55c6 [WIP] Crowdin: fixes pre-0.18 release
Includes some whitespace fixes as well
2019-01-30 11:08:03 -02:00
Mateusz Skowroński
ec7d24e035 Fix GCC 8 warning: type qualifiers ignored on cast result type [-Wignored-qualifiers] 2018-12-23 11:05:02 -02:00
DeepSOIC
47ae980fa2 Gui: Gesture: add option to disable tilt
On Qt5, using pinch will inevitably cause tilt. It's annoying, so it is disabled by default.

In the future, it's best to introduce some kind of threshold to overcome for the tilt to be triggered.
2018-11-29 15:29:27 -03:00
DeepSOIC
dadf0e80a9 GestureNavigationStyle: fix interaction with SoClipPlaneManip 2018-09-11 00:38:06 +03:00
luz.paz
9167064fc1 Misc. typos
Found via `codespell`
2018-04-25 09:41:33 -03:00
wmayer
b502d764fd fixes #0003394: Crash on gesture rotation with focus 2018-03-30 15:24:57 +02:00
Mateusz Skowroński
dee8769d0e Fix some GCC 7 warnings:
* dynamic exception specifications are deprecated [-Wdeprecated]
* this statement may fall through [-Wimplicit-fallthrough=]
2017-12-05 17:22:00 +01:00
luzpaz
a225b13bef Misc. typos
- Tooltip uniformity 
- source comment typo fixes
- remove double whitespaces
2017-11-24 09:45:08 -02:00
DeepSOIC
7cf1cfb63e Gui: GestureNav: disable rotation when over a dragger 2017-05-06 12:48:26 +03:00
DeepSOIC
e1c68e59a6 Gui: GestureNav: fix constant hand cursor 2017-05-06 02:15:45 +03:00
Mateusz Skowroński
6942c23895 Qt4's qglobal.h defined TRUE and FALSE. Qt5 does not do it anymore. Replace it with true and false.
158f39ec78

This change is Qt4/Qt5 neutral.
2016-01-05 16:43:33 +01:00
wmayer
4a176cbe29 + fix various warnings 2015-08-29 22:05:09 +02:00
wwmayer
6bf065c097 + fix many minor warnings, activate -Wall for gcc 2015-08-02 22:32:18 +02:00
DeepSOIC
3baafccb60 GestureNav: bug fix (tilting) + kill messagebox
Fixed a bug where starting tilting with LMB+RMB with LMB in sketcher
caused odd behavior.
No more messagebox upon hitting H key when the cursor is over nothing
(replaced with a warning). The messagebox was very annoying when trying
to hunt a point with touch input.
2015-04-07 00:57:24 +03:00
DeepSOIC
3d2e364317 GestureNav: bug fix (gesture lockup in sketcher)
Navigation by gestures didn't work after double-clicking a constraint in
sketcher to edit a value. This was probably caused by the last mouse
button release event not reaching the viewer.
2015-04-07 00:57:23 +03:00
wmayer
697dd741d4 + fix various things 2015-03-31 23:08:12 +02:00