kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
30,505 Commits 41 Branches 6 Tags
5367aa8ab263e45944d26a1f7fbc988e38e59d13
Commit Graph

49 Commits

Author SHA1 Message Date
Uwe
5367aa8ab2 [TD] remove redundant nullptr checks 2022-10-03 04:25:33 +02:00
wmayer
af8421c1fb TD: remove unused member variables to fix -Wunused-private-field 2022-09-08 08:15:19 +02:00
wandererfan
aa2b1b8392 [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Wanderer Fan
aa1193559b [TD]clazy warnings and duplicate setter/getter 
- clazy warning re missing Q_OBJECT

- include TechDrawGlobal.h in headers

- resolve duplicate setter/getters
 2022-08-18 09:34:32 -04:00
Wanderer Fan
b467cd32f2 [TD]refactor scene/view/mdi 
- move scene related functions out of mdiViewPage
  and QGVPage.
- route requests for scene/view/mdi through
  ViewProviderPage
 2022-08-18 09:34:32 -04:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Benjamin Bræstrup Sayoc
f30c30b06f [TechDraw] Simplify code getting default line weights 2022-08-02 16:13:01 -04:00
Uwe
5486c9808d [TD] remove some more superfluous nullptr checks 2022-07-20 02:53:48 +02:00
Uwe
15ec3e2cda [TD] Gui: remove more superfluous nullptr checks 2022-07-19 03:40:32 +02:00
Uwe
b514f47c21 [TD] Gui: remove some superfluous nullptr checks 2022-07-19 02:49:46 +02:00
Benjamin Bræstrup Sayoc
9c0c565ecb [TechDraw] Improve readability of TaskRichAnno.cpp 2022-07-15 11:31:11 -04:00
Wanderer Fan
db89eec8e3 [TD]implement navigation styles 2022-06-24 10:03:02 -04:00
Chris Hennes
84ae226ec6 TD: PR6497 move return statement to new line 2022-03-29 13:26:01 -05:00
wmayer
ccc0d54d97 TD: [skip ci] activate PCH of TechDraw (Gui) and use forward declarations 
For MSVC this reduces compile time by ~20%
 2022-03-25 13:54:47 +01:00
Uwe
5757cdf2ad [TD] remove a single-header file 2022-03-25 04:11:53 +01:00
wmayer
e8f9c8a1d3 TD: modernize C++11 
* use nullptr
 2022-03-23 19:26:14 +01:00
andrea reale
83d3a916c0 remove QT4 references 2022-03-19 23:07:38 +01:00
wmayer
8f786ea6ef Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Wanderer Fan
d4c5074ee5 [TD]remove redundant edits from 9 Task dialogs 2022-01-22 14:51:20 -05:00
luz paz
d13e450343 [TD] Renamed SpreadsheetView, RichTextAnnotation, SectionView... 
`Quadrants`, `DetailView`, `ShowAll`
 2021-04-17 11:38:10 +02:00
Chris Hennes
bd86b4dcfe [TD] Remove deprecated Qt < 5.9 code 2021-04-02 12:02:54 +02:00
wmayer
5c4fcaef1d TD: [skip ci] Fix coverity warning 
Coverity warnings fixed:

CID 316559 (#1 of 1): Uninitialized scalar variable (UNINIT)
3. uninit_use_in_call: Using uninitialized value we. Field we.idx is uninitialized when calling push_back

CID 316549 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member pageheight is not initialized in this constructor nor in any functions that it calls.

CID 186161 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member parent is not initialized in this constructor nor in any functions that it calls.

CID 305170 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking this->m_baseFeat suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

CID 186152 (#2 of 2): Uninitialized pointer field (UNINIT_CTOR)
3. uninit_member: Non-static class member m_mdi is not initialized in this constructor nor in any functions that it calls.

CID 192588 (#1 of 1): Same on both sides (CONSTANT_EXPRESSION_RESULT)
pointless_expression
 2021-02-21 16:30:30 +01:00
donovaly
691eaa6e8f [TD] make pointers to the UI std::unique_ptr 
as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all TD dialogs that don't already use a unique_ptr.
 2021-01-19 19:24:27 +01:00
donovaly
4bae944950 [TD] make LineGroup selectable 
At the moment one has to specify the LineGroup as string. But one doesn't know what groups exist. So one has to check the Wiki, learn there where the groups are defined and then open the definition file with a text editor.

This PR simplifies this by reading the existing groups out of the definition file and fill the combobox accordingly.
It also give the user info what the selected LineGroup defines via the tooltip.

A nice side effect is that no typos can occur since you don't have to enter the LineGroup name as text.
 2020-12-03 17:24:49 +01:00
luz paz
89664642fb TD: Issue #0004473: Expose openCommand() to translation 
Continuing the work to expose the undo/redo functionality to translation. This commit does so for the TechDraw Wb.  
Ticket: https://tracker.freecadweb.org/view.php?id=4473
 2020-12-01 14:53:35 +01:00
luz paz
ae71abd1cc TechDraw: Header uniformity and whitespace fixes 2020-11-14 16:59:51 +01:00
wmayer
2588d0701a Coverity: [skip ci] Dereference before null check 2020-07-21 14:31:09 +02:00
wmayer
983939b32d Coverity: Uninitialized scalar/pointer field 2020-07-20 17:34:30 +02:00
wmayer
ba683bf241 Coverity: Dereference null return value 2020-07-20 17:34:26 +02:00
wmayer
1ae38aea04 PVS: V522 There might be dereferencing of a potential null pointer 2020-07-18 10:59:27 +02:00
wandererfan
a3029fec74 [TD]Centralize preference getters 2020-04-24 11:13:49 -04:00
donovaly
29c6aaa0b8 [TD] use Gui::QuantitySpinBox in dialogs 
as recently discussed

- also add lost alignment properties
 2020-03-28 08:51:12 -04:00
wandererfan
3a2fd3c2f3 [TD]fix RTA edit when no MDI 2020-02-16 14:24:14 -05:00
Zheng, Lei
e1a6100bac TechDraw: remove duplicated fix 2020-02-11 15:40:27 -05:00
Zheng, Lei
5b3c63c9be TechDraw: fix build for qt4 2020-02-11 15:40:27 -05:00
wmayer
c81f88d7d7 TechDraw: [skip ci] user visible text should be translated 2020-02-03 13:41:35 +01:00
donovaly
66c9166618 [TD] TaskRichAnno tr to fix Qt4 build 2020-02-03 07:20:52 -05:00
donovaly
dc76b7fb5c [TD] set default text size for RichAnno dialog 
see https://forum.freecadweb.org/viewtopic.php?f=35&t=42414&p=364965#p364965
 2020-01-31 08:35:38 -05:00
wandererfan
c4394eadc6 [TD]Default color and weight for markup lines 2020-01-29 15:26:06 -05:00
donovaly
922c955218 [TD] fix regression with line width I introduced today 2020-01-28 21:07:49 -05:00
donovaly
853dc6d884 [TD] improve RichAnno and LeaderLine dialog 
see: https://forum.freecadweb.org/viewtopic.php?f=35&t=42746&p=364126#p364126
 2020-01-28 12:40:56 -05:00
donovaly
ce06f31435 [TD] rename some Draw* elements - try 2 
as discussed here: https://forum.freecadweb.org/viewtopic.php?p=360042#p360042
 2020-01-18 06:57:29 -05:00
wandererfan
0b4f82f280 [TD]fix parenting in Tree 2020-01-15 15:46:37 -05:00
wandererfan
1458e49e13 [TD]Cleanup dead code in TaskRichAnno 2020-01-15 07:17:18 -05:00
wandererfan
cc1b5736d9 [TD]fix jumping Rich Text Annotation 2019-12-04 10:16:19 -05:00
donovaly
896f1c25b7 TD renaming tools, part 2/2 
as discussed in https://forum.freecadweb.org/viewtopic.php?p=344899#p344800
we need a more consistent naming for the Wiki
 2019-11-17 08:22:09 -05:00
wandererfan
f47422d366 Remove Surplus VP properties 
- color, size and font info are embedded in the rich text
 2019-05-17 19:35:25 -04:00
wandererfan
de24943885 Pass font/fontsize to RT editor 2019-05-05 21:01:31 -04:00
wandererfan
c1f9f11c27 Leader and RichText block improvements 2019-05-05 21:01:31 -04:00