Commit Graph

51 Commits

Author SHA1 Message Date
Uwe
5486c9808d [TD] remove some more superfluous nullptr checks 2022-07-20 02:53:48 +02:00
Uwe
b514f47c21 [TD] Gui: remove some superfluous nullptr checks 2022-07-19 02:49:46 +02:00
Benjamin Bræstrup Sayoc
47b98c0684 [TechDraw] Improve readability of TaskProjGroup.cpp 2022-07-15 11:31:11 -04:00
Chris Hennes
84ae226ec6 TD: PR6497 move return statement to new line 2022-03-29 13:26:01 -05:00
wmayer
ccc0d54d97 TD: [skip ci] activate PCH of TechDraw (Gui) and use forward declarations
For MSVC this reduces compile time by ~20%
2022-03-25 13:54:47 +01:00
wmayer
e8f9c8a1d3 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Benjamin Bræstrup Sayoc
7edfd902a3 Improve code simplicity/readability 2022-02-01 09:10:36 -05:00
luz paz
f1eb1ff44e [TD] Renamed ProjectionGroup, Hatch, GeomericHatch 2021-04-17 11:38:10 +02:00
donovaly
691eaa6e8f [TD] make pointers to the UI std::unique_ptr
as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all TD dialogs that don't already use a unique_ptr.
2021-01-19 19:24:27 +01:00
luz paz
ae71abd1cc TechDraw: Header uniformity and whitespace fixes 2020-11-14 16:59:51 +01:00
wmayer
9424395afc PVS: V1004 A pointer was used unsafely after it was verified against nullptr 2020-07-18 10:59:27 +02:00
donovaly
eb6a8e5339 [TD] add spacing to ProjGroup dialog
Add the setting to auto-distribute projections to the dialog
2020-06-21 08:22:49 -04:00
donovaly
97e1274b00 Merge branch 'master' of github.com:FreeCAD/FreeCAD into TD-DetailWork 2020-05-09 01:36:49 +02:00
wandererfan
8b7d9ee749 [TD]handle ProjectionAngle changes 2020-04-24 11:13:49 -04:00
donovaly
ec58acb7df [TD] some Detail View fixes
see https://forum.freecadweb.org/viewtopic.php?f=35&t=45236&p=388925#p388925 for a description of the changes
2020-04-18 14:56:01 +02:00
wmayer
e14e5b845e [skip ci] use QLocale class consistently to make it possible to change it application-wide 2020-03-26 16:37:45 +01:00
donovaly
056ff6d1b6 TD renaming tools
as discussed in https://forum.freecadweb.org/viewtopic.php?p=344899#p344800
we need a more consistent naming for the Wiki
2019-11-17 08:22:09 -05:00
wandererfan
251e16b6f1 [TD]Transition to on demand page updates ph1 2019-10-23 14:19:52 -04:00
Zheng, Lei
ecc857cdf1 TechDraw: fix projection group editing update 2019-08-17 15:32:51 +02:00
wandererfan
db3a69ba11 Remove superfluous updates
- under certain conditions, unnecessary screen paints
  were being performed.
2019-03-07 10:58:28 +01:00
wandererfan
cf738047d4 Fix double scaling in DPG AutoScale 2018-09-26 16:59:39 +02:00
wandererfan
f2c6edbb19 Fix late repaint of secondary views
- when ScaleType=Automatic and Scale changes
  individual views were not being repainted until
  next document recompute.
2018-09-26 16:59:12 +02:00
wandererfan
95f95d54fb Use Face or 3D direction for View and ProjGroup
- use current 3D window direction as starting
  direction for DrawViewPart and ProjectionGroup
- if a Face is selected, use Face normal as
  starting direction.
2018-09-06 08:00:00 +02:00
TeroK
442892ffa7 Fixed indentation 2018-01-07 18:39:47 -02:00
TeroK
c5e5958a6e Fixes #3294 TechDraw: Prevent scale changing
Now scale number changing controls are disabled by default and enabled only in
Custom Scale mode.

Previously user was all time allowed to edit scale numerical values.
But this had effect on the size of generated views in drawing page only
when scale type was set to Custom.
2018-01-07 18:39:47 -02:00
WandererFan
857aca5e8b Fix calculation of integer scale
- conversion of <double> scale to/from integer scale
  n:d was generating odd fractions and overflowing
  spinboxes in ui.
2017-11-12 19:08:33 -05:00
WandererFan
e35e2f2573 Eliminate superfluous DPG executes 2017-09-10 15:22:49 +02:00
WandererFan
c5c42e74a7 Coverity fixes
151677
151789  - OK as is
152005
152508
154871  - false positive
156593
163235
2017-07-17 19:47:44 -03:00
WandererFan
4c4e1e3210 Replace DPG table lookup logic with calculations
DPG used a pair of large tables to determine view
direction and rotation vector when subject was rotated
and spun.  There were many errors in the tables that
needed manual checking to correct.  The new version
uses calculations on a virtual glass cube to find view
direction and rotation vector.
2017-06-23 08:14:46 +02:00
WandererFan
190ab71055 Fix potential race when cancelling DPG creation 2017-01-29 19:40:34 -05:00
WandererFan
01b34749a9 Section directions from rotated DPGI's 2016-12-29 14:43:37 +01:00
WandererFan
920eb5eaf7 Working revolving part DPG 2016-12-29 14:43:25 +01:00
WandererFan
2dd56a6c2a Reset/Match 3d buttons working 2016-12-29 14:43:13 +01:00
WandererFan
09f701786f Working proof of concept for DPG rots & dirs 2016-12-29 14:43:00 +01:00
wmayer
7b3de466bf fix CIDs 154889, 151939, 151763, 154892, 154891, 151802, 151936, 151803, 153359 2016-12-18 14:12:13 +01:00
wmayer
07a180b18f fix CIDs 154873, 154874, 153875, 153876, 154883, 154884, 154886 2016-12-18 13:27:34 +01:00
WandererFan
54798d3641 Remove old debug message 2016-12-08 14:51:10 -05:00
WandererFan
bddd9e0e19 Prevent crash when no document open 2016-12-04 15:26:54 +01:00
WandererFan
efb7f14866 DPG improvements
eliminate orientation matrix
remove appl logic from dialog
add 3D/Front buttons
2016-12-04 15:25:47 +01:00
WandererFan
a2cd878708 Improve ProjectionGroup dialog
Text to icons in dialog
Fix rotation directions
2016-12-04 15:25:32 +01:00
wmayer
06da15e643 + add convenience method recomputeFeature()
+ make method recompute() protected
2016-11-06 17:16:50 +01:00
WandererFan
b3c3d7a950 Rename "Document" selection value to "Page" 2016-10-31 11:06:15 -02:00
WandererFan
200ed7a675 Fix ProjectionGroup Automatic scaling 2016-10-31 11:06:15 -02:00
WandererFan
7c4ad55ed6 Correct delayed update when adding views to ProjectionGroup 2016-10-31 11:06:15 -02:00
wmayer
6148bf4df5 fix -Wextra & -Wdeprecated in TechDraw 2016-09-22 19:32:16 +02:00
WandererFan
3182ad1754 Fix #2692 TaskProjectGroup cancel button 2016-09-11 13:12:24 -04:00
WandererFan
e264a16b62 Fix ProjectionGroupItem spacing 2016-09-01 12:14:42 -04:00
WandererFan
27aafada9c Include file cleanup per cppclean analysis 2016-07-14 14:39:06 +02:00
WandererFan
c57379aa03 Fix #41 Projoection Group Spacing
Fix glitch when change First <-> Third Angle
2016-07-11 15:32:16 +02:00
WandererFan
ebc19e7215 misc /Mod/Drawing, QGI, obs functions 2016-07-11 15:32:16 +02:00