kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
30,639 Commits 41 Branches 6 Tags
5ca5a94f5efa76112dbf06978c9dfd2fa962e9f2
Commit Graph

2481 Commits

Author SHA1 Message Date
sliptonic
22d23f0d6c Merge pull request #6651 from sliptonic/bug/5956 
[Path] Fix # 5956.
 2022-03-24 09:05:39 -05:00
sliptonic
e0f5e2837f Expose PocketLastStepOver property 
Property can be useful to fine tune the last stepover for some shapes
 2022-03-23 15:10:34 -05:00
Uwe
56dd1f1ff0 [Path] Fixes #5832 
Remove unused and confusing spiral and triangle patterns
 2022-03-23 10:35:58 -05:00
Russell Johnson
d8a8084c29 Path: Fix Face Region with no Base 
This fix addresses an incorrect shape variable passed when Boundary Shape is set to Face Region and there is no Base geometry - indicating entire model to be milled.
 2022-03-22 18:16:31 -05:00
sliptonic
837589ef4f Merge pull request #6612 from mlampert/bugfix/bag-of-minor-isssues 
PATH: Bugfix/bag of minor isssues
 2022-03-21 08:34:23 -05:00
Markus Lampert
115fbd68bb Blanket black formatting for Path python files 2022-03-20 13:23:48 -07:00
Markus Lampert
75e5dc95d5 Fixed read-only state of quantity spin box when expression is 'clear'ed 2022-03-20 13:23:48 -07:00
markus
6751212dd0 Fixed setting a face's normal as the axis for model alignment 2022-03-20 13:23:48 -07:00
Russell Johnson
50117a57de Path: Simplify changes per developer conversations 
Also update TestPathDepthParams.py to reflect simplification of changes.
Remove some comments.
Employ `sorted()` function per MLampert suggestion
 2022-03-20 14:25:17 -05:00
sliptonic
cf64b06c89 simpler way to filter roughly equal depth values 2022-03-20 14:25:16 -05:00
Russell Johnson
abdb4eea86 Path: Fix roughly equal depth entries 
Add code block to remove first of any two consecutive, roughly equal depth values (twin values).

Add two unit tests to support new code block and use cases.
 2022-03-20 14:25:14 -05:00
luz paz
773bd041e9 Path: remove superfluous 'pass' per LGTM 
ref: https://lgtm.com/rules/910088/
 2022-03-19 20:06:48 -04:00
sliptonic
b25eaec2e5 Merge pull request #6575 from Russ4262/fix/rebuild_empty_job_with_gui 
Path: Extend Job integrity check to GUI side, issue #6207 [Bug]
 2022-03-19 15:44:28 -05:00
Russell Johnson
61888959e2 Path: Change action to warning with option for action. 2022-03-16 11:47:51 -05:00
Russell Johnson
b2ab3d7c48 Path: Correct comment spelling 2022-03-16 11:40:24 -05:00
Russell Johnson
4e8d93ee72 Path: Extend Job integrity check to GUI side, issue #6207 [Bug] 
This commit adds a simple `_jobIntegrityCheck()` method to verify that a model and tool exists within the Job object, when interacting with the Task Panel.  If either is missing, the appropriate tab is activated in the task window, and the appropriate edit window is opened for the user, with messages printed in the report view window.

Add check for existence of `SetupSheet` property of empty Job object.

These changes improve upon fixes in PR #5008 and related bug fixes.
 2022-03-16 11:40:23 -05:00
sliptonic
6309575591 [Path] Warn user if enabling legacy tools 
Warn user if opening job that contains legacy tools
 2022-03-15 11:05:20 -05:00
sliptonic
4b49c87650 Merge pull request #6577 from Russ4262/fix/millface_removalshapes 
Path: Fix `self.removalshapes` declaration [Bug]
 2022-03-15 09:26:39 -05:00
sliptonic
da2b77d611 Merge pull request #6576 from Russ4262/fix/cancel_new_dressup_cleanup 
Path: Fix automatic `commitTransaction()` calls, issue #6149 [Bug]
 2022-03-15 09:25:43 -05:00
sliptonic
86539bf6db Merge pull request #6571 from Russ4262/fix/tag_dressup_radius_value 
Path: Fix inconsistent float type usage, issue #6170 [Bug]
 2022-03-14 09:26:24 -05:00
Russell Johnson
4e9f7b0b62 Path: Fix self.removalshapes declaration [Bug] 
Prior to this fix, the `self.removalshapes` variable is not declared if `obj.Base` does not exist, or is empty.  This moves the declaration up in scope to the method level.
 2022-03-12 22:34:03 -06:00
Russell Johnson
2bc14f84aa Path: Fix automatic commitTransaction() calls, issue #6149 [Bug] 
This commit removes the automatic committal of transactions when activated with GUI command.  The committal of the transaction is executed with the `accept()` and `reject()` methods of the respective task panel.
 2022-03-12 22:05:04 -06:00
Russell Johnson
68d20e7e90 Path: Improve value assignment syntax for radius 2022-03-12 20:00:40 -06:00
sliptonic
73e995a0f7 Merge pull request #6566 from Russ4262/fix/boundary_dressup_begin_safeheight_retraction 
Path: Correct beginning retraction to safe height in Boundary Dressup, issue #6279 [Bug]
 2022-03-12 19:05:39 -06:00
Russell Johnson
ba4611a260 Path: Fix radius type inconsistency, issue #6170 [Bug] 
Make `self.radius` a float type throughout since other methods and functions treat it as such.
 2022-03-12 18:29:21 -06:00
Matti Eiden
34ed7bc123 PathArray: Support applying PathArray on Dressups 2022-03-12 22:31:16 +02:00
Russell Johnson
4ae4e7be1a Path: Correct beginning retraction to safe height feed rate, issue #6279 [Bug] 
This commit changes the feed rate of the beginning retraction from G1 at Feed to a G0 Rapid rate.  This initial command is causing a problem with the Tag Dressup due to the first move being a G1 to Safe Height.
 2022-03-12 12:18:09 -06:00
sliptonic
da2dcaa7f4 Merge pull request #6552 from Russ4262/fix/leadin_leadout_simulation 
Path: Fix Leadin-Leadout dressup simulation related to arcs [Bug]
 2022-03-11 10:06:42 -06:00
sliptonic
14949faf06 Merge pull request #6541 from Russ4262/fix/ramp_entry_dressup 
Path: Fix enumeration dictionary error [Bug]
 2022-03-11 10:04:53 -06:00
Russell Johnson
a52e63b934 Path: Fix Leadin-Leadout dressup simulation related to arcs 
Add missing "Z" and "K" parameters for arc commands to appease Path simulator.
 2022-03-10 20:05:52 -06:00
Russell Johnson
c1529aba40 Path: Fix enumeration dictionary error 
This commit corrects an incorrect dictionary key in the enumeration dictionary updated with recent translation fixes.
 2022-03-09 21:03:34 -06:00
sliptonic
e0c0590631 fixes #5954 
Make headers less confusing and ambiguous
 2022-03-08 08:40:05 -06:00
sliptonic
714cab8f6f fixes 6114 
replaces DlgJobChooser with QInputDialog.
 2022-03-07 17:51:00 -06:00
sliptonic
ee8193322c Merge pull request #6485 from mlampert/feature/external-thread-milling 
Path: Feature/external thread milling
 2022-03-04 12:52:31 -06:00
sliptonic
9028976d16 Merge pull request #4911 from sliptonic/feature/nopathjob 
[Path] Make Job and Operation visibility more natural
 2022-03-04 12:51:25 -06:00
Markus Lampert
c02dedbb3c Split out thread milling generator into its own file 2022-03-04 10:42:34 -08:00
sliptonic
69a17578d3 black format 2022-03-04 10:42:34 -08:00
Markus Lampert
2baca43e17 Removed debugging gates 2022-03-04 10:42:34 -08:00
Markus Lampert
2df74990eb Fixed UI update upond changing the thread type 2022-03-04 10:42:34 -08:00
Markus Lampert
eef8fd4f48 Fixed multi pass for external threads with proper lead in/out 2022-03-04 10:42:34 -08:00
Markus Lampert
a1117040b3 Changed passes for constant tool engagement 2022-03-04 10:42:34 -08:00
Markus Lampert
00d2341748 Disabled debugging comments 2022-03-04 10:42:34 -08:00
Markus Lampert
263eeffd71 Fixed lead in/out with elevator location. 2022-03-04 10:42:34 -08:00
Markus Lampert
c12748d8c4 Added thread generation unit tests and fixed finishing the thread 2022-03-04 10:42:34 -08:00
Markus Lampert
67dbb8675a Some code cleanup 2022-03-04 10:42:34 -08:00
Markus Lampert
8e38a80aa8 Added imperial external and split data files according to tolerance classes 2022-03-04 10:42:34 -08:00
Markus Lampert
bdeb5776b0 First shot at external thread milling 2022-03-04 10:42:34 -08:00
sliptonic
b08cb1f7b7 Merge pull request #6480 from sliptonic/bug/velocitywarn 
[Path] Fix bug with velocity warning.
 2022-03-01 08:18:10 -06:00
Markus Lampert
37095fbf78 Consistent black formatting of all Path python files 2022-02-28 21:06:16 -08:00
Markus Lampert
122fd49b37 Remove pylint annotations and script 2022-02-28 21:02:45 -08:00