Commit Graph

32 Commits

Author SHA1 Message Date
Wanderer Fan
d4c5074ee5 [TD]remove redundant edits from 9 Task dialogs 2022-01-22 14:51:20 -05:00
wmayer
5c4fcaef1d TD: [skip ci] Fix coverity warning
Coverity warnings fixed:

CID 316559 (#1 of 1): Uninitialized scalar variable (UNINIT)
3. uninit_use_in_call: Using uninitialized value we. Field we.idx is uninitialized when calling push_back

CID 316549 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member pageheight is not initialized in this constructor nor in any functions that it calls.

CID 186161 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member parent is not initialized in this constructor nor in any functions that it calls.

CID 305170 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking this->m_baseFeat suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

CID 186152 (#2 of 2): Uninitialized pointer field (UNINIT_CTOR)
3. uninit_member: Non-static class member m_mdi is not initialized in this constructor nor in any functions that it calls.

CID 192588 (#1 of 1): Same on both sides (CONSTANT_EXPRESSION_RESULT)
pointless_expression
2021-02-21 16:30:30 +01:00
donovaly
691eaa6e8f [TD] make pointers to the UI std::unique_ptr
as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all TD dialogs that don't already use a unique_ptr.
2021-01-19 19:24:27 +01:00
donovaly
4bae944950 [TD] make LineGroup selectable
At the moment one has to specify the LineGroup as string. But one doesn't know what groups exist. So one has to check the Wiki, learn there where the groups are defined and then open the definition file with a text editor.

This PR simplifies this by reading the existing groups out of the definition file and fill the combobox accordingly.
It also give the user info what the selected LineGroup defines via the tooltip.

A nice side effect is that no typos can occur since you don't have to enter the LineGroup name as text.
2020-12-03 17:24:49 +01:00
luz paz
89664642fb TD: Issue #0004473: Expose openCommand() to translation
Continuing the work to expose the undo/redo functionality to translation. This commit does so for the TechDraw Wb.  
Ticket: https://tracker.freecadweb.org/view.php?id=4473
2020-12-01 14:53:35 +01:00
luz paz
ae71abd1cc TechDraw: Header uniformity and whitespace fixes 2020-11-14 16:59:51 +01:00
wmayer
2588d0701a Coverity: [skip ci] Dereference before null check 2020-07-21 14:31:09 +02:00
wmayer
983939b32d Coverity: Uninitialized scalar/pointer field 2020-07-20 17:34:30 +02:00
wmayer
0a6929a122 Coverity: Dereference after null check 2020-07-20 17:34:25 +02:00
wandererfan
a3029fec74 [TD]Centralize preference getters 2020-04-24 11:13:49 -04:00
wandererfan
03d36e3a40 [TD]correct button text 2020-03-24 18:16:23 -04:00
wandererfan
a564c468f0 [TD]fix Leader end type selection 2020-03-23 09:23:08 -04:00
wandererfan
2d404558a7 [TD]fix Leader attach point secondary views 2020-03-23 09:23:08 -04:00
donovaly
baf6dc50e7 [TD] make LeaderLine dialog show changes immediately 2020-03-22 09:37:04 -04:00
donovaly
e16a452c3d [TD] fix order of arrow heads
see https://forum.freecadweb.org/viewtopic.php?f=35&t=44334#p378675
2020-03-21 09:44:07 -04:00
wandererfan
b493b3841d [TD]harmonize Arrow enums 2020-03-11 09:33:54 -04:00
donovaly
47def896a1 [TD] LeadlerLine dialog beautifications
(add tooltips, use a display widget)

see https://forum.freecadweb.org/viewtopic.php?f=35&t=43360&p=369885#p369885
2020-02-18 07:36:59 -05:00
wandererfan
9e6d1ad077 [TD]fix LL edit when no MDI 2020-02-16 14:24:14 -05:00
WandererFan
06357db88d [TD]sync icon names and menu entries
- contributed by @uwe
2020-02-03 07:20:52 -05:00
wandererfan
c4394eadc6 [TD]Default color and weight for markup lines 2020-01-29 15:26:06 -05:00
donovaly
922c955218 [TD] fix regression with line width I introduced today 2020-01-28 21:07:49 -05:00
donovaly
853dc6d884 [TD] improve RichAnno and LeaderLine dialog
see: https://forum.freecadweb.org/viewtopic.php?f=35&t=42746&p=364126#p364126
2020-01-28 12:40:56 -05:00
donovaly
ce06f31435 [TD] rename some Draw* elements - try 2
as discussed here: https://forum.freecadweb.org/viewtopic.php?p=360042#p360042
2020-01-18 06:57:29 -05:00
wandererfan
0b4f82f280 [TD]fix parenting in Tree 2020-01-15 15:46:37 -05:00
wandererfan
eaa42b0dcd [TD]fix leader line display attributes 2020-01-14 06:41:35 -05:00
wandererfan
b11df24e86 [TD]Restore context menu after leader edit 2019-08-22 17:11:55 -04:00
wandererfan
db257df76c [TD]Remove tracker on Cancel 2019-06-26 08:19:12 -04:00
wandererfan
fc904288a5 Fix point edit when attach point changed 2019-05-24 22:18:32 -04:00
wandererfan
f7c0f32830 Fix regression in LeaderLine initial position 2019-05-19 13:25:57 -04:00
wandererfan
e555e8d97d Fix Leader point edit 2019-05-16 06:32:44 -04:00
wandererfan
d150467018 Fix QGEPath selection area 2019-05-09 07:31:31 -04:00
wandererfan
c1f9f11c27 Leader and RichText block improvements 2019-05-05 21:01:31 -04:00