kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
26,601 Commits 41 Branches 6 Tags
63138c67ea6d78ba4b65eb8195100b662128398c
Commit Graph

20767 Commits

Author SHA1 Message Date
luz paz
63138c67ea Path: fix file header uniformity 2021-12-10 02:36:56 +01:00
wmayer
1e71c7ce5b Test: explicitly switch on undo/redo mode in testIssue4649 2021-12-10 00:04:40 +01:00
wmayer
c618f069a1 Test: disable a test that fails in command line mode 2021-12-09 21:32:02 +01:00
wmayer
5dc14d2e48 Test: add unit test for issue 0004649 2021-12-09 18:47:38 +01:00
luz paz
430aadb791 Fix various typos and grammatical refinements 2021-12-09 08:57:52 -06:00
wmayer
5575ae5e09 Part: [skip ci] 0004665: Part/projection tool : Unhandled unknown exception caught when mouse gets over a datum plane 2021-12-09 14:16:06 +01:00
wmayer
9f2b6c5ec6 PD: 0004699: ShapeBinder still touched after recompute 2021-12-09 12:33:09 +01:00
Yorik van Havre
e83843ce82 Merge pull request #5223 from Roy-043/Draft_fix_task_panel_issues 
Draft fix task panel issues
 2021-12-09 11:16:45 +01:00
wmayer
b7237f6876 PD: 0004582: Mulit-transformation dialog cannot be cancelled 2021-12-09 06:13:25 +01:00
Roy-043
21a8c21020 Draft: fix regression draftlink.py (#5220) 
* Draft: fix regression draftlink.py

This PR fixes a regression introduces with #5180.

Using transformShape is the correct solution.
 2021-12-08 07:37:23 -06:00
luz paz
bcc2873fb9 Draft: fix doxygen typos 2021-12-07 22:53:54 -06:00
Paul Lee
c5c5c8a880 [ArchWall] Do not copy shape 
Discussions-
https://forum.freecadweb.org/viewtopic.php?style=1&t=62968&p=540585
234899409f
 2021-12-07 18:55:43 -06:00
Abdullah Tahiri
f7deb780a5 Sketcher: Addition of layerId field to SketcherGeometryExtension, GeometryFacade and ExternalGeometryFacade, and their Python wrappers 2021-12-07 16:30:55 +01:00
Abdullah Tahiri
01d37cdaad Sketcher: move GUI common utility functions to a new file Utils.h 
=================================================================

Common utility functions used by almost all Command classes were previous in Constraint.h.

Aside from providing a very bad intent, it created unnecessary header dependencies.

This commit separates these common functions into a new header, utils.h, which is then
used in all command classes where it is necessary.
 2021-12-07 16:30:55 +01:00
Abdullah Tahiri
ffa6f0c50f Sketcher: CommandSketcherTools add missing include that was indirectly satisfied 2021-12-07 16:30:53 +01:00
Abdullah Tahiri
0e286af509 Sketcher: ConstraintType enum indicate underlying type 
======================================================

This enables forward declaration
 2021-12-07 16:30:53 +01:00
Abdullah Tahiri
0331b8a0ab Sketcher: SketchObject - method to getCompleteGeometry as GeometryFacade 
========================================================================

As GeometryFacade is provided with more sketcher specific functionality, the demand
for to get GeometryFacades instead of Part::Geometry object increases too. This
addition reflects this increase of demand.
 2021-12-07 16:30:53 +01:00
Abdullah Tahiri
9a6e12b73d Sketcher: Move GeoEnum struct to separate file 
==============================================

Separate struct into own file to avoid having to include all the dependencies of SketchObject in other code that relies on GeoEnum.
 2021-12-07 16:30:53 +01:00
Abdullah Tahiri
feba33a9b8 Sketcher: Create GeoList class 
==============================

Class for managing internal and external geometry as a single object. This is a light-weight alternative to
passing the whole SketchObject.

It reflects the format used in getCompleteGeometry of SketchObject and Sketch solver facade class, while providing
several convenient conversion functions to map indices.

Internal and external geometries are present in a single geometry vector one after the other.

The index of the geomlist (all layers) and the GeoId can be converted from each other at needed
using the member fuctions (and sometimes the static member functions).

Internal implementation is as a template GeoListModel<T>.

The following types are instantiated. Specialisation is provided where necessary.

GeoList = GeoListModel<Part::Geometry *>;
GeoListFacade = GeoListModel<std::unique_ptr<const Sketcher::GeometryFacade>>;

This enables to use the lighter GeoList were sufficient, while enabling off-the-shelf replacement
when switching to a GeoListFacade is necessary.
 2021-12-07 16:30:53 +01:00
Abdullah Tahiri
cc94820a06 Sketcher: GeometryFacade Improvements 
===============================================

1. Correct GeometryFacade getGeometry for const objects.
2. Modifications to avoid exceptions on the constructors.
3. Add default move constructor and move assignment operator.
4. Delete default copy constructor and copy assigment operator.
 2021-12-07 16:30:53 +01:00
Abdullah Tahiri
a16cbdc7a4 Part: Geometry - Curve member to calculate the normal at Point 
==============================================================

Convenience member function combining closestParameter and normalAt using parameter.
 2021-12-07 16:30:53 +01:00
Abdullah Tahiri
80f9793344 Part: Geometry - Extend Geometry Curve to query the value at parameter point directly from D0 
=============================================================================================

Use the geometry specific D0 to calculate value at parameter point.
 2021-12-07 16:30:53 +01:00
Abdullah Tahiri
70757f8ae3 Sketcher: Constraint.h - add underlying type to PointPos enum 
==============================================================

This enables forward declarations.
 2021-12-07 16:30:53 +01:00
wmayer
a6838cf58f Gui: rename methods of SelectionObserver to clarify intention in client code 2021-12-07 14:17:07 +01:00
wmayer
8424c9323b PD: enable selection only on request and disable it after selecting an object 2021-12-07 13:06:48 +01:00
wmayer
90db4c885b PD: eliminate the boolean argument from TaskSketchBasedParameters::onSelectReference 2021-12-07 11:04:22 +01:00
wmayer
c1289a0d6f PD: 0004759: Bad error message when creating pad with 0 length 2021-12-07 10:09:11 +01:00
Uwe
242531b1c2 [PD] improve selection mode exit for Helix 
exit the selection mode if selection was got - like we do it for all other PD features
 2021-12-07 04:18:33 +01:00
Uwe
31abf0a3e6 [PD] fix calculation of possible Helix intersections 
the current routine fails for the growth mode.

This PR fixes this by handling this case separately from the other modes.
 2021-12-07 03:19:35 +01:00
wmayer
a20383af34 Part: 0004742: Editing features by context menu may not be undoable 2021-12-06 19:34:52 +01:00
wmayer
a12695e44f Gui: move methods startDefaultEditMode() and addDefaultAction() to ViewProviderDocumentObject 2021-12-06 19:24:26 +01:00
wmayer
d360917583 PD: 0004742: Editing features by context menu may not be undoable 2021-12-06 14:11:10 +01:00
Uwe
dd639cbe8d [PD] fix division by zero in Helix 
- when a helix is defined in the growth mode it can have a pitch of zero

This commit fixes the resulting division by zero by directly setting the known turns
 2021-12-06 02:40:34 +01:00
Uwe
9abe56741a [PD] Helix: improve variable naming 
use unique variable names
 2021-12-05 21:59:06 +01:00
Uwe
6dc5358a2e [PD] rewrite a Helix function 
rewrite the function to check if helix might intersect itself to make it better readable/understandable
 2021-12-05 21:28:52 +01:00
Uwe
45db2195d3 [PD] add missing tooltips for Helix dialog 2021-12-05 19:21:27 +01:00
wmayer
45de32c4e1 Spreadsheet: fix format of table cells when used for printing, by default use landscape orientation 2021-12-05 12:16:54 +01:00
wmayer
1d3822822d Spreadsheet: issue 0002957: spreadsheet direct printing 2021-12-04 23:36:11 +01:00
Roy-043
a62ffdf93d Draft: fix task panel_issues (gui_texts.py) 2021-12-04 22:01:29 +01:00
Roy-043
6684196c81 Draft: fix task panel issues (gui_polygons.py) 2021-12-04 22:00:43 +01:00
Roy-043
4f8094baec Draft: fix task panel issues (gui_points.py) 2021-12-04 21:59:47 +01:00
Roy-043
d97ba3c622 Draft: fix task panel issues (gui_edit.py) 2021-12-04 21:58:50 +01:00
Roy-043
aec803fe8d Draft: fix task panel issues (DraftGui.py) 2021-12-04 21:57:31 +01:00
wmayer
b9d2aca09f PD: refactor ReferenceSelection 2021-12-03 21:38:28 +01:00
wmayer
0579052cbc PD: comment out dead code 2021-12-03 20:18:46 +01:00
0penBrain
2f8f4d6a7f [Gui] UserEditMode : fix operating on PartDesignObject 2021-12-03 16:53:30 +01:00
wmayer
945028847a PD: avoid include generated .ui file in header file 2021-12-03 15:59:15 +01:00
wmayer
e9c4f4acc1 PD: minor cleanup in view provider headers 2021-12-03 15:58:23 +01:00
wmayer
b165947625 PD: cleanup the mess with boolean arguments and replace them with a bitmask 2021-12-03 14:46:19 +01:00
Yorik van Havre
9135b5ec90 Merge pull request #5219 from luzpaz/gender-neutral-fixes 
Make source code comments use gender neutral pronouns
 2021-12-03 13:36:17 +01:00