Commit Graph

22499 Commits

Author SHA1 Message Date
wmayer
66bf741d37 FEM: [skip ci] Coverity: Dereference after null check 2020-09-22 20:32:21 +02:00
wmayer
adae2b6613 PartDesign: [skip ci] Coverity: Structurally dead code 2020-09-22 20:22:26 +02:00
wmayer
cb6ec67d02 PartDesign: [skip ci] Coverity: Bad use of null-like value 2020-09-22 20:03:42 +02:00
wmayer
e5a86986d8 PartDesign: [skip ci] fix method to access main window in shaft wizard 2020-09-22 19:15:59 +02:00
wmayer
6f196dc827 OpenSCAD: [skip ci] Coverity: Bad use of null-like value 2020-09-22 14:22:10 +02:00
Oscar Rainford
9107d1f376 Include Inventor/SbByteBuffer.h in QuarterWidget.cpp to allow compilation with latest Coin3D library. 2020-09-22 14:05:01 +02:00
Yorik van Havre
b822809c94 Arch: allow exporting of objects with no solid or shell to IFC 2020-09-22 13:31:04 +02:00
vocx-fc
d908fad16d Draft: fix loading of arrays 2020-09-22 12:12:00 +02:00
wmayer
95d03c8d92 Sketcher: [skip ci] fix computing of hotspot of sketcher icons on Windows 2020-09-21 16:32:25 +02:00
wmayer
f55f7f040a Python: [skip ci] expose Python types in their corresponding modules 2020-09-21 15:04:26 +02:00
Yorik van Havre
6d0b9de0e9 Added liberapay badge to readme 2020-09-21 15:03:02 +02:00
vocx-fc
5465726b85 Draft: split svg.get_path function for paths that are BSplines
If it's not a circle nor ellipse nor straight line
convert the curve to BSpline. Move into a subfunction.

Improve a few varible names to be more verbose, like `vertex`
and `edge`.
2020-09-21 14:25:03 +02:00
vocx-fc
d3cbfa4071 Draft: svg, move test so the code is less indented
The angle between the curve and plane is tested for being coplanar,
0 or 180 degrees. The negative test is done earlier so that the
return is done earlier, and the rest of the code is not indented.
2020-09-21 14:25:03 +02:00
vocx-fc
85397a60bd Draft: split svg.get_path into smaller readable functions
Split the SVG string for circular and elliptical paths.
2020-09-21 14:25:03 +02:00
vocx-fc
0fe7994b42 Draft: split svg.get_text into smaller readable functions
Split the code for SVG string that will be displayed
for TechDraw pages; also split the header for other cases.
2020-09-21 14:25:03 +02:00
vocx-fc
c57ede8ca3 Draft: clean up SVG processing code, add comments
For the try-except blocks we should trap a specific `Exception`,
not just any type. It seems string handling was an issue
with Python 2, so the string needed UTF8 decoding.

When the software no longer supports Python 2, these
blocks can be removed.
2020-09-21 14:25:03 +02:00
vocx-fc
90fb07dbc6 Draft: Drawing is still used in get_dxf function 2020-09-21 14:25:03 +02:00
Zheng, Lei
7ee075325a Draft: fix point array without using link 2020-09-21 14:01:42 +02:00
Zheng, Lei
e3e7686773 Draft: add support for point link array 2020-09-21 14:01:39 +02:00
wmayer
423c374258 PD: [skip ci] fix msvc warning 2020-09-21 13:28:56 +02:00
sgrogan
9dbd7ba015 Update Libpack 2020-09-20 22:26:45 +02:00
tomate44
d76a7044ee Part: remove uIso and vIso methods from RectangularTrimmedSurface 2020-09-20 18:25:39 +02:00
tomate44
cbb1faf116 convert Geom_TrimmedCurve to subclass 2020-09-20 18:25:39 +02:00
tomate44
b81f654905 Part: remove uIso and vIso methods. Methods from base class GeomSurface will be used instead 2020-09-20 18:25:39 +02:00
vejmarie
4e524cbb1c Fix MacOS build with boost 1.73 and updated Homebrew packages 2020-09-19 19:35:39 +02:00
donovaly
78efc9c34f [PD] simplify item handling
according to https://github.com/FreeCAD/FreeCAD/commit/c1fd0320

"QListWidget::takeItem() returns a pointer to the removed item. So a previous call of QListWidget::item() is superfluous"
2020-09-18 17:30:09 +02:00
Zheng, Lei
32f8c66e02 Gui: fix property editor transaction closing 2020-09-18 13:56:20 +02:00
wmayer
4e101a555f Web: [skip ci] when dropping local file on StartPage then open it instead of downloading it 2020-09-18 13:14:09 +02:00
donovaly
8217e0f0d0 [PD] make sections sortable
- allow to sort loft sections by dragging: https://forum.freecadweb.org/viewtopic.php?f=19&t=50222

- fix bug of uninitialized options: https://forum.freecadweb.org/viewtopic.php?f=19&t=50221

- use better code for the context menu of the listWidget (the same we use in other placed of PD)

- add missing tooltip for mirror feature
2020-09-17 23:59:15 +02:00
wmayer
17e758ec69 MeshGui: [skip ci] expose highlightSegments() to Python 2020-09-17 18:25:14 +02:00
wmayer
c69612c748 PD: improve reference highlighting of a pipe
This change allows to highlight the spline, auxiliary spine, profile and sections of a pipe.
This gives the user a much better feedback of what external shapes are already used to build the pipe
2020-09-17 16:19:38 +02:00
wmayer
44b1a27cd4 PD: [skip ci] fixes for pipe task panel
+ Add/Remove are checkable buttons so if user unchecks it then disable highlighting of spine
+ Avoid superfluous char* -> QString conversion
2020-09-17 14:04:36 +02:00
wmayer
8fa096f23b PD: fixes for pipe task panel
+ fix Qt4 build failure
+ fix handling of adding items to spine/auxiliary spine/sections to allow to remove them again
+ QListWidget::takeItem() returns a pointer to the removed item. So a previous call of QListWidget::item() is superfluous
2020-09-17 11:35:41 +02:00
donovaly
329c763916 [PD] add context menus to sweep Dialog
- elements in the list of edges/spines/sections can now be deleted by pressing DEL and there is a context menu for this action

see https://forum.freecadweb.org/viewtopic.php?f=19&t=50222&p=431021#p431021
2020-09-17 00:45:43 +02:00
wmayer
1f1048d7c9 PartDesign: [skip ci] hide base feature of pad after it successful recompute 2020-09-16 17:18:49 +02:00
wmayer
c3354a46db Gui: [skip ci] fix crash in DocumentObjectData::updateChildren() when canceling a pending task 2020-09-16 13:41:03 +02:00
vocx-fc
7b34a43c16 Draft: small fixes to the closest function.
Correct the Pythonic style for the changes made in 85286bf044.
2020-09-16 13:09:57 +02:00
vocx-fc
b202b0d469 Draft: move getDXF to draftfunctions submodule
Update the appropriate interface in `Draft.py`.
2020-09-16 13:09:13 +02:00
Roy-043
cc8bc60e02 Arch: Minor improvements to testWallMultiMatAlign unit test. 2020-09-16 13:08:45 +02:00
Roy-043
b6f17bfa55 Arch: Arch_Wall fix MultiMaterial alignment bug (unit test)
Added the testWallMultiMatAlign unit test. Have kept the testWall test. Changed the code to 'import FreeCAD as App'.
2020-09-16 13:08:45 +02:00
Roy-043
48218690ce Arch: Arch_Wall fix MultiMaterial alignment bug. 2020-09-16 13:08:45 +02:00
Roy-043
80a1505530 Draft: Again revised the 5 scale unit tests. No longer relying on the math module.
Also avoided the use of a Boolean 'result' variable.
2020-09-16 13:07:50 +02:00
Roy-043
2ac6909671 Draft: Revised the 5 Draft.scale unit tests. No longer using scale_vector_from_center.
The old Draft.scale unit tests uses the scale_vector_from_center function from Draft.scale. This obviously didn't make sense.
2020-09-16 13:07:50 +02:00
Roy-043
19e7cff253 Draft: added 5 scale unit tests to test_modifications
The added functions are test_scale_part_feature_arcs, test_scale_part_feature_lines, test_scale_rectangle, test_scale_spline and test_scale_wire.
When comparing vectors and floats a tolerance of 1e-8 is used, but only for the midpoints of the arcs in test_scale_part_feature_arcs is this tolerance required. Scaling a part feature is not possible with the Draft_Scale command, but Draft.scale does support it.
2020-09-16 13:07:50 +02:00
wmayer
e426c12787 PartDesign: make sure to remove selection gate when closing task panel 2020-09-16 12:15:19 +02:00
wmayer
7723ad94f9 Fem: make sure to remove selection gate when closing task panel 2020-09-16 12:15:01 +02:00
wmayer
23a178edc4 Part: do not use local event loop in sweep and thickness panel 2020-09-16 12:14:04 +02:00
donovaly
b0faf1197c [PD] fix wording for skew prisms
the UI and the property is not consistent. In the dialog we use the term angle upon user feedback while the property still has the name "skew" in it.
I simply forgot this change in my PR that implemented skew prisms.

This is now corrected by this PR.
2020-09-15 22:13:26 +02:00
sliptonic
922ec0dce5 Merge pull request #3861 from Russ4262/profile_reset_fix
[Path] Fixes #4433 - `Cut Side` reset with certain Base Geometry changes
2020-09-15 14:12:01 -05:00
sliptonic
968ea0061e Merge pull request #3862 from Russ4262/pocketshape_fix
[Path] PocketShape - fix improper path generation
2020-09-15 14:09:57 -05:00