Kacper Donat
8c399e1fd0
PartDesign: Revolution - add FuseOrder
...
In older versions of FreeCAD the boolean order was base + result. After
TNP mitigation the order was changed to be result + base. For the
resulting shape that does not matter, but order of edges can differ if
arguments are in a different order.
This can impact refine algorithm which may pick other face as the base
one and result in a differnt shape after refining. This commit restores
previous order. For most files it should not make any difference, but it
may fix some older files.
To support all cases we introduce FuseOrder compatibility property that
will be set to FeatureFirst for files saved with 1.0 to preserve
behavior.
2025-12-22 11:17:27 -06:00
chris
46066e1cca
partdesign: pd: fix for issue #25794
2025-12-22 14:58:07 +01:00
Chris
452f9b2087
Part Design: Add sketch sub element names for refs in revolutions ( #26227 )
...
* part design: partdesign: pd: fix regression issue #26223 add sketch sub element names for refs in revolutions
* refractor code to remove else blocks as every condition has a return statement, make lsp happy
2025-12-22 14:56:53 +01:00
Alfredo Monclus
d9e0fd6251
PartDesign: fix hole clearance not appearing in the taskpanel when switching type
2025-12-22 14:56:09 +01:00
Alfredo Monclus
6729540a78
PartDesign: fix thread depth not shown in taskpanel
2025-12-22 14:55:45 +01:00
Chris Hennes
76bd68e672
PD: Fix missing silent mode check in GetTopoShapeVerifiedFace
...
Also ensure that all calls to this method actually verify the result.
2025-12-22 14:34:25 +01:00
Kacper Donat
4d712f44c2
PartDesign: Chamfer - migrate Size and Size2 for older files ( #26137 )
...
* PartDesign: Chamfer - migrate Size and Size2 for older files
* Apply suggestions from code review
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org >
---------
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org >
2025-12-22 11:52:55 +00:00
freecad-gh-actions-translation-bot
8b7ec488f0
Update translations from Crowdin
2025-12-22 12:40:21 +01:00
Kacper Donat
fe3dc9f06a
Compiler warning cleanup ( #26229 )
...
* App: Compiler warning cleanup
* Gui: Compiler warning cleanup
* Assembly: Compiler warning cleanup
* Measure: Compiler warning cleanup
* Sketcher: Compiler warning cleanup
* TechDraw: Compiler warning cleanup
* PartDesign: Compiler warning cleanup
2025-12-18 07:50:26 +01:00
freecad-gh-actions-translation-bot
6c6cff7322
Update translations from Crowdin
2025-12-17 21:10:10 -06:00
Chris Hennes
0ba75a7573
PartDesign: Compiler warning cleanup
2025-12-17 11:08:38 -06:00
Saksham Malhotra
b7735044c4
PartDesign: move AllowCompound to Base property group ( #26180 )
2025-12-15 21:45:29 -06:00
Chris Hennes
3208b6de5f
PD: Don't warn about Midplane on document load
2025-12-15 18:22:31 +01:00
Chris Hennes
5ba7f207ab
PD: Correct is-datum-in-body check
2025-12-15 18:20:04 +01:00
Alfredo Monclus
f92c8e126c
PardDesign: fix hole task thread combos not translating
2025-12-11 18:56:10 -06:00
Kacper Donat
c10f5d74d3
PartDesign: Recompute preview after forced recompute
...
This fixes some cases where Preview was stale and not recomputed after
changes done via code.
2025-12-11 18:55:10 -06:00
Chris Hennes
67948d60a2
PD: Add deprecation warning if Midplane is set
2025-12-10 12:42:13 +01:00
freecad-gh-actions-translation-bot
f7483a08b4
Update translations from Crowdin
2025-12-08 22:31:48 -06:00
Captain
a371231aea
PartDesign: fix symmetric mode of draggers in revolution/groove ( #25656 )
2025-11-30 23:03:31 -06:00
Chris Hennes
dfb9baf678
Merge pull request #24262 from mnesarco/pyi-fixes-1
2025-11-29 20:23:37 -06:00
PaddleStroke
5ae67ee2f9
PartDesign: Polar pattern: Accept negative angles ( #25621 )
2025-11-27 18:08:01 -06:00
Chris Hennes
8604c26ce3
Merge pull request #25580 from kadet1090/fix-boolean-position
...
PartDesign: Fix boolean positioning
2025-11-26 14:22:59 -06:00
Chris
5382ca4bbb
PartDesign: Use c++ exception to prevent crash ( #25671 )
...
* part design: fix issue #25639 use c++ exception to prevent crash
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-11-26 15:43:47 +01:00
github-actions
68cb0a3270
Update translations from Crowdin
2025-11-25 21:20:42 -06:00
Kacper Donat
88543612e4
PartDesign: Use true tool positions for boolean preview
...
This fixes positioning of some previews for booleans that were misplaced
after #24750 was merged. It restores previous code that was correct for
most cases. The reason for some previews being misaligned is described
in the #25578 - the preview actually shows how the result should be but
due to some shortcuts taken in code the result is incorrect.
2025-11-24 10:48:32 -06:00
chris
0fc96a1a6f
part design: reimp feature to move datum objects using modal / dialogue box from right click menu in model tab
2025-11-24 10:39:13 -06:00
Kacper Donat
527b2de560
PartDesign: Bake in geometry transform after boolean
...
This bakes in transform into geometry after boolean to ensure that
regardless of parameters the result of boolean operation is the same.
2025-11-23 23:10:25 +01:00
Kacper Donat
1555f65075
PartDesign: Simplify FeatureBoolean
...
This commit removes a ton of dead code from FeatureBoolean. It might
been ported here from the Link branch but it is not used and it is
confusing. The reason for having that code here is also not really
obvious so there is no reason to keep it.
2025-11-23 23:10:25 +01:00
pre-commit-ci[bot]
78bb40c419
[pre-commit.ci] auto fixes from pre-commit.com hooks
...
for more information, see https://pre-commit.ci
2025-11-20 19:04:34 +00:00
Syres916
1e30362dd4
[PartDesign] Fix string encoding for document name and face reference
2025-11-20 19:02:25 +00:00
captain0xff
5d387ae014
PartDesign: fix the interactive controls for revolution/groove
2025-11-18 15:39:42 +01:00
Roy-043
45866b5f41
PartDesign: Update TaskFeaturePick.cpp text (Title Case mod)
2025-11-18 15:35:12 +01:00
github-actions
8432fab0a9
Update translations from Crowdin
2025-11-11 23:44:18 -06:00
pre-commit-ci[bot]
5e0dd60ee5
[pre-commit.ci] auto fixes from pre-commit.com hooks
...
for more information, see https://pre-commit.ci
2025-11-11 19:34:32 +00:00
Frank Martinez
3561d25c2d
[License] Fix pyi license headers.
2025-11-11 13:26:18 -05:00
Frank Martinez
93e4858b01
[bindings] remove redundant signatures. batch2
2025-11-11 13:23:10 -05:00
Frank Martinez
1cf57d6e11
[bindings] Format with yapf (precommit will reformat)
2025-11-11 13:23:10 -05:00
Frank Martinez
2ada443c18
Clean unused imports in .pyi files
2025-11-11 13:23:10 -05:00
Frank Martinez
39d15c011e
black formatting
2025-11-11 13:23:10 -05:00
Frank Martinez
0eae00b9a1
[bindings] Code formatting
2025-11-11 13:23:09 -05:00
Frank Martinez
748004b4e4
[bindings] fix signatures in pyi files
2025-11-11 13:16:26 -05:00
pre-commit-ci[bot]
25c3ba7338
All: Reformat according to new standard
2025-11-11 13:49:01 +01:00
PaddleStroke
0ff0359524
PartDesign: Fix 'UpToShape' not saving correctly
2025-11-10 10:49:50 -06:00
wwmayer
1844fdd443
PD: Toggling transparency doesn't reset colors
2025-11-01 09:05:03 +01:00
github-actions
11fecb1558
Update translations from Crowdin
2025-10-27 21:06:54 -05:00
Florian Foinant-Willig
501c6273a3
PartDesign: only warn on refine failure
2025-10-26 22:16:04 +01:00
Leandro Heck
873fa449ce
PD: Show custom direction settings on Pad/Pocket only when necessary. ( #24642 )
...
* PD: Show custom direction settings on Pad/Pocket only when necessary.
* Update the visibility of parameters.
2025-10-23 00:00:11 +02:00
Florian Foinant-Willig
7f6c39c358
PartDesign: fix MultiTransform from existant Transform
2025-10-20 17:55:01 +02:00
Syres916
5ba4feac59
[PartDesign] create a new Gui Unit Test for the creation of a sketch … ( #23601 )
...
* [PartDesign] create a new Gui Unit Test for the creation of a sketch and...
...improve the Selection Filter syntax error to show where it's being generated from.
* [PartDesign] address Lint feedback
* PD/Tests: Ensure test file does not exist before SaveAs
---------
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org >
2025-10-20 10:34:05 -05:00
github-actions
50d1dec4e0
Update translations from Crowdin
2025-10-20 09:57:05 -05:00
