Commit Graph

24978 Commits

Author SHA1 Message Date
Ajinkya Dahale
69a56bc3fa [Sketcher] Fix typos caused by copying content in new DSH
Some parts of `DrawSketchHandlerBSplineByInterpolation` were taken from
`DrawSketchHandlerBSpline` but not modified to reflect the differences.

This commit is part of a project funded by the Open Toolchain Foundation under the title "Open Toolchain Foundation - Curve drawing tool in Sketcher Workbench"
2023-03-24 16:30:48 +01:00
Ajinkya Dahale
d2349f29db [Sketcher] Clarify keyboard input for B-spline DSH
Specifically, when drawing by interpolation, only cubic splines are currently
supported.

Some related "TODO" comments are also removed or modified.

This commit is part of a project funded by the Open Toolchain Foundation under the title "Open Toolchain Foundation - Curve drawing tool in Sketcher Workbench"
2023-03-24 16:30:48 +01:00
Ajinkya Dahale
e83a9804c1 [Sketcher] Create DSH for drawing B-splines by interpolation
Only creates 1-degree splines by describing knots.

This commit is part of a project funded by the Open Toolchain Foundation under the title "Open Toolchain Foundation - Curve drawing tool in Sketcher Workbench"
2023-03-24 16:30:48 +01:00
marioalexis
c97de6c038 Fem: Add option to select default solver when creating Analysis 2023-03-24 15:40:54 +01:00
Uwe
7e3d37a5fe [FEM] implement further object addition mode
- for e.g. the solver objects it is important that the added equations are visible in the TreeView
- also improve activation of analyses for documents with multiple analyses: one activates one and can then subsequently add an object to it because the activation will also select
2023-03-24 07:22:27 +01:00
Uwe
26bb8b1666 [TD] GeometryMatcher.cpp: fix compiler warning
about unused variable
2023-03-24 06:16:31 +01:00
Uwe
1bd5739708 [FEM] auto-activate Analyses
- this PR addresses a long-standing annoying issue: You are already in the FEM WB and load a file.
  Then you cannot just start but first have to activate the Analysis. But one is in the FEM WB to work with analyses.
2023-03-24 06:05:54 +01:00
Chris Hennes
59fa7c9205 Addon Manager: Fix wiki macro icon cleanup 2023-03-23 21:49:05 -05:00
Uwe
5a0f8436c2 [FEM] don't add CCX solver by default for new analyses
- if there are other solvers found, we should handle all solvers equally
- also reduce amount of console output on every analysis run
2023-03-24 03:25:02 +01:00
Uwe
ce62cfae95 [FEM] implement new object addition mode
- for e.g. the Elmer equations it is important that one can add several equations subsequently and that the added equations are visible in the TreeView
2023-03-24 02:43:01 +01:00
Uwe
a377a5e490 [FEM] remove unused code
- remove commented-out code that is in Python since years
2023-03-24 02:42:19 +01:00
Uwe
7edea318ea [FEM] Elmer: group mechanical equations
- also simplify code to check for existing analysis
2023-03-24 01:59:46 +01:00
sliptonic
8a373c7e9a Change file license to CC4.0
I have discussed with mlampert via email and he agreed to all changes
2023-03-23 23:55:10 +01:00
Chris Hennes
d0f46f3fd4 Merge pull request #8923 from Ondsel-Development/toponaming-p1-4
[Core] Create `ElementMap.h` and tests
2023-03-23 09:40:56 -05:00
Chris Hennes
c2bde98dba Addon Manager: Fixes #9001, icon was string 2023-03-23 09:39:20 -05:00
Uwe
4c9afb4546 [FEM] activate spring constraint
- the spring constraint is currently unused but it can be used for Elmer mechanical analyses
This PR does so and also overhaul the dialog UI.
- use the spring constraint also in an example file
2023-03-23 15:14:50 +01:00
0penBrain
6bf7c137ea Sketcher: use default palette text color for normal solver messages
These messages had a forced black color which is a problem when using
 OS dark themes.
2023-03-23 10:50:01 +01:00
Uwe
3bced92364 [FEM] add example file for deformation 2023-03-23 06:17:09 +01:00
wandererfan
354480e9a4 [TD]Lint/Tidy/Review comments applied 2023-03-22 20:09:35 -04:00
wandererfan
fd26842001 [TD]autocorrect default to true 2023-03-22 20:09:35 -04:00
wandererfan
8a11528a7e [TD]corrupt dim reference detect and correct 2023-03-22 20:09:35 -04:00
Uwe
45743d4fbd [FEM] improve displacement constraint
- use a Distance and Angle property to get the unit handling right
2023-03-23 00:50:40 +01:00
Chris Hennes
f679823c6e Merge pull request #8955 from wwmayer/issue_8556
Move image loading to core
2023-03-22 16:00:43 -05:00
wmayer
9fa3cf8d8d Fem: fix warning field 'dimension' will be initialized after field 'ui' [-Wreorder-ctor] 2023-03-22 20:37:29 +01:00
wmayer
6b498d82cc Import: issue #8884: C++ DXF importer never imports text (annotations
This reverts commit 877f6c09817
2023-03-22 20:09:20 +01:00
Uwe
9d45d40ec5 [FEM] use std::unique_ptr for all dialog objects
- also fix too long line
- also further clang automatic code style changes
2023-03-22 20:08:13 +01:00
Uwe
b74425b441 [PD] revolve: remove unused code
- also come code style unification
2023-03-22 17:46:03 +01:00
Ajinkya Dahale
a4bbc79d99 [Part] Add TopoShapeOpCode.h
Constants to be used in the future.

Apply suggestions from code review

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2023-03-22 22:09:13 +05:30
luzpaz
f1bbcd9e13 Fix typos and whitespace 2023-03-22 17:10:38 +01:00
wmayer
3e3540192b Image: remove module 2023-03-22 16:25:19 +01:00
Uwe
c9cb01531f [FEM] extend displacement constraint
- add fields to specify a formula for the displacement, this is necessary to make transient deformation analyses with Elmer
- add option to set displacement from result of flow equation
- this way also a major overhaul -> simpler dialog logic etc.
2023-03-22 15:23:32 +01:00
liukaiwen
de63e13adb fix: macro WIN32 is deprecated, but is implicit defined by some certain environment including visual studio 2023-03-22 13:29:35 +01:00
wmayer
cbd0f792bb C++17: remove workaround for external smesh to fix build failure on Conda 2023-03-22 13:24:21 +01:00
Yorik van Havre
25e954652d Merge pull request #8973 from kpemartin/Issue8968
Issue 8968: Correct C++ DXF importer to get all of long MTEXT text
2023-03-22 11:09:19 +01:00
Uwe
14c88f41fb [FEM] several Elmer fixes
- fix whitespace in the SIF writer
- Elmer GUI uses only 20 nonlinear iterations, so we should do the same (500 were also not sensible)
- don't restrict nonlinear-Newton iterations to 100, 500 might be necessary for turbulent flow
- update author
2023-03-22 07:27:20 +01:00
Uwe
333cf5fdd7 [FEM] fixes for deformation equation
- deformation is a nonlinear equation
- use the default that Elmer GUI uses for this equation
2023-03-22 07:20:51 +01:00
Uwe
0fcea8b3bb [FEM] Elmer add support for nonlinear elasticity solver
- adds new equation "Deformation" (this name since the stress solver got in FreeCAD the misleading name "elasticity")

- this way change icon of elastic solver to make the difference clear
2023-03-22 03:27:27 +01:00
luzpaz
818c66d663 FEM: [skip ci] fix grammar for console message 2023-03-21 01:39:09 +01:00
Uwe
6bf09c512d [Sketch] Constraints.cpp: formatting fixes
- fix too long lines
- also let clang reformat the file to uniform the formatting
2023-03-20 16:53:41 +01:00
Kevin Martin
ad8483d320 Issue 8968: Correct C++ DXF importer to get all of long MTEXT text
If the MTEXT exceeds 250 characters, the contents are broken up into
several records in the DXF file. The C++ importer has been changed
to collect all these pieces into a single string containing all the text.
2023-03-20 11:48:47 -04:00
luzpaz
f87b919e0d Fix various whitespace issues 2023-03-20 16:38:40 +01:00
Florian Foinant-Willig
c23f6a9221 Fix circles distance constraint for concentrics 2023-03-20 16:02:08 +01:00
Uwe
f1799f27b0 [FEM] fine-tune flow examples
- use a more sensible velocity distribution
- change inlet temperature for 2 examples

- also change step size for nonlinear iterations for more convenience for practical usage
2023-03-20 07:17:11 +01:00
Uwe
866ea2551d [FEM] rewrite initial velocity constraint
- same as #8963 but for initial velocity

- add an example file that demonstrates the influence of the initial velocity
- some fine-tuning for the existing flow example
2023-03-20 04:58:24 +01:00
Uwe
b496a41cd1 [FEM] rewrite velocity constraint
- complete revision of the constraint.

This is a breaking change, meaning existing constraints won't work.

This is possible because since 2 days ago the whole flow equation did not work at all. Also the existing constraint implementation if buggy and cannot be used to do the Elmer tutorial. Also, the constraint is only used by Elmer and only be the flow equation.

Since nobody complained about the obvious wrong results, we can assume the flow equation was not yet in practical usage (and for FC 0.20 we known that it does not work at all, first with FC 0.20.1).

It is necessary since it must be possible to either input a velocity or an equation. With an equation, a velocity profile can be specified.

- update the flow examples accordingly:
-- simplify them since an initial and and output velocity is not necessary to specify
-- use a formula as input velocity for the non-turbulent example
2023-03-20 01:57:09 +01:00
Uwe
715472a991 [FEM] Elmer: support for variable strings
- Elmer offers the "Variable" calls do define variables via math equations. These are for example used to define as constraint a certain velocity profile
2023-03-20 01:14:34 +01:00
Uwe
0e0ba00987 [FEM] output less messages
- the message how to use the feature is not useful since it is triggered by the GUI selection and in the GUI has already the info in form of tooltips how to use
2023-03-20 01:13:46 +01:00
Abdullah Tahiri
40ed989991 Missing overrides 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
1db929e702 Refactor of CmdSketcherSnap and SnapSpaceAction to reduce verbose calls to retrieve preference parameters 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
53304af62c Refactor parameter in a single place 2023-03-19 19:14:22 +01:00