Commit Graph

24939 Commits

Author SHA1 Message Date
Uwe
6bf09c512d [Sketch] Constraints.cpp: formatting fixes
- fix too long lines
- also let clang reformat the file to uniform the formatting
2023-03-20 16:53:41 +01:00
luzpaz
f87b919e0d Fix various whitespace issues 2023-03-20 16:38:40 +01:00
Florian Foinant-Willig
c23f6a9221 Fix circles distance constraint for concentrics 2023-03-20 16:02:08 +01:00
Uwe
f1799f27b0 [FEM] fine-tune flow examples
- use a more sensible velocity distribution
- change inlet temperature for 2 examples

- also change step size for nonlinear iterations for more convenience for practical usage
2023-03-20 07:17:11 +01:00
Uwe
866ea2551d [FEM] rewrite initial velocity constraint
- same as #8963 but for initial velocity

- add an example file that demonstrates the influence of the initial velocity
- some fine-tuning for the existing flow example
2023-03-20 04:58:24 +01:00
Uwe
b496a41cd1 [FEM] rewrite velocity constraint
- complete revision of the constraint.

This is a breaking change, meaning existing constraints won't work.

This is possible because since 2 days ago the whole flow equation did not work at all. Also the existing constraint implementation if buggy and cannot be used to do the Elmer tutorial. Also, the constraint is only used by Elmer and only be the flow equation.

Since nobody complained about the obvious wrong results, we can assume the flow equation was not yet in practical usage (and for FC 0.20 we known that it does not work at all, first with FC 0.20.1).

It is necessary since it must be possible to either input a velocity or an equation. With an equation, a velocity profile can be specified.

- update the flow examples accordingly:
-- simplify them since an initial and and output velocity is not necessary to specify
-- use a formula as input velocity for the non-turbulent example
2023-03-20 01:57:09 +01:00
Uwe
715472a991 [FEM] Elmer: support for variable strings
- Elmer offers the "Variable" calls do define variables via math equations. These are for example used to define as constraint a certain velocity profile
2023-03-20 01:14:34 +01:00
Uwe
0e0ba00987 [FEM] output less messages
- the message how to use the feature is not useful since it is triggered by the GUI selection and in the GUI has already the info in form of tooltips how to use
2023-03-20 01:13:46 +01:00
Abdullah Tahiri
40ed989991 Missing overrides 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
1db929e702 Refactor of CmdSketcherSnap and SnapSpaceAction to reduce verbose calls to retrieve preference parameters 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
53304af62c Refactor parameter in a single place 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
669b2d0993 Prevent unnecessary update of snapAngle, block signals when auto updating 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
3975d4bb34 Remove unnecessary ViewProvider retrieving and checking, as it is unused 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
485d4f3194 Rename angleSnapEnabled to angleSnapRequested for consistency with the other snap flags 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
b2e7883462 Remov warning -squash group by meaningful groups 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
7903fa4e87 Remove warning - SnapManager initialisation order in constructor different from class declaration 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
7036939f17 Encapsulate interface data members 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
febaca9070 Rename preference parameter 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
e5e1f54729 Remove left-over code 2023-03-19 19:14:22 +01:00
Paddle
67615d6222 Sketcher: Snap: Add 'Snap at angle' to Arc of Ellipse DSH. 2023-03-19 19:14:22 +01:00
Paddle
a1255d11f8 Sketcher: Snap: Add 'Snap at angle' to Ellipse DSH. 2023-03-19 19:14:22 +01:00
Paddle
881d27d82f Sketcher: Snap: Add 'Snap at angle' to Line DSH. 2023-03-19 19:14:22 +01:00
Paddle
8bca9f0c36 Sketcher: Snap: Add 'Snap at angle' to Arc DSH. 2023-03-19 19:14:22 +01:00
Paddle
849fdd6956 Sketcher: Snap: Add 'Snap at angle' support to DrawSketchHandler. 2023-03-19 19:14:22 +01:00
Paddle
ecb1724bf1 Sketcher: Snap: initial implementation: - creation of SnapManager class. - Move grid snap to this new class. - Add snap to object. - Add snap at angle. 2023-03-19 19:14:22 +01:00
flachyjoe
e2a13763e9 Sketcher: Add circle to circle distance constraint 2023-03-19 14:05:35 +01:00
wmayer
6fb167582a TD: move all XML query handling to a single function 2023-03-18 19:26:01 -04:00
Paddle
f28938eead Sketcher: Constraint Widget: Change showHideButton from QPushButton to QToolButton to avoid style problems. 2023-03-18 18:22:21 +01:00
Abdullah Tahiri
a7853a088c ElementWidget: remove unnecesary element pointer
================================================

This should fix this (I cannot reproduce it):
https://forum.freecad.org/viewtopic.php?p=667579#p667579

Lately I added the geometry pointer to the item. This has indeed
the potential for an already deleted pointer being accessed.

This PR removes the geometry pointer from the item and relies on the
ViewProvider to indirectly access an updated pointer.
2023-03-18 11:32:22 +01:00
Abdullah Tahiri
4e815584c3 ElementWidget: reorganise implementation class declarations 2023-03-18 11:32:22 +01:00
Abdullah Tahiri
adf6d81ebb Sketcher: Elements Widget - Fix crash when moving external geometry to another layer
====================================================================================

As reported:
https://forum.freecad.org/viewtopic.php?p=667426#p667426

Support for moving external geometry to another layer will come in the future.
2023-03-18 07:45:04 +01:00
Abdullah Tahiri
6c77d5ae44 ElementsWidget: Move ElementFilterList to implementation
========================================================

Only moving code from header to implementation.
2023-03-18 07:45:04 +01:00
Abdullah Tahiri
1c502b4acf ElementsWidget: Move Delegate to implementation
===============================================

Only moving code from header to implementation.
2023-03-18 07:45:04 +01:00
Uwe
6dc12e0c19 [FEM] update a file license
- like in #8933
2023-03-18 01:04:17 +01:00
Uwe
95087132a2 Merge pull request #8934 from jbaehr/partdesign-ingolutegear-profileshift
PD: Implement Profile Shift for InvoluteGear
2023-03-18 00:48:44 +01:00
Chris Hennes
5e6a63be24 Fem: Fix licensing of Calculix test FCStd files (#8933)
* Fem: Fix licensing of Calculix test FCStd files
2023-03-18 00:47:02 +01:00
Jonas Bähr
e05231aa7f PD: Implement Profile Shift for InvoluteGear
This commit adds the ability to shift the involute profile inside or
outside. Profile shift is implemented as coefficient, i.e. normalized by
the module, so that it the whole profile scales with the module without
chaning shape.
To verify the profile, the tests implement an "over pins measurement"
using formulae found in literature.
Backward compatibility with FreeCAD-v0.20 is garanteed by already
existing tests, not touched by this commit.

This addresses issue #5618.
2023-03-17 22:22:34 +01:00
Uwe
cf29318063 [FEM] add an example for a turbulent flow 2023-03-17 17:57:09 +01:00
Uwe
17e3c70c3f [FEM] improve check for fluid material
- it is sufficient if there is a dynamic viscosity defined
2023-03-17 17:56:41 +01:00
Uwe
619e909202 [FEM] fix 1D thermomech example
- the heat capacity of water was wrong
- also specify just thermal expansion, this make that water is recognized as material and then all water parameters will be available

(that the analysis fail despite CalculiX reports everything went well s is another issue, I will investigate later)
2023-03-17 17:55:50 +01:00
Uwe
14b5c95f06 [FEM] Elmer: add new default coordinate system
- for new versions of Elmer the default coordinate system is "Cartesian". (if 2D or 3D is determined by the "Variable" setting for the equation)
2023-03-17 16:03:23 +01:00
Paddle
a70b808930 Draft: Remove unit selector in status bar as it is now implemented in core's sizeLabel. 2023-03-17 14:04:24 +00:00
Paddle
0ef42a1455 Sketcher: Add parameter observer for system unit, such that the view is updated when user change the unit system through the sizeLabel widget. 2023-03-17 14:04:24 +00:00
Uwe
2759105469 [FEM] fix flow equation
- the density must be output using the correct units. Due to this bug also the viscosity was written with wrong units-
- if there is a dynamic viscosity given for a material, use it directly
2023-03-17 03:55:23 +01:00
Uwe
929713af03 [FEM] improve deletion warning
- don't popup a warning if all children of an object are selected too when deleting the object
2023-03-16 21:54:09 +01:00
sliptonic
07df9a4e84 Path Update license to CC 4.0 2023-03-16 19:49:40 +01:00
marioalexis
3d3c20e72a Fem: Remove unused member node 2023-03-16 17:50:21 +01:00
Russell Johnson
383902e495 Path: Update license
Addresses user-specific need in #8894
2023-03-16 17:46:27 +01:00
LarryWoestman
db3fcf9ac4 Path: Updated the licensing to Creative Commons 4.0 2023-03-16 16:33:47 +01:00
wandererfan
966c577ec4 [TD]add wait for threads to Dimension test script 2023-03-16 10:37:14 -04:00