Commit Graph

34981 Commits

Author SHA1 Message Date
Abdullah Tahiri
6eb55822a0 Sketcher: Box selection - Hyperbola/Parabola endpoint fix 2023-11-11 21:19:12 +01:00
Abdullah Tahiri
2d499873b0 Sketcher: DSH - improving geo creation helpers for ShapeGeometry
================================================================

In some DSHs instead of the convenience function, the code is being duplicated because
of the need to access the geometry after pushing it to the std::vector.

This commit leverages emplace_back return reference to improve code reuse.
2023-11-11 21:18:20 +01:00
pre-commit-ci[bot]
dce4dc3518 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-11-11 18:21:31 +01:00
bgbsww
640de8ceb2 Fix 10545 by using position of array members 2023-11-11 18:21:31 +01:00
wandererfan
22a73f7d2f [TD]fix 3x extension circle methods #11310 2023-11-11 07:48:03 -05:00
wandererfan
6ccf57b3a2 [TD]add 2 utility methods
- toAppSpace converts qt point to app view coords
- angleWithX(Base::Vector3d) returns [0,2pi]
2023-11-11 07:48:03 -05:00
Abdullah Tahiri
c4085b0a8f Sketcher: Adapt DSHs to new dynamic cursor 2023-11-11 11:15:54 +01:00
Abdullah Tahiri
1d0c72a685 Sketcher: DSHController - extend framework to make cursors OVP visibility dependent 2023-11-11 11:15:54 +01:00
Abdullah Tahiri
c863f2f341 Sketcher: DSH - new cursor drawing functions 2023-11-11 11:15:54 +01:00
pavltom
9de796d4e6 [TechDraw] Issue #6527 - Implement face transparency 2023-11-10 10:48:06 -05:00
wandererfan
3d9c37c3e3 [TD]fix Print Center Marks #11309 2023-11-10 09:30:19 -05:00
wandererfan
458b7ca5ac [TD]Fix margins on PDF output #11308 2023-11-10 09:30:19 -05:00
Roy-043
89c967008d Draft: Improve grid behavior
This PR improves the behavior of the Draft grid:
* Options in the preferences: "Always show the grid" and "Show the grid during commands".
* The parameters are used for new views. In existing views the grid can be toggled either during a command or when no command is active.
* When switching to a different workbench all grids are hidden unless GridHideInOtherWorkbenches is set to `False`. This can be a Fine-tuning parameter IMO.

Notes:
* The defaultCameraHeight parameter becomes obsolete. It was only used in very specific circumstances.
* The code of PR #8818 becomes obsolete. It makes more sense to use `App.activeDraftCommand` instead of adding a `tool` argument to some functions. Will do some related cleanup later.
* Improved alignment for the related preference ui. The checkbox interaction has been fixed as well.
2023-11-10 14:02:38 +01:00
Roy-043
b3a06b746b Arch: make Arch_CutPlane nesting and link aware
Forum topic:
https://forum.freecad.org/viewtopic.php?t=82340
2023-11-10 11:04:27 +01:00
Roy-043
1205925ec8 MEASUREMENT should also be checked if INSUNITS is zero 2023-11-10 10:21:54 +01:00
Roy-043
6458f4dd53 Avoid Python match function 2023-11-10 10:21:54 +01:00
Roy-043
86788e3777 Draft: fix import scale for Legacy DXF importer
Fixes #10253.
2023-11-10 10:21:54 +01:00
czinehuba
12a34be4a6 Update iso10642.json (#11302)
* Update iso10642.json

Update ISO10642 with M2 and M2.5 sizes

* Update iso10642.json

Updated dimensions
2023-11-09 12:26:56 -06:00
Chris Hennes
61aaba74fd Tools: Add check for existence in updatecrowdin.py (#11304) 2023-11-09 12:24:54 -06:00
Chris Hennes
f25af97811 Update translations 2023-11-09 12:23:56 -06:00
Roy-043
1266b6f445 Merge pull request #11319 from Roy-043/Arch-start-and-stop-WP-view-observer
Arch: start and stop WP view observer
2023-11-09 12:15:46 +01:00
wmayer
efa78a3f62 JtReader: allow to open JT files using TKJT 2023-11-09 01:40:54 +01:00
wmayer
48ad05cf6c Base: extend ShapeHintsItem to allow to set vertex ordering and shape type 2023-11-08 21:03:33 +01:00
Abdullah Tahiri
f56eebea64 Sketcher: Fix lints 2023-11-08 17:46:34 +01:00
Abdullah Tahiri
2f40dd34c8 Sketcher: Encapsulate function to ensure MDI focus 2023-11-08 17:46:34 +01:00
Roy-043
48f05dca17 Arch: start and stop WP view observer
See #11257.
2023-11-08 16:36:31 +01:00
Roy-043
247afe2a99 Merge pull request #11295 from Roy-043/Draft-improved-props_changed_placement_only-function
Draft: improved props_changed_placement_only function
2023-11-08 15:31:43 +01:00
Roy-043
d7720e1314 Merge pull request #11280 from Roy-043/Arch-Fix-issue-with-getSceneGraph
Arch: Fix issue with getSceneGraph
2023-11-08 15:30:50 +01:00
Roy-043
35ae166586 Merge pull request #11257 from Roy-043/Draft-PlaneGui-view-observer-to-update-the-Tray
Draft: PlaneGui: view observer to update the Tray
2023-11-08 15:29:18 +01:00
Paddle
fd0f300415 Line DSH : hide widget if OVP disabled. 2023-11-08 15:20:13 +01:00
Paddle
c7f0b19eaa Remove moveCursorToSketchPoint on init. 2023-11-08 15:20:13 +01:00
Paddle
8be614abcc Fix bug where M key stop working in some cases by giving focus to MDI on reset. 2023-11-08 15:20:13 +01:00
Paddle
fc55350abf Rectangle DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
379ab4cd90 Polygon DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
80d4a9b2ab Offset DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
0984b6e7dc Line DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
988aecea6c Add preference for OVP visibility. 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
9db65bbf9a Sketcher: Update DSHs to set value via framework only when they are visible 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
ed9e6d104b Sketcher: DrawSketchController - Extend framework to support hiding OVPs via preference 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
dca052bd9d Fix Compiler warnings of previous merged PRs 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
5a4267a58e EditableDatumLabel: Extend with function to differentiate positioning from dimensioning OVPs 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
d0f9869f6d Sketcher Gui: DrawSketchController - lints 2023-11-08 15:20:13 +01:00
wmayer
bb90ced93e PD: fixes #11197: If bounding box of Body is activated it will be done for each sub-feature 2023-11-08 10:38:42 +01:00
Abdullah Tahiri
13e3491148 Sketcher: Handling of right mouse button during handler execution
=================================================================

    Instead of terminating the handler, as mandated before this PR by ViewProviderSketch, ViewProviderSketch
    delegates the action to DrawSketchHandler.

    DrawSketchHandler implements by default this terminating behaviour, but allows to override it.

    DrawSketchDefaultHandler (and all tools deriving from it) implement as default behaviour to cancel if
    in initial state, otherwise to reset.
2023-11-07 16:05:08 +01:00
Abdullah Tahiri
cc5e928d74 Sketcher: Handling of ESC keypress during handler execution
===========================================================

Instead of terminating the handler, as mandated before this PR by ViewProviderSketch, ViewProviderSketch
delegates the action to DrawSketchHandler.

DrawSketchHandler implements by default this terminating behaviour, but allows to override it.

DrawSketchDefaultHandler (and all tools deriving from it) implement as default behaviour to cancel if
in initial state, otherwise to reset.
2023-11-07 16:05:08 +01:00
Paddle
95e6699a3e EditableDatumLabel : Fix issue where the spinbox would get in the way of the cursor for angle. For example line angle. 2023-11-07 15:36:21 +01:00
Paddle
4e20c25839 EditableDatumLabel : make sure the spinbox that has the focus is on top. 2023-11-07 15:36:21 +01:00
Paddle
72b03cb787 Offset DSH : various fixes 2023-11-07 15:36:21 +01:00
Paddle
8e3ade309d Rectangle DSH : fix a bug when trying to make inward thickness. 2023-11-07 15:36:21 +01:00
Paddle
3334ac289c Rectangle DSH : Fixes #11287. Issue where the spinbox for frame thickness doesn't get focus. 2023-11-07 15:36:21 +01:00