Commit Graph

77 Commits

Author SHA1 Message Date
wandererfan
704fb894a5 [TD]getters and setters for geometry
- make attributes private (or protected) and use
  getters and setters instead of accessing attributes
  directly.
2023-02-28 08:15:06 -05:00
luzpaz
91a336b659 TechDraw: header uniformity + trailing whitespace 2023-01-21 20:11:08 -05:00
wandererfan
437457e996 [TD]remove obsolete log messages 2023-01-13 12:15:33 -05:00
wandererfan
88c7aac0d9 [TD]fix issues reported by 3d dimension testers
- correct interpretation of True vs Projected

- handle long subelement names in references

- fix "too small" value condition

- better error messages for bad dimension geometry
2023-01-07 16:32:03 -05:00
wandererfan
208104e9e0 [TD]Refactor Dimensions for 3d upgrade
- separate validation, geometry and reference handling into
  individual files
- improve 3d reference geometry handling
- eliminate duplicate dim creation code

- add Dimension reference repair dialog

- Refactor formatting out of DrawViewDimension

- move dimension repaint control to ViewProvider
2023-01-07 16:32:03 -05:00
wandererfan
0ff473a9b6 [TD]Complex Section - initial implementation 2022-10-28 08:47:45 -04:00
Uwe
d3c70c8740 [TD] E* - L*: remove unused includes
- also sort includes
- also additions to precompiled header
2022-10-05 03:43:42 +02:00
marioalexis
87dfe33833 TechDraw: Replace C cast 2022-09-18 11:06:51 -05:00
Benjamin Bræstrup Sayoc
b2a3d954ea [TechDraw] Improve readability of Geometry.cpp 2022-09-06 14:16:25 -04:00
wandererfan
aa2b1b8392 [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
luz paz
7b10713d6f Fix typos and whitespace
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,ro,rougly,seperator,serie,sinc,siz,strack,substraction,te,technic,thist,thru,tread,uint,unter,uptodate,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./src/Base/StackWalker.cpp,./build/doc/SourceDocu`
2022-08-23 18:49:47 +02:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Uwe
36add10c86 [TD] App: remove some superfluous nullptr checks 2022-07-19 02:03:50 +02:00
Uwe
19c8a76c62 [TD] App Headers: remove unused header - part 3/3 2022-03-25 01:13:34 +01:00
wmayer
e8f9c8a1d3 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
wmayer
883012e4b0 TD: Fix several coverity issues:
* CID 316569: Uninitialized scalar variable
* CID 350651: Unchecked dynamic_cast
* CID 350565: Unchecked dynamic_cast
* CID 350595: Unchecked dynamic_cast
* CID 350638: Unchecked dynamic_cast
* CID 350547: Division or modulo by float zero
2022-03-13 15:40:49 +01:00
edi271
8003ea80e5 [TD] Include Intersection method into DrawUtil class 2022-01-29 14:49:44 -05:00
Wanderer Fan
28c5890bc9 [TD] avoid memory leaks by using shared_ptr
TD geometry objects are sometimes double deleted.  This
change uses shared_ptr instead of raw pointers to manage
deletions.
2022-01-07 13:34:20 -05:00
wmayer
3fa4a321d3 TD: replace usage of raw pointers of Vertex and Face with shared pointers.
This fixes issue 4741: Broken File After Using Landmark Dimension in TechDraw
2021-12-10 14:25:24 +01:00
wmayer
a7f9c2f1b9 OCCT: port FreeCAD sources to version 7.6
SMESH is not yet ported
Although FreeCAD code compiles with OCCT 7.6 it doesn't work at the moment
2021-10-09 13:49:02 +02:00
Tomas Pavlicek
f31988b010 TechDraw - Add edge midpoint cosmetic vertex fix - added comments 2021-06-24 20:47:10 +02:00
Tomas Pavlicek
505a12cb5a TechDraw - Add edge midpoint cosmetic vertex fix 2021-06-21 15:20:52 +02:00
wmayer
9209d35390 TD: fix memory leaks in BaseGeom::baseFactory() and make code more readable 2021-04-23 17:05:13 +02:00
WandererFan
64a96e2216 [TD]CosmeticEdge setters and getters 2020-06-09 18:40:59 -04:00
WandererFan
2db99798f6 [TD]Improve section face display 2020-06-04 09:00:22 -04:00
wandererfan
cb2a3d529c [TD]Landmark Dims initial impl 2020-02-25 17:21:00 -05:00
wandererfan
15f180038f [TD]add ability to filter obvious geometry errors
- also add checks for geometry errors
2019-12-10 06:51:09 -05:00
wandererfan
a78e4229da [TD]correct face detection to avoid ghost faces 2019-11-27 07:31:45 -05:00
asapelkin
ced8100ab9 use emplace_back instead of push_back where justified 2019-11-21 14:48:09 +01:00
wandererfan
e64929de14 [TD]const-ness for dump function parameter 2019-11-10 15:58:45 -05:00
wandererfan
585a1ed772 [TD]fix duplicate name in parent & derived 2019-11-07 16:59:10 -05:00
wandererfan
5957b72573 [TD]ensure default edge avail for geom copy 2019-11-06 20:31:02 -05:00
wandererfan
f539a0ea8c [TD]use UUID for CosmeticEdges instead of indices 2019-11-06 20:31:02 -05:00
wandererfan
b34eb9de77 [TD]Implement unique tags for Cosmetic Vertex 2019-11-02 14:59:32 -04:00
wandererfan
88b07896e6 [TD]Extent Dimensions 2019-11-02 14:59:32 -04:00
wandererfan
67bfc739ec [TD]Check first/last geom points exist 2019-09-17 06:51:04 -04:00
wmayer
a79ce8d823 add missing std:: namespace to build on Debian 10 2019-08-21 23:56:46 +02:00
wandererfan
9828655f48 [TD]Add Properties for Cosmetic persistence 2019-07-15 12:36:48 -04:00
wandererfan
5d601c1cdd [TD]Add CenterLine edit function 2019-07-15 12:36:48 -04:00
wandererfan
7ee2f0c80a Cleanup dangling debug code 2019-07-15 12:36:48 -04:00
wandererfan
fbfdb69c20 [TD]Py Cosmetic Vertex, Line, Circle Arc 2019-07-15 12:36:48 -04:00
wandererfan
07e26d3624 Initial working version Face Centerline 2019-06-06 19:58:15 -04:00
wandererfan
108038df91 Add Midpoint and Quadrant Cosmetic Vertex 2019-05-24 19:38:02 -04:00
wandererfan
3f7570ad80 Initial version addCosmeticVertex 2019-05-24 19:38:02 -04:00
wandererfan
af0271691c Improve radius/diameter dims for ellipse,spline 2019-05-13 12:29:15 -04:00
wandererfan
626ee0c98d Fix TD Dfx export - spline conversion 2019-03-28 10:44:33 -03:00
wmayer
d7ec2b1368 Replace Base::Exception with appropriate subclass 2018-11-14 19:42:10 +01:00
wandererfan
fce600e29c Handle case of no points returned
- GeomAPI_ProjectPointOnCurve sometimes returns
  zero points and/or throws "NotDone" exception.
2018-11-09 22:26:37 +01:00
wandererfan
3ec9b798bf Fix BSpline/Circle conversion 2018-10-30 13:25:33 +01:00
wandererfan
64538f7b3c Use circles for circular BSplines 2018-10-25 10:58:53 -03:00