Commit Graph

21823 Commits

Author SHA1 Message Date
Abdullah Tahiri
7294d4d7a3 Sketcher: move comment to right position 2022-03-12 18:45:16 +01:00
Uwe
c50f2e980c [Assembly] fix typos found by the spellchecker CI 2022-03-12 17:52:33 +01:00
Uwe
931e2a3c17 [Robot] fix some typos found by the spellchecker CI 2022-03-12 17:46:48 +01:00
Abdullah Tahiri
5e88ee99f5 Sketcher: BSpline code review and fix
=====================================

- Avoid using EditCurve for the double use of storing the pole positions and the last mouse position. Split into individual vector for poles and previous cursor position (with appropriate names).
- Store all pole geoids to better show the intend of the code.
- Avoid indexing when referring the last inserted value of a std::vector, use back() instead.
- Encapsulate code to draw the bspline polygon and the cursor text to the given position. This allow to select the right function for every case, while avoiding unclear names, such as "mousemove()".
- Refactor code to finish command, to avoid calling unclear names such as "releasebutton" to better show the intend of the function call.
- Ensure deleted pole does not appear anymore in the scenograph.
2022-03-12 15:47:50 +01:00
Uwe
e4777d16f8 [Part] remove unused variable
MSVC complained about it
2022-03-12 15:44:27 +01:00
Wanderer Fan
7bef267503 [TD]fix 2 edge angle Dim special case 2022-03-12 08:55:35 -05:00
Chris Hennes
589f074e7d Test: Add first tests for Metadata 2022-03-11 20:15:44 -06:00
Chris Hennes
e7d50f0b13 Addon Manager: Fix window focus issues 2022-03-11 20:07:20 -06:00
mwganson
fc617e1524 Part: 2doffset fix crash by chacking for null shape before adding with builder.Add() 2022-03-12 02:48:22 +01:00
Zheng, Lei
2a28ad5cef PD: add SubShapeBinder 'Refine' property
Respect setting in BaseApp/Preferences/Mod/PartDesign/RefineModel
2022-03-12 02:45:13 +01:00
Zheng, Lei
8d6b06bc86 PD: fix SubShapeBinder 'Fuse' function 2022-03-12 02:45:13 +01:00
Uwe
5d798e26cf [Path] fix a typo 2022-03-12 02:24:44 +01:00
Uwe
5dba742beb [Path] 2nd part of the Git fix attempt
renaming it back
2022-03-12 02:01:29 +01:00
Uwe
99a0a67867 [Path] next attempt to fix Git error by renaming
use lowercase letters fro file ending like it is also in the CMake file
2022-03-12 02:00:40 +01:00
Uwe
76e601a712 [Path] try to silence a git error with a file
Git has issues with this file telling me it is corrupted and its file ending is wrong (in Git lowercase, in the file uppercase).

The attempt is to just to save save it with FC 0.20.
2022-03-12 01:55:37 +01:00
wmayer
ec8353ba99 Part: refactor PropertyPartShape::SaveDocFile and PropertyPartShape::RestoreDocFile
Set exception mask of std::istream::failbit | std::istream::badbit to istream to make sure it raises an exception for corrupted input files.
See: https://forum.freecadweb.org/viewtopic.php?p=536747
2022-03-11 22:06:38 +01:00
Wanderer Fan
cb5334a98c [TD]fix getScale should be Scale.getValue 2022-03-11 11:59:31 -05:00
sliptonic
da2dcaa7f4 Merge pull request #6552 from Russ4262/fix/leadin_leadout_simulation
Path: Fix Leadin-Leadout dressup simulation related to arcs [Bug]
2022-03-11 10:06:42 -06:00
sliptonic
14949faf06 Merge pull request #6541 from Russ4262/fix/ramp_entry_dressup
Path: Fix enumeration dictionary error [Bug]
2022-03-11 10:04:53 -06:00
sliptonic
f8fa9c047e Merge pull request #6530 from sliptonic/bug/6114
[Path] Fix minor non-modal bug.  Fixes 6114
2022-03-11 10:03:53 -06:00
sliptonic
f82951a6bc Merge pull request #6536 from J-Dunn/master
PATH: Fix tool shapes for zero dimension bugs
2022-03-11 09:56:52 -06:00
Wanderer Fan
53a105c397 [TD]fix Dim text on wrong side 2022-03-11 08:10:58 -05:00
wmayer
490dd63e77 Test: fix unit test 'Menu' 2022-03-11 13:57:56 +01:00
Civil Guy
3c2c38fd1a Minor spelling fixes 2022-03-11 13:57:03 +01:00
Yorik van Havre
82d93293b1 Arch: Fixed auto-height of child walls & structures - fixes #5732 2022-03-11 11:52:33 +01:00
Chris Hennes
dc113efa17 Addon Manager: Fix bug in macro button
Don't offer to install a toolbar button if it already exists.
2022-03-10 21:50:34 -06:00
Russell Johnson
a52e63b934 Path: Fix Leadin-Leadout dressup simulation related to arcs
Add missing "Z" and "K" parameters for arc commands to appease Path simulator.
2022-03-10 20:05:52 -06:00
luz paz
44bb1674b6 AddonManager: fix typos
Fixed via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,ro,rougly,seperator,serie,sinc,strack,substraction,te,technic,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./src/Base/StackWalker.cpp,./build/doc/SourceDocu`
2022-03-10 18:28:10 -05:00
Wanderer Fan
7903904f13 [TD]add missing ScaleType to Section dlg 2022-03-10 09:25:52 -05:00
Wanderer Fan
d9afcaa807 [TD]handle ScaleType in old documents 2022-03-10 09:25:52 -05:00
Yorik van Havre
419594a5dc Draft: Fixed error in SVG rendering of LinkedArrays - fixes #6516 2022-03-10 13:34:18 +01:00
Chris Hennes
c1d86b2f0b Addon Manager: Refactor to improve testability 2022-03-09 23:14:59 -06:00
Russell Johnson
c1529aba40 Path: Fix enumeration dictionary error
This commit corrects an incorrect dictionary key in the enumeration dictionary updated with recent translation fixes.
2022-03-09 21:03:34 -06:00
marioalexis
7124476d7a Part: Some updates in CompoundFilter.py 2022-03-10 03:07:07 +01:00
wmayer
042d9d248e App: correctly handle int as argument for ocumentPy::getObject
Add a unit test to confirm correct behaviour
2022-03-09 23:02:22 +01:00
wmayer
08b77bff08 Core/Mod: modernize C++11
* use nullptr
2022-03-09 21:55:31 +01:00
Chris Hennes
f4a51f3788 Addon Manager: Begin Macro unit tests 2022-03-09 12:14:57 -06:00
Ajinkya Dahale
201ef90a89 [Sketcher] Constrain first pole when created
By doing this, duplicate radius constraints are not made when deleting and
redefining second pole.
2022-03-09 16:43:47 +01:00
Ajinkya Dahale
f10ccfc0fb [Sketcher] Safeguard against spurious pre-selection
Preselection is sometimes not updated under some circumstances
1. when deleting an object through python;
2. before autoconstraint when deleting previous pole in bspline creation mode.

When the preselected curve is the deleted object, segfault/crash can happen.
2022-03-09 16:43:47 +01:00
Ajinkya Dahale
3fa1735088 [Sketcher] Redraw correctly on pole delete in "create b-spline"
This ensures that the last preview line drawn is always at the cursor and that
the coordinates are always w.r.t. the last defined pole.
2022-03-09 16:43:47 +01:00
marioalexis
3c2fc9374f Part: Check geometry in Part_ExplodeCompound command 2022-03-09 15:41:30 +01:00
J-Dunn
ce4637092e Add files via upload
Current V-bit totally hangs FC when cutting edge height is zero. Tip diameter of zero also causes errors. 
These two tool shapes add 1um offsets to various dimensions to prevent user entered parameters from inducing zero dimensions which make the solver barf.  
The rotational geometry has also been simplified. 
Some are non critical but tip diam increment is a work around. To be rigorous, the fixed value such ideally be relative to some dimension of the job, not the arbitrary constant. Hopefully 1um will be suitable for most FC applications unless someone is doing uv lithography masks ;) 
https://forum.freecadweb.org/viewtopic.php?f=15&t=54880&p=479739#p479739
This replaces earlier PR where these files were not uploaded. 
https://github.com/FreeCAD/FreeCAD/pull/4491
2022-03-09 12:13:40 +01:00
Uwe
b62cf543c7 [Part] change sGroup for Section Cut
as discussed here: https://forum.freecadweb.org/viewtopic.php?p=577536#p577536
2022-03-09 11:43:23 +01:00
Uwe
7de25e8c37 [Part] Section Cut: fix cut object naming issue 2022-03-09 03:04:13 +01:00
Chris Hennes
bbfc77f167 Addon Manager: Add unit tests for dependencies 2022-03-08 19:15:01 -06:00
Chris Hennes
936a1f01d4 Addon Manager: Improve dependency handling 2022-03-08 19:15:01 -06:00
Uwe
d1fae66f55 [Part] Section Cut: fix for tooltip handling 2022-03-09 01:52:16 +01:00
wmayer
b626b7d719 Gui: Optimize includes to reduce compile time 2022-03-09 01:25:29 +01:00
Uwe
4f5c29edd6 [Gui] Quarter: remove unused includes 2022-03-09 01:12:15 +01:00
wmayer
b02cb69baa Sketch: [skip ci] fix linking error with MSVC
For more details see: https://forum.freecadweb.org/viewtopic.php?f=10&t=66939
2022-03-09 01:11:15 +01:00