Commit Graph

1914 Commits

Author SHA1 Message Date
wmayer
c4e4b5cf02 TD: Use new-style syntax of connect()
When fixing clazy issues -Wclazy-fully-qualified-moc-types then old-style syntax of connect() may fail. Thus, replace it with the new-style syntax
2022-07-26 16:10:45 +02:00
Benjamin Bræstrup Sayoc
a1dfe2465f [TechDraw] Make image test a unittest 2022-07-26 09:40:19 -04:00
Benjamin Bræstrup Sayoc
4fc8596d7b [TechDraw] Make symbol test a unittest 2022-07-26 09:40:19 -04:00
Benjamin Bræstrup Sayoc
906618c0b6 [TechDraw] Make annotation test a unittest 2022-07-26 09:40:19 -04:00
Benjamin Bræstrup Sayoc
d1f107f656 [TechDraw] Make hatch test a unittest 2022-07-26 09:40:19 -04:00
andrea
5a9ffe468c Remove deprecated function 2022-07-26 08:52:04 -04:00
Uwe
c9b709d814 [TD] remove unnecessary nullptr checks 2022-07-26 00:28:57 +02:00
wmayer
e7edda9679 TD: [skip ci] Fix several clazy issues:
* Using copy-ctor but class TechDraw::anglePoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Using copy-ctor but class TechDraw::arcPoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
* signal arguments need to be fully-qualified (TechDrawGui::QGIView instead of QGIView) [-Wclazy-fully-qualified-moc-types]
* Use multi-arg instead [-Wclazy-qstring-arg]
* Use midRef() instead [-Wclazy-qstring-ref]
2022-07-25 17:00:48 +02:00
luz paz
a55f5eb1ae Fix typos in Part and TechDraw workbenches
[skip ci]
2022-07-21 15:15:35 +02:00
Benjamin Bræstrup Sayoc
6ed38eeb99 [TechDraw] Improve readability of DrawViewDetail.cpp
[TechDraw] Improve readability of DrawViewDimension.cpp

[TechDraw] Improve readability of DrawViewDimExtent.cpp

[TechDraw] Improve readability of DrawViewDraft.cpp

[TechDraw] Improve readability of DrawViewImage.cpp

[TechDraw] Improve readability of DrawViewMulti.cpp
2022-07-20 16:44:26 -04:00
edi271
a203b1ae30 [TD] Add SurfaceFinishSymbol command
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
2022-07-20 16:13:56 -04:00
Wanderer Fan
111aef4866 [TD]review comments and rebase for PR7197 2022-07-20 12:59:12 -04:00
Benjamin Bræstrup Sayoc
e326f9bd99 [TechDraw] Improve readability of DrawViewClip.cpp 2022-07-20 12:59:12 -04:00
Benjamin Bræstrup Sayoc
3979d589a3 [TechDraw] Improve readability of DrawViewBalloon.cpp 2022-07-20 12:59:12 -04:00
Benjamin Bræstrup Sayoc
b349d02496 [TechDraw] Improve readability of DrawViewArch.cpp 2022-07-20 12:59:12 -04:00
Benjamin Bræstrup Sayoc
fa27525021 [TechDraw] Improve readability of DrawViewAnnotation.cpp 2022-07-20 12:59:12 -04:00
Benjamin Bræstrup Sayoc
6aef122551 [TechDraw] Improve readability of DrawTile.cpp 2022-07-20 12:59:12 -04:00
Benjamin Bræstrup Sayoc
380219ad7f [TechDraw] Improve readability of DrawRichAnno.cpp 2022-07-20 12:59:12 -04:00
Uwe
7ab531c51a [TD] last part of removal of superfluous nullptr checks 2022-07-20 12:17:16 +02:00
Uwe
40d8ebb372 [TD] remove some more superfluous nullptr checks 2022-07-20 11:54:28 +02:00
Uwe
31bc9f3913 [TD] remove some more superfluous nullptr checks 2022-07-20 02:53:48 +02:00
Uwe
8304a0942e [TD] remove more superfluous nullptr checks 2022-07-20 02:32:52 +02:00
Uwe
af18a97913 [TD] Gui: remove more superfluous nullptr checks 2022-07-19 03:40:32 +02:00
Uwe
2e5e4dced8 [TD] Gui: remove some superfluous nullptr checks 2022-07-19 02:49:46 +02:00
Uwe
93796e2d92 [TD] App: remove some superfluous nullptr checks 2022-07-19 02:03:50 +02:00
Uwe
a4ec6d4f83 [TD] fix compilation on MSVC
- CLMODE was used before its declaration, therefore it did not compile
forum thread: https://forum.freecadweb.org/viewtopic.php?f=10&t=70316
2022-07-17 00:26:13 +02:00
Benjamin Bræstrup Sayoc
e80e8bf731 [TechDraw] Improve readability of DrawUtil.cpp 2022-07-16 16:00:43 -04:00
Benjamin Bræstrup Sayoc
0421d7cc5d [TechDraw] Gather rotation calculations in a single function 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
137a4e0ee6 [TechDraw] Improve readability of Cosmetic.cpp 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
568cc79186 [TechDraw] Refactor CosmeticEdge constructors
Use constructor delegation and default parameters for CosmeticEdge
2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
fac4e72ea4 [TechDraw] Use constructor delegation for CosmeticEdge 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
eb3a04f30e [TechDraw] Use default parameters for LineFormat constructor 2022-07-16 16:00:10 -04:00
Wanderer Fan
3137a81604 [TD]check for spline on linear Dims 2022-07-16 11:28:38 -04:00
Wanderer Fan
5d93fbe0bb [TD]fix ext line gap preference 2022-07-16 11:28:38 -04:00
Benjamin Alterauge
83203153cd Group dxf relevant files in one folder 2022-07-16 10:55:24 +02:00
Benjamin Bræstrup Sayoc
619c7942aa [TechDraw] Improve readability of ViewProviderWeld.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
bb44c9ece4 [TechDraw] Improve readability of ViewProviderViewSection.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
700a0217b4 [TechDraw] Improve readability of ViewProviderViewPart.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
87d4c8e237 [TechDraw] Improve readability of ViewProviderTemplate.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
cd1cc2e6e9 [TechDraw] Improve readability of ViewProviderRichAnno.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
46ab6b7534 [TechDraw] Improve readability of ViewProviderProjGroupItem.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
0bf9f1de93 [TechDraw] Improve readability of ViewProviderPage.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
0001965476 [TechDraw] Improve readability of ViewProviderLeader.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
4203420b02 [TechDraw] Improve readability of ViewProviderHatch.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
60e6a0e73e [TechDraw] Improve readability of ViewProviderGeomHatch.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
886f4fe1b9 [TechDraw] Improve readability of ViewProviderGeomHatch.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
c90fc4fe49 [TechDraw] Improve readability of ViewProviderBalloon.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
23c3cf76be [TechDraw] Improve readability of TaskWeldingSymbol.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
9830cabb33 [TechDraw] Improve readability of TaskSelectLineAttributes.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
8d7cb491f7 [TechDraw] Improve readability of TaskSectionView.cpp 2022-07-15 11:31:11 -04:00