kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
23,913 Commits 41 Branches 6 Tags
7413a8a71750c24f4e31bb1ef3a0db6d7768d586
Commit Graph

23913 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
j
7413a8a717 Sketcher: Preserve corner and constraints for sketch fillets 
Currently the sketch fillet tool deletes any constraints associated with
the two lines to be filleted. By leaving a vertex at the intersection,
we can instead preserve most constraints in reasonable ways.

Sketch fillet horizontal and vertical point-to-point constraint support
Also better future compatibility for point constraints, and some minor tweaks.
 2021-02-04 08:10:28 +01:00
sliptonic
fde9048778 Merge pull request #4262 from Schildkroet/adaptive_improve 
[PATH] Adaptive improve helix entry
 2021-02-03 19:02:38 -06:00
luz paz
19d0e1123f Draft: fix LGTM 'Testing for None should use the 'is' operator' alerrts 
https://lgtm.com/projects/g/FreeCAD/FreeCAD/alerts/?mode=tree&ruleFocus=7900090
 2021-02-03 21:58:47 +01:00
Benjamin Alterauge
19ad2e47bd Temporarily qt5 fixes for Apple Silicon need to disable the qtwebengine. That has to be considered in MacAppBundle. 2021-02-03 21:58:07 +01:00
wmayer
1efb1e344e Gui: [skip ci] restore tab order in selection settings page 2021-02-03 21:56:43 +01:00
Benjamin Nauck
67f21d663d Gui: Add support for selecting multiple objects without keyboard 
Adds checkboxes to the document tree which makes it possible to
select multiple document objects on devices without physical keyboard.

These checkboxes are opt-in and can be enabled/disabled from:
Edit -> Preferences -> Display -> Navigation -> Selection

Forum thread for feature the request:
https://forum.freecadweb.org/viewtopic.php?f=34&t=53065

We need to iterate the tree to add/remove the selection boxes when
the enable-setting has been changed.

The size for the first column in the tree is adjusted to fit both
name and optional checkbox.
 2021-02-03 21:51:56 +01:00
wmayer
78158a058b Gui: add preferences tab for selection 2021-02-03 18:06:55 +01:00
David Osterberg
c19341b866 PartDesign: Allow selection of sketch plane by double click in picker dialog 
Thanks to @0penBrain for solving a tricky segmentation fault
 2021-02-03 16:46:47 +01:00
donovaly
09385d9d00 fix issue reported by @chennes 
also fix annoying variable naming - different variables representing different types should not have the same name

also update a comment according to depending PRs
 2021-02-03 16:24:01 +01:00
donovaly
2a6d30da27 [PD] hole fix custom cut handling 
This PR is based on PR #4344 and a spin-off of PR #4337. It fixes:

We have normed screw head cuts. These values can be overridden but we must store the info about the overriding. Why? - because when you have e.g. made a custom change to a normed countersink and then change to another countersink norm, you would either not get the values defined in the norm or you get these values but loose e.g. your depth settings
 2021-02-03 16:23:28 +01:00
donovaly
c5fe2589d5 [PD] fix UTS clearance holes 
This PR is based on PR #4343 and a spin-off of PR #4337. It fixes:

- the bug that we did not use the normed clearance hole diameters for UTS holes
- missing recompute when changing existing hole from Metric to UTS type
 2021-02-03 16:19:24 +01:00
donovaly
19605200a1 [PD] hole dialog UI fixes 
This PR is the first in a series of probably 3 PRs to fix known hole dialog bugs.

This one fixes:

- the .ui file issues
- readonly status issues of some widgets/properties (e.g. when the hole is through all, disable drill point settings)
- the bug that updateHoleCutParams() overwrote the previously correctly determined hole diameter
- just a trifle: change a function name to fit into the naming scheme
 2021-02-03 16:14:36 +01:00
wmayer
d65937d338 Part: [skip ci] rename methods in TopoShape that override non-virtual functions of base class 2021-02-03 16:10:38 +01:00
donovaly
69f2f3b9e1 [PD] fix typo in iso7046.json 
This mistake was introduced by me in commit 51c9640f
 2021-02-03 15:08:30 +01:00
donovaly
8a3cc86d0c [TD] fix color change for dimensions 
This PR fixes issue C reported here: https://forum.freecadweb.org/viewtopic.php?f=35&t=55008#p472939
- the changed color must also be applied to the dimension line and arrows
 2021-02-03 14:11:44 +01:00
luz paz
d0d2581410 Fix various typos [skip ci] 
Found via codespell v2.1.dev0  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu
```
 2021-02-03 14:08:57 +01:00
wmayer
d3e4da9f51 Part: offer all supported STEP schemes by OCC in a combo box 2021-02-02 21:51:11 +01:00
Yorik van Havre
e947b9bb3b TechDraw: Exposed GeomHatch functionality to Python in TechDraw.makeGeomHatch() 2021-02-02 17:49:44 +01:00
Yorik van Havre
85f9d82937 Merge pull request #4331 from chennes/openSCADFix 
[Draft] OpenSCAD/DXF error: fix DXF import with no layers
 2021-02-02 14:01:43 +01:00
Yorik van Havre
762728b8c7 Merge pull request #4346 from chennes/validateStartHTMLWithW3C 
[Start] Modify generated HTML to comply with W3C Validator Recommendations
 2021-02-02 13:59:09 +01:00
Yorik van Havre
8b7debf8d3 Merge pull request #4351 from chennes/fixSurfaceDeleteShortcuts 
[Surface] Fix task panel Delete shortcut use to use Widget context
 2021-02-02 11:52:36 +01:00
Chris Hennes
a6b689f57c Fix Surface task panel shortcut use to use Widget context 
The Delete key shortcut of the three different panels in the
Surface Workbench TaskFilling sidebar conflicted between
the panels if multiple were showing. This is resolved by
making the QAction's context the widget, rather than the window.
 2021-02-01 19:40:33 -06:00
Chris Hennes
15afa3ae59 Remove extraneous lines from export 
Corrects a merge issue from an earlier PR: the removed lines are
redundant.
 2021-02-01 13:38:21 +01:00
Chris Hennes
4f3cc41d65 Modify Start HTML to be valid HTML 
Using the W3C validator, a number of minor issues were found with the Start page
HTML. Those items were:
* Missing language setting on the body of the document
* Deprecated attributes set for the style and script tags
* Image tags require alt text
* List tags can only contain list items
* All file:/// URLs must not contain backslashes, even on Windows
 2021-01-31 22:13:47 -06:00
Chris Hennes
2758e42adb Add tests for Start Page HTML validity 
This test is in two parts: first the generated HTML is sanitized to remove any
potentially sensitive information (e.g. filenames, authors, document info, etc.)
and is then sent to the W3C Validator service at https://validator.w3.org/nu.
The results are interrogated and if any errors or warnings are returned, the
test fails. If the site cannot be reached this is NOT treated as a test failure.

Second, the actual (unsanitized) filenames are checked for validity: the HTML
standard prohibits backslashes in URLs, even if the URL refers to a local file
on a system that uses backslashes as a path separator (e.g. Windows). This
would have been caught by the W3C Validator if we had not sanitized the filenames.
 2021-01-31 21:49:17 -06:00
Patrick F
9d0df01d17 [PATH] Limited cone angle for adaptiv helix 2021-01-31 21:23:57 +01:00
Zheng, Lei
52ae5f8d6c Gui: sync recent action file list from external modification 2021-01-31 18:14:18 +01:00
wmayer
8adf2aac25 [PD] [skip ci] fix alignment in pad dialog 
just a minor UI issue: when you decrease the width of the pad dialog (e.g. because you have a small screen), the alignment of the widgets is lost. This fixes it by grouping the widgets in a grid.
 2021-01-31 16:26:22 +01:00
donovaly
a884ea703e [PD] fix alignment in pocket dialog 
just a minor UI issue: when you decrease the width of the pocket dialog (e.g. because you have a small screen), the alignment of the widgets is lost. This PR fixes this by grouping the widgets in a grid.
 2021-01-31 16:03:57 +01:00
Aapo
9f49b122f4 [TD] Dimensions: donovaly's minor fixes for TheoreticalExact dimensions. 2021-01-31 15:17:46 +01:00
Aapo
f362930664 [TD] Improve arbitrary tolerance and unit handling for Equal Tolerances. 2021-01-31 15:17:46 +01:00
Aapo
dbef970697 [TD] Add under- and overtolerances for Dimension Task layout, fixes for Dimension tolerance refresh and behavior. 2021-01-31 15:17:46 +01:00
Aapo
5350a2c3d0 [TD] Fix degree sign processing for equilateral angular plusminus dimensions. 2021-01-31 15:17:46 +01:00
Aapo
e6ef62e711 [TD] Fix regression in Dimensions: Setting arbitrary under tolerance was somehow lost. 2021-01-31 15:17:46 +01:00
donovaly
96cbb986e2 [PD] correct hole cut definitions 
I was able to get the norms and could update the definitions accordingly.
For example in the ISO 10462, sizes smaller than M3 are not defined and your definition files should only contain what is really defined.
 2021-01-31 13:45:57 +01:00
Chris Hennes
049fd712e3 Enable LGTM to analyze some C++ source code 
FreeCAD as a whole is too large for LGTM to analyze the entire codebase, the operation
times out after three hours. By focusing only on the core code, this patch allows the
automated testing framework there to analyze our C++ code, in addition to the Python
and JavaScript analsis it was already doing.
 2021-01-30 17:30:22 +01:00
wmayer
ff28b5212f App: [skip ci] use better deprecation warning as used in PR 4335 2021-01-30 17:27:08 +01:00
wmayer
d77d3e81cb Part: [skip ci] fix path of attachment icon 2021-01-30 17:22:54 +01:00
wmayer
54a7ce43a0 App: [skip ci] print deprecation warning if addExtension() has two arguments 2021-01-30 17:20:43 +01:00
Stefan Tröger
ec5ac30756 Remove ExtensionProxy and rely on default Python proxy for extensions. fixes #0004534 2021-01-30 16:00:48 +01:00
Benjamin Nauck
51f8ea11d9 Spreadsheet: Add test for undo alias issue 2021-01-30 14:04:57 +01:00
Benjamin Nauck
aa91457491 Spreadsheet: Allow alias removed by undo to be reused 
Fixes issue descripted in the forum post:
https://forum.freecadweb.org/viewtopic.php?f=3&t=54009
 2021-01-30 14:04:57 +01:00
Kurt Kremitzki
1fb4e38e5e Merge pull request #4134 from donovaly/PD-Hole-DrillPoint 
[PD] improve blind hole depth handling
 2021-01-30 05:14:52 -06:00
Kurt Kremitzki
445bd30b76 Merge pull request #4165 from chennes/addImportExportRecentFilesPrefs 
[App] Add prefs for import/export in Recent Files
 2021-01-30 05:14:36 -06:00
Benjamin Nauck
49b7f237be [MeshPart] Fix copy-paste error 
It doesn't make sense to check minLen and then call SetMinSize to maxLen
so this must be a copy-paste error.

Introduced in eb6f60469a

Found with Coverity.
 2021-01-30 11:47:06 +01:00
Kurt Kremitzki
f1073ce6ae Merge branch 'master' into PD-Hole-DrillPoint 2021-01-29 19:02:34 -06:00
Kurt Kremitzki
f859e82b15 Merge branch 'master' into addImportExportRecentFilesPrefs 2021-01-29 19:02:21 -06:00
Chris Hennes
cbceb87d95 Fix DXF import with no layers 
As discussed in https://forum.freecadweb.org/viewtopic.php?f=3&t=54842, if OpenSCAD creates a DXF with no layers in it, the code that is supposed to handle that in FreeCAD has a minor type error in it that prevents the import from working.
 2021-01-29 17:01:22 -06:00
sliptonic
88a8eba77f Merge pull request #4325 from machste/fix_simple_copy 
Path: Fix creating simple copy
 2021-01-28 14:14:02 -06:00
Stefan Brüns
27cdc7cd9c Fix ODR violation, correct Ui_TaskSketcherGeneral namespace 
The generated ui_TaskSketcherGeneral.h defines the class in the
SketcherGui namespace.

Fixes #4529
 2021-01-28 17:43:10 +01:00