Commit Graph

30995 Commits

Author SHA1 Message Date
wmayer
756e081a78 Gui: fix some clang-tidy warnings:
* readability-braces-around-statements
2022-11-13 17:42:08 +01:00
wmayer
904f92d747 Gui: [skip ci] fix some clang-tidy warnings:
* cppcoreguidelines-non-private-member-variables-in-classes
2022-11-13 17:16:03 +01:00
wmayer
a62da05d5c clang-tidy: disable 'readability-redundant-access-specifiers' because clang-tidy fails to distinguish between 'public' vs. 'public Q_SLOTS' 2022-11-13 16:50:15 +01:00
wmayer
bbb3697b77 Gui: [skip ci] fix some clang-tidy warnings:
* cppcoreguidelines-special-member-functions
* cppcoreguidelines-explicit-virtual-functions
* readability-inconsistent-declaration-parameter-name
2022-11-13 16:35:11 +01:00
wmayer
951ea0a768 Gui: fix clazy warnings:
* Wclazy-connect-by-name
* Wclazy-connect-3arg-lambda
2022-11-13 16:08:46 +01:00
wmayer
fce59ca723 Sketcher: fix clazy warnings:
* Wclazy-connect-by-name
* Wclazy-unused-non-trivial-variable
* Wclazy-detaching-temporary
2022-11-13 15:39:27 +01:00
Paddle
0a5358c24f Sketcher: Fix element widget repaint delay bug
Related to https://github.com/FreeCAD/FreeCAD/pull/7567#issuecomment-1304724547
2022-11-13 07:13:06 +01:00
wmayer
0679c40d26 Gui: fix readability-identifier-length 2022-11-12 23:57:14 +01:00
wmayer
182aa2ac4c Gui: replace old-style with new-style connect 2022-11-12 21:57:26 +01:00
wmayer
ad8974e9d8 Gui: improve usability of QuantitySpinBox when used as menu item 2022-11-12 18:24:27 +01:00
wandererfan
2a6bd73fc0 [TD]apply review comments from @chennes
- also delete empty execute method
2022-11-12 11:35:22 -05:00
wandererfan
fe4a402b04 [TD]simplify section hatch file handling 2022-11-12 11:35:22 -05:00
wandererfan
3ce218d1d7 [TD]simplify embedded image handling 2022-11-12 11:35:22 -05:00
wandererfan
199fd11623 [TD]simplify embedded file handling 2022-11-12 11:35:22 -05:00
wandererfan
75e163213a [TD]simplify embedded hatch file handling 2022-11-12 11:35:22 -05:00
wandererfan
9c9013810e [TD]fix embedded template file handling 2022-11-12 11:35:22 -05:00
Chris Hennes
eed9b6480f Addon Manager: Refactor to extract metadata checker 2022-11-11 21:50:16 -06:00
wandererfan
d7ace29c75 [TD]fix vertical alignment of section pieces 2022-11-11 19:37:42 -05:00
wmayer
6a8468f5bd Gui: implement WorkbenchSwitcher class to encapsulate the parameter details 2022-11-11 22:53:02 +01:00
wmayer
c966c98614 Gui: simplify code to handle workbench selector
+ replace three boolean parameters with a single string parameter
+ refactor DlgGeneralImp::saveSettings/loadSettings
+ handle visibility of corner widgets
2022-11-11 22:53:02 +01:00
wmayer
2390ed8c8f Gui: [skip ci] fix several warnings reported by GH actions 2022-11-11 22:53:02 +01:00
wmayer
ceb1c83a35 Gui: replace old-style connect() with new-style 2022-11-11 22:53:02 +01:00
wandererfan
a4fbb2d802 [TD]Section dialog gui tweaks 2022-11-11 08:53:29 -05:00
Uwe
dbff8faef6 [Mesh] Feature*: remove unused includes
- also some sorting
2022-11-11 14:02:49 +01:00
wmayer
21f47cf2ec Gui: fix warnings reported by GH Actions:
* Fix trailing spaces
* Replace tabs
* Mark constructors with one argument explicit
* Fix typos
* Include FCGlobal.h to fix parsing errors
2022-11-11 09:56:43 +01:00
vernzimm
5f4dbf7b4c Gui: Add default JPEG save quality (#7737)
* Update SoFCOffscreenRenderer.cpp

Set jpg screenshot capture to 100% quality vs qimage defaulting to -1

* Add default quality to JPG export

Fixed original version and use quality 90% as compromise between file size and fidelity.
2022-11-10 22:49:28 -06:00
Uwe
7869b443db [skip ci] [Gui] NaviCube: fix warning about too short variable name
- also some whitespace unification
2022-11-11 05:16:18 +01:00
Uwe
70b9db569b [skip ci] [.clang] set pointer style to left
- since we added the .clang-format file we used Left for the pointer asterisk. It is annoying to get now all the time automatic diffs because the -clang file uses Right.
2022-11-11 05:12:47 +01:00
Uwe
60d536bdf2 [Gui] NaviCube: fix rotation to backside
- when pressing the "dot" besides the NaviCube, the rotation to the backside was not in the center thus the view jumped
2022-11-11 04:58:20 +01:00
Chris Hennes
33f671c6c1 Addon Manager: Ensure check message closes 2022-11-10 21:35:46 -06:00
Chris Hennes
103f8b77bf Addon Manager: Refactor to extract connection check GUI 2022-11-10 21:09:47 -06:00
Uwe
818ab2b3ff [.clang] use line break after case
- we used in the past line breaks after a case statements to better overview. This should be kept.
2022-11-11 04:06:21 +01:00
Uwe
8f2720b8b7 [Path] PathSimulator: remove unused includes
- also some sorting
2022-11-11 04:04:33 +01:00
Uwe
bc4a5fa006 [skip ci] [Github] add file endings 2022-11-11 03:47:00 +01:00
Uwe
7e7b046041 [Mesh] Imp* - end: remove unused includes
- also some sorting
2022-11-11 03:34:31 +01:00
wmayer
3ee47be1e0 Gui: don't use '_tooltip' as argument name because it's already used for a class member 2022-11-11 01:25:33 +01:00
wandererfan
1a9637a384 [TD]fix XDirection rotation of simple sections 2022-11-10 19:19:22 -05:00
wandererfan
94c5888921 [TD]fix oblique section line ends 2022-11-10 19:19:22 -05:00
wandererfan
0ebf61184a [TD]Section dialogs minor fixes
- make simple and complex dialogs consistent
- fix translation contexts
2022-11-10 19:19:22 -05:00
wandererfan
674b341af6 [TD]fix fail in calculating section line length 2022-11-10 19:19:22 -05:00
wmayer
1139e209a8 Gui: [skip ci] fix several warnings reported by GH actions 2022-11-10 23:52:29 +01:00
wmayer
84d0f4fb6f Gui: fix regression: show commands of selected category in Toolbar tab 2022-11-10 23:20:18 +01:00
wmayer
a95aefdb18 Gui: use new-style connect and add curly braces to improve readability 2022-11-10 23:20:18 +01:00
wmayer
1147758787 Gui: restore fixes of DlgKeyboard.ui and DlgToolbars.ui and fix build failure 2022-11-10 23:20:18 +01:00
Zheng, Lei
1611724d39 Gui: do not remove ending puncuation when clean action title 2022-11-10 23:20:18 +01:00
Zheng, Lei
7458912b33 Gui: fix shortcut context handling in ShortcutManager
Related #6097

Qt ignores shortcut of actions in invisible toolbar, but not for actions
in a hidden menu action of menu bar, which is likely a Qt bug. The
desired behavior should be that of toolbar actions, so that actions
belong to different workbenches can have the same shortcut without
conflict.

This commit works around this inconsistency by ensuring only the active
actions are added in menu bar. In addition, all active actions will be
added to a zero sized child widget of the main window, which ensures the
shortcuts of these actions being active regardless whether the action is
in toolbar or menu bar, visible or not.
2022-11-10 23:20:18 +01:00
Zheng, Lei
b48458673c Gu: fix readonly AccelLineEdit 2022-11-10 23:20:18 +01:00
Zheng, Lei
4b377e2c31 Gui: fix command completer selection on item activate 2022-11-10 23:20:18 +01:00
Zheng, Lei
362c781553 Gui: fix Customize -> Keyboard shortcut priroity list
Add API Command::initAction() to force create action for all commands
with shortcut in order to register with ShortcutManager to obtain a
complete list of actions with the same shortcut.
2022-11-10 23:20:18 +01:00
Zheng, Lei
93c4c0884e Gui: remove command description label in Customize -> Keyboard
Because long description may cause undesired dialog layout changes. The
description is available through tool tip of the command tree widget.
2022-11-10 23:20:18 +01:00