Commit Graph

21843 Commits

Author SHA1 Message Date
wmayer
76d1180283 Fem: Fix several coverity issues:
* make SelectionChangeModes an enum class
* CID 350596: Uninitialized scalar field
* CID 350572: Uncaught exception
* CID 350647: Uncaught exception
2022-03-13 14:09:04 +01:00
Anders Torger
08552c6e68 Apply multi-thread configuration for Calculix also when started via task panel 2022-03-13 13:32:30 +01:00
wmayer
68b92c504f Fix several coverity issues:
* CID 350617: Dereference after null check
* CID 350585: Out-of-bounds read
* CID 350624: Resource leak
* CID 332701: Uncaught exception
* CID 350642: Uninitialized scalar field
* CID 350590: Uninitialized scalar field
* CID 350629: Uninitialized scalar variable
* CID 350602: Uninitialized scalar variable
* CID 350564: Uninitialized scalar variable
* CID 350548: Uninitialized scalar variable
2022-03-13 12:12:49 +01:00
wmayer
02bd57ac82 PD: Fix several coverity issues:
* CID 350622: Negative array index read
* CID 350613: Negative array index read
* CID 166163: Negative array index read
* refactor Hole::updateDiameterParam()
2022-03-13 12:10:01 +01:00
Abdullah Tahiri
8c35a895eb Sketcher: Redraw constraints on wheel event
===========================================

https://forum.freecadweb.org/viewtopic.php?p=577585#p577585
2022-03-13 11:33:52 +01:00
wmayer
33577a087f Robot: [skip ci] add header with export macros 2022-03-13 08:37:58 +01:00
Ajinkya Dahale
76029a5b2d [Sketcher] Fix "toggle internal geo" on multi-selection
Some deleted GeoIds can stay in selection and GeoIds can change as some objects
are deleted.
2022-03-13 06:58:40 +01:00
sliptonic
b0d19d28d7 Merge pull request #6566 from Russ4262/fix/boundary_dressup_begin_safeheight_retraction
Path: Correct beginning retraction to safe height in Boundary Dressup, issue #6279 [Bug]
2022-03-12 19:05:39 -06:00
Uwe
131a8d038a [Assembly] fox typos in element names
all found by the spellchecker CI
2022-03-13 01:32:27 +01:00
sliptonic
a10fd46b09 Merge pull request #5440 from voneiden/path-array-improvements
Path: Path Array dressup compatibility
2022-03-12 18:21:40 -06:00
mwganson
3e18c76d4f PartDesign::SubShapeBinder add 2D offsetting 2022-03-12 23:30:09 +01:00
Anders Torger
65718f0e51 Add General.NumThreads = CPU core count setting to Gmsh
settings file to enable multi-threaded meshing (much faster
for larger models)
2022-03-12 23:26:55 +01:00
Matti Eiden
af8b6fba07 PathArray: Support applying PathArray on Dressups 2022-03-12 22:31:16 +02:00
Abdullah Tahiri
a5d0de0994 Sketcher: Coverity 332695 - unlikely array indexing with negative value 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
4185b8b849 Sketcher: Coverity 332679 - logically dead code removed 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
d60da72b6e Sketcher: Coverity 332685, 332686, 332696
=========================================

Detected by coverity as unchanged variable (constant intended).

It was actually an unnecessary variable that prevented correct command committing.
2022-03-12 21:14:19 +01:00
Abdullah Tahiri
fb87709193 Sketcher: Coverity 350601 - possible resource leak 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
c7367dc167 Sketcher: Coverity 350637 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
8a20f1a071 Sketcher: Coverity 350641 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Russell Johnson
dd76cabb34 Path: Correct beginning retraction to safe height feed rate, issue #6279 [Bug]
This commit changes the feed rate of the beginning retraction from G1 at Feed to a G0 Rapid rate.  This initial command is causing a problem with the Tag Dressup due to the first move being a G1 to Safe Height.
2022-03-12 12:18:09 -06:00
Abdullah Tahiri
e48d3e355d Sketcher: move comment to right position 2022-03-12 18:45:16 +01:00
Uwe
a9b510f640 [Assembly] fix typos found by the spellchecker CI 2022-03-12 17:52:33 +01:00
Uwe
06c9907982 [Robot] fix some typos found by the spellchecker CI 2022-03-12 17:46:48 +01:00
Abdullah Tahiri
a6e67dafa2 Sketcher: BSpline code review and fix
=====================================

- Avoid using EditCurve for the double use of storing the pole positions and the last mouse position. Split into individual vector for poles and previous cursor position (with appropriate names).
- Store all pole geoids to better show the intend of the code.
- Avoid indexing when referring the last inserted value of a std::vector, use back() instead.
- Encapsulate code to draw the bspline polygon and the cursor text to the given position. This allow to select the right function for every case, while avoiding unclear names, such as "mousemove()".
- Refactor code to finish command, to avoid calling unclear names such as "releasebutton" to better show the intend of the function call.
- Ensure deleted pole does not appear anymore in the scenograph.
2022-03-12 15:47:50 +01:00
Uwe
1e852e6d6b [Part] remove unused variable
MSVC complained about it
2022-03-12 15:44:27 +01:00
Wanderer Fan
12f0736189 [TD]fix 2 edge angle Dim special case 2022-03-12 08:55:35 -05:00
Chris Hennes
84bc5ea5d1 Test: Add first tests for Metadata 2022-03-11 20:15:44 -06:00
Chris Hennes
633449f8f7 Addon Manager: Fix window focus issues 2022-03-11 20:07:20 -06:00
mwganson
72e06ae529 Part: 2doffset fix crash by chacking for null shape before adding with builder.Add() 2022-03-12 02:48:22 +01:00
Zheng, Lei
b47e6723dc PD: add SubShapeBinder 'Refine' property
Respect setting in BaseApp/Preferences/Mod/PartDesign/RefineModel
2022-03-12 02:45:13 +01:00
Zheng, Lei
e56bcbc924 PD: fix SubShapeBinder 'Fuse' function 2022-03-12 02:45:13 +01:00
Uwe
48b2c3da12 [Path] fix a typo 2022-03-12 02:24:44 +01:00
Uwe
bc09020e8b [Path] 2nd part of the Git fix attempt
renaming it back
2022-03-12 02:01:29 +01:00
Uwe
6901b9cf63 [Path] next attempt to fix Git error by renaming
use lowercase letters fro file ending like it is also in the CMake file
2022-03-12 02:00:40 +01:00
Uwe
b6f3295201 [Path] try to silence a git error with a file
Git has issues with this file telling me it is corrupted and its file ending is wrong (in Git lowercase, in the file uppercase).

The attempt is to just to save save it with FC 0.20.
2022-03-12 01:55:37 +01:00
wmayer
c3828d6225 Part: refactor PropertyPartShape::SaveDocFile and PropertyPartShape::RestoreDocFile
Set exception mask of std::istream::failbit | std::istream::badbit to istream to make sure it raises an exception for corrupted input files.
See: https://forum.freecadweb.org/viewtopic.php?p=536747
2022-03-11 22:06:38 +01:00
Wanderer Fan
ed82b361bf [TD]fix getScale should be Scale.getValue 2022-03-11 11:59:31 -05:00
sliptonic
e1ce0c7695 Merge pull request #6552 from Russ4262/fix/leadin_leadout_simulation
Path: Fix Leadin-Leadout dressup simulation related to arcs [Bug]
2022-03-11 10:06:42 -06:00
sliptonic
0bc9edeb50 Merge pull request #6541 from Russ4262/fix/ramp_entry_dressup
Path: Fix enumeration dictionary error [Bug]
2022-03-11 10:04:53 -06:00
sliptonic
182cabcfbb Merge pull request #6530 from sliptonic/bug/6114
[Path] Fix minor non-modal bug.  Fixes 6114
2022-03-11 10:03:53 -06:00
sliptonic
5eb170df1a Merge pull request #6536 from J-Dunn/master
PATH: Fix tool shapes for zero dimension bugs
2022-03-11 09:56:52 -06:00
Wanderer Fan
0676c27443 [TD]fix Dim text on wrong side 2022-03-11 08:10:58 -05:00
wmayer
92ec0d2334 Test: fix unit test 'Menu' 2022-03-11 13:57:56 +01:00
Civil Guy
6a00ef0ed1 Minor spelling fixes 2022-03-11 13:57:03 +01:00
Yorik van Havre
ffbbb4ec9f Arch: Fixed auto-height of child walls & structures - fixes #5732 2022-03-11 11:52:33 +01:00
Chris Hennes
248946009c Addon Manager: Fix bug in macro button
Don't offer to install a toolbar button if it already exists.
2022-03-10 21:50:34 -06:00
Russell Johnson
48e4622193 Path: Fix Leadin-Leadout dressup simulation related to arcs
Add missing "Z" and "K" parameters for arc commands to appease Path simulator.
2022-03-10 20:05:52 -06:00
luz paz
8204fc84bf AddonManager: fix typos
Fixed via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,ro,rougly,seperator,serie,sinc,strack,substraction,te,technic,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./src/Base/StackWalker.cpp,./build/doc/SourceDocu`
2022-03-10 18:28:10 -05:00
Wanderer Fan
3b4b5a4e7c [TD]add missing ScaleType to Section dlg 2022-03-10 09:25:52 -05:00
Wanderer Fan
bbffb3f413 [TD]handle ScaleType in old documents 2022-03-10 09:25:52 -05:00