Commit Graph

20441 Commits

Author SHA1 Message Date
Abdullah Tahiri
779631a67b Sketcher: Element Widget External/Construction icons fixes
==========================================================

Changes:
- Move multIcon structure to be internal to TaskSketcherElements class
- Change Caps to MultIcon for consistency
- Move tamperIcon from TaskSketcherElements to MultIcon struct
- Change tamperIcon method to be the constructor of MultIcon and change from struct to class
- Update the tamperIcon algorithm, so that only the point that is not marked in green as selected
is made pink.

Bug fix:

UpdateIcons and SlotElementsChanged are methods sharing code (they could benefit from a refactoring), but
they are conceptually different and are called in very different circumnstances.

UpdateIcons preserves selection. This means that one may select the stating point of line1, press z to switch
to edges, select the edge of line 2 and do a point on object constraint all without touching the 3D view.

SlotElementsChanged occurs when there are additions or removals in the number of geometry elements of the widget.

Warning:

This code requires QT 5.6 because of function pixelColour(int, int):
https://doc.qt.io/qt-5/qimage.html#pixelColor-1

Travis without QT5 complains with:

/home/travis/build/FreeCAD/FreeCAD/src/Mod/Sketcher/Gui/TaskSketcherElements.cpp:1120:31: error: ‘class QImage’ has no member named ‘pixelColor’; did you mean ‘setColor’?
2020-04-07 17:05:37 +02:00
0penBrain
7db539fb21 [Sketcher] Distinguish normal/reference/construction elements in task dialog 2020-04-07 17:05:37 +02:00
sliptonic
591675cb0a Merge pull request #3316 from realthunder/FixPathSort
Path: handle open edges when sorting path
2020-04-07 09:31:01 -05:00
wmayer
969c759a56 Cloud: [skip ci] fix linking issues on macOS 2020-04-07 15:52:29 +02:00
sliptonic
fc82fda520 Merge pull request #3295 from etrombly/3d_surface_perf
[PATH] 3d surface performance improvements
2020-04-07 08:47:32 -05:00
wmayer
83bbf2ffa8 [skip ci] fix typos 2020-04-07 12:50:54 +02:00
sliptonic
baa5c92bae Merge branch 'master' into FixPathSort 2020-04-06 14:33:55 -05:00
sliptonic
78b08c6298 Merge branch 'master' into 3d_surface_perf 2020-04-06 14:33:26 -05:00
sliptonic
9faec4bced Merge pull request #3318 from Schildkroet/deburr+dressup
[Path] Removed offset check
2020-04-06 14:31:16 -05:00
Patrick F
2359919078 Removed offset check 2020-04-06 21:11:40 +02:00
wmayer
20745f3301 Gui: [skip ci] add options to set one-pass and backface-pass rendering 2020-04-06 19:50:58 +02:00
wmayer
3c52ff6c7f Gui: [skip ci] improve whitespaces 2020-04-06 19:50:08 +02:00
wmayer
7f0852ef11 Cloud: [skip ci] restore old CMake variable to link to OpenSSL to fix build failure on Linux and Windows 2020-04-06 17:58:08 +02:00
wmayer
a0c5f999a3 Cloud: fix broken CMake file 2020-04-06 17:07:09 +02:00
wmayer
43844e9a59 Part: [skip ci] set again Two-side rendering as default lighting style 2020-04-06 14:12:44 +02:00
Eric Trombly
56769f1a27 change isOnLine to isOnLineSegment 2020-04-06 06:34:53 -05:00
Eric Trombly
1ac9c2f4e9 move getFacets from Path to Part 2020-04-06 06:34:53 -05:00
Eric Trombly
6262dc561f added check that facets are valid in getFacets 2020-04-06 06:34:53 -05:00
Eric Trombly
6bb5873e3e add changes to Waterline 2020-04-06 06:34:53 -05:00
Eric Trombly
169d910eca Area.cpp and CMakeLists.txt had extranious line ending 2020-04-06 06:34:53 -05:00
Eric Trombly
c8901cd5af clean up commented old code 2020-04-06 06:34:53 -05:00
Eric Trombly
7cc190fff0 remove debug profiling from surface 2020-04-06 06:34:53 -05:00
Eric Trombly
edf9319f5a visual studio doesn't like indexing facets with [, changed to ( 2020-04-06 06:34:53 -05:00
Eric Trombly
a0e45bffaa remove parallel processing, replace mesh generation with getting facets 2020-04-06 06:34:53 -05:00
Eric Trombly
94935996cb change from openmp to std::thread 2020-04-06 06:34:53 -05:00
Eric Trombly
144d3b62f3 changed some for loops to list comprehensions, added openmp for area to make two loops parallel, changed a fuse to a compound 2020-04-06 06:34:53 -05:00
Eric Trombly
f210d71f18 remove sleep calls, change some for loops to list comp, move isPointOnLine to base vector 2020-04-06 06:34:53 -05:00
Syres916
a0ec977152 [Gui] Edit Menu Remove Duplicate Shift+E...
....shortcut, return Toggle Edit to pre-Big Merge with no shortcut.

See Discussion https://forum.freecadweb.org/viewtopic.php?f=3&t=44394
2020-04-06 13:04:01 +02:00
vocx-fc
9d9102bc7e Draft: Draft_Text split lines by newline characters 2020-04-06 13:01:32 +02:00
vocx-fc
9f28844bf2 Draft: example file with a preview in the Start page 2020-04-06 12:58:32 +02:00
Jean-Marie Verdun
6a96fc2bee Fix MacOS build with Catalina and latest homebrew
Add support for self signed certificate in the case the end user wants
to use minio or any other self hosted s3 storage
2020-04-06 12:57:44 +02:00
luz.paz
ae72e2c762 Trivial code formatting for some {.cpp,.h} files 2020-04-06 12:55:27 +02:00
vocx-fc
3f726f662f Draft: update unit test for gui_edit 2020-04-06 12:51:55 +02:00
vocx-fc
7d102a5370 Draft: move Draft_Edit to another module 2020-04-06 12:51:55 +02:00
Zheng, Lei
9c86629a5f Path: handle open edges when sorting path 2020-04-06 09:58:01 +08:00
sliptonic
23ae15edc2 Merge pull request #3132 from Schildkroet/deburr+dressup
[Path] Deburr+DressupLeadInOut fixes
2020-04-05 18:34:52 -05:00
wandererfan
147539f37a [TD]fix single quote in anno string list 2020-04-04 22:42:13 -04:00
donovaly
3736ef56e7 [TD] sanitize broken SVGs
-also move them to the right folder
see discussion in: https://github.com/FreeCAD/FreeCAD/pull/3304
2020-04-04 09:32:58 -04:00
wmayer
aac7392740 Gui: move functions to list menus and toolbars from sub-class to base Workbench class
implement new function to list all toolbars and their used commands
2020-04-04 11:46:45 +02:00
wmayer
ef303c766e Gui: [skip ci] replace tabs with spaces in GUI init script 2020-04-04 09:42:30 +02:00
wmayer
e2e4ecf36c Gui: [skip ci] fix regression by using UTF-8 encoding in PropertyItem::setPropertyValue 2020-04-03 16:22:35 +02:00
wmayer
ff9029938f [skip ci] improve whitespaces 2020-04-03 16:19:24 +02:00
wmayer
5ea0ae5471 Gui: [skip ci] disable workaround to avoid handling an event twice because it leads to a regression on macOS 2020-04-03 15:11:24 +02:00
wandererfan
04fb64b411 [TD]Add symbols from AndreH 2020-04-03 08:16:53 -04:00
wandererfan
3483ebdb31 [TD]do not write BOM on SVG export 2020-04-03 08:16:53 -04:00
wmayer
a709ac2f03 App: [skip ci] handle types long and unsigned long in PropertyPlacement::setPathValue() 2020-04-03 12:02:46 +02:00
sliptonic
69726fcf92 Merge pull request #3303 from Schildkroet/4th-axis-improve
[Path] Bugfix for circular hole base
2020-04-02 15:39:43 -05:00
Patrick F
7d3c7dfef0 Bugfix for circular hole base 2020-04-02 19:38:21 +02:00
wmayer
acb29dead8 [skip ci] fix typos 2020-04-02 17:46:46 +02:00
vocx-fc
2cd9a542b5 Draft: task_scale, small style improvements 2020-04-02 16:53:49 +02:00