Commit Graph

33310 Commits

Author SHA1 Message Date
Abdullah Tahiri
78ae9c1d7d SketcherGui: apply clang-format 2023-05-25 17:08:03 +02:00
Chris Hennes
dc2d861bf0 Merge pull request #9637 from Ondsel-Development/sanitybug
fix label and file size
2023-05-25 07:28:33 -05:00
Roy-043
3aca29a8b4 Sketcher: fix typo in Refraction constraint menu text 2023-05-25 14:12:06 +02:00
Roy-043
254cec4067 Sketcher: Improve grid and snap related GUI texts
- Always use sentence case (as elsewhere in Sketcher)
- 'Toggle grid' instead of 'Activate grid'.
- Some other minor changes.
2023-05-25 14:10:45 +02:00
Abdullah Tahiri
0bdc7bb370 SketcherGui: Separate user and developer errors
===============================================

Revisiting all console calls:
- Using the Notification Framework when the user needs to be notified
- Turning them into DeveloperError/DeveloperWarnings when messages are intended only for developers
2023-05-25 14:09:06 +02:00
Abdullah Tahiri
0638a1b507 Console: Update loging macros to only send to developers 2023-05-25 14:09:06 +02:00
Przemo Firszt
896938e21f [COPR] Add BuildRequires: qqc2-desktop-style
Signed-off-by: Przemo Firszt <przemo@firszt.eu>
2023-05-24 22:44:37 +02:00
Chris Hennes
1ea981c34a Gui: Don't show raw exception to user 2023-05-24 20:57:43 +02:00
Abdullah Tahiri
7dbba6dc86 Sketcher: add clang formatting commits to git blame ignore 2023-05-24 20:55:50 +02:00
Roy-043
2b853b0126 Draft: Draft_CubicBezCurve: set EnableSelection to False, fixes #6452 (#9640)
While the command is active set EnableSelection to False to correctly detect mouse up events.
2023-05-24 20:35:24 +02:00
Yorik van Havre
b801983109 Draft: Fixes continuing dimensions - fixes #9507 (#9632) 2023-05-24 20:34:52 +02:00
Abdullah Tahiri
2bc3295cf3 Sketcher: Obey non-intrusive preferences for modal pop-ups
==========================================================

This commit turns the remaining blocking pop-ups in which the user can only click "ok"
into non-intrusive notifications, depending on the user preferences in settings.
2023-05-24 18:35:41 +02:00
Abdullah Tahiri
6a797bc1e9 Gui: Notifications Framework - accept more notifier types
=========================================================

Extends notifier types to Gui::Document, App::Document, Gui::ViewProviderDocumentObject.

This allows to pass these objects as notifiers, and the framework gets the right string
from the Label or FullLabel as appropriate.
2023-05-24 18:35:41 +02:00
wandererfan
e8bc9af344 [TD]prevent object deletion outside dialog 2023-05-24 10:15:45 -04:00
wandererfan
27ef8a598d [TD]fix fail on object deleted during dialog (#9626) 2023-05-24 10:15:45 -04:00
Jonas Bähr
83dec50295 Add myself to CONTRIBUTORS 2023-05-23 17:13:56 -04:00
wmayer
9fba227887 Sketcher: fix crash when creating a parabola or hyperbola or when using Sketcher_Split
Forum: https://forum.freecad.org/viewtopic.php?t=78543
2023-05-23 20:01:41 +02:00
wmayer
c72459c268 MeshPart: Allow to cancel trim by plane 2023-05-23 16:05:49 +02:00
Abdullah Tahiri
55a61e82a9 Console: Improve the documentation 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
28b7176691 NotificationArea/Preferences: Allow Opt-in for Developer warnings and errors
============================================================================

The old preferences had errors and warnings ON by default and allowed to opt-out.
It was not possible to separate errors/warnings intended for users from those intended for developers.

The new version has developer errors and warnings OFF by default. User intended ones are ON.
It is possible to opt-in for developer errors and warnings from the preferences dialog.

As developer errors and warnings are NOT translated, if opting-in, they won't be localised.

User errors and warnings should be translated. If they are not, it is a bug.
2023-05-23 14:24:45 +02:00
Abdullah Tahiri
bcedfae708 Sketcher: Command constraints error handling adaptation
=======================================================

- Better handling for exceptions originating in Python addConstraint.
- Refactor to reuse code for handling of exceptions
2023-05-23 14:24:45 +02:00
Abdullah Tahiri
17f65d8746 Sketcher: Make Command Constraints show the severity of warning for typical user mistakes 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
1b59b75482 Base: Interpreter - Mark Exception reporting and stack as intended for developers 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
5e5d863968 Console: Remove Translated Notification message
===============================================

With the new console extension, the translation state is coded separatedly.

Therefore, it is possible to code a Notification as translated without needing a specific type.

Additionally, any other message, such as Error of Warning can be translated.

It does not make sense to leave this message, if only for reasons of coherence and to simplify
maintainance of code.
2023-05-23 14:24:45 +02:00
Abdullah Tahiri
3b04601ade Gui: Adapt Notifications Framework 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
3097892d08 App: NotificationArea adaptation to the new messages 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
3b82bf62f7 Console: Extend the Python interface 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
125a6f7bc4 Console: Convenience dedicated functions 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
5f52885fbf Ilogger - Separate behaviour for user exposed and not exposed loggers 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
9d9f928b2d Console: Extend framework with intended recipient and content type metainformation
==================================================================================

Limitations of the current framework:
- Codes the translated state only for TranslatedNotification as part of the type.
- Does not code the intended recipient (user, developer, ...)

Problems:
- Some errors are intended for developers, some errors may only be intended for users,
if, for example, there is another developer error which already contains all the information.
The current framework may lead to information duplication or to showing to the user developer
information, which is perceived as annoying.
- Logs shall be in English (report view), while every message to the user (UI) shall be translated.
The current framework can only differentiate where to report based on subscription (legacy logs do not
subscribe to notifications), and for notifications, whether it is translated or not depends on the type.
It is not possible to code errors or warnings that are already translated.

Solution:
- To extend the ILogger interface with additional metainformation, indicating the intended recipient
(User, Developer, All), and the content of the message (translated, untranslated, untranslatable). The latter
is useful for dynamic strings that won't find a match in the translation framework.

Bonus:
- This extended version allows to do away with translatednotification, as now any message can be independently
marked as translated or untranslated or untraslatable.
- It is now possible to provide the right icon of severity (error, warning, info), even when it is only user intended
and already translated.
2023-05-23 14:24:45 +02:00
Jonas Bähr
f3595bce0b Sketcher: Add tests for Circle to Line distance constraint
Note that support for secants currently only works for reference
constraints but not for driving ones. If and how this should be done
is still under discussion [1].

[1]: https://github.com/FreeCAD/FreeCAD/pull/9044#issuecomment-1548006842
2023-05-23 14:19:51 +02:00
Yorik van Havre
4250d8f991 Merge pull request #9586 from yorikvanhavre/arch-ifc-export-fix
Arch: Minor fix to IFC exporter
2023-05-23 13:53:14 +02:00
Yorik van Havre
2751e92db5 Merge pull request #9585 from yorikvanhavre/arch-svg-fill
Arch: Fixed SVG fill
2023-05-23 13:52:33 +02:00
sliptonic
df1d81c2d5 fix label and file size 2023-05-22 20:25:16 -05:00
Chris Hennes
5ce3e83eac Merge pull request #9624 from wwmayer/fix_OpenSCAD_cmds
OpenSCAD: Hull/Minkowski also work for a single selected object
2023-05-22 13:45:31 -05:00
Chris Hennes
24a22f9635 Merge pull request #9381 from wwmayer/tweak_clang_format
Set BreakConstructorInitializers to BeforeComma
2023-05-22 09:01:12 -05:00
Chris Hennes
7e6fe6030f Merge pull request #9627 from chennes/addonManagerMiscBugs
Addon Manager: Minor error handling cleanup
2023-05-21 20:37:54 -05:00
Chris Hennes
9e45aa4e1b Merge pull request #9629 from chennes/updateTranslations20230521
Update translations
2023-05-21 19:58:00 -05:00
Chris Hennes
452067c43c Update translations 2023-05-21 19:13:11 -05:00
Chris Hennes
cb8f1a9baa Merge pull request #9628 from chennes/crowdInScriptTweak
Tools: Modify CrowdIn to only generate QMs when needed
2023-05-21 19:11:18 -05:00
Chris Hennes
b851452557 Tools: Modify CrowdIn to only generate QMs when needed 2023-05-21 19:01:42 -05:00
Chris Hennes
aae9334b7f Addon Manager: Minor error handling cleanup 2023-05-21 15:50:29 -05:00
wmayer
f5fef1c6db OpenSCAD: Hull/Minkowski also work for a single selected object 2023-05-21 16:42:09 +02:00
Roy-043
e1829be977 Draft: fix props_changed_placement_only for attached clones and similar (#9623)
For an attached object whose Shape depends on one or more source objects props_changed_placement_only should always return False.
2023-05-21 16:15:55 +02:00
Chris Hennes
38230171f4 Merge pull request #9614 from chennes/fixPrefPageContext
Gui: Correct translation context of pref pages
2023-05-20 19:53:32 -05:00
MaxiV
f1ab344881 Delete A4_IRAM4504.svg
It is included in the AR_IRAM folder
2023-05-20 10:31:00 -04:00
sliptonic
890979b3c3 Merge pull request #9608 from chennes/pathHTMLRemoval
Path: Remove HTML where not needed
2023-05-20 07:51:57 -05:00
Roy-043
6d69a65218 Draft: remove obsolete gui_array_simple.py (#9616) 2023-05-20 10:37:31 +02:00
Abdullah Tahiri
9dfbd6d24b Sketcher: Add App directory to pre-commit 2023-05-20 07:55:05 +02:00
Abdullah Tahiri
0f14065d0a Sketcher: App - Clang-format 2023-05-20 07:55:05 +02:00