kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
27,511 Commits 40 Branches 6 Tags
7c2beac6de6d9a69700193c25e55a73e456ae185
Commit Graph

63 Commits

Author SHA1 Message Date
wmayer
7c2beac6de PD: restore old method name and fix doxygen documentation 2022-02-13 22:30:17 +01:00
Uwe
12b0e0dd92 [PD] add option to create tapered Pad / Pocket 
This PR adds the same functionality as provided by Part Extrude.
The used code parts are sorted out to a new helper function that is used by Part and PartDesign.
 2022-02-02 01:04:06 +01:00
Uwe
5dc8144720 [PD] uniform default Pad/Pocket lengths 
- the initialization of the length was different than the default set in Command.cpp
- it is annoying that the default 2nd length was 10 and 20 times the default for the 1st length
  -> uniform and take the same than the 1st length
 2022-01-23 13:42:07 +01:00
Uwe
849751a771 Revert "[PD] uniform default Pad/Pocket lengths" 
This reverts commit ab879eff243c3c5ed7f8c250db32522e5aff329c.

Sorry, this should have gone to a PR
 2022-01-23 05:06:38 +01:00
Uwe
de3bc18247 [PD] uniform default Pad/Pocket lengths 
- the goal of the recent Pad/Pocket code refactoring was to handle Pad and Pocket the same
  default Pad were 10 long, Pocket only 5 -> uniform this to 10
- the initialization of the length were different than the default set in Command.cpp
- it was annoying that the default 2nd length was 10 and 20 times the default for the 1st length -> uniform and take the same than the 1st length
 2022-01-23 04:58:58 +01:00
Uwe
21f6602d5b [PD] Pad/Pocket: sort out common code 
- sort out a constraint used by Pad and Pocket
- also unify Length2 parameter naming
 2022-01-08 00:45:19 +01:00
Uwe
6c2178d082 [PD] get rid of a CI compiler warning (#5335) 
* [PD] get rid of a CI compiler warning

The CI compiler outputs this warning:
FeaturePad.cpp:101:20: warning: variable 'obj' set but not used [-Wunused-but-set-variable]

Co-authored-by: 0penBrain <48731257+0penBrain@users.noreply.github.com>
 2022-01-05 12:26:48 +01:00
wmayer
84b7185a28 PD: [skip ci] code clean-up in pad and pocket feature 2021-11-20 12:01:55 +01:00
wmayer
998abc8d4d PD: move duplicated code to common base class 2021-11-20 11:45:13 +01:00
wmayer
408e8a40ef PD: [skip ci] for pockets use opposite direction of reference axis 2021-11-16 00:35:57 +01:00
Uwe
3eed892880 [PD] add feature to set direction for pockets 
This PR adds the functionality of pads to pad along either a custom direction or along an edge to pockets.

So with this PR Pad and Pocket are on the same level of functionality.
 2021-11-11 15:55:42 -06:00
wmayer
145eb8ea8c PD: fixes #0004567: Pattern from a feature type UpToFace and Offset > copy whole body 2021-02-24 17:08:20 +01:00
wmayer
4c18734d2e PD: [skip ci] code refactoring 
Move adding offset to face from getUpToFace() to addOffsetToFace()
 2021-02-24 16:08:03 +01:00
wmayer
385e4df10c PartDesign: [skip ci] fixes #0004494: Error "Result is empty" for Pads and Pockets with non zero Offset 2020-11-16 14:45:55 +01:00
wmayer
5e07809384 PartDesign: [skip ci] support negative values as second length of a pocket 2020-11-16 11:35:05 +01:00
vocx-fc
b8dd14b01d PartDesign: replace unicode characters with simple hyphens 2020-06-03 14:51:01 +02:00
wmayer
4e5d6be326 fixes #0003979: Pocket with mode 'up to face' doesn't work correctly 2019-06-15 23:54:10 +02:00
Abdullah Tahiri
7b0a501c0a PartDesign: 3rdParty to PCH 2019-05-02 07:12:27 +02:00
wmayer
2888ff2557 improve error messages for Pocket, Hole and Groove feature 2018-12-31 18:30:13 +01:00
wandererfan
a712d49685 Revise multiple solids message 2018-07-13 10:23:42 -03:00
wandererfan
0d3008e4eb Fix #3401 warning on multiple solid 
- PartDesign only uses the first result shape
  of an operation and discards the rest without
  warning.

- this also fixes #1707
 2018-07-13 10:23:42 -03:00
Abdullah Tahiri
fd7d75b309 PartDesign: Extension of Pocket Feature to have two dimensions 
fixes #2915
 2018-01-20 16:15:38 +01:00
wmayer
0d617f97d6 Port to occ7.2: 
+ Standard_Failure::Caught() is now marked as deprecated and should be replaced with standard C++ exception handling
 2017-09-01 16:27:46 +02:00
Peter Lama
fa4bebf2e0 Use OCCT Handle macro for Handle_ classes 
This is the result of running OCCT's upgrade script provided
with OCCT 7.0. See
https://www.opencascade.com/content/freecad-occt710-and-windows-rtti-data-missing#comment-form
and
https://www.forum.freecadweb.org/viewtopic.php?f=4&t=21405&start=120#p169019
for why this is necessary for OCCT >= 7.1
 2017-04-20 12:27:34 +02:00
AjinkyaDahale
f139ecd22b Possible solution to a problem in pad/pocket up-to-face 
Somehow we weren't able to pad/pocket up-to-face when the profile sketch
is made on a datum plane
 2017-03-19 18:09:14 -03:00
Stefan Tröger
609da4749a fixes #0002512 Allow multi-face part design tools 2016-05-18 23:54:18 +02:00
wmayer
cb73d010bb + port to OCC 7.0 2016-05-14 16:53:27 +02:00
Stefan Tröger
ae9dac71d7 PartDesign: Modeling features work with faces 
-Rename Sketchbased to ProfileBased to show new behavior
-Adopt ProfileBased to make the relevant helper functions work with faces too
-Adopt features for unified use of helper functions
-Adopt commands to allow face selection
 2016-04-12 18:12:22 +02:00
Alexander Golubev
7d8fc476bd PartDesign/App: a small fix to offset constraint syntax for Pad and Pocket 2016-04-12 18:12:21 +02:00
Alexander Golubev
09b32218ef PartDesign: fix negative Offset property in pad and pocket 2016-04-12 18:12:16 +02:00
Alexander Golubev
984b0dd715 PartDesign/Task{Pad,Pocket}Parameters: massive refactoring 
Give a massive refactoring to Task dialogs for pocket and pad.
This commit features:
 * Make Task dialogs for pocket and pad look nice in side-by side diff and
   cross import features missing in each other.
 * As a result it fixes several minor bugs.
 * Gives a rework to the UpdateUI function.
 * This one also fixes offset option support and migrates it to use unit
   framework.
 2016-04-12 18:12:15 +02:00
DeepSOIC
f20ff5a8d4 PartDesign: refactor positionBySketch 
Rename it to positionByPrevious. Rewrite.
Rewrite SketchBased::transformPlacement.
 2016-04-12 18:12:11 +02:00
DeepSOIC
220c88edb6 PartDesign: tidy up sketch support and base feature confusion 
Not complete, transformPlacement and positionBySketch are pending...
 2016-04-12 18:12:11 +02:00
Stefan Tröger
b0817ff086 allow non-sketch based additive and subtractive features 2016-04-12 18:12:06 +02:00
jrheinlaender
ef76cf8b52 Added some comments about things to be fixed in the future 2016-04-12 18:11:55 +02:00
jrheinlaender
12bf1d58f6 Allow extruding from a datum plane to another face or plane, optionally with an offset 2016-04-12 18:11:53 +02:00
jrheinlaender
2d0fdac40b Give user feedback about not being able to extrude UpToFace if sketch is on a datum plane 2016-04-12 18:11:52 +02:00
jrheinlaender
9a932e09a0 Allow Pad and Pocket up to a face with sketch located on datum plane 2016-04-12 18:11:51 +02:00
jrheinlaender
2732f44b42 Miscellaneous fixes 2016-04-12 18:11:51 +02:00
jrheinlaender
de17a3ede4 Pad/Pocket: Allow extrude up to a datum plane 2016-04-12 18:11:50 +02:00
jrheinlaender
575b6cf6df Added Reversed button to Pocket UI if the sketch plane is a datum plane 2016-04-12 18:11:50 +02:00
jrheinlaender
61b0f03778 Made Pocket, Revolution and Groove aware of the SketchBased::BaseFeature property 2016-04-12 18:11:48 +02:00
wmayer
7957a7fb00 + fixes #0001655: Pocket type UpToFirst and UpToFace doesn't produce expected results. 2015-05-16 12:44:07 +02:00
wmayer
11048388e8 + set correct group information to pad and pocket properties 2014-03-21 15:18:26 +01:00
wmayer
79e9f108e6 + Add option to refine solid on sketch-based features 2013-09-21 09:16:44 +02:00
wmayer
605e85b952 Make FeaturePython Python binding a template class to avoid code duplication 2013-03-22 00:34:18 +01:00
wmayer
15fc11c16f Fix build failures with automake 2012-12-06 20:13:24 +01:00
wmayer
2f690378ac Reset modified flag after document is loaded, touch pad/pocket if its Type has changed 2012-11-06 21:12:39 +01:00
wmayer
22c0f85672 Algorithm to remap support shape, fix bugs in pad/pocket 2012-11-04 16:48:52 +01:00
jrheinlaender
1d0be7954e PartDesign, 758, 766, 773, 775: several improvements, fixes and code refactoring for Pad and Pocket 2012-11-03 23:07:48 +01:00