Commit Graph

10846 Commits

Author SHA1 Message Date
balazs-bamer
7c95f25abf Warning for surfaces with 2 edges only
If the user creates a surface from 2 edges, a warning dialog appears.
Some refactoring in Command.cpp to make it simpler.
2017-04-17 16:20:44 +02:00
balazs-bamer
76c357ad70 Cancelling the just created surface deletes it
Now if the user creates a surface, the cancel in the widget deletes it.
If an already existing one is opened for editing, cancel rejects the
user change in fill type, but the surface remains.
2017-04-17 16:20:44 +02:00
balazs-bamer
29eed4a3f6 Unified UI for Bezier and b-spline surfaces
I have unified the user interface for Bezier and b-spline surfaces.
Based on the selection contents the CmdSurfaceBSurf::isActive method
determines which one can be created, and marks it for the activate
method.

For any sort of inappropriate selection contents, including foreign
shapes or mixture of Bezier and b-spline curves, the tool remains
disabled.
2017-04-17 16:20:44 +02:00
balazs-bamer
8aeb5ae971 Cancel by fill type edit did not work
After clicking Apply the old fill type was overwritten and canceling the
whole edit did not revert the fill type into the original value.
2017-04-17 16:20:44 +02:00
blobfish
1920b407ee use taskbox in taskdialog 2017-04-17 16:20:44 +02:00
blobfish
e83189b9bf header clean up 2017-04-17 16:20:44 +02:00
blobfish
4372355e4c createFace function signature 2017-04-17 16:20:44 +02:00
blobfish
17946ce033 task widget based from qwidget instead of qdialog 2017-04-17 16:20:44 +02:00
blobfish
9d1dc7d23e task flow
synchronize fill types on setEdit
    finishing up command
    make activate for commands similar
    don't call execute directly
    remove unneeded update calls
2017-04-17 16:20:44 +02:00
blobfish
64bc5abe30 class hierarchy and macros 2017-04-17 16:20:44 +02:00
balazs-bamer
d5a999447e Dialog with radio buttons for choosing Bezier and b-spline surface fill type
A regular common dialog with apply, cancel and OK buttons allowing
surface fill type selection for Bezier and b-spline surfaces.

The Bezier and b-spline surface functionality now seems to be complete.
2017-04-17 16:20:44 +02:00
balazs-bamer
486578e5b3 diagnostics
Some diagnostics to let me see what happens
2017-04-17 16:20:44 +02:00
balazs-bamer
405fa9c39a One more experiment
No success yet
2017-04-17 16:20:44 +02:00
balazs-bamer
0c76e1f1e1 One step towards the dialog
Problem registering the own ViewProvider
2017-04-17 16:20:44 +02:00
balazs-bamer
90ad7e3470 Next try for showing dialog
Does not work yet.
2017-04-17 16:20:44 +02:00
balazs-bamer
65bd9da6d2 fill type radio buttons - incomplete
I tried to implement a dialog with fill type radio buttons, but no
success yet.
2017-04-17 16:20:44 +02:00
balazs-bamer
328d525a82 Bezier and B spline cleanup, fixed B spline error
I have made further cleanup in Bezier and B spline surface code, and
corrected the bug in face creation for B splines (Nate has also written
that that was incomplete).
2017-04-17 16:20:44 +02:00
balazs-bamer
c85368bfc0 B-spline surface operation enabled
I have converted Nate's b-spline generation to use my superclass
FeatureBSurf and added it to the GUI. Other half-ready operations as
filling and cut are commented out.

Missing:
- the fill type must be queried from the user. The data panel lets it
modify, but it is not user-friendly.
- b-spline surface is generated, but it covers only a fraction of the
supporting curves. It may lie on OCC error.
2017-04-17 16:20:44 +02:00
balazs-bamer
37406a968e Bezier surface: check selected objects
As the GUI selection changes, the Bezier surface tool avaibility is
always updated, so it is active if and only if 2-4 Bezier curves are
selected.
2017-04-17 16:20:44 +02:00
balazs-bamer
1311d5cf2c cleanup: fill type into superclass
Fill type translation gets into superclass BSurf
2017-04-17 16:20:44 +02:00
balazs-bamer
1fb63c097e Refactor and cleanup: FeatureBezSurf
Refactored and cleaned up code for FeatureBezSurf and created a new
common ancestor class for this and FeatureBSplineSurf.
2017-04-17 16:20:44 +02:00
balazs-bamer
186bd33585 WMayer's fix: subshape copy
The subshape is copied to prevent the wire tool from modifying it. This
lets the user modify any supporting Bezier curves and the Bezier surface
will follow them.
2017-04-17 16:20:44 +02:00
balazs-bamer
14014bc61a Fix build failures on Windows by WMayer
Patch request from WMayer to fix build failures on Windows.
2017-04-17 16:20:44 +02:00
balazs-bamer
00f245efdd Transformed Bezier curves work now
One gets the curve and the location from the healed wire. However, the
curve has the original coordinates, the transformation the user used to
obtain it need to be applied before adding it to the surface builder.
2017-04-17 16:20:44 +02:00
balazs-bamer
66e44578f5 Specify edge name correctly
PropertyLinkSubList does not work without a correctly specified edge name.

Signed-off-by: balazs-bamer <kolaloka@freemail.hu>
2017-04-17 16:20:44 +02:00
balazs-bamer
4f96fa2300 Let the Surface workbench appear and try to create a Bezier surface
Modifications for:
 - let the surface workbench appear
 - use only one Surface menu and toolbar instead of two separate ones
 - create a Bezier surface using 2..4 Bezier curves (does not work yet)
 - use enums for fill type

Signed-off-by: balazs-bamer <kolaloka@freemail.hu>
2017-04-17 16:20:44 +02:00
NateAM
6f4e3acce4 Added Surface module
I have added Nate's SurfaceTools module with the name changed to Surface in all files and filenames.
2017-04-17 16:20:44 +02:00
wmayer
6b26fa6ca7 fix segmentation fault in TaskFeaturePick::makeCopy 2017-04-17 11:07:54 +02:00
Yorik van Havre
5f1158ce49 Moving Arch BIMServer, Arch Git and Web Sketchfab to new external WebTools workbench 2017-04-16 16:37:25 -03:00
Yorik van Havre
cf7bc5bdf0 Draft: Clones now adopt color/transparency of their cloned objects on creation 2017-04-16 15:37:34 -03:00
Yorik van Havre
66884ef2c8 Arch: Allow to set which wire cuts the hole in Arch Windows 2017-04-16 14:54:59 -03:00
Yorik van Havre
ff9b027ddb Draft: Adding missing stuff from last commit 2017-04-16 14:09:57 -03:00
Yorik van Havre
fcae6ef451 Draft: Finally fixed Draft UI focus bug - fixes #2810 2017-04-16 14:07:15 -03:00
Yorik van Havre
17b597fb6e TechDraw: Fixed scaling of Draft/Arch views 2017-04-16 13:51:34 -03:00
Yorik van Havre
b7d81a836c Arch: Support for Panels based on other shapes in PanelCut 2017-04-16 13:13:14 -03:00
Yorik van Havre
3b06b86162 Draft: Fixed weaknesses in Draft Edit command 2017-04-16 12:18:21 -03:00
wmayer
9a3b2a976e when removing faces in thickness tool via context menu then remove selection gate 2017-04-15 13:29:19 +02:00
wmayer
eb02efa004 do not use translated text for icon names 2017-04-15 12:58:35 +02:00
wmayer
8f5057a88b readd removed preferences icon for sketcher 2017-04-14 11:57:17 +02:00
Yorik van Havre
b32e9806e1 Arch: Fixed support of v/vt/vn notation in OBJ importer 2017-04-12 20:30:38 -03:00
wwmayer
6661d048d3 Merge pull request #690 from abdullahtahiriyo/_more_sketcher_fixes_
more sketcher fixes
2017-04-12 17:00:41 +02:00
Abdullah Tahiri
e57dc5c37c Sketcher: change carbon copy alignment by-pass from ALT to ALT+CTRL for Linux compatibility 2017-04-12 14:28:43 +02:00
Abdullah Tahiri
4909c02892 Sketcher: fix incresing bspline degree fails to show new poles 2017-04-12 14:21:54 +02:00
wmayer
c2e83c7818 consistently use term 'B-spline' in the sketcher GUI 2017-04-12 09:37:58 +02:00
Amritpal Singh
10ce910c03 updated recompute() function 2017-04-11 15:23:30 -03:00
Amritpal Singh
91121a8793 added recompute() function to reflect changes in the GUI 2017-04-11 15:23:30 -03:00
Kurt Kremitzki
0a2a02ff2d Fix AddonManager sorting for Macros 2017-04-11 15:10:44 -03:00
Kurt Kremitzki
7e5d0ed0af Fix AddonManager sorting 2017-04-11 15:10:44 -03:00
wmayer
cababe1269 fix scan coverity issues 2017-04-11 19:01:32 +02:00
wmayer
ce36b29cb7 fix scan coverity issues 2017-04-11 15:06:37 +02:00