Commit Graph

22741 Commits

Author SHA1 Message Date
sliptonic
166e4a3e1e Merge pull request #6616 from FreeCAD/Path/LGTM-pas
Path: remove superfluous 'pass' per LGTM
2022-03-20 10:41:40 -05:00
wmayer
cb81addfa1 Mesh: [skip ci] lgtm: Multiplication result converted to larger type
Multiplication result may overflow 'float' before it is converted to 'double'.
2022-03-20 15:53:04 +01:00
Matthijs Kooijman
f06fc0163e Arch: When inverting hinge position, keep opening direction
Previously, just the hinge position was changed, with the rotation
direction kept unchanged, which would make the door open towards the
other side of the wall. This also inverts the rotation direction, so the
door still opens toward the same side of the wall, which is more
intuitively what you would expect.
2022-03-20 14:46:13 +01:00
Matthijs Kooijman
f49b38a595 Draft: Fix incorrect use of in operator
Looking at the surrounding code, this should be `==` rather than `in`.
The code does work as intended, because a string is always a substring
of itself, but better to fix it anyway.

Seems this was broken since this code was first introduced in commit
94b0fe1599 (Draft: clean up ViewProviderLabel class)
2022-03-20 14:45:52 +01:00
Uwe
8f894ebefe [Part] remove Python.h from headers
seems not to be necessary anymore
2022-03-20 14:16:55 +01:00
Uwe
d06dc1527c [PD] remove Python.h from headers
seems not to be necessary anymore
2022-03-20 14:16:41 +01:00
wmayer
c3aebfeb1e MeshPart: suppress incorrect warning with clang/MSYS 2022-03-20 13:45:43 +01:00
wmayer
fdf5df5645 Fem: [skip ci] change include order to fix compiler warning due to a re-defition of a macro in a Python header 2022-03-20 13:44:55 +01:00
Uwe
d355b9d9e2 [Part] fix TaskFaceColors dialog
fixes these issues:
- the actual or chosen color is never displayed in the dialog's color button (it was there but with zero transparency)
- after a color has been set one does not see it (because the changed faces were still highlighted and got the highlight color)
2022-03-20 05:41:34 +01:00
luz paz
8939e3a2eb Path: remove superfluous 'pass' per LGTM
ref: https://lgtm.com/rules/910088/
2022-03-19 20:06:48 -04:00
wmayer
a999a249e3 Qt: remove some more leftovers of Qt4 2022-03-19 23:27:28 +01:00
andrea reale
13e09b36f8 remove QT4 references 2022-03-19 23:07:38 +01:00
sliptonic
06959ededb Merge pull request #6575 from Russ4262/fix/rebuild_empty_job_with_gui
Path: Extend Job integrity check to GUI side, issue #6207 [Bug]
2022-03-19 15:44:28 -05:00
Chris Hennes
21ac5f9a9c Addon Manager: Add py-slvs to allowed packages
Used by ASM3, and maintained by @realthunder.
2022-03-19 12:32:59 -05:00
Uwe
8ccc661379 [FEM] adapt a test to previous commit
(I run of course all tests using the Test Framework WB but did not get an error.)
2022-03-19 18:09:14 +01:00
Uwe
29f5e78583 [FEM] proper Elmer input file write solution
- assure that independent on the used unit scheme, SI units are written to the Elmer input file
- reverts commits https://github.com/FreeCAD/FreeCAD/commit/4a7f7a0faa and https://github.com/FreeCAD/FreeCAD/commit/28a4f6aef
2022-03-19 17:48:11 +01:00
wmayer
90d546d1e7 Fem: replace raw pointer with WeakPtrT to check if the object has been deleted, fix crash in destructor of TaskFemConstraintOnBoundary 2022-03-19 15:37:31 +01:00
Uwe
00ea879bfd [FEM] change example to fit with Elmer's tutorial
- this example is the Elmer tutorial number 13: https://www.nic.funet.fi/pub/sci/physics/elmer/doc/ElmerTutorials.pdf and they use a potential of 1.0, since Elmer uses SI units, it is 1.0 V
2022-03-19 15:29:55 +01:00
Uwe
e7f1fd5444 [Part] TaskFaceColors: remove unused includes
- also some code style fixes by MSVC and sorting
2022-03-19 15:16:09 +01:00
wmayer
2ad512f14b Sketcher: [skip ci] close directory in unit test 2022-03-19 13:54:59 +01:00
Uwe
c360c6e5f5 [FEM] electrostatic dialog revision
- use a quantity spinbox and do simple signal/slot handling in the UI file
2022-03-19 05:01:23 +01:00
Uwe
aba3d40b2f [FEM] forgot this test case in previous commit 2022-03-19 03:51:06 +01:00
Uwe
258bce7261 [FEM] update test files to previous Elmer fixes 2022-03-19 03:34:18 +01:00
Uwe
28a4f6aefa [FEM] fix vacuum permittivity for the Elmer solver
also a missing fix for the density
2022-03-19 03:06:27 +01:00
Uwe
4a7f7a0faa [FEM] fix the Elmer solver writer
- fixes #6604
as it was, Elmer was almost unusable because most values were input with wrong units to Elmer.
Elmer uses pure SI units

ToDo: fix the still wrong Vacuum permittivity
2022-03-19 01:53:26 +01:00
Uwe
4fa884a2cf [FEM] [skip CI] improve electrostatic dialog
- to gain more horizontal space
2022-03-19 01:50:37 +01:00
Uwe
66a5cd1a49 [Part] Section cut: add missing color handling for the cut faces
- the color was not handled at all and thus was often criticized
2022-03-18 17:05:47 +01:00
sliptonic
94c32d9a46 Merge pull request #6590 from sliptonic/feature/warnlegacy
[Path]  Warn user if enabling legacy tools
2022-03-18 10:46:42 -05:00
Wanderer Fan
c9f6aea463 [TD]fix default scale 2022-03-18 08:21:21 -04:00
Uwe
b98ada4c07 [Part] Section Cut: add missing handling of valueChanged
- when the user changed the value without moving the slider (e.g. by clicking), nothing happened
2022-03-18 06:26:12 +01:00
Chris Hennes
1fb1524492 Test: Change Metadata exception tests to use assertRaises 2022-03-17 19:09:01 -05:00
Uwe
e3f6fa6661 [skip CI] [FEM] cleanup SVG code of new icon 2022-03-18 00:45:08 +01:00
Uwe
1293eb2116 [FEM] add icon for the new supported MYSTRAN solver 2022-03-18 00:18:25 +01:00
Uwe
5f5e5a4b35 [skip CI] [FEM] save an icon as plain SVG 2022-03-18 00:16:57 +01:00
Uwe
2cb9ddddae [FEM] task dialogs: remove unused includes
- also some code style fixes from MSVC
2022-03-17 23:31:17 +01:00
Uwe
7d692a82db [FEM] save new icon as plain SVG 2022-03-17 22:38:09 +01:00
Uwe
4e7b96d250 [FEM] add missing preferences settings
- since 0.19 we support to check meshes
- since 0.20 we support buckling

- also revise dialog to get rid of arbitrary limits etc.
2022-03-17 22:33:56 +01:00
Uwe
9590317cd9 [FEM] settings dialogs: uniform width
- some minor changes automatically done by Qt Designer
2022-03-17 21:47:58 +01:00
Uwe
d00e52c81d [FEM] settings dialogs: remove unused includes 2022-03-17 21:27:46 +01:00
Uwe
1ddb4d27e7 [FEM] remove unused headers from WBs main files
- also some code style fixes by MSVC
2022-03-17 20:33:33 +01:00
wmayer
89e4455057 Part: [skip ci] print warning only if eof bit is not set, i.e. ignore it for empty files 2022-03-17 20:24:06 +01:00
Uwe
2e084ed18a [FEM] remove some unused includes for some dialogs
- also some style fixes made by MSVC
2022-03-17 19:53:12 +01:00
Yorik van Havre
4aec686c46 Merge branch 'master' of github.com:FreeCAD/FreeCAD 2022-03-17 16:11:30 +01:00
Yorik van Havre
f636ff9df4 Merge pull request #6544 from Roy-043/Draft-Fix-Angle-Lock-for-non-XY-workingplane
Draft: Fix Angle Lock for non-XY workingplane
2022-03-17 15:46:52 +01:00
Yorik van Havre
84a505287c Arch: Fixed export of texts and dimensions to IFC 2022-03-17 15:46:18 +01:00
Stefan Brüns
0a844f1ca3 [Test] Fix tkinter module name for python 3
The module name changed from uppercase Tkinter to tkinter.
2022-03-17 15:20:42 +01:00
wmayer
9160f06e1c Base: rename BaseExceptionFreeCADError to PyExc_FC_GeneralError 2022-03-17 14:45:48 +01:00
wmayer
d69defaa3c Py: replace BaseExceptionFreeCADError with more suitable exception types 2022-03-17 13:54:23 +01:00
Yorik van Havre
d84fd8a2df Merge pull request #6594 from FlachyJoe/draft_grid_FitAll
[Draft] Don't take grid into account when View_FitAll
2022-03-17 12:04:41 +01:00
Uwe
c0ceecbcf6 [FEM] Contact and Displacement: remove unused headers 2022-03-17 03:46:41 +01:00