Commit Graph

22741 Commits

Author SHA1 Message Date
Uwe
dead2fc8f1 [FEM] Bearing and FluidBoundary: code improvements
- get rid of UI-coded limits
- fix layout issues
- code simplifications
- remove unused headers
2022-03-17 03:45:38 +01:00
Uwe
c6ac4affc8 [FEM] sanitize some dialogs
- uniform button layout
- uniform width
- fix layout issues reported by Qt Designer
2022-03-17 03:02:05 +01:00
Russell Johnson
b06389edb2 Path: Change action to warning with option for action. 2022-03-16 11:47:51 -05:00
Russell Johnson
70d5a422f7 Path: Correct comment spelling 2022-03-16 11:40:24 -05:00
Russell Johnson
e4286139db Path: Extend Job integrity check to GUI side, issue #6207 [Bug]
This commit adds a simple `_jobIntegrityCheck()` method to verify that a model and tool exists within the Job object, when interacting with the Task Panel.  If either is missing, the appropriate tab is activated in the task window, and the appropriate edit window is opened for the user, with messages printed in the report view window.

Add check for existence of `SetupSheet` property of empty Job object.

These changes improve upon fixes in PR #5008 and related bug fixes.
2022-03-16 11:40:23 -05:00
flachyjoe
e6f3f4ba57 Don't take grid into account when View_FitAll 2022-03-16 17:30:25 +01:00
Wanderer Fan
aa4ba37a6c [TD]fix update suppression logic 2022-03-16 09:31:29 -04:00
wmayer
67bbb3ba79 Mesh: [skip ci] replace some casts 2022-03-16 08:46:21 +01:00
Uwe
c4f5628899 [Gui] So headers: remove unused includes
- also sort out some headers to be used in precompiled headers
- also move a boost header to precompiled headers
2022-03-16 02:01:32 +01:00
Uwe
122e137939 [FEM] fixes for displacement dialog
- add missing global dialog layout (reported by Qt Designer)
- get rid of arbitrary spinbox limits
- uniform UI element names
- simplify code
2022-03-16 01:29:46 +01:00
wmayer
200e4be033 Test: [skip ci] fix installation directory of metadata test files 2022-03-15 20:34:02 +01:00
sliptonic
de94520d9b [Path] Warn user if enabling legacy tools
Warn user if opening job that contains legacy tools
2022-03-15 11:05:20 -05:00
sliptonic
b640a1d106 Merge pull request #6577 from Russ4262/fix/millface_removalshapes
Path: Fix `self.removalshapes` declaration [Bug]
2022-03-15 09:26:39 -05:00
sliptonic
a70adce220 Merge pull request #6576 from Russ4262/fix/cancel_new_dressup_cleanup
Path: Fix automatic `commitTransaction()` calls, issue #6149 [Bug]
2022-03-15 09:25:43 -05:00
Abdullah Tahiri
c4b17c5f2b Sketcher: Fix edit curve drawing for bounded curves 2022-03-15 13:16:48 +01:00
Uwe
e6f488393a [FEM] fix logic in electric potential dialog
if capacitance is not specified the spinbox must not be enabled
2022-03-15 04:53:59 +01:00
Uwe
14dd46a0fd [FEM] add tooltips for electrostatic dialog 2022-03-15 04:27:31 +01:00
Uwe
0f05a7d378 [FEM] fixes for electrostatic dialog
- fix form layout, fix distance between objects etc. (most reported by Qt's designer)
2022-03-15 03:06:15 +01:00
Chris Hennes
cb7912db8c Addon Manager: Fix Window on top of everything 2022-03-14 19:35:11 -05:00
Wanderer Fan
02155296ce [TD]fix spelling mistake in comment for CI 2022-03-14 20:03:08 -04:00
Wanderer Fan
8f1bd5340b [TD]fix DetailView alignment 2022-03-14 20:03:08 -04:00
Wanderer Fan
7c6a7aa25b [TD]fix detail highlight on DrawViewDetail 2022-03-14 20:03:08 -04:00
Uwe
ac52b39328 [FEM] fix Results dialog size
- reduce to a sensible size and get rid of unneeded spacer
- further changes automatically done by Qt's Designer
2022-03-14 22:14:06 +01:00
Uwe
075276e215 [FEM] fix Centrif dialog size
- reduce to a sensible size and get git on unneeded spacer
2022-03-14 20:51:27 +01:00
Abdullah Tahiri
89bf7f3d0b Sketcher: DrawSketchHandler draw multiple edit curves
=====================================================

Extension of the framework to draw an arbitrary curve in draw sketch handlers, so that
a plurality of curves can be handled.

DrawSketchHandler is extended to additionally offer drawing several curves:
- void drawEdit(const std::list<std::vector<Base::Vector2d>> &list);
- void drawEdit(const std::vector<Part::Geometry *> &geometries);

A new class, CurveConverter, enables to convert individual Part::Geometry or vectors of them
to appropriate vectors or list of vectors of Vector2d representing the curves. This can be
used in a specific DrawSketchHandler to combine Part::Geometries and arbritary curves.
2022-03-14 16:02:49 +01:00
sliptonic
75fee12d7b Merge pull request #6571 from Russ4262/fix/tag_dressup_radius_value
Path: Fix inconsistent float type usage, issue #6170 [Bug]
2022-03-14 09:26:24 -05:00
Yorik van Havre
6efe74a554 Merged crowdin translations 2022-03-14 12:21:01 +01:00
Yorik van Havre
583206d47c Updated master ts files 2022-03-14 12:13:40 +01:00
wmayer
0054cbddaa Fix coverity issue:
* CID 332682: Resource leak
* CID 350607: Resource leak
* CID 332677: Resource leak
2022-03-14 11:35:04 +01:00
Chris Hennes
56eab3f08b Addon Manager: Correct parent of modal dialogs 2022-03-13 22:30:14 -05:00
Uwe
4d08cefe0e [Part] Section Cut: respect App::Part placement
if object to be cut are within an App::Part container the container placement needs to be respected

- also fix a performance issue
2022-03-14 03:32:09 +01:00
Chris Hennes
2fc9c93235 App: Improve Metadata error handling
Report XML parse exception details.
2022-03-13 21:01:47 -05:00
Chris Hennes
2ac4e60ab5 App: Fix Metadata Py constructors
Also adds unit tests for the corrected Copy and Default constructors.
2022-03-13 21:01:47 -05:00
Uwe
7a2952abf7 [TD] fix compilation error 2022-03-14 01:13:56 +01:00
Wanderer Fan
244caf39cd [TD]fix unit display to standards 2022-03-13 19:04:42 -04:00
Abdullah Tahiri
2908150282 Sketcher: Some code comments 2022-03-13 19:28:38 +01:00
wmayer
55f8d68b4e PD: Fix coverity issue:
* CID 350645: Uncaught exception
2022-03-13 17:24:07 +01:00
wmayer
0be04bb5e0 Points: Fix several coverity issues:
* CID 350545: Resource leak
* CID 350553: Resource leak
* CID 350559: Resource leak
* CID 350593: Resource leak
* CID 350604: Resource leak
* CID 350625: Resource leak
* CID 350650: Resource leak
* CID 129019: Division or modulo by float zero (false-positive)
* CID 129020: Division or modulo by float zero (false-positive)
* CID 129021: Division or modulo by float zero (false-positive)
2022-03-13 16:48:19 +01:00
wmayer
9ef2470799 PD: Fix several coverity issues:
* CID 350558: Uninitialized pointer field
* CID 350554: Uninitialized pointer field
* CID 350589: Uninitialized pointer field
* CID 350608: Uninitialized pointer field
* CID 350544: Uncaught exception
* CID 350568: Uncaught exception
* CID 350603: Uncaught exception
* CID 350562: Unchecked dynamic_cast
* CID 350591: Unchecked dynamic_cast
* CID 350583: Unchecked dynamic_cast
* CID 350598: Unchecked dynamic_cast
2022-03-13 16:32:19 +01:00
wmayer
edd346cc3d Part: Fix several coverity issues:
* CID 350581: Structurally dead code
* CID 350620: Structurally dead code
* CID 350563: Big parameter passed by value
* CID 350552: Uncaught exception
* CID 305193: Uncaught exception
* CID 350556: Uninitialized scalar field
* CID 350579: Uninitialized pointer read
2022-03-13 16:06:40 +01:00
wmayer
716a27de25 MeshPart: Fix several coverity issues:
* CID 350570: Uninitialized scalar variable
* CID 350628: Uncaught exception
2022-03-13 15:50:39 +01:00
wmayer
68171bd20c TD: Fix several coverity issues:
* CID 316569: Uninitialized scalar variable
* CID 350651: Unchecked dynamic_cast
* CID 350565: Unchecked dynamic_cast
* CID 350595: Unchecked dynamic_cast
* CID 350638: Unchecked dynamic_cast
* CID 350547: Division or modulo by float zero
2022-03-13 15:40:49 +01:00
wmayer
f6f21f4fa6 Mesh: Fix several coverity issues:
* CID 350557: Out-of-bounds read (false-positive)
* CID 316517: Uninitialized scalar variable
* CID 316519: Uninitialized scalar variable
* CID 316547: Uninitialized scalar variable
* CID 316556: Uninitialized scalar variable
* CID 350614: Uncaught exception
* CID 350606: Uncaught exception
* CID 332681: Using invalid iterator
2022-03-13 14:58:14 +01:00
wmayer
76d1180283 Fem: Fix several coverity issues:
* make SelectionChangeModes an enum class
* CID 350596: Uninitialized scalar field
* CID 350572: Uncaught exception
* CID 350647: Uncaught exception
2022-03-13 14:09:04 +01:00
Anders Torger
08552c6e68 Apply multi-thread configuration for Calculix also when started via task panel 2022-03-13 13:32:30 +01:00
wmayer
68b92c504f Fix several coverity issues:
* CID 350617: Dereference after null check
* CID 350585: Out-of-bounds read
* CID 350624: Resource leak
* CID 332701: Uncaught exception
* CID 350642: Uninitialized scalar field
* CID 350590: Uninitialized scalar field
* CID 350629: Uninitialized scalar variable
* CID 350602: Uninitialized scalar variable
* CID 350564: Uninitialized scalar variable
* CID 350548: Uninitialized scalar variable
2022-03-13 12:12:49 +01:00
wmayer
02bd57ac82 PD: Fix several coverity issues:
* CID 350622: Negative array index read
* CID 350613: Negative array index read
* CID 166163: Negative array index read
* refactor Hole::updateDiameterParam()
2022-03-13 12:10:01 +01:00
Abdullah Tahiri
8c35a895eb Sketcher: Redraw constraints on wheel event
===========================================

https://forum.freecadweb.org/viewtopic.php?p=577585#p577585
2022-03-13 11:33:52 +01:00
wmayer
33577a087f Robot: [skip ci] add header with export macros 2022-03-13 08:37:58 +01:00
Ajinkya Dahale
76029a5b2d [Sketcher] Fix "toggle internal geo" on multi-selection
Some deleted GeoIds can stay in selection and GeoIds can change as some objects
are deleted.
2022-03-13 06:58:40 +01:00