kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
31,703 Commits 41 Branches 6 Tags
80da187cd792b3a48042aa00298b95e9edf93129
Commit Graph

2068 Commits

Author SHA1 Message Date
wmayer
2c8ae49f48 PD: [skip ci] improve readability of argument list 2021-12-19 22:02:08 +01:00
Uwe
08137aaeb8 [PD] fix compilation issue with Helix 
I introduced it with commit e87b0f4a
 2021-12-19 21:58:19 +01:00
Uwe
b0bf7f5e5f [PD] style improvements for Helix 
all done automatically by MSVC
 2021-12-19 17:52:33 +01:00
Uwe
0e9decfe33 [PD] small code improvements for Helix 2021-12-19 17:34:14 +01:00
jbaehr
b3ba98fafe PD: Fix helix property visibility/writability (#5254) 
[PD]: Fix helix property visibility/writeability

* Hide irrelevant and internal helix properties
- The `HasBeenEdited` property is only used internally to check whether to
  fill certain other parameters with initial values. So there is no need
  show it in the property grid at all.
- The `Outside` property is only used in the subtractive helix and thus
  hidden for the additive helix.

* Make derived helix properties read-only
Depending on the input mode, some properties are primary input, others
are derived. Prior to this change, also the derived properties have been
writable but their values are ignored and overwritten on the next
recompute. Now, when changing the input mode, only the primary input
props are writable.

* Reorder some helix properties
This change puts the reference axis and input mode at the top to become
more prominent. Only "Base" and "Axis" are higher in the list for
consistency with the other axis-based features.
 2021-12-19 16:50:51 +01:00
Jonas Bähr
cfb3e7eaf6 PD: Fix assignment of Angle/Growth properties 
Depending on the input mode, either `Growth` or `Angle` is used to create
a conical or flat spiral. The respective other can easily be calculated
to give consistent view. This is already done for the other properties,
e.g. `Height` is calculated from `Pitch` and `Turns`.
With this patch, the same is done for `Angle` and `Growth`.
 2021-12-19 16:21:51 +01:00
luz paz
1a56a24d07 PD: Adjust header uniformity 2021-12-16 23:55:48 +01:00
wmayer
fb3448536e PD: support of wires in ReferenceHighlighter 2021-12-15 16:25:06 +01:00
wmayer
22d804d985 PD: handle Base::Exception in Loft::execute 2021-12-15 16:24:42 +01:00
wmayer
317e0b11bf PD: do not throw an exception in TaskSketchBasedParameters::make2DLabel as otherwise editing a broken loft/pipe won't be possible 2021-12-15 15:36:36 +01:00
wmayer
c2823b0435 PD: hide the sections of a loft only if it can be recomputed successfully 2021-12-15 15:13:33 +01:00
wmayer
9ff2e22654 PD: hide the profile of a sketch based feature only if it can be recomputed successfully 2021-12-15 15:13:03 +01:00
wmayer
5fe41f8e4e PD: in ViewProviderLoft::highlightSection follow the same logic as in Loft::execute for selected profiles/sections 2021-12-14 00:30:59 +01:00
wmayer
8db3453ffe PD: use class ReferenceHighlighter inside ViewProviderDressUp 2021-12-13 16:56:48 +01:00
wmayer
b2b86477a5 PD: use class ReferenceHighlighter inside ViewProviderPipe 2021-12-13 15:58:55 +01:00
wmayer
0be9d97c91 PD: properly reset line colors when un-highlighting loft profile/sections 2021-12-13 15:46:04 +01:00
wmayer
e6ea67bc1e PD: highlight current profile and sections of a loft when selecting a new profile/section 2021-12-13 15:01:08 +01:00
wmayer
506c40ab60 PD: make Loft working again when two sketches are pre-selected 2021-12-13 10:32:40 +01:00
Jonas Bähr
0b1f1ddc50 PD: Enhance the helix property docs 
Most strings are based on descriptions from the wiki [1]. Some have been
extended where I saw need. Note that I'm not a native speaker, though.

[1]: https://wiki.freecadweb.org/PartDesign_AdditiveHelix
 2021-12-11 23:33:28 +01:00
luz paz
430aadb791 Fix various typos and grammatical refinements 2021-12-09 08:57:52 -06:00
wmayer
9f2b6c5ec6 PD: 0004699: ShapeBinder still touched after recompute 2021-12-09 12:33:09 +01:00
wmayer
b7237f6876 PD: 0004582: Mulit-transformation dialog cannot be cancelled 2021-12-09 06:13:25 +01:00
wmayer
a6838cf58f Gui: rename methods of SelectionObserver to clarify intention in client code 2021-12-07 14:17:07 +01:00
wmayer
8424c9323b PD: enable selection only on request and disable it after selecting an object 2021-12-07 13:06:48 +01:00
wmayer
90db4c885b PD: eliminate the boolean argument from TaskSketchBasedParameters::onSelectReference 2021-12-07 11:04:22 +01:00
wmayer
c1289a0d6f PD: 0004759: Bad error message when creating pad with 0 length 2021-12-07 10:09:11 +01:00
Uwe
242531b1c2 [PD] improve selection mode exit for Helix 
exit the selection mode if selection was got - like we do it for all other PD features
 2021-12-07 04:18:33 +01:00
Uwe
31abf0a3e6 [PD] fix calculation of possible Helix intersections 
the current routine fails for the growth mode.

This PR fixes this by handling this case separately from the other modes.
 2021-12-07 03:19:35 +01:00
wmayer
a12695e44f Gui: move methods startDefaultEditMode() and addDefaultAction() to ViewProviderDocumentObject 2021-12-06 19:24:26 +01:00
wmayer
d360917583 PD: 0004742: Editing features by context menu may not be undoable 2021-12-06 14:11:10 +01:00
Uwe
dd639cbe8d [PD] fix division by zero in Helix 
- when a helix is defined in the growth mode it can have a pitch of zero

This commit fixes the resulting division by zero by directly setting the known turns
 2021-12-06 02:40:34 +01:00
Uwe
9abe56741a [PD] Helix: improve variable naming 
use unique variable names
 2021-12-05 21:59:06 +01:00
Uwe
6dc5358a2e [PD] rewrite a Helix function 
rewrite the function to check if helix might intersect itself to make it better readable/understandable
 2021-12-05 21:28:52 +01:00
Uwe
45db2195d3 [PD] add missing tooltips for Helix dialog 2021-12-05 19:21:27 +01:00
wmayer
b9d2aca09f PD: refactor ReferenceSelection 2021-12-03 21:38:28 +01:00
wmayer
0579052cbc PD: comment out dead code 2021-12-03 20:18:46 +01:00
0penBrain
2f8f4d6a7f [Gui] UserEditMode : fix operating on PartDesignObject 2021-12-03 16:53:30 +01:00
wmayer
945028847a PD: avoid include generated .ui file in header file 2021-12-03 15:59:15 +01:00
wmayer
e9c4f4acc1 PD: minor cleanup in view provider headers 2021-12-03 15:58:23 +01:00
wmayer
b165947625 PD: cleanup the mess with boolean arguments and replace them with a bitmask 2021-12-03 14:46:19 +01:00
Yorik van Havre
9135b5ec90 Merge pull request #5219 from luzpaz/gender-neutral-fixes 
Make source code comments use gender neutral pronouns
 2021-12-03 13:36:17 +01:00
wmayer
0711f6003b PD: use button group to make mid-plane and reversed option mutual exclusive 2021-12-03 00:01:49 +01:00
luz paz
d877ee4d47 Make source code comments use gender neutral pronouns 
The changes also include some grammatical fixes as well.
 2021-12-02 16:18:04 -05:00
wmayer
d4f0eb5bfb PD: fix ProfileBased::getAxis 
Introduce an enum to verify the axis depending on the used context.
* For helix no restriction is needed
* For Pad/Pocket the axis must not be parallel with the sketch plane
* For Revolve/Groove the axis must not be perpendicular with the sketch plane
 2021-12-02 17:24:18 +01:00
wmayer
5e66475757 PD: fix build failure with C++20 2021-12-01 23:24:16 +01:00
wmayer
d56b05678f PD: refactoring of TaskHelixParameters 2021-11-30 11:47:06 +01:00
wmayer
1ecc59d6a4 PD: fix crash in TaskHelixParameters::updateStatus() 2021-11-30 10:36:36 +01:00
wmayer
0cd9ed7429 PD: refactoring of TaskHelixParameters, update status after each recompute 2021-11-29 22:14:14 +01:00
wmayer
3b4012719e PD: handle language change in TaskHelixParameters 2021-11-29 20:14:29 +01:00
Uwe
6051148b66 [PD] use existing definition for PI in Helix 
- also a lot of style fixes kindly done by MSVC
 2021-11-29 12:05:10 +01:00