Commit Graph

3319 Commits

Author SHA1 Message Date
sliptonic
892891f0c4 Merge pull request #6590 from sliptonic/feature/warnlegacy
[Path]  Warn user if enabling legacy tools
2022-03-18 10:46:42 -05:00
wmayer
e4d1ed8366 Base: rename BaseExceptionFreeCADError to PyExc_FC_GeneralError 2022-03-17 14:45:48 +01:00
wmayer
1f12dca2b4 Py: replace BaseExceptionFreeCADError with more suitable exception types 2022-03-17 13:54:23 +01:00
sliptonic
6309575591 [Path] Warn user if enabling legacy tools
Warn user if opening job that contains legacy tools
2022-03-15 11:05:20 -05:00
sliptonic
4b49c87650 Merge pull request #6577 from Russ4262/fix/millface_removalshapes
Path: Fix `self.removalshapes` declaration [Bug]
2022-03-15 09:26:39 -05:00
sliptonic
da2b77d611 Merge pull request #6576 from Russ4262/fix/cancel_new_dressup_cleanup
Path: Fix automatic `commitTransaction()` calls, issue #6149 [Bug]
2022-03-15 09:25:43 -05:00
sliptonic
86539bf6db Merge pull request #6571 from Russ4262/fix/tag_dressup_radius_value
Path: Fix inconsistent float type usage, issue #6170 [Bug]
2022-03-14 09:26:24 -05:00
Yorik van Havre
a55ee61840 Merged crowdin translations 2022-03-14 12:21:01 +01:00
Yorik van Havre
cfdd2af62d Updated master ts files 2022-03-14 12:13:40 +01:00
wmayer
0f9768fb33 Fix coverity issue:
* CID 332682: Resource leak
* CID 350607: Resource leak
* CID 332677: Resource leak
2022-03-14 11:35:04 +01:00
Russell Johnson
4e9f7b0b62 Path: Fix self.removalshapes declaration [Bug]
Prior to this fix, the `self.removalshapes` variable is not declared if `obj.Base` does not exist, or is empty.  This moves the declaration up in scope to the method level.
2022-03-12 22:34:03 -06:00
Russell Johnson
2bc14f84aa Path: Fix automatic commitTransaction() calls, issue #6149 [Bug]
This commit removes the automatic committal of transactions when activated with GUI command.  The committal of the transaction is executed with the `accept()` and `reject()` methods of the respective task panel.
2022-03-12 22:05:04 -06:00
Russell Johnson
68d20e7e90 Path: Improve value assignment syntax for radius 2022-03-12 20:00:40 -06:00
sliptonic
73e995a0f7 Merge pull request #6566 from Russ4262/fix/boundary_dressup_begin_safeheight_retraction
Path: Correct beginning retraction to safe height in Boundary Dressup, issue #6279 [Bug]
2022-03-12 19:05:39 -06:00
Russell Johnson
ba4611a260 Path: Fix radius type inconsistency, issue #6170 [Bug]
Make `self.radius` a float type throughout since other methods and functions treat it as such.
2022-03-12 18:29:21 -06:00
Matti Eiden
34ed7bc123 PathArray: Support applying PathArray on Dressups 2022-03-12 22:31:16 +02:00
Russell Johnson
4ae4e7be1a Path: Correct beginning retraction to safe height feed rate, issue #6279 [Bug]
This commit changes the feed rate of the beginning retraction from G1 at Feed to a G0 Rapid rate.  This initial command is causing a problem with the Tag Dressup due to the first move being a G1 to Safe Height.
2022-03-12 12:18:09 -06:00
Uwe
5d798e26cf [Path] fix a typo 2022-03-12 02:24:44 +01:00
Uwe
5dba742beb [Path] 2nd part of the Git fix attempt
renaming it back
2022-03-12 02:01:29 +01:00
Uwe
99a0a67867 [Path] next attempt to fix Git error by renaming
use lowercase letters fro file ending like it is also in the CMake file
2022-03-12 02:00:40 +01:00
Uwe
76e601a712 [Path] try to silence a git error with a file
Git has issues with this file telling me it is corrupted and its file ending is wrong (in Git lowercase, in the file uppercase).

The attempt is to just to save save it with FC 0.20.
2022-03-12 01:55:37 +01:00
sliptonic
da2dcaa7f4 Merge pull request #6552 from Russ4262/fix/leadin_leadout_simulation
Path: Fix Leadin-Leadout dressup simulation related to arcs [Bug]
2022-03-11 10:06:42 -06:00
sliptonic
14949faf06 Merge pull request #6541 from Russ4262/fix/ramp_entry_dressup
Path: Fix enumeration dictionary error [Bug]
2022-03-11 10:04:53 -06:00
sliptonic
f8fa9c047e Merge pull request #6530 from sliptonic/bug/6114
[Path] Fix minor non-modal bug.  Fixes 6114
2022-03-11 10:03:53 -06:00
sliptonic
f82951a6bc Merge pull request #6536 from J-Dunn/master
PATH: Fix tool shapes for zero dimension bugs
2022-03-11 09:56:52 -06:00
Russell Johnson
a52e63b934 Path: Fix Leadin-Leadout dressup simulation related to arcs
Add missing "Z" and "K" parameters for arc commands to appease Path simulator.
2022-03-10 20:05:52 -06:00
Russell Johnson
c1529aba40 Path: Fix enumeration dictionary error
This commit corrects an incorrect dictionary key in the enumeration dictionary updated with recent translation fixes.
2022-03-09 21:03:34 -06:00
wmayer
08b77bff08 Core/Mod: modernize C++11
* use nullptr
2022-03-09 21:55:31 +01:00
J-Dunn
ce4637092e Add files via upload
Current V-bit totally hangs FC when cutting edge height is zero. Tip diameter of zero also causes errors. 
These two tool shapes add 1um offsets to various dimensions to prevent user entered parameters from inducing zero dimensions which make the solver barf.  
The rotational geometry has also been simplified. 
Some are non critical but tip diam increment is a work around. To be rigorous, the fixed value such ideally be relative to some dimension of the job, not the arbitrary constant. Hopefully 1um will be suitable for most FC applications unless someone is doing uv lithography masks ;) 
https://forum.freecadweb.org/viewtopic.php?f=15&t=54880&p=479739#p479739
This replaces earlier PR where these files were not uploaded. 
https://github.com/FreeCAD/FreeCAD/pull/4491
2022-03-09 12:13:40 +01:00
sliptonic
e0c0590631 fixes #5954
Make headers less confusing and ambiguous
2022-03-08 08:40:05 -06:00
sliptonic
714cab8f6f fixes 6114
replaces DlgJobChooser with QInputDialog.
2022-03-07 17:51:00 -06:00
Uwe
554635cc7d [Gui] rename the Qt header list 2022-03-07 20:35:38 +01:00
wmayer
8f786ea6ef Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Yorik van Havre
2cff977548 Merged crowdin translations 2022-03-07 14:55:22 +01:00
Yorik van Havre
6b71ce3a3e Updated master translation files 2022-03-07 14:49:13 +01:00
wmayer
5e0cfc64ee App: use forward declarations 2022-03-04 21:09:46 +01:00
sliptonic
ee8193322c Merge pull request #6485 from mlampert/feature/external-thread-milling
Path: Feature/external thread milling
2022-03-04 12:52:31 -06:00
sliptonic
9028976d16 Merge pull request #4911 from sliptonic/feature/nopathjob
[Path] Make Job and Operation visibility more natural
2022-03-04 12:51:25 -06:00
Markus Lampert
c02dedbb3c Split out thread milling generator into its own file 2022-03-04 10:42:34 -08:00
sliptonic
69a17578d3 black format 2022-03-04 10:42:34 -08:00
Markus Lampert
fc668181c3 Fixed unit tests 2022-03-04 10:42:34 -08:00
Markus Lampert
2baca43e17 Removed debugging gates 2022-03-04 10:42:34 -08:00
Markus Lampert
2df74990eb Fixed UI update upond changing the thread type 2022-03-04 10:42:34 -08:00
Markus Lampert
eef8fd4f48 Fixed multi pass for external threads with proper lead in/out 2022-03-04 10:42:34 -08:00
Markus Lampert
a1117040b3 Changed passes for constant tool engagement 2022-03-04 10:42:34 -08:00
Markus Lampert
00d2341748 Disabled debugging comments 2022-03-04 10:42:34 -08:00
Markus Lampert
263eeffd71 Fixed lead in/out with elevator location. 2022-03-04 10:42:34 -08:00
Markus Lampert
c12748d8c4 Added thread generation unit tests and fixed finishing the thread 2022-03-04 10:42:34 -08:00
Markus Lampert
82aa3fa1e6 Fixed threads data file list 2022-03-04 10:42:34 -08:00
Markus Lampert
67dbb8675a Some code cleanup 2022-03-04 10:42:34 -08:00