Commit Graph

3088 Commits

Author SHA1 Message Date
Benjamin Nauck
bfdaa9aab2 Techdraw: Use std::numeric_limits and std::numbers instead of defines 2025-03-29 13:32:39 +01:00
PaddleStroke
4631e11230 TechDraw: Section task: Fix spinbox (#20413)
Co-authored-by: Kacper Donat <kadet1090@gmail.com>
2025-03-26 21:41:17 +01:00
Benjamin Bræstrup Sayoc
c106e1fdc6 TechDraw: arc dimensions should not have fill
Fixes #20418. Regression by commit 998f713c97
2025-03-26 11:02:57 +01:00
mosfet80
b33c236322 Clean QGTracker.cpp
Clean code
2025-03-24 19:02:34 +01:00
j-hap
aa725c6866 TechDraw: Replace annotation edit dialog with QPlainTextEdit (#20092)
* TechDraw: Replace annotation edit dialog with QPlainTextEdit

* Remove useless include introduced in previous commit

* Remove trailing _ for members to conform with rest of the codebase

* Add const & to string vectors that don't need copying

* Fix IWYU linter warnings

* Forward all annotation double clicks to the StringList property editor

* Remove unused dialog

* Fix Qt 5 build error

* Fix missing exports with MSVC
2025-03-24 13:27:55 -04:00
Chris Hennes
c0b14e6b77 Merge pull request #20369 from WandererFan/SplineAsCircleYetAgain20347
[TD] Spline as circle yet again  (fix 20347)
2025-03-24 12:05:59 -05:00
Chris Hennes
f15ba6b681 Merge pull request #20110 from WandererFan/HeadlessViewCreation20024
[TD]Headless view creation (fix #20024)
2025-03-22 12:20:58 -05:00
WandererFan
b255deb354 [TD]fix view loses dimensions (fix #19968) (#20122)
* [TD]fix view loses dimensions (fix #19968)

* [TD]Apply review comment
2025-03-22 11:12:42 -05:00
Chris Hennes
c2df0a1315 TD: Ensure WalkerEdge is fully initialized
Coverity thinks that the edge_t is not getting fully initialized, so add a constructor to WalkerEdge that ensures the two components in question are set to zero (resulting in an invalid edge).
2025-03-22 07:15:15 +01:00
wandererfan
c0d6d71896 [TD]use Ptolemy's Theorem for bspline to circle conversion 2025-03-21 11:10:17 -04:00
wandererfan
06346da2a5 [TD]fix reversed condition prevents 3d dimension 2025-03-21 11:01:20 -04:00
wandererfan
8ac44a2c9c [TD]clean annoying lint messages 2025-03-21 11:01:15 -04:00
wandererfan
1bbeb21eec [TD]apply review comments 2025-03-21 09:49:14 -04:00
Chris Hennes
64d658e38a FreeCAD: Compiler warning fixes 2025-03-19 10:13:34 +01:00
Chris Hennes
e574fa1efc Merge pull request #19899 from tritao/cmake-cleanup-targets
CMake: Cleanup targets with transitive dependencies
2025-03-17 13:15:37 -05:00
Captain
384fcdf006 TechDraw: changed CosmeticVertex point picker dashed circle to filled dot. (#20095)
* techdraw: changed the cosmetic vertex shape

* add back the call to prepareGeometryChange

* add getVertexSize and getLineWidth methods to QGIViewPart

* use doubles for sizes

* update setRadius in QGMarker to use double instead of float
2025-03-17 12:05:29 -05:00
Chris Hennes
c43fd51588 Merge pull request #20177 from captain0xff/flickering-cursor
TechDraw: Fix flickering cursor issue
2025-03-17 11:15:40 -05:00
tritao
6c2c6847eb CMake: Cleanup targets with transitive dependencies 2025-03-17 12:12:06 +00:00
Chris Hennes
5f623390fb Merge pull request #20142 from bofdahof/ranges
Apply C++20 std::ranges (mainly to std::find)
2025-03-17 03:08:27 -05:00
Chris Hennes
42cc0d93be Merge pull request #20160 from karliss/popup-parent
Add missing parent for messagbox and other popups.
2025-03-17 00:16:49 -05:00
Chris Hennes
998f713c97 Merge pull request #19788 from benj5378/state2
TechDraw: remove unneeded state, part 1
2025-03-17 00:02:20 -05:00
Chris Hennes
b89ad30bc0 Merge pull request #19917 from tritao/refactor-document-recompute
Core: Refactor code around document and feature recompute
2025-03-16 23:59:12 -05:00
bofdahof
20141d7f19 TechDraw: apply std::ranges 2025-03-16 17:18:23 -05:00
Karliss
fa61131590 Add missing parent for messagebox and other popups
Unparented popups can easily get lost in backround, but they still block top level event loop when run with ::exec() thus preventing interactions with main window.  This mainly happens on wayland. Setting the parent ensures they are always kept on top and reasonably positioned.
2025-03-16 16:02:36 -05:00
Luz Paz
17102251e5 Fix various typos 2025-03-14 12:37:12 -04:00
captain0xff
18b6b07a57 stop the cursor from flickering while picking a cosmetic vertex in techdraw 2025-03-13 21:30:44 +05:30
Benjamin Bræstrup Sayoc
2607c74e47 TechDraw: remove unneeded state from QGIFace 2025-03-13 13:44:30 +01:00
Benjamin Bræstrup Sayoc
8af47beaac TechDraw: remove unneeded state from QGIDecoration 2025-03-13 13:42:02 +01:00
Benjamin Bræstrup Sayoc
9a323909e1 TechDraw: remove unneeded state from QGCustomText 2025-03-13 13:42:02 +01:00
Benjamin Bræstrup Sayoc
aead9ac8c7 TechDraw: remove unneeded state from QGIPrimPath 2025-03-13 13:41:59 +01:00
Chris Hennes
be8b92182c Merge pull request #19921 from mosfet80/QT_CLEAN
REMOVE old QT<= 5.14 code
2025-03-11 20:54:59 +00:00
Chris Hennes
5281e07029 Merge pull request #19946 from j-hap/fix_double_free
TechDraw: Fix double free when resetting line formats
2025-03-11 20:29:06 +00:00
Chris Hennes
ee50b0f25b Merge pull request #20050 from captain0xff/gp_pnt-conversion
TechDraw: removed gp_* conversion code from TechDraw workbench
2025-03-11 02:28:37 +00:00
captain0xff
f7441510b1 remove gp_* conversion code from TechDraw workbench 2025-03-11 05:21:58 +05:30
Chris Hennes
71843a937e Merge pull request #19941 from WandererFan/PropertiesAndSpinBoxes
[TD]Properties and spin boxes
2025-03-10 16:55:13 +00:00
wandererfan
ac4ba822b4 [TD]allow view creation in main thread if gui no available 2025-03-09 19:48:22 -04:00
wandererfan
1fc53e5f27 [TD]add check for Gui up 2025-03-09 19:48:12 -04:00
wandererfan
a6b89251a4 [TD]prevent crash when no event loop
- threaded hlr operations do not return if qApplication is not available
2025-03-09 19:48:08 -04:00
Andrea
da66720d3a REMOVE old QT<= 5.14 code
Ubuntu 22.04  use qt 1.15.3.
In the code is still used qt code <5.10.
A cleanup was done by removing qT code version used in ubuntu 18.04.
2025-03-05 09:32:06 +01:00
j-hap
922ceb8b9e TechDraw: Fix double free when resetting line formats 2025-03-04 18:41:29 +01:00
Chris Hennes
01092f66b1 TD: Add missing Boost headers to PCH 2025-03-03 23:18:47 -06:00
Joao Matos
8710bbd825 Part/PartDesign/TechDraw: Simplify calls to DocumentObject::recomputeFeature. 2025-03-03 21:22:22 +00:00
wandererfan
d7e98b61cc [TD]change scaling default for Draft & BIM views 2025-03-03 10:44:03 -06:00
Chris Hennes
72d8a7be71 Merge pull request #19411 from benj5378/enums2
TechDraw: hard type enums, part 2
2025-03-03 10:37:21 -06:00
Chris Hennes
215e966c3e Merge pull request #19753 from benj5378/tag
TechDraw: centralize tag functionality
2025-03-03 10:36:24 -06:00
Aurélien Pascal
e97aa7d47e TechDraw: Fix hatch drawing (#19458)
* TechDraw: Fix hatch drawing (#16353)

* TechDraw: Fix hatch drawing in Tech View
2025-03-03 10:35:13 -06:00
WandererFan
b4b93763ae Broken view no compress19647 (#19688)
* [TD]fix broken view does not collapse

* [TD]delint and clean up code

* Update src/Mod/TechDraw/App/DrawBrokenView.cpp

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>

* Update src/Mod/TechDraw/App/DrawBrokenView.cpp

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>

* Update src/Mod/TechDraw/App/DrawBrokenView.h

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>

* Update src/Mod/TechDraw/App/DrawBrokenView.h

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>

* Update src/Mod/TechDraw/App/DrawBrokenView.cpp

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>

* [TD]fix merge errors

---------

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
2025-03-03 10:34:23 -06:00
Chris Hennes
7f1c43a335 Merge pull request #19636 from kadet1090/color-in-base
Base: Move App::Color to Base
2025-03-02 16:36:40 -06:00
Chris Hennes
729f09ede4 Merge pull request #19626 from tritao/qt-gl-cleanup
Gui: Remove QtOpenGL.h.
2025-03-02 16:22:57 -06:00
Benjamin Bræstrup Sayoc
b386e461c2 Remove magic number and hard type enums in DrawViewPart.h
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-03-02 17:14:24 +01:00