Commit Graph

210 Commits

Author SHA1 Message Date
Roy-043
f9b84079cf Arch: Fix ArchWall onBeforeChange
The onBeforeChange method in the ArchWall class did not call onBeforeChange from its parent class. This blocked the 'MoveWithHost' behavior of windows placed in walls.
2022-01-17 16:22:16 +01:00
Yorik van Havre
af3e510715 Arch: Added 'flip direction' context menu option to walls 2021-12-28 13:17:47 +01:00
Paul Lee
ea25f69f03 [ArchWall] Do not copy shape
Discussions-
https://forum.freecadweb.org/viewtopic.php?style=1&t=62968&p=540585
234899409f
2021-12-07 18:55:43 -06:00
Chris Hennes
17ebbd1662 [Arch] Remove redundant else: from while loop 2021-10-11 22:01:44 -05:00
paul lee
24e472cdde [ArchWall] Fix MakeBlocks to work if Base is Sketch with 1 edge only
To be merged with #4955
2021-08-09 09:06:03 +08:00
Yorik van Havre
2c940e3a98 Arch: Remember wall alignment when creating from existing wires 2021-08-03 16:45:07 +02:00
Roy-043
084a8e6fae Arch: Fix Arch_Wall: block joints where put on the wrong side of offset
In the execute method block joints were put on the wrong side of the offset which lead to the first block in each row being larger than intended.
2021-07-07 18:54:34 +02:00
Chris Hennes
8228d64ac4 [ARCH] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
Abdullah Tahiri
2386df93aa Arch: Make ArchWall use Sketcher GeometryFacade 2020-12-13 15:36:59 +01:00
luz paz
67381e9579 Arch: Fix header uniformity and remove trailing whitespace 2020-11-16 14:51:53 +01:00
Yorik van Havre
87eae7c58c Arch: Enabled ellipse-based walls - fixes #3859 2020-10-20 13:13:54 +02:00
Yorik van Havre
dd51cbccb2 Arch: Fixed translation of wall (better version) 2020-10-12 15:58:41 +02:00
Yorik van Havre
a0114ac41a Arch: Fixed translation of wall 2020-10-12 15:57:15 +02:00
Roy-043
8ef5e8e333 Arch: Arch_Wall fix MultiMaterial alignment bug. 2020-09-16 13:08:45 +02:00
carlopav
6f2691631c Draft: fixed obj.TypeId output after utils.get_type() change
.


.
2020-09-09 14:13:29 +02:00
Vanuan
0811c61435 Fix non-center aligned wall with multimaterial 2020-08-11 12:21:41 +02:00
paul lee
4e36cde00a [ArchWall] Failed if Sketch as Base has Point, now OK
FC Forum Discussion -
https://forum.freecadweb.org/viewtopic.php?f=23&t=48668&sid=ba6dd68ad32eefbad6ae95d8fadc30e6#p416779
2020-07-20 14:17:28 +02:00
paul lee
07349609da [ArchWall] Fix #0004400 - Archwall creation from certain wire fails.
Forum Discussion - https://forum.freecadweb.org/viewtopic.php?f=23&t=47505
2020-07-16 13:53:11 +02:00
hlg
a48b74d8a5 [Arch] ignore extrusion direction vector length 2020-07-13 14:39:28 +02:00
paul lee
8ff45dfb39 [ArchWall] Revert comments in getExtrusionData() 2020-06-24 11:29:07 +02:00
paul lee
81dd47b039 [ArchWall] ArchWall Offset should now works with Base as Sketch 2020-06-24 11:29:07 +02:00
paul lee
bd02e1bb9d [ArchWall] Fix Align Right with Multi-Material invalid case problem 2020-05-25 13:34:46 +02:00
Yorik van Havre
40600a55c2 Arch: Misc improvements to curtain wall
- Can be based on an edge like normal wall
- Now has a 'host' property to embed into another object (tree only)
- Mullions have different height and width properties
- Mullions or panels can be disabled
2020-05-19 13:58:46 +02:00
Yorik van Havre
6945e37635 Arch: Fixed regression in compound walls 2020-05-18 15:04:26 +02:00
Yorik van Havre
146a175370 Arch: Removed wrong warning in walls 2020-05-18 13:28:55 +02:00
vocx-fc
0fe0f2a31f Arch: fix wall's addDefault call
A previous fix was in 8d4ed61782, but some calls to `addDefault`
were not changed.
2020-05-04 10:55:56 +02:00
Yorik van Havre
8d4ed61782 Arch: Fixed regression in wall 2020-04-24 15:10:42 +02:00
David Daish
c11ebcd43a Rewrote the function and method docstrings in an imperative style. 2020-04-22 12:17:08 +02:00
David Daish
14283ea3ee Moved __init__ docstrings into the class docstring 2020-04-22 12:17:08 +02:00
David Daish
5f0438fb9c Removed incorrect apostrophies. 2020-04-22 12:17:08 +02:00
David Daish
7490f3fc4c Comparison with None is now using 'is' operator 2020-04-22 12:17:08 +02:00
David Daish
0c9fde600a Moved all module docstrings to the top of the file. 2020-04-22 12:17:08 +02:00
David Daish
d3f6d8d5ce Spellcheck 2020-04-22 12:17:08 +02:00
David Daish
0dd278fcb4 Fixed docstrings straying too far right, after indentation was fixed. 2020-04-22 12:17:08 +02:00
David Daish
eda726041b Added docstrings for arch project, and corrected some doc mistakes. 2020-04-22 12:17:08 +02:00
David Daish
0c3e513c36 Added docstrings for ArchFloor 2020-04-22 12:17:08 +02:00
David Daish
5a382d0dc8 Added docstrings to _Wall, and remaining parts of ArchWall 2020-04-22 12:17:08 +02:00
David Daish
918daad31d Fixed syntax error 2020-04-22 12:17:08 +02:00
David Daish
f868ff36ea Made recommended formatting changes. 2020-04-22 12:17:08 +02:00
David Daish
ac16e173fe Added docstrings to all of the Component class's methods. 2020-04-22 12:17:08 +02:00
luz.paz
90812a05a0 [skip ci] Fix typos
Found via codespell v1.17.0.dev0
```
codespell -i 3 -w -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml ./src/Mod/Arch/
```
2020-04-22 12:17:08 +02:00
David Daish
07605ff852 Best efforts on arch wall for now. 2020-04-22 12:17:08 +02:00
David Daish
28ecdbac03 Work on adding docstrings to ArchWall 2020-04-22 12:17:08 +02:00
vocx-fc
58d4596888 Arch: use the new Draft trackers module
Previously it was `DraftTrackers.py`.
Now we import the trackers from `draftguitools/gui_trackers.py`.
2020-03-31 12:09:25 +02:00
Yorik van Havre
1fb999be37 Arch: Fixed regression in layers 2020-03-12 11:33:07 -03:00
paullee0
97c40204a4 [ArchWall, DraftGeomUtils] fix bug: ArchWall with Offset Attribute set and based on Sketch fails at some cases
DraftGeomUtils.offsetWire() supports ArchWall Offset setting inherently now.

Discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=42933
2020-02-10 11:19:47 +01:00
paullee0
a322effcef [ArchWall] Typo 2020-01-22 10:16:54 +01:00
paullee0
d562b9f01a [ArchWall] Use OverridenWidth/Align when ArchSketch getWidths/Aligns() not implemented 2020-01-22 10:16:54 +01:00
paullee0
b9fc008e22 [ArchWall] Remove remarks about Werner's earlier commit 2020-01-08 15:22:54 +01:00
paullee0
1ca234177c [ArchWall] Write back Werner's code in commit 58fdbdc - check tex.image is not None 2020-01-08 15:22:54 +01:00