wmayer
955eeb4775
Gui: [skip ci] use full namespace of AccelLineEdit
2022-11-16 23:26:08 +01:00
wmayer
4067cc158f
Gui: fix endless-loop in View3DInventorSelection::checkGroupOnTop
2022-11-16 21:02:49 +01:00
wmayer
4b17636c5e
Gui: code-refactoring
...
Split selection handling from View3DInventorViewer and move to View3DInventorSelection
2022-11-16 20:27:14 +01:00
Ajinkya Dahale
249ee72333
[Sketcher][planegcs] Make changes as per comments on #7484
...
Comments by @abdullahtahiriyo.
Remove default values and smaller constructor for `CenterOfGravity` and
`WeightedLinearCombination` constraints.
Clarify comments.
Improve readability of `CenterOfGravity` and `WeightedLinearCombination`
constraints.
2022-11-16 15:35:37 +01:00
Ajinkya Dahale
2537ea883f
[Sketcher][planegcs] Set knot constraint as internal alignment
2022-11-16 15:35:37 +01:00
Ajinkya Dahale
19810fac2a
[Sketcher] Do not make knots construction points
2022-11-16 15:35:37 +01:00
Ajinkya Dahale
430b0baa00
[Sketcher] Stop treating knots as fixed in GUI commands
...
This stops constraints from becoming non-driving when not set.
Follow 0penbrain's comments
typo
2022-11-16 15:35:37 +01:00
Ajinkya Dahale
7cd2cbd29c
[Sketcher] Constrain B-spline knots as linear combination of poles
...
Also squashes:
[Sketcher] Create center of gravity constraint in planegcs
[Sketcher] typo
[Sketcher] Use accurate "weights" for knots
By weights we mean the linear combination factor B_i(x) such that
spline(x) = sum(pole_i * B_i(x)) for _non-rational_ splines.
[Sketcher] Use more appropriate weights for knots
These are relevant for knots _away_ from any ends (and possibly other high
multiplicity knots).
[Sketcher] Make COG constraint weights user-definable
[Sketcher] Make `flattenedknots` for periodic B-Splines
[Sketcher] Fix incorrect setup of `flattenedknots`
Without ensuring enough space, iterators become invalid. These iterators are
needed because for periodic B-splines we need to pad flattenedknots with offset
values within flattenedknots.
Apparently there is still some iterator issues even after the reserve. Just use
fresh vectors instead.
[Sketcher] Apply knot constraints by parameter
Hopefully this will allow directly applying constraints on knots.
[Sketcher] Disable some knot updating
[Sketcher] Use center of gravity constraint on knots
[Sketcher] Fix knot COG constraint for periodic splines
[Sketcher] Add start/end point of periodic spline to solver
This removes the trouble of transferring constraints to the underlying knot.
[Sketcher] Support knot constraints on rational B-splines
[Sketcher] Remove virtual from overridden methods in planegcs
Follow 0penbrain's comments
[Sketcher][planegcs] Use `unsigned int` in signatures
Also `size_t` at places
Suggestions by @abdullahtahiriyo
2022-11-16 15:35:37 +01:00
Ajinkya Dahale
027504ce16
[Sketcher] Reformat some if-else for readability
...
Weren't folding right in spacemacs.
This commit can be omitted if undesired.
2022-11-16 15:35:37 +01:00
wandererfan
4f96b1bf60
[TD]fix alignment of section line marks on rotated base view
2022-11-16 08:56:00 -05:00
0penBrain
e3cd132af7
[Typo]Sketcher: 'Clone' is the first command of CompCopy, match the tooltip
2022-11-16 14:48:39 +01:00
wmayer
4483c77530
Gui: MSVC requires a user-defined destructor of RecentFilesAction
...
otherwise the class declaration of Private is needed in the header file
2022-11-16 12:46:47 +01:00
Yorik van Havre
e1aa6f58e3
Merge pull request #7526 from paullee0/ArchWall_15_UseAndCreate-ArchSketch-If-Present
...
[ArchWall] Use and Create ArchSketch if add-on is present
2022-11-16 11:08:11 +01:00
Yorik van Havre
f6b70cce41
Merge pull request #7786 from Roy-043/Draft-housekeeping-rename-snap-icons
...
Draft: housekeeping: rename snap icons
2022-11-16 09:58:47 +01:00
wmayer
9e9c784041
TD: fix memory leaks with raw pointers of GeometryObject
...
Replacing the use of raw pointers of GeometryObject with shared pointers fixes the observed memory leaks when running the unit tests of TechDraw
2022-11-15 16:16:08 -05:00
luz paz
a9283c9945
[skip ci] Add commits to .git-blame-ignore-revs
...
Added:
b389f6e602
2022-11-15 14:30:28 -06:00
luz paz
6e542b6fad
Part: remove trailing whitespace
2022-11-15 14:19:30 -06:00
luz paz
a6133a583a
[skip ci] Add commits to .git-blame-ignore-revs
...
Added:
390e09db3257d0c2000a
2022-11-15 16:17:47 +01:00
luz paz
b389f6e602
TechDraw: remove trailing whitespace
2022-11-15 16:17:22 +01:00
luz paz
57d0c2000a
MeshPart: remove trailing whitespace
2022-11-15 12:45:52 +01:00
wmayer
61dee6b8ad
App: fix memory leak and consistently use Py::asObject() in DocumentObserverPython
2022-11-15 11:04:41 +01:00
wmayer
6298a3a339
Gui: [skip ci] consistently use Py::asObject() in DocumentObserverPython
2022-11-15 11:04:07 +01:00
luz paz
390e09db32
Mesh: remove trailing whitespace
2022-11-14 21:37:03 -06:00
wandererfan
0c83a17ce8
[TD]prevent Complex Section with no Base View
2022-11-14 19:41:12 -05:00
wandererfan
26d7fe14e1
[TD]add section line marks for simple section
2022-11-14 19:41:12 -05:00
marioalexis
93133040e8
TechDraw: Improve and clean up code in some Python classes
2022-11-14 16:40:07 -05:00
wandererfan
53f5883ea1
[TD]fix handling of multiple pages
...
- the routines for retrieving a view's parent page
did not correctly deal with duplicate page entries
2022-11-14 16:38:27 -05:00
wandererfan
075cbb64f0
[Measurement]apply globalPlacement to geometry
2022-11-14 16:38:06 -05:00
wmayer
de04434d1f
Test: [skip ci] add method clear() to document observers
2022-11-14 19:53:35 +01:00
wmayer
6e7ee14062
App: [skip ci] fix memory leak
2022-11-14 19:42:33 +01:00
Paddle
f9ba739e70
Sketcher: Coincidence constraint: fix error introduced by concentric capability.
2022-11-14 17:39:09 +01:00
wmayer
3d7b116358
App: implement option to set config key
2022-11-13 19:54:30 +01:00
wmayer
dacf04c835
Gui: fix some clang-tidy warnings:
...
* modernize-return-braced-init-list
* modernize-use-equals-default
* modernize-loop-convert
* readability-implicit-bool-conversion
* readability-named-parameter
2022-11-13 18:43:39 +01:00
wmayer
756e081a78
Gui: fix some clang-tidy warnings:
...
* readability-braces-around-statements
2022-11-13 17:42:08 +01:00
wmayer
904f92d747
Gui: [skip ci] fix some clang-tidy warnings:
...
* cppcoreguidelines-non-private-member-variables-in-classes
2022-11-13 17:16:03 +01:00
wmayer
a62da05d5c
clang-tidy: disable 'readability-redundant-access-specifiers' because clang-tidy fails to distinguish between 'public' vs. 'public Q_SLOTS'
2022-11-13 16:50:15 +01:00
wmayer
bbb3697b77
Gui: [skip ci] fix some clang-tidy warnings:
...
* cppcoreguidelines-special-member-functions
* cppcoreguidelines-explicit-virtual-functions
* readability-inconsistent-declaration-parameter-name
2022-11-13 16:35:11 +01:00
wmayer
951ea0a768
Gui: fix clazy warnings:
...
* Wclazy-connect-by-name
* Wclazy-connect-3arg-lambda
2022-11-13 16:08:46 +01:00
wmayer
fce59ca723
Sketcher: fix clazy warnings:
...
* Wclazy-connect-by-name
* Wclazy-unused-non-trivial-variable
* Wclazy-detaching-temporary
2022-11-13 15:39:27 +01:00
Paddle
0a5358c24f
Sketcher: Fix element widget repaint delay bug
...
Related to https://github.com/FreeCAD/FreeCAD/pull/7567#issuecomment-1304724547
2022-11-13 07:13:06 +01:00
wmayer
0679c40d26
Gui: fix readability-identifier-length
2022-11-12 23:57:14 +01:00
wmayer
182aa2ac4c
Gui: replace old-style with new-style connect
2022-11-12 21:57:26 +01:00
wmayer
ad8974e9d8
Gui: improve usability of QuantitySpinBox when used as menu item
2022-11-12 18:24:27 +01:00
wandererfan
2a6bd73fc0
[TD]apply review comments from @chennes
...
- also delete empty execute method
2022-11-12 11:35:22 -05:00
wandererfan
fe4a402b04
[TD]simplify section hatch file handling
2022-11-12 11:35:22 -05:00
wandererfan
3ce218d1d7
[TD]simplify embedded image handling
2022-11-12 11:35:22 -05:00
wandererfan
199fd11623
[TD]simplify embedded file handling
2022-11-12 11:35:22 -05:00
wandererfan
75e163213a
[TD]simplify embedded hatch file handling
2022-11-12 11:35:22 -05:00
wandererfan
9c9013810e
[TD]fix embedded template file handling
2022-11-12 11:35:22 -05:00
Chris Hennes
eed9b6480f
Addon Manager: Refactor to extract metadata checker
2022-11-11 21:50:16 -06:00
