kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
28,339 Commits 41 Branches 6 Tags
97330443a2bc0db57b6de7d89036098cc39a0b0a
Commit Graph

738 Commits

Author SHA1 Message Date
wmayer
97330443a2 All: modernize C++11 
* replace deprecated headers
 2022-03-23 22:44:18 +01:00
Uwe
ea81ce76b4 [PD] fix #6482 
The idea with the large factor, introduced in #5363 fixed real bugs, so it should not be reverted.
However we must compensate the factor at the path position movement. Otherwise we get wrong helix positions when the angle is negative.

The PR was tested with the files in the bug reports:
https://forum.freecadweb.org/viewtopic.php?f=3&t=65136
https://forum.freecadweb.org/viewtopic.php?p=572618#p572618
 2022-03-23 19:29:02 +01:00
wmayer
3608ee7f51 PD: modernize C++11 
* use nullptr
 2022-03-23 19:26:14 +01:00
Uwe
b037d8e240 [PD] remove unused Xerces 2022-03-20 20:43:02 +01:00
wmayer
c9a0fae9db lgtm: [skip ci] FIXME comment 
Change FIXME or remove it
 2022-03-20 16:51:23 +01:00
Uwe
d06dc1527c [PD] remove Python.h from headers 
seems not to be necessary anymore
 2022-03-20 14:16:41 +01:00
wmayer
0054cbddaa Fix coverity issue: 
* CID 332682: Resource leak
* CID 350607: Resource leak
* CID 332677: Resource leak
 2022-03-14 11:35:04 +01:00
wmayer
55f8d68b4e PD: Fix coverity issue: 
* CID 350645: Uncaught exception
 2022-03-13 17:24:07 +01:00
wmayer
02bd57ac82 PD: Fix several coverity issues: 
* CID 350622: Negative array index read
* CID 350613: Negative array index read
* CID 166163: Negative array index read
* refactor Hole::updateDiameterParam()
 2022-03-13 12:10:01 +01:00
mwganson
3e18c76d4f PartDesign::SubShapeBinder add 2D offsetting 2022-03-12 23:30:09 +01:00
Zheng, Lei
b47e6723dc PD: add SubShapeBinder 'Refine' property 
Respect setting in BaseApp/Preferences/Mod/PartDesign/RefineModel
 2022-03-12 02:45:13 +01:00
Zheng, Lei
e56bcbc924 PD: fix SubShapeBinder 'Fuse' function 2022-03-12 02:45:13 +01:00
Uwe
b5163ab49f [PD] Boolean: re-add necessary include 2022-03-02 02:50:46 +01:00
Uwe
1e640865a9 [PD] Boolean: remove unused include 2022-03-02 02:30:28 +01:00
mosfet80
ebe57601cd PD: remove duplicate verifications 2022-03-01 17:41:09 +01:00
wmayer
5e0789e2f1 PD: fix const correctness in ProfileBased 2022-02-28 18:10:58 +01:00
wmayer
b05fb73196 PD: [skip ci] refactor Hole feature 2022-02-26 17:06:38 +01:00
wmayer
3ce87cb2fa PD: [skip ci] refactor Hole feature 2022-02-26 16:48:37 +01:00
wmayer
9ddfcb89a5 PD: [skip ci] fix const correctness in Hole feature 2022-02-26 16:34:44 +01:00
wmayer
df0fac1de8 PD: [skip ci] refactor Hole feature 2022-02-26 16:18:20 +01:00
wmayer
4753b0232d PD: fix error 'gp_Dir::Crossed() - result vector has zero norm' 
As reported here: https://forum.freecadweb.org/viewtopic.php?f=3&t=65826
 2022-02-26 16:07:35 +01:00
Uwe
7162c1a1f4 [PD] final work to remove unused includes 2022-02-22 02:18:49 +01:00
Uwe
660436d50b [PD] remove some more unused includes 2022-02-21 15:13:54 +01:00
Uwe
02c8b0452e [PD] some more work to remove unused includes 2022-02-21 02:50:16 +01:00
Uwe
fd19d1a7b0 [PD] more work to remove unused includes 2022-02-21 02:18:17 +01:00
Uwe
4b08dd8142 [PD] Boolean to Groove: remove unused includes 2022-02-21 01:07:36 +01:00
Uwe
fc151aa8b5 [PD] Workbench and Command: remove unused includes 2022-02-20 21:55:15 +01:00
Uwe
c7e48869b6 [PD] Body and utils: remove unused includes 2022-02-20 21:23:05 +01:00
Uwe
7c44008e2d [PD] App: remove unused includes 2022-02-20 20:41:46 +01:00
Syres916
7200915317 [PartDesign] OCC7.3 regression replace include.. (#6402) 
* [PD] OCC 7.3 needs Precision.hxx in header
 2022-02-20 18:44:06 +01:00
Uwe
c1fbf28e22 [PD] Datums: remove unused includes 2022-02-19 19:32:00 +01:00
Uwe
7c8031d356 [PD] Hole, Pipe and Revolution: remove unused includes 2022-02-19 18:47:26 +01:00
Uwe
61d54b6078 [PD] Pad and Pocket: remove unused includes 2022-02-19 17:57:11 +01:00
Uwe
9b7572e9a9 [PD] FeatureHelix: simplify code 
- also rename some variables for better readability
- remove unused includes
 2022-02-19 00:48:11 +01:00
wmayer
95f583a677 Part: fix typos in make* functions 2022-02-16 12:48:02 +01:00
Uwe
7786e24fcd [PD] change default FaceMaker to Bullseye 
Part does already use this FaceMaker since it can also handle islands.

The PR therefore
- uniforms the behavior of PD and Part
- fixes #6366
- enables to use nested sketches for the various PD features like Revolve
 2022-02-16 11:20:02 +01:00
wmayer
15ff4c8f94 PD: for better cohesion do not call generateTaperedPrism inside generatePrism 2022-02-14 00:46:48 +01:00
wmayer
32ae033b43 PD: restore old method name and fix doxygen documentation 2022-02-13 22:30:17 +01:00
Uwe
dc332a5ca0 [PD] moves Extrude code to FeatureExtrude 
* [PD] moves Extrude code to FeatureExtrude

- since the Extrude code is only used by Pocket/pad, it should better in FeatureExtrude
 2022-02-12 19:37:53 +01:00
wmayer
5c9bffb73d PD: fix 'stack-use-after-scope' crash 2022-02-08 17:16:59 +01:00
Mark Ganson TheMarkster
aa76cbc875 [PartDesign Fillet/Chamfer] add UseAllEdges boolean property (#5340) 
- [PartDesign Fillet/Chamfer] add UseAllEdges boolean property
- add UseAllEdges checkbox to fillet and chamfer dialogs
- put UseAllEdges property into Chamfer and Fillet groups, create Fillet group for fillets and put Radius into it, too.
 2022-02-05 01:50:51 +01:00
Uwe
cfdf334b7f [PD] add option to create tapered Pad / Pocket 
This PR adds the same functionality as provided by Part Extrude.
The used code parts are sorted out to a new helper function that is used by Part and PartDesign.
 2022-02-02 01:04:06 +01:00
Uwe
09d7b44495 [PD] uniform default Pad/Pocket lengths 
- the initialization of the length was different than the default set in Command.cpp
- it is annoying that the default 2nd length was 10 and 20 times the default for the 1st length
  -> uniform and take the same than the 1st length
 2022-01-23 13:42:07 +01:00
wmayer
59c470dedf PD: fix bad formatting 2022-01-23 11:07:59 +01:00
Uwe
ad24b32fef Revert "[PD] uniform default Pad/Pocket lengths" 
This reverts commit 501b45bac8.

Sorry, this should have gone to a PR
 2022-01-23 05:06:38 +01:00
Uwe
501b45bac8 [PD] uniform default Pad/Pocket lengths 
- the goal of the recent Pad/Pocket code refactoring was to handle Pad and Pocket the same
  default Pad were 10 long, Pocket only 5 -> uniform this to 10
- the initialization of the length were different than the default set in Command.cpp
- it was annoying that the default 2nd length was 10 and 20 times the default for the 1st length -> uniform and take the same than the 1st length
 2022-01-23 04:58:58 +01:00
Uwe
62ed6b509e [PD] FeatureSketchBased: only style fixes 
to reduce diffs of coming and pending PRs

all fixes were automatically made by MSVC
 2022-01-23 04:50:52 +01:00
luz paz
19e984f8c9 Fix various typos 
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu`
 2022-01-12 14:50:39 -06:00
David Österberg
2ba95b3423 PartDesign: Improve orientation behaviour for conical helices (#5363) 
* PartDesign: Improve orientation behavior for conical helices

As identified in the forum
https://forum.freecadweb.org/viewtopic.php?f=3&t=65136

The Freenet orientation mode does not give expected results for helices with cone angle.
By using an auxiliary helix that is axially offset it is guaranteed that the orientation frame
is always consistent with a cylindrical coordinate system.

Results will be the same as before when cone angle is 0.
 2022-01-09 22:13:15 +01:00
Uwe
f84d32d1b6 [PD] sort includes 
- to keep the overview
- removed double entries
- will make diff of pending PRs smaller
 2022-01-09 21:36:07 +01:00