Commit Graph

24002 Commits

Author SHA1 Message Date
Yorik van Havre
97379e035a merged crowdin translations 2021-02-09 16:12:18 +01:00
wmayer
a4aea3f480 Gui: [skip ci] add convenience function updateActions() to Application
Use updateActions() in ViewProvider::onChanged() to also trigger an update on pure view property changes
2021-02-09 15:21:17 +01:00
wmayer
2a86b5b153 Mesh: [skip ci] use a more appropriate icons for cross sections 2021-02-09 13:29:13 +01:00
wmayer
2ce88f2fe9 MeshPart: [skip ci] use correct icon for Mesh cross-section dialog 2021-02-09 12:21:31 +01:00
Yorik van Havre
2ded7a3f95 Merge pull request #4402 from luzpaz/ArchSchedule
Arch: update tooltip reference to LibreOffice version within ArchSchedule
2021-02-09 12:06:58 +01:00
Stanislav Meduna
c932d2f76d Adds 3DConnexion SpaceMouse Pro Button Map 2021-02-09 11:59:48 +01:00
bitacovir
5983f5d87b Fix mesh icon names of 9 SVG files 2021-02-09 11:57:41 +01:00
Abdullah Tahiri
26c060f64f Sketcher: Geometry state synchronisation
========================================

The geometry state stored in the geometryFacade is modified following a mutable model
(without setting the Geometry property on Constraint change), in order to avoid coupling
the addition/removal of a constraint with a change of the Geometry Property.

This design decision however interferes with the ability of the Geometry property to restore
the correct geometry state upon redo/undo.

While such a situation is rare in the case of Internal Alignment geometry, because constraint
addition/removal is performed with the corresponding geometry addition/removal (within the same
transaction. That is not the case with the Block constraint (or another future general case where
the geometry state may be applied).

This commit leverages the synchronisation mechanism already in use for non-properties (e.g. external geometry or
vertex indices) to check and synchronise geometry state upon undo/redo and restore.

Bonus:
- addGeometryState is refactored to separate the checking logic from the setting logic.
2021-02-09 08:14:36 +01:00
Chris Hennes
40c99417bd [PD] Catch Python exceptions in dtors (Coverity)
In some PartDesign task dialogs, the destructors call functions that may
throw exceptions. If that occurs and the exception is uncaught, this
will ususally end up terminating the program. This commit adds try-catch
blocks around each instance of that (identified by Coverity) and handles
the Python exception in the normal reporting workflow.
2021-02-08 21:30:22 +01:00
luz paz
8eec5d56dd Arch: update tooltip ref. to LibreOffice version within ArchSchedule
Ref: https://crowdin.com/translate/freecad/6766/en-en?filter=basic&value=0#6576778
2021-02-08 12:56:53 -05:00
wmayer
ff85177c3f Gui: [skip ci] add possibility to auto-expand items in property editor 2021-02-08 18:53:07 +01:00
sliptonic
a8bd33ed1c Merge pull request #4383 from mlampert/feature/path-hide-ops-by-default
[Path]: Set operation Visibility to False, and turn it back on while editing.
2021-02-08 11:12:41 -06:00
Yorik van Havre
098ecdc311 More required items in the github pull request template 2021-02-08 17:29:52 +01:00
sliptonic
86bf9ecc13 Merge pull request #4253 from J-Dunn/master
[Path]: fix several minor bugs in arc slot ops
2021-02-08 09:44:30 -06:00
sliptonic
6239b1ed2c Merge pull request #4393 from mlampert/bugfix/issue-4557
[Path]: bugfix/issue 4557
2021-02-08 09:41:57 -06:00
bitacovir
9d343219b0 Fix mesh icons names of SVG files 2021-02-08 16:40:58 +01:00
Chris Hennes
5f80300de6 LGTM: Remove superfluous conditional 2021-02-08 16:39:40 +01:00
Yorik van Havre
5d18625677 Updated master TS files 2021-02-08 16:35:41 +01:00
Yorik van Havre
96dc265f5b Merge pull request #4341 from hyarion/feature-error-handling-get_svg
[0.19] [Draft] Add better error message in get_svg for direction
2021-02-08 16:08:18 +01:00
Yorik van Havre
18bd651385 Merge pull request #4386 from marioalexis84/draft-clone
Draft: Fixes #0004113: When Clone is used in Draft/Scale, the cloned part placement is always set to origin whatever is the reference point
2021-02-08 16:07:35 +01:00
wmayer
fdd2e0e315 Gui: [skip ci] support undo/redo for view properties in editor 2021-02-08 13:22:14 +01:00
bitacovir
71f378fd70 [UI] Add SVG icon for Mesh SplitComponents 2021-02-08 10:53:18 +01:00
donovaly
de1c0cfb26 [FEM] save icons as plain SVG
without Inkscape specials, just plan SVG 1.1

we frequently have problems that some of our SVGs cannot correctly be displayed by other programs like the Chrome browser. In most cases the reason is that the SVG were created with old Inkscape versions that added stuff that are not in the SVG specs. The clean way to avoid this for the future is to save as "plain SVG" from within Inkscape

THis PR does this only for those SVG for which I got DPI warnings and for some also git warnings about inconsistent line endings.
2021-02-08 10:51:07 +01:00
Chris Hennes
27a5fea60e Remove extra comma in Asymptote surface color definition
Found via LGTM.
2021-02-08 10:50:18 +01:00
Chris Hennes
70ad3cbf83 Silence incorrect LGTM warning. 2021-02-08 10:48:17 +01:00
wmayer
0b58f8b4f5 Base: [skip ci] fix MSVC build failure 2021-02-08 09:58:25 +01:00
Markus Lampert
1087d90f07 import DraftTools if Snapper isn't loaded yet (before using it) 2021-02-07 12:39:21 -08:00
David Osterberg
b0486c4808 FEM: Fix svg icons that causes warning messages
I opened the icons in InkScape, converted the text to a path, and saved.
2021-02-07 19:07:39 +01:00
wmayer
5023a35c48 App: make sure to also call a feature's extensions when recomputing it 2021-02-07 17:43:36 +01:00
Zheng, Lei
0dd091e8c4 Part: allow TaskAttachmentEditor to install attacher extension on demand 2021-02-07 15:39:12 +01:00
Zheng, Lei
813b6b4df7 App: fix Link extensionGetPropertyByName()
Do not query linked object if the owner object has property with the
given name.
2021-02-07 14:49:49 +01:00
luz paz
9b440f9b26 LGTM: remove redundant variable assignment
ref: ddeaa48851/files/src/Mod/Spreadsheet/App/Spreadsheet_legacy.py (x687bc63f783c60bd):1
2021-02-07 13:42:55 +01:00
Chris Hennes
53972c62e3 Remove catch block for plain C strings
LGTM complains about this construct leaking memory. Commit 227cf6de88
eliminated the parts of FreeCAD that throw those strings. This commit
eliminates the catch block.
2021-02-07 13:41:42 +01:00
wmayer
18dc155b3f Mesh: [skip ci] fix MeshPy::trim 2021-02-07 13:12:23 +01:00
marioalexis
ae4ef332ff Draft: Correct the placement in scale_with_clone - fixes #0004113 2021-02-06 23:42:22 -03:00
Markus Lampert
df43fb458f Set operation Visibility to False, and turn it back on while editing. 2021-02-06 16:45:26 -08:00
Zheng, Lei
97a5a2f2af Mesh: minor change to exporter based on suggestion 2021-02-06 17:13:36 +01:00
Zheng, Lei
a01e2aaf8f Mesh: refactor mesh exporter for better support of Link 2021-02-06 17:13:36 +01:00
wmayer
0d5b38385c [skip ci] Do not throw plain C string as exception 2021-02-06 15:52:21 +01:00
David Osterberg
bad8257370 PartDesign: Fix sign error in Helix 2021-02-06 08:22:37 +01:00
Abdullah Tahiri
cc75dc2ab0 Sketcher: Fix wrong diameter reference constraint value when blocked
====================================================================

Fixes:
https://forum.freecadweb.org/viewtopic.php?p=474276#p474276
2021-02-06 06:22:30 +01:00
Aapo
f0992574bd [TD] ShapeExtractor.cpp: Fix linked View source bug, link targets were translated but not scaled in TD. 2021-02-05 22:41:09 +01:00
Chris Hennes
37bf5c22a7 Modify LGTM config to exclude legacy/unmaintained 2021-02-05 22:40:38 +01:00
David Osterberg
a819a89ede PartDesign: fix regression in Helix 2021-02-05 20:55:34 +01:00
Aapo
462dc33d48 [TD] Fix XSource handling of sub-objects of links to another document(s) in TD Views. 2021-02-05 19:19:24 +01:00
David Osterberg
a45e6038b7 PartDesign: [Helix] Fix helix starting point bug 2021-02-05 19:17:00 +01:00
donovaly
b483fc0518 [PD] make pointers to the UI std::unique_ptr
Same as PR #4293, just for PartDesign

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all PartDesign dialogs that don't already use a unique_ptr.
2021-02-05 18:01:57 +01:00
sliptonic
cd2005adee Merge pull request #4333 from Russ4262/remove_feature_expand_profile
[Path] Remove `Expand Profile` feature from Profile op
2021-02-05 10:47:43 -06:00
wmayer
9572ceab3e Part: [skip ci] fix -Wreorder 2021-02-05 17:26:47 +01:00
donovaly
09fd3dbffa [Part] make pointers to the UI std::unique_ptr
Same as PR #4293, just for Part

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all Part dialogs that don't already use a unique_ptr.
2021-02-05 17:16:20 +01:00