Commit Graph

20441 Commits

Author SHA1 Message Date
Abdullah Tahiri
9752de8602 Sketcher: Element Widget External/Construction icons fixes
==========================================================

Changes:
- Move multIcon structure to be internal to TaskSketcherElements class
- Change Caps to MultIcon for consistency
- Move tamperIcon from TaskSketcherElements to MultIcon struct
- Change tamperIcon method to be the constructor of MultIcon and change from struct to class
- Update the tamperIcon algorithm, so that only the point that is not marked in green as selected
is made pink.

Bug fix:

UpdateIcons and SlotElementsChanged are methods sharing code (they could benefit from a refactoring), but
they are conceptually different and are called in very different circumnstances.

UpdateIcons preserves selection. This means that one may select the stating point of line1, press z to switch
to edges, select the edge of line 2 and do a point on object constraint all without touching the 3D view.

SlotElementsChanged occurs when there are additions or removals in the number of geometry elements of the widget.

Warning:

This code requires QT 5.6 because of function pixelColour(int, int):
https://doc.qt.io/qt-5/qimage.html#pixelColor-1

Travis without QT5 complains with:

/home/travis/build/FreeCAD/FreeCAD/src/Mod/Sketcher/Gui/TaskSketcherElements.cpp:1120:31: error: ‘class QImage’ has no member named ‘pixelColor’; did you mean ‘setColor’?
2020-04-07 17:05:37 +02:00
0penBrain
9b2e7b22c5 [Sketcher] Distinguish normal/reference/construction elements in task dialog 2020-04-07 17:05:37 +02:00
sliptonic
d1205005ee Merge pull request #3316 from realthunder/FixPathSort
Path: handle open edges when sorting path
2020-04-07 09:31:01 -05:00
wmayer
815db40a9c Cloud: [skip ci] fix linking issues on macOS 2020-04-07 15:52:29 +02:00
sliptonic
275a34c455 Merge pull request #3295 from etrombly/3d_surface_perf
[PATH] 3d surface performance improvements
2020-04-07 08:47:32 -05:00
wmayer
ce35c641b5 [skip ci] fix typos 2020-04-07 12:50:54 +02:00
sliptonic
d9b9663510 Merge branch 'master' into FixPathSort 2020-04-06 14:33:55 -05:00
sliptonic
c200734dc6 Merge branch 'master' into 3d_surface_perf 2020-04-06 14:33:26 -05:00
sliptonic
3e0357af6d Merge pull request #3318 from Schildkroet/deburr+dressup
[Path] Removed offset check
2020-04-06 14:31:16 -05:00
Patrick F
65aee430af Removed offset check 2020-04-06 21:11:40 +02:00
wmayer
ea8d3bb242 Gui: [skip ci] add options to set one-pass and backface-pass rendering 2020-04-06 19:50:58 +02:00
wmayer
359d3a2b48 Gui: [skip ci] improve whitespaces 2020-04-06 19:50:08 +02:00
wmayer
60ac500048 Cloud: [skip ci] restore old CMake variable to link to OpenSSL to fix build failure on Linux and Windows 2020-04-06 17:58:08 +02:00
wmayer
7a06067150 Cloud: fix broken CMake file 2020-04-06 17:07:09 +02:00
wmayer
d414fc6311 Part: [skip ci] set again Two-side rendering as default lighting style 2020-04-06 14:12:44 +02:00
Eric Trombly
5ecbc89f30 change isOnLine to isOnLineSegment 2020-04-06 06:34:53 -05:00
Eric Trombly
b631c5600a move getFacets from Path to Part 2020-04-06 06:34:53 -05:00
Eric Trombly
db959f1f09 added check that facets are valid in getFacets 2020-04-06 06:34:53 -05:00
Eric Trombly
2b8cd1be42 add changes to Waterline 2020-04-06 06:34:53 -05:00
Eric Trombly
bab00360c5 Area.cpp and CMakeLists.txt had extranious line ending 2020-04-06 06:34:53 -05:00
Eric Trombly
0cbf56886a clean up commented old code 2020-04-06 06:34:53 -05:00
Eric Trombly
54022ea630 remove debug profiling from surface 2020-04-06 06:34:53 -05:00
Eric Trombly
948ec03492 visual studio doesn't like indexing facets with [, changed to ( 2020-04-06 06:34:53 -05:00
Eric Trombly
fbc266c158 remove parallel processing, replace mesh generation with getting facets 2020-04-06 06:34:53 -05:00
Eric Trombly
3f36f55853 change from openmp to std::thread 2020-04-06 06:34:53 -05:00
Eric Trombly
651c383925 changed some for loops to list comprehensions, added openmp for area to make two loops parallel, changed a fuse to a compound 2020-04-06 06:34:53 -05:00
Eric Trombly
5f648aa2c1 remove sleep calls, change some for loops to list comp, move isPointOnLine to base vector 2020-04-06 06:34:53 -05:00
Syres916
3ff9a068d7 [Gui] Edit Menu Remove Duplicate Shift+E...
....shortcut, return Toggle Edit to pre-Big Merge with no shortcut.

See Discussion https://forum.freecadweb.org/viewtopic.php?f=3&t=44394
2020-04-06 13:04:01 +02:00
vocx-fc
6cc5001c08 Draft: Draft_Text split lines by newline characters 2020-04-06 13:01:32 +02:00
vocx-fc
21fd53e5ed Draft: example file with a preview in the Start page 2020-04-06 12:58:32 +02:00
Jean-Marie Verdun
5e84d3238b Fix MacOS build with Catalina and latest homebrew
Add support for self signed certificate in the case the end user wants
to use minio or any other self hosted s3 storage
2020-04-06 12:57:44 +02:00
luz.paz
d36c3ebe57 Trivial code formatting for some {.cpp,.h} files 2020-04-06 12:55:27 +02:00
vocx-fc
a45738c629 Draft: update unit test for gui_edit 2020-04-06 12:51:55 +02:00
vocx-fc
9ed42f61a7 Draft: move Draft_Edit to another module 2020-04-06 12:51:55 +02:00
Zheng, Lei
da72b47cfe Path: handle open edges when sorting path 2020-04-06 09:58:01 +08:00
sliptonic
bb45a2b01f Merge pull request #3132 from Schildkroet/deburr+dressup
[Path] Deburr+DressupLeadInOut fixes
2020-04-05 18:34:52 -05:00
wandererfan
da92b8c242 [TD]fix single quote in anno string list 2020-04-04 22:42:13 -04:00
donovaly
57cde015f7 [TD] sanitize broken SVGs
-also move them to the right folder
see discussion in: https://github.com/FreeCAD/FreeCAD/pull/3304
2020-04-04 09:32:58 -04:00
wmayer
8663e724f5 Gui: move functions to list menus and toolbars from sub-class to base Workbench class
implement new function to list all toolbars and their used commands
2020-04-04 11:46:45 +02:00
wmayer
475f518510 Gui: [skip ci] replace tabs with spaces in GUI init script 2020-04-04 09:42:30 +02:00
wmayer
f9984a0ab1 Gui: [skip ci] fix regression by using UTF-8 encoding in PropertyItem::setPropertyValue 2020-04-03 16:22:35 +02:00
wmayer
110ea2c68e [skip ci] improve whitespaces 2020-04-03 16:19:24 +02:00
wmayer
dbb095a47c Gui: [skip ci] disable workaround to avoid handling an event twice because it leads to a regression on macOS 2020-04-03 15:11:24 +02:00
wandererfan
0d8681a64a [TD]Add symbols from AndreH 2020-04-03 08:16:53 -04:00
wandererfan
18e732e38f [TD]do not write BOM on SVG export 2020-04-03 08:16:53 -04:00
wmayer
919b414dcb App: [skip ci] handle types long and unsigned long in PropertyPlacement::setPathValue() 2020-04-03 12:02:46 +02:00
sliptonic
2994b11997 Merge pull request #3303 from Schildkroet/4th-axis-improve
[Path] Bugfix for circular hole base
2020-04-02 15:39:43 -05:00
Patrick F
b8a32610c8 Bugfix for circular hole base 2020-04-02 19:38:21 +02:00
wmayer
b5d7ac6438 [skip ci] fix typos 2020-04-02 17:46:46 +02:00
vocx-fc
67dca69d60 Draft: task_scale, small style improvements 2020-04-02 16:53:49 +02:00