kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
29,671 Commits 39 Branches 6 Tags
98dae1b217b495189dafade8fd653c14f7a02036
Commit Graph

29 Commits

Author SHA1 Message Date
Uwe
98dae1b217 [PD] TaskExtrudeParameters: simplify code 
to avoid several time the same translatable string
 2022-07-20 03:16:56 +02:00
Uwe
e4dfc42f33 [PD] improve face selection for Pad/Pocket 
- this PR extends PR #7191 as described in this forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=70327
 2022-07-17 18:35:34 +02:00
Uwe
10c6d6eabf [skip CI] [PD] fix typo 2022-06-10 03:39:04 +02:00
wmayer
3608ee7f51 PD: modernize C++11 
* use nullptr
 2022-03-23 19:26:14 +01:00
wmayer
9ef2470799 PD: Fix several coverity issues: 
* CID 350558: Uninitialized pointer field
* CID 350554: Uninitialized pointer field
* CID 350589: Uninitialized pointer field
* CID 350608: Uninitialized pointer field
* CID 350544: Uncaught exception
* CID 350568: Uncaught exception
* CID 350603: Uncaught exception
* CID 350562: Unchecked dynamic_cast
* CID 350591: Unchecked dynamic_cast
* CID 350583: Unchecked dynamic_cast
* CID 350598: Unchecked dynamic_cast
 2022-03-13 16:32:19 +01:00
wmayer
1ca7429705 Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Uwe
52a0a9ba40 [PD] Gui: Boolean to Groove: remove unused includes 2022-02-21 01:33:04 +01:00
0penBrain
aed8864cd9 Modernize signal/slot connection for real :) 2022-02-08 17:51:36 +01:00
Uwe
d9f8516c4a [PD] Extrude: modernize SignalSlot connection 
as suggested recently by @chennes
 2022-02-04 22:20:31 -06:00
Uwe
eb0c313506 [PD] Extrude: handle angle edit visibility 
- adds missing code to handle the edits for the taper angle
 2022-02-05 02:11:14 +01:00
Uwe
cfdf334b7f [PD] add option to create tapered Pad / Pocket 
This PR adds the same functionality as provided by Part Extrude.
The used code parts are sorted out to a new helper function that is used by Part and PartDesign.
 2022-02-02 01:04:06 +01:00
Uwe
3c7ed89306 [PD] correct copyright year 
both files were created in 2021
 2022-01-23 04:45:12 +01:00
0penBrain
5bbd24e48d Display Midplane checkbox with Pocket/ThroughAll 
Was enabled but not visible.
Hopefully last time I fix it. :)
 2022-01-22 10:34:14 +01:00
Chris Hennes
089b18f868 Part Design: Missing = 2022-01-14 09:38:45 -06:00
Uwe
66864bbe7b [PD] Pad/Pocket: sort out duplicated code 
the checkboxes are almost identical and it avoids work to have them in one location
 2022-01-14 13:17:25 +01:00
Uwe
626425526b [PD] sort out more Pad/Pocket code 
as suggested in #5349
 2022-01-10 14:33:02 +01:00
Uwe
38cc6f29e0 [PD] Pad /Pocket: remove unused code 2022-01-08 03:24:09 +01:00
Uwe
5aadc54d18 [PD] Pad/Pocket: fix reverse behavior 
- bring back intended behavior as in FC 0.19:
 - if 2 lengths, then midplane is invisible
 - if reversed checked, then no symmetric and if symmetric then no reverse
- unify the code for Pad and Pocket (reversed is always visible)
- fix a typo in a bool name
 2022-01-08 01:15:23 +01:00
Uwe
7c158a3751 [PD] rename a UI file 
Pad and Pocket share the same UI file therefore change the name to make this clear that changes in that file must be handled for Pad and Pocket
 2022-01-07 20:36:29 +01:00
Uwe
ccc45659b0 [PD] correct copyright 
these files were added by Werner in 2020
 2022-01-06 21:56:53 +01:00
wmayer
ca5c799ce2 Gui: rename methods of SelectionObserver to clarify intention in client code 2021-12-07 14:17:07 +01:00
wmayer
ce88fa2052 PD: enable selection only on request and disable it after selecting an object 2021-12-07 13:06:48 +01:00
wmayer
a27b3067ba PD: eliminate the boolean argument from TaskSketchBasedParameters::onSelectReference 2021-12-07 11:04:22 +01:00
wmayer
3ee1d91b88 PD: cleanup the mess with boolean arguments and replace them with a bitmask 2021-12-03 14:46:19 +01:00
wmayer
269681d83c PD: use button group to make mid-plane and reversed option mutual exclusive 2021-12-03 00:01:49 +01:00
Ajinkya Dahale
bc90f4480b [PD] Use compare to compare strings instead of substr 
Used when finding subelements of a feature. Many of the comparisons used to also
check for string lengths, but as far as I can tell they are not strictly
necessary (see https://www.cplusplus.com/reference/string/string/substr/) and
just `substr` can be used without them. However, `compare` explicitly is for
comparing, and does not make a new object that `substr` does.
 2021-11-28 22:05:46 +01:00
wmayer
6c16094d5a PD: fix bug in TaskExtrudeParameters 
When switching from Custom direction to Select reference mode do not jump back to Custom direction mode after selecting an edge
 2021-11-27 02:22:37 +01:00
wmayer
cb8330d5bd PD: code-refactoring of TaskExtrudeParameters 2021-11-27 01:45:08 +01:00
wmayer
6a0cf8233a PD: create a common base class of TaskPocketParameters and TaskPocketParameters to reduce code duplications 2021-11-26 16:23:45 +01:00