Commit Graph

42363 Commits

Author SHA1 Message Date
Max Wilfinger
9ac06adaeb Update src/Mod/Mesh/Gui/Command.cpp
Co-authored-by: Ryan K <114723629+ryankembrey@users.noreply.github.com>
2025-06-30 10:34:36 -05:00
Max Wilfinger
7704a311bc Update src/Mod/Mesh/Gui/Command.cpp
Co-authored-by: Ryan K <114723629+ryankembrey@users.noreply.github.com>
2025-06-30 10:34:36 -05:00
Max Wilfinger
d6f92c4521 Update src/Mod/Mesh/App/MeshPy.xml
Co-authored-by: Ryan K <114723629+ryankembrey@users.noreply.github.com>
2025-06-30 10:34:36 -05:00
Max Wilfinger
d8cd6d184c Update src/Mod/Mesh/Gui/Command.cpp
Co-authored-by: Ryan K <114723629+ryankembrey@users.noreply.github.com>
2025-06-30 10:34:36 -05:00
Max Wilfinger
84c73b096c Update src/Mod/Mesh/App/MeshPy.xml
Co-authored-by: Ryan K <114723629+ryankembrey@users.noreply.github.com>
2025-06-30 10:34:36 -05:00
Max Wilfinger
54af8d18e7 Update src/Mod/Mesh/App/AppMeshPy.cpp
Co-authored-by: Ryan K <114723629+ryankembrey@users.noreply.github.com>
2025-06-30 10:34:36 -05:00
Max Wilfinger
f59398e6a0 Mesh: Update UI strings for consistency 2025-06-30 10:34:36 -05:00
Max Wilfinger
acc790cabf Update src/Mod/Points/Gui/Command.cpp
Co-authored-by: Ryan K <114723629+ryankembrey@users.noreply.github.com>
2025-06-30 10:34:28 -05:00
Max Wilfinger
2e28cb38ef Update src/Mod/Points/Gui/Command.cpp
Co-authored-by: Ryan K <114723629+ryankembrey@users.noreply.github.com>
2025-06-30 10:34:28 -05:00
Max Wilfinger
43d63ecfec Update src/Mod/Points/Gui/Command.cpp
Co-authored-by: Ryan K <114723629+ryankembrey@users.noreply.github.com>
2025-06-30 10:34:28 -05:00
Max Wilfinger
a7344b0f78 Update src/Mod/Points/Gui/Command.cpp
Co-authored-by: Ryan K <114723629+ryankembrey@users.noreply.github.com>
2025-06-30 10:34:28 -05:00
Max Wilfinger
668d4c5d45 Points: Update UI strings for consistency 2025-06-30 10:34:28 -05:00
Max Wilfinger
8ca7007683 Inspection: Update UI strings for consistency 2025-06-30 10:34:19 -05:00
Karliss
d152bda853 Sketcher: fix Esc can leave setting synchronization 2025-06-30 09:51:08 -05:00
Kacper Donat
c23e48aa6b Contributing: Add requirement to clearly mark ownership for cherry-picked PRs (#22001)
* Contributing: Add requirement to clearly mark ownership for cherry-picked PRs

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
Co-authored-by: Furgo <148809153+furgo16@users.noreply.github.com>
2025-06-29 19:11:30 +00:00
Max Wilfinger
a1aaa15733 Start: Update UI strings for consistency 2025-06-29 11:27:43 -05:00
Jakub Klinkovský
21a2ee8238 Use vtkUnstructuredGrid::GetLinks instead of vtkUnstructuredGrid::GetCellLinks for VTK >= 9.3
The vtkUnstructuredGrid::GetCellLinks has been deprecated in VTK 9.3 and
silently removed in 9.5:

https://gitlab.kitware.com/vtk/vtk/-/blob/master/Documentation/release/9.3.md
2025-06-29 10:37:27 -05:00
Max Wilfinger
45f305aa79 OpenSCAD: Update UI strings for consistency 2025-06-29 10:32:47 -05:00
FEA-eng
d0dcf76a26 FEM: Fix data extraction checkbox typo (#22225)
* FEM: Update PostHistogramFieldAppEdit.ui

* FEM: Update PostLineplotFieldAppEdit.ui

* FEM: Update view_post_histogram.py
2025-06-28 19:14:30 -05:00
mosfet80
6503d22fe7 Clean EditableDatumLabel.cpp
removed unused variable
2025-06-28 19:05:06 -05:00
Chris Hennes
79aa35a288 Gui: Selectively disable MSVC 4251 warning
This warning is not relevant to our project in this instance. We are not concerned about ABI-compatibility of DLLs since they are all compiled at the same time when building FreeCAD.
2025-06-28 18:58:32 -05:00
Chris Hennes
04cd342f59 FEM: Fix missing VTK headers in PreCompiled.h 2025-06-28 16:21:25 +02:00
dependabot[bot]
deda767dd5 Bump github/codeql-action from 3.29.0 to 3.29.1
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.29.0 to 3.29.1.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](ce28f5bb42...39edc492db)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-27 14:13:38 -05:00
Syres916
b0c63c5537 [BIM][Draft] QCheckBox fix regressions introduced by PR #21939 (#22199)
* [BIM][Draft] QCheckBox fix regressions introduced by PR #21939

* [BIM] Remove unwanted index values - CodeQL feedback
2025-06-27 11:25:36 +02:00
tetektoza
a5eff61993 Draft: Remove redundant QGroupBoxes from some of the array panels (#21980)
* Draft: Remove main QGroupBox from Circular Array tool

* Draft: Remove main QGroupBox from Polar Array tool

* Draft: Remove main QGroupBox from Ortho Array tool

* Draft: Remove AxisMode QGroup from Ortho Array tool

* Draft: Remove main QGroup from ShapeString tool
2025-06-26 10:11:26 +02:00
Kacper Donat
46d7d8a8b4 Merge pull request #22169 from 3x380V/fix_19002
PD: Fix regression about single-solid check
2025-06-25 21:40:05 +02:00
sliptonic
79d22d1bd6 Merge pull request #22168 from Roy-043/CAM-fix-window-handling-in-ImageBuilder.py
CAM: fix window handling in ImageBuilder.py
2025-06-25 14:39:41 -05:00
sliptonic
76ff1b5e46 Merge pull request #22051 from tarman3/tagfixes
CAM: Dressup Tag some fixes
2025-06-25 13:03:10 -05:00
Kacper Donat
c383703c01 Merge pull request #22150 from Rexbas/remove-camera-adjust-method
Remove Command::adjustCameraPosition()
2025-06-25 13:11:00 +02:00
Kacper Donat
bca09d0ce6 Gui: Use no_except=true for getExtensionByType in ViewProviderDragger
Fixes: #22166
2025-06-25 12:54:11 +02:00
wmayer
86359a3183 PD: Correctly handle single solid rule for loft with and without base 2025-06-25 00:14:15 +02:00
wmayer
7335c798d1 PD: Use isSingleSolidRuleSatisfied() for pipe feature
This fixes issue 18977

Fixes: 17ad40b2c9f0 ("PartDesign: Refactor single-solid rule enforcement")
2025-06-25 00:13:54 +02:00
wmayer
25e73289ae PD: Fix regression about single-solid check
For several PD features the single-solid check fails. The regression
is caused by PR 13960 and reported as issue 19002. The reason for the
failure is that the first solid of the output shape is retrieved and
then checked for a single solid. This test will always pass, of course.

The single-solid is fixed for these features:
* Pad
* Pocket (never worked there)
* Fillet
* Chamfer
* Groove (never worked there)
* Revolution (never worked there)
* Loft

Fixes: 17ad40b2c9f0 ("PartDesign: Refactor single-solid rule enforcement")
2025-06-25 00:09:33 +02:00
Roy-043
822999ba93 Update ImageBuilder.py 2025-06-24 20:30:46 +02:00
sliptonic
f7beb3e41b Merge pull request #21732 from tarman3/engrave
CAM: Engrave - Fix step down for closed profile
2025-06-24 12:49:05 -05:00
alafr
8329a181c9 Draft : fix Label Justification (#13444)
Draft Label ViewObject.Justification property was overriden by Object.StraightDistance property. The Justification in the 3D view was reset after recompute. This commit fixes the problem by setting Object.StraightDistance automatically when ViewObject.Justification is changed and vice versa. Also fixes the frame position when Justification is Center.
2025-06-24 10:45:46 +02:00
tarman3
8a0d3d2423 Merge branch 'main' into engrave 2025-06-24 08:14:59 +03:00
Kacper Donat
a1f0d7b5fc Spreadsheet Fix '=' regression in spreadsheets (#22146)
* Tools: Add ExpressionLineEdit to QtDesigner plugin

* Spreadsheet: Only use validator when when prefix is not '='

---------

Co-authored-by: wmayer <wmayer@freecad.org>
2025-06-23 22:20:25 +02:00
sliptonic
441d3742cc Merge pull request #21961 from knipknap/tool-cleanups
CAM: Some cleanups (moving DetachedDocumentObject around)
2025-06-23 15:02:24 -05:00
George Peden
2c1d23e4e5 Sketcher: Add contextual input hints to constraint commands (InputHints Phase 2) (#21751)
* Sketcher: Extend InputHints infrastructure to constraint tools

- Implement DrawSketchHandler::getToolHints() for constraint workflows
- Add centralized hint table mapping constraint commands to step-specific InputHints
- Integrate hint lookup in DrawSketchHandlerGenConstraint and dimension handler
- Provide step-by-step user guidance for:
  - Coincident, PointOnObject, Distance (X/Y)
  - Horizontal, Vertical, HorVer, Lock, Block
  - Equal, Symmetric, Radius, Diameter, Angle
  - Tangent, Perpendicular, Parallel

This continues the InputHints work started for drawing tools by enabling consistent, contextual guidance for constraint creation, including multi-step workflows like tangent-via-point.

* Call updateHint() after selection reset to re-arm the first-step prompt
when the tool stays active after apply.

* Add comments to hints table structure

* Sketcher: Update constraint hint text to use "pick" instead of "Select"

Change constraint hint text from "Select" to "pick" to maintain consistency
with existing FreeCAD UI style. This affects the DrawSketchHandlerGenConstraint
hint system for various constraint operations including coincident, distance,
horizontal/vertical, block, lock, symmetry, tangent, perpendicular, parallel,
and distance constraints.

The hints now follow the pattern:
- "%1 pick first point or edge"
- "%1 pick second point or edge"
- "%1 pick line or two points"
etc.

This provides consistent terminology throughout the sketcher constraint
creation workflow.

* - Remove redundant 'first' from initial selection hints
- Improve consistency in hint text formatting per Developer Guidelines
- Add consistent spacing in comment sections"

* Per PR feedback for DrawSketchHandlerDimension hints:
* Change 'Click to' to "pick"
* Simplify hint wording
* Combine redundant else
* Use direct return pattern instead of building hints list

* Update lookupConstraintHints() to use C++20 std:ranges::find_if form per PR review feedback

* Sketcher: Refine constraint hints per PR feedback

- Use consistent 'point or edge' phrasing in Distance and DistanceX/Y tools
- Reword Horizontal/Vertical step 0 to avoid misleading 'two points'
- Generalize Tangent and Perpendicular hints to 'edge' with optional point
- Simplify legacy Distance to 'point or edge'

* Add dynamic hint handling for PointOnObject constraint
- Implemented contextual hints in getToolHints() to generate an appropriate step 2 hint based on step 1 selection type
- Preserved static lookupConstraintHints() for all other tools

* Sketcher: Convert constraint hint table to C++20 designated initializer syntax

- Refactored static constraint hint table to follow Sketcher hint development guidelines
- Uses C++20 designated initializers for clarity and maintainability
- No changes to hint logic or behavior; content is identical to previous version
2025-06-23 21:24:33 +02:00
sliptonic
062f40d2b6 Refactor slot op. (#21799)
* Refactor slot op.
Move out of experimenation features

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Incorporate Hyarion's suggestions

* Update src/Mod/CAM/Path/Op/Slot.py

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2025-06-23 21:22:33 +02:00
Benjamin Nauck
1ef1a53679 Merge pull request #21943 from tetektoza/fix/21927_change_enter_ovp_accepting_dim
Sketcher: Change enter behavior on OVP to put OVP in lock state only
2025-06-23 21:18:41 +02:00
Samuel
46bff2af05 CAM: Load preferences before activating the workbench (#21981) 2025-06-23 14:11:23 -05:00
Luz Paz
77334c8d4f FEM: fix typos 2025-06-23 20:46:33 +02:00
Kacper Donat
c9532316ff Gui: Fix wildcard call disconnects warnings Qt6.9 (#22096)
* Gui: Fix wildcard call disconnects warnings Qt6.9

* Gui: Fix typo

---------

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2025-06-23 17:42:03 +00:00
tiagomscardoso
ab6e3d18dd Gui: prevent hover tooltip from covering menu items (#22019)
* fix #21330: prevent hover tooltip from covering menu items
Instead of showing the tooltip at the mouse cursor,
it is now displayed to the right of the corresponding
menu option, avoiding overlap with the menu itself.

* Update src/Gui/Action.cpp

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2025-06-23 17:40:16 +00:00
Bas Ruigrok
a2dc39a5bc Gui: Remove adjustCameraPosition() 2025-06-23 19:29:11 +02:00
Bas Ruigrok
7a49335cad PartDesign: Remove use of adjustCameraPosition() 2025-06-23 19:28:56 +02:00
Bas Ruigrok
37b0d12e83 Part: Remove use of adjustCameraPosition() 2025-06-23 19:27:09 +02:00
tetektoza
625458f119 Sketcher: Make TAB clear the field if user hasn't valid input 2025-06-23 19:25:57 +02:00