kindred/create
1
1
Fork 0
Code Issues 31 Pull Requests 1 Actions 5 Packages Projects 9 Releases 2 Wiki Activity
27,018 Commits 41 Branches 6 Tags
9c142ccb8bf6413cfc8ea101ace7ee479c7f35ec
Commit Graph

27018 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Österberg
9c142ccb8b PartDesign: Improve orientation behaviour for conical helices (#5363) 
* PartDesign: Improve orientation behavior for conical helices

As identified in the forum
https://forum.freecadweb.org/viewtopic.php?f=3&t=65136

The Freenet orientation mode does not give expected results for helices with cone angle.
By using an auxiliary helix that is axially offset it is guaranteed that the orientation frame
is always consistent with a cylindrical coordinate system.

Results will be the same as before when cone angle is 0.
 2022-01-09 22:13:15 +01:00
Uwe
f44c683e0e [Part] sort includes 2022-01-09 21:59:02 +01:00
Uwe
0cd329de73 [PD] sort includes 
- to keep the overview
- removed double entries
- will make diff of pending PRs smaller
 2022-01-09 21:36:07 +01:00
Abdullah Tahiri
d885bb7ef7 Sketcher: Remove unnecesary geometry touch 2022-01-09 11:40:49 +01:00
Abdullah Tahiri
5279bf68c7 Sketcher: EditCoinManager - Check constraint types on updating constraint color 
===============================================================================

Problem:
- While SketchObject inhibits intermediate updates during internal command execution, sometimes
a change in the selection (clear selection) in an intermediary step triggers an spurious update colour.

- There will be a final draw and this update colours at the end of the internal command.

- If the types of the constraints changed during the intermediary steps, it may happen that the constraint
coin nodes at a given position no longer correspond to the constraint type in the SketchObject property. This
may cause a attempt to access to a non-existing node or static casting a existing node to the wrong type.

Solution:
- Check the type of the constraint against the cached type. If not matching, cancel the color update.
 2022-01-09 11:40:49 +01:00
Ajinkya Dahale
37e93cc167 [Sketcher] Add knot insertion command in Sketcher workbench 2022-01-09 11:33:53 +01:00
Ajinkya Dahale
07cad4ab64 [Sketcher] Add insertBSplineKnot to SketcherObject 
[Sketcher] Workaround for segfault on knot insertion
 2022-01-09 11:33:53 +01:00
Ajinkya Dahale
ff2e246a55 [Part] Support insertion of knots in b-splines 2022-01-09 11:33:53 +01:00
wmayer
7a85baa7eb PD: declare signedLengthConstraint in FeatureExtrude as static class member 2022-01-09 10:53:04 +01:00
wmayer
ce05165f21 App: replace three boolean of CellAddress::toString() with a bitmask of enums 2022-01-09 10:39:54 +01:00
Chris Hennes
06144dd944 Addon Manager: Display download progress 2022-01-09 00:46:07 -06:00
Chris Hennes
131ca065d9 Addon Manager: Correct typo 2022-01-08 22:39:42 -06:00
Chris Hennes
47ca151c81 Addon Manager: Clean up thread termination 2022-01-08 22:30:05 -06:00
Chris Hennes
a34aa34b0b Addon Manager: Correct bad metadata update 2022-01-08 21:07:32 -06:00
Chris Hennes
13a626d228 Addon Manager: Improve stability when cache update interrupted 2022-01-08 19:47:57 -06:00
wmayer
c68183d9d6 Base: [skip ci] add class Flags 2022-01-08 19:18:04 +01:00
Chris Hennes
5342169b03 Addon Manager: Silence error on missing cache 2022-01-08 11:32:33 -06:00
Chris Hennes
aaaf5518bc Addon Manager: Fix error on fast failed connection 2022-01-08 11:29:43 -06:00
luz paz
80250eafb2 Start: header uniformity + whitespace management + misc. pep8 fixes 2022-01-08 18:28:27 +01:00
Uwe
5b04644159 [Part] improve Extrude dialog 
- adds missing tooltip and label
- improve tooltips
 2022-01-08 18:13:06 +01:00
wmayer
254bc470b0 Base: [skip ci] support bitmask operations for enums 2022-01-08 15:48:40 +01:00
David Osterberg
3af6bf0880 PartDesign: Silence noisy FeatureTransformed 
Remove several report view messages that are not necessary for everyday use.
By request from the forum (https://forum.freecadweb.org/viewtopic.php?f=3&t=64900&start=20#p558962)
 2022-01-08 15:30:39 +01:00
wmayer
bd93c0a5cc Sketcher: improve exception handling 
* if determining the normal raises an exception then fall back to a default value
* when handling a Base::Exception then call its ReportException() function to get as much information as possible
 2022-01-08 13:48:01 +01:00
Uwe
74e36f3e0c [PD] Pad /Pocket: remove unused code 2022-01-08 03:24:09 +01:00
Uwe
c1d3cb5fee [PD] Pad/Pocket: fix reverse behavior 
- bring back intended behavior as in FC 0.19:
 - if 2 lengths, then midplane is invisible
 - if reversed checked, then no symmetric and if symmetric then no reverse
- unify the code for Pad and Pocket (reversed is always visible)
- fix a typo in a bool name
 2022-01-08 01:15:23 +01:00
Uwe
21f6602d5b [PD] Pad/Pocket: sort out common code 
- sort out a constraint used by Pad and Pocket
- also unify Length2 parameter naming
 2022-01-08 00:45:19 +01:00
Floriansimmer
d1396058fb Codespell: skip *.svg + add more ignored words (#5338) 
* Codespell: skip *.svg + add more ignored words

* possible words to remove from the ignorelist
 2022-01-07 17:19:49 -06:00
Roy-043
981ddd4699 Draft: Fix issues with translate and _tr (#5351) 2022-01-08 00:04:53 +01:00
marioalexis
5acf2f5340 Draft: Use super() to call base class methods 2022-01-07 22:24:21 +01:00
Uwe
891c2fe1a0 [PD] remove double include 2022-01-07 21:58:16 +01:00
Uwe
d89185d2e1 [Gui] use predefined M_PI 2022-01-07 21:55:48 +01:00
Uwe
f591489594 [Mesh] use predefined M_PI 2022-01-07 21:54:47 +01:00
Uwe
95edb2be56 [Drawing] use predefined M_PI 2022-01-07 21:52:24 +01:00
Uwe
b8bdf9f67c [FEM] use predefined M_PI 2022-01-07 21:50:47 +01:00
Uwe
2db409659e [TD] coding style fixes for new extensions 
all done by MSVC

I do this since on one hand the readability is in this case really improved and because whenever I made a change, MSVC tries to fix the style and then the diffs are unnecessarily large. Also the MSVC style is almost what we use as the "standard" coding style.
 2022-01-07 21:35:46 +01:00
Uwe
05a91e822b [TD] fix another compiler warning about double to float truncation 2022-01-07 21:28:27 +01:00
Uwe
af094bb0b0 [TD] fix compiler warning and use predefined M_PI 
- fixes:
CommandExtensionPack.cpp(1702,38): warning C4305: 'initializing': truncation from 'double' to 'float'

- uses our predefined M_PI constant
 2022-01-07 21:21:51 +01:00
Uwe
734bb426bf [PD] Hole: fix angle constraints 
- all 3 angles cannot be >= 180°
- also add missing minimum in UI for taper angle
 2022-01-07 20:38:05 +01:00
Uwe
b40ab916bc [PD] rename a UI file 
Pad and Pocket share the same UI file therefore change the name to make this clear that changes in that file must be handled for Pad and Pocket
 2022-01-07 20:36:29 +01:00
wmayer
5e509227d2 Spreadsheet: proper implementation of mp_subscript of Mapping protocol of PropertySheetPy 2022-01-07 19:55:21 +01:00
Wanderer Fan
a67e78bda0 [TD]use smart pointers in Extensions 2022-01-07 13:34:20 -05:00
Wanderer Fan
28c5890bc9 [TD] avoid memory leaks by using shared_ptr 
TD geometry objects are sometimes double deleted.  This
change uses shared_ptr instead of raw pointers to manage
deletions.
 2022-01-07 13:34:20 -05:00
Chris Hennes
ad2169e5ae Addon manager dependency resolver (#5339) 
Squashed:
* Addon Manager: Refactor metadata.txt download
* Addon Manager: Basic dependency walker
* Addon Manager: Add basic support for dependencies
* Addon Manager: Improve network detection messaging
* Addon Manager: Black reformat
* Addon Manager: Display dependency info in dialog
* Addon Manager: Dependency dialog added
* Addon Manager: Improve display of update all results
* Addon Manager: Improve display of package list
* Addon Manager: Fix codespell
* Addon Manager: Clean up unused signal
 2022-01-07 10:16:44 -06:00
wmayer
54047878ac App: [skip ci] fix Property::isSame() and subclasses by first comparing the pointers directly 2022-01-07 17:09:08 +01:00
sliptonic
829d69ae6d Merge pull request #5350 from jimzim111/Path_Post_MachineCommands 
Path: PathArray: use python library 're' instead of 'regex'
 2022-01-07 09:06:13 -06:00
wmayer
ad30b7dbc8 PD: [skip ci] remove unused variable 2022-01-07 15:50:09 +01:00
wandererfan
8e86c4473e [TD]fix typo in command name 2022-01-07 08:58:10 -05:00
wandererfan
dffa7040b9 [TD]combine @wmayer and edi271 changes re command extensions 2022-01-07 08:58:10 -05:00
edi271
85662489f9 using getCircleCenter from Part WB 2022-01-07 08:58:10 -05:00
edi271
6f60892209 using enums to define line attributes 2022-01-07 08:58:10 -05:00