Commit Graph

236 Commits

Author SHA1 Message Date
donovaly
003c2d5b62 [PD] allow multiselection on creation of pattern
- Since realthunder's contributions some months ago, the 4 pattern features (mirror, linear, polar, mulitransform) can handle several features at once.
This PR allows to select multiple features when creating a pattern.
(This speeds up the workflow because at the moment one has to create the pattern with one feature and subsequently add more.)

- fix dialog issue that Add and Remove button could be active the same time

- use the keyboardTracking feature to avoid unnecessary recomputes (e.g. currently 3 recomputes when inserting "12.5" to the length field of linear pattern)

- fix wrong <extends> statement in .ui files (automatically spotted and fixed by Qt's Designer)
2020-07-30 10:56:24 +02:00
wmayer
45e0673645 LGTM: [skip ci] fix: Declaration hides parameter
A local variable hides a parameter. This may be confusing. Consider renaming one of them.
2020-07-27 10:57:34 +02:00
luz paz
e82f7f74f4 Fix Crowdin typos + trim superfluous whitespace [skip-ci]
Some issues that this PR fixes (but not all listed):  
https://crowdin.com/translate/freecad/27911/en-en#6581578  
https://crowdin.com/translate/freecad/27911/en-en#6579080  
https://crowdin.com/translate/freecad/27911/en-en#6581580  
https://crowdin.com/translate/freecad/27911/en-en#6579086
2020-07-23 13:52:44 +02:00
wmayer
0eb7967c40 Coverity: [skip ci] Dereference before null check
Remove logically dead code because 'pcActiveBody' cannot be null at this stage
2020-07-21 14:33:54 +02:00
wmayer
2453a50aba Coverity: Structurally/Logically dead code 2020-07-20 17:34:28 +02:00
Zheng, Lei
397e0b8a4f PartDesign: change SubShapeBinder make command
Allows making binder to another binder.
2020-07-12 19:43:23 +02:00
Zheng, Lei
caaea49d59 PartDesign: fix SubShapeBinder make command 2020-03-21 22:12:27 +01:00
Zheng, Lei
fa8c7ee0a3 PartDesign: allow making new ProfileBased feature using multiple faces 2020-03-20 16:38:00 +01:00
Zheng, Lei
ce6eff0a22 PartDesign: improve SubShapeBinder make command 2020-03-20 15:02:20 +01:00
wmayer
f0f3597da8 PartDesign: [skip ci] New sketch function doesn't try any more to edit a selected sketch 2020-03-11 15:14:18 +01:00
luz.paz
fb32601746 Fix various (doxy) typos and whitespace issues
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,currenty,dof,doubleclick,dum,eiter,elemente,feld,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml`
2019-10-03 07:57:13 +02:00
wmayer
b1dd1e61a7 force strict ISO C++ (-Wpedantic)
for Fem, Import, PartDesign, Robot, Sketcher, TechDraw
2019-09-18 14:18:07 +02:00
DeepSOIC
f19e21a224 PartDesign: change view sizing on new sketch 2019-09-11 21:39:16 +02:00
Zheng, Lei
cd2b7e297c PartDesign changes
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
2019-08-17 15:15:47 +02:00
wmayer
61b0755c89 automatically redirect to tip object in case body display mode is set to Tip and a face was selected to create a new sketch 2019-07-08 11:46:09 +02:00
luz.paz
2b02659010 Misc. typo and whitespace fixes
Found via `codespell`
2019-05-30 19:56:12 +02:00
Abdullah Tahiri
07dacdba36 PartDesign: PCH GUI 2019-05-02 07:12:51 +02:00
wmayer
58bcee0e04 PVS: V595 The pointer was utilized before it was verified against nullptr 2019-02-17 20:55:52 +01:00
wmayer
b2a5f47e44 PVS: V560 A part of conditional expression is always true 2019-02-17 13:56:48 +01:00
wmayer
2239483a58 in selection dialog also offer planar shape binders 2019-02-15 18:45:45 +01:00
wmayer
2455be94b7 Add command to create coordinate system as datum item 2019-01-08 12:48:37 +01:00
wmayer
5105ef279c make handling more user-friendly if Sketch is outside of Body object 2019-01-06 22:43:14 +01:00
wmayer
7683bb2b4f Fix usage of Reference dialog:
+ fix memory leak by using QDialog on the stack
+ open a transaction where needed when making a copy to avoid mess with undo/redo
+ set proper title and use main window as parent
+ replace class name Dialog with PartDesignGui::DlgReference
2018-12-03 17:54:05 +01:00
wmayer
058211148f set the cloned shape the tip of the created body 2018-10-16 19:39:07 +02:00
wmayer
5625c58261 fixes 0003621: Additive and subtractive loft preview not showing during creation 2018-10-03 12:40:43 +02:00
wmayer
8bb51de89d fixes 0003509: Create MultiTransform Feature from existing Transform Feature forces document migration 2018-09-30 18:14:22 +02:00
wmayer
ac8aaa2419 fixes 0003447: False PartDesign migration request 2018-09-22 13:59:34 +02:00
ageeye
be6fb16f29 PartDesign::Clone maintain the colors of the original 2018-06-12 10:30:07 -03:00
wmayer
bbbbf6c691 don't allow to set empty list of bodies for boolean operations
don't update the body feature if boolean body list is empty
2018-03-15 12:05:13 +01:00
wmayer
03ce0f276e fixes #0003376: PartDesign Boolean produces exception with wrong selection of active Body 2018-03-15 11:13:45 +01:00
wmayer
2de84d64e8 fix warning: lambda capture 'this' is not used [-Wunused-lambda-capture] 2018-02-10 12:42:41 +01:00
Markus Lampert
a61ee41695 Fixed whitespace inconsistency. 2017-10-22 11:24:58 -07:00
wmayer
9bb1454ef4 allow the user to proceed if default settings for revolution/groove raises an exception 2017-10-18 12:52:04 +02:00
wmayer
16e32c0020 automatically set the tip after creating transform features to avoid messing up the history 2017-10-06 10:20:26 +02:00
wmayer
5d9c1d0434 implement clone command for part design 2017-10-01 18:25:55 +02:00
wmayer
6f6ff3bab1 harmonize creation of linear pattern inside a multi transform to direction creation of linear pattern 2017-09-29 23:57:31 +02:00
wmayer
0d03ad13da allow to attach a sketch to any kind of planar surfaces, not only planes 2017-09-23 22:46:54 +02:00
wmayer
1884413deb fix cyclic dependency if body is selected when creating a datum entity 2017-09-22 11:21:20 +02:00
Stefan Tröger
903a71c8d4 PartDesign: Boolean must show the operation result, not the children. fixes #0003184 2017-09-21 10:48:38 +02:00
wmayer
0983c7e9ac fix cyclic dependency if body is created when creating a shape binder 2017-09-13 12:20:16 +02:00
Stefan Tröger
3e12f4b8c0 PartDesign: Prevent problems with link scopes during feature creation 2017-09-09 16:55:55 +02:00
Stefan Tröger
8841fb0805 Make PartDesign::Boolean work with new Link structure
This is the first feature that used GeoFeatureGroupExtension and required links to the groups inside as well as to things on the same level. Hence a few modifications to link scopes have been nesseccary.
2017-09-09 16:55:55 +02:00
triplus
62626da940 PDN - what's this and command names improvements 2017-08-06 20:47:09 +02:00
Eivind Kvedalen
91bafde563 PartDesign Hole Feature implemented.
Minor contributions from Mateusz Skowroński <skowri@gmail.com>
2017-07-26 23:39:00 +02:00
Yorik van Havre
fcac902186 Fixed typo - crowdin issue 2017-07-24 11:02:52 -03:00
wmayer
1da1d811f6 fixes #0003122: FC 0.17 crashes when a sketched located outside a body object 2017-07-16 16:56:06 +02:00
Kurt Kremitzki
bee42f6c43 Revise PartDesign Loft tooltips 2017-07-01 19:30:49 -05:00
Kurt Kremitzki
06cf363999 Make PartDesign Loft have different tooltip than PartDesign Pipe 2017-07-01 19:30:49 -05:00
Abdullah Tahiri
70a9cce767 Notification to the user that a body is not active when inserting a datum entity - fixes #2511 2017-05-31 02:41:29 +02:00
asiersarasua
4564e4f4a4 Fix typos 2017-04-20 09:49:19 +02:00