kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
36,876 Commits 41 Branches 6 Tags
a837f710d33ec9f2d61b7915bd22aea4d72ac0d1
Commit Graph

229 Commits

Author SHA1 Message Date
Roy-043
a837f710d3 Arch: Fix several Arch_Wall issues 
* The Placement of Draft Line base objects was not adjusted to account for the current working plane. Forum topic: https://forum.freecad.org/viewtopic.php?t=86780
* Continue mode checkbox did not behave correctly because its value was based on FreeCADGui.draftToolBar.continueMode, which does not update as the parameter is changed. Will update other Arch code later.
* There was an issue with Draft Line based walls and continue mode. A Draft Line is selected after creation and the next command call would also use that line because of that. Resulting in 2 walls using the same line and an interuption of continue mode.
* setUseSketch changed the wrong parameter.
 2024-04-16 15:04:29 +02:00
paullee
f4df8d0c10 [ArchWall] Fix regression make block from DraftWire 
See FC Forum Discussion
- https://forum.freecad.org/viewtopic.php?t=86365
 2024-04-08 12:03:40 -04:00
paul
d3d18ac7e0 [ArchWall] getExtrusionData() fix normal problem by adding get_shape_normal() (#12603) 
* [ArchWall] getExtrusionData() fix normal problem by adding get_shape_normal()

In geometry.py
- added get_shape_normal()
- fixed is_straight_line()
DraftGeomUtils.py
- added get_shape_normal()

FC Discussion - https://forum.freecad.org/viewtopic.php?p=726101#p726101

* [ArchWall] getExtrusionData() fix normal problem

Follow-up following discussion at https://github.com/FreeCAD/FreeCAD/pull/12603

- delete trailing whitespaces
- put Part.makePolygon() in try statement
- study and findings at https://github.com/FreeCAD/FreeCAD/pull/12603#issuecomment-1969277743

In geometry.py
- added get_shape_normal()
- fixed is_straight_line()
DraftGeomUtils.py
- added get_shape_normal()

FC Discussion - https://forum.freecad.org/viewtopic.php?p=726101#p726101

* Update geometry.py

* Update geometry.py

* Update geometry.py

---------

Co-authored-by: Yorik van Havre <yorik@uncreated.net>
 2024-04-02 11:54:27 +02:00
Yorik van Havre
673beb7d3a Arch: Register interactive arch tools to draft 2024-03-21 10:38:19 +01:00
luzpaz
5839134e95 Fix various typos throughout the codebase (#13029) 
* Fix various typos throughout the codebase

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2024-03-18 16:54:30 -05:00
Roy-043
544bd1e7ea Arch: implement new get_param functions 
Additionally 2 Arch_Window bugs were fixed:
* If the W1 value was changed the box tracker was not repositioned relative to the cursor.
* The WindowColor was not applied because of a typo in the code. De current default color is quite dark BTW.

Note that all dimensional values that were not really defaults, but just the last entered values, have been removed from preferences-archdefaults.ui. As a result the layout looks a bit strange. That will be improved in a next PR.
 2024-01-18 15:43:15 +01:00
paullee
8c3696adec [ArchWall] Fix getExtrusionData() with DraftWire base problem 
See discussion on FreeCAD forum :
- https://forum.freecad.org/viewtopic.php?p=727868#p727868
( How to use the partdesign_subshapebinder for walls / Walls on "3d sketch"? )
 2024-01-08 10:56:41 +01:00
Roy-043
3a396e1ed3 Arch: Updates related to the PlaneGui class (#11153) 
Related issue:
#5603.
 2023-10-23 18:42:20 +02:00
Roy-043
ea35f0f003 Arch: endpoint after Wall length change was not in local sketch coords (#9592) 2023-05-16 21:24:16 +02:00
luzpaz
129d5882a7 Migrate domain name from freecadweb to freecad (#9352) 
* Migrate domain name from freecadweb to freecad
* Migrate src/Mod/Material files
* Migrate Stylesheet related files
* Migrate *.svg files
* Migrate miscellaneous files
* Migrate some build files
* Migrate recently added TD AR_IRAM template files

Closes #6415
 2023-04-24 15:19:20 -05:00
Roy-043
3aebe166b4 [Arch] remove obsolete decode code (#9316) 
* Update ArchCommands.py

* Update ArchPanel.py

* Update ArchReference.py

* Update ArchWall.py

* Update import3DS.py

* Update importDAE.py

* Update importIFClegacy.py

* Update importOBJ.py

* Update importSHP.py

* Update importSHP.py

Reverted

* Update importSH3D.py
 2023-04-19 15:58:06 +02:00
luzpaz
1c75bbb48a Arch: lint bad indentation, superfluous formatting (#9310) 2023-04-19 09:40:16 +02:00
luzpaz
bc1f217664 Arch: linting multiple imports on one line (#9281) 2023-04-18 16:23:44 +02:00
Roy-043
42a74daa19 Arch: improve context menus (rebase) 2023-01-12 22:54:09 +01:00
Paul Lee
c24004e130 [ArchWall] Use and Create ArchSketch if add-on is present: following Yorik's comment 
(~ 17.10.2022) https://github.com/FreeCAD/FreeCAD/pull/7526#discussion_r997010867
 2022-10-23 11:33:24 +08:00
Paul Lee
72bca3193d [ArchWall] Use and Create ArchSketch if add-on is present 2022-09-26 00:46:04 +08:00
Roy-043
8aaa36a013 Arch: Fix baseface generation for walls with a trace that self-intersects, has T-connections or that overlaps 2022-09-03 09:06:51 +02:00
Roy-043
bafe141745 Arch: Housekeeping: import translate from correct file 2022-07-21 10:17:03 +02:00
Uwe
94155361a0 [Arch] fix typo in function name 
- just to please the spellchecker CI
 2022-07-01 03:35:55 +02:00
Roy-043
f9b84079cf Arch: Fix ArchWall onBeforeChange 
The onBeforeChange method in the ArchWall class did not call onBeforeChange from its parent class. This blocked the 'MoveWithHost' behavior of windows placed in walls.
 2022-01-17 16:22:16 +01:00
Yorik van Havre
af3e510715 Arch: Added 'flip direction' context menu option to walls 2021-12-28 13:17:47 +01:00
Paul Lee
ea25f69f03 [ArchWall] Do not copy shape 
Discussions-
https://forum.freecadweb.org/viewtopic.php?style=1&t=62968&p=540585
234899409f
 2021-12-07 18:55:43 -06:00
Chris Hennes
17ebbd1662 [Arch] Remove redundant else: from while loop 2021-10-11 22:01:44 -05:00
paul lee
24e472cdde [ArchWall] Fix MakeBlocks to work if Base is Sketch with 1 edge only 
To be merged with #4955
 2021-08-09 09:06:03 +08:00
Yorik van Havre
2c940e3a98 Arch: Remember wall alignment when creating from existing wires 2021-08-03 16:45:07 +02:00
Roy-043
084a8e6fae Arch: Fix Arch_Wall: block joints where put on the wrong side of offset 
In the execute method block joints were put on the wrong side of the offset which lead to the first block in each row being larger than intended.
 2021-07-07 18:54:34 +02:00
Chris Hennes
8228d64ac4 [ARCH] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
Abdullah Tahiri
2386df93aa Arch: Make ArchWall use Sketcher GeometryFacade 2020-12-13 15:36:59 +01:00
luz paz
67381e9579 Arch: Fix header uniformity and remove trailing whitespace 2020-11-16 14:51:53 +01:00
Yorik van Havre
87eae7c58c Arch: Enabled ellipse-based walls - fixes #3859 2020-10-20 13:13:54 +02:00
Yorik van Havre
dd51cbccb2 Arch: Fixed translation of wall (better version) 2020-10-12 15:58:41 +02:00
Yorik van Havre
a0114ac41a Arch: Fixed translation of wall 2020-10-12 15:57:15 +02:00
Roy-043
8ef5e8e333 Arch: Arch_Wall fix MultiMaterial alignment bug. 2020-09-16 13:08:45 +02:00
carlopav
6f2691631c Draft: fixed obj.TypeId output after utils.get_type() change 
.


.
 2020-09-09 14:13:29 +02:00
Vanuan
0811c61435 Fix non-center aligned wall with multimaterial 2020-08-11 12:21:41 +02:00
paul lee
4e36cde00a [ArchWall] Failed if Sketch as Base has Point, now OK 
FC Forum Discussion -
https://forum.freecadweb.org/viewtopic.php?f=23&t=48668&sid=ba6dd68ad32eefbad6ae95d8fadc30e6#p416779
 2020-07-20 14:17:28 +02:00
paul lee
07349609da [ArchWall] Fix #0004400 - Archwall creation from certain wire fails. 
Forum Discussion - https://forum.freecadweb.org/viewtopic.php?f=23&t=47505
 2020-07-16 13:53:11 +02:00
hlg
a48b74d8a5 [Arch] ignore extrusion direction vector length 2020-07-13 14:39:28 +02:00
paul lee
8ff45dfb39 [ArchWall] Revert comments in getExtrusionData() 2020-06-24 11:29:07 +02:00
paul lee
81dd47b039 [ArchWall] ArchWall Offset should now works with Base as Sketch 2020-06-24 11:29:07 +02:00
paul lee
bd02e1bb9d [ArchWall] Fix Align Right with Multi-Material invalid case problem 2020-05-25 13:34:46 +02:00
Yorik van Havre
40600a55c2 Arch: Misc improvements to curtain wall 
- Can be based on an edge like normal wall
- Now has a 'host' property to embed into another object (tree only)
- Mullions have different height and width properties
- Mullions or panels can be disabled
 2020-05-19 13:58:46 +02:00
Yorik van Havre
6945e37635 Arch: Fixed regression in compound walls 2020-05-18 15:04:26 +02:00
Yorik van Havre
146a175370 Arch: Removed wrong warning in walls 2020-05-18 13:28:55 +02:00
vocx-fc
0fe0f2a31f Arch: fix wall's addDefault call 
A previous fix was in 8d4ed61782, but some calls to `addDefault`
were not changed.
 2020-05-04 10:55:56 +02:00
Yorik van Havre
8d4ed61782 Arch: Fixed regression in wall 2020-04-24 15:10:42 +02:00
David Daish
c11ebcd43a Rewrote the function and method docstrings in an imperative style. 2020-04-22 12:17:08 +02:00
David Daish
14283ea3ee Moved __init__ docstrings into the class docstring 2020-04-22 12:17:08 +02:00
David Daish
5f0438fb9c Removed incorrect apostrophies. 2020-04-22 12:17:08 +02:00
David Daish
7490f3fc4c Comparison with None is now using 'is' operator 2020-04-22 12:17:08 +02:00