kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
26,821 Commits 39 Branches 6 Tags
a930d4ebac8d8036db03de4d74606b32f344eff5
Commit Graph

43 Commits

Author SHA1 Message Date
mwganson
a930d4ebac [PartDesign] for chamfer and fillet, add SelectAllEdges option in the context menu while in add or remove mode 2021-12-31 14:01:43 +01:00
wmayer
482884cfd4 PD: [skip ci] fix regression caused by e0d07257b7 
In the accept() method the view provider of the edited object must be made visible if it's valid as otherwise it can happen that the view is empty.

See https://forum.freecadweb.org/viewtopic.php?f=13&t=55915
 2021-02-23 11:20:45 +01:00
donovaly
e0d07257b7 [PD] fix dressup feature display when broken 
As discussed in https://forum.freecadweb.org/viewtopic.php?p=479647#p479377
the user can end up without either seeing nothing or an inexisting dressup feature.

This PR fixes this.
 2021-02-19 14:51:52 +01:00
Chris Hennes
41a40c1c31 [PD] Catch Python exceptions in dtors (Coverity) 
In some PartDesign task dialogs, the destructors call functions that may
throw exceptions. If that occurs and the exception is uncaught, this
will ususally end up terminating the program. This commit adds try-catch
blocks around each instance of that (identified by Coverity) and handles
the Python exception in the normal reporting workflow.
 2021-02-08 21:30:22 +01:00
donovaly
2ac84872ec [PD] make pointers to the UI std::unique_ptr 
Same as PR #4293, just for PartDesign

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all PartDesign dialogs that don't already use a unique_ptr.
 2021-02-05 18:01:57 +01:00
luz paz
faa8688ee5 PartDesign: Issue #0004473: Expose openCommand() to translation 
Continuing the work to expose the undo/redo functionality to translation. This commit does so for the PartDesign Wb.  
Ticket: https://tracker.freecadweb.org/view.php?id=4473
 2020-12-01 14:53:35 +01:00
wmayer
bdd8d257d9 PartDesign: [skip ci] optimize when removing items from dress-up features 2020-02-23 14:58:48 +01:00
donovaly
da6352c43d [PD] only recompute once per deletion action 
see https://forum.freecadweb.org/viewtopic.php?f=19&t=43383&p=370357#p370357
 2020-02-23 12:43:11 +01:00
donovaly
361acd5a84 [PD] enable selection of fillets etc. using arrow keys in Dlg 
see https://forum.freecadweb.org/viewtopic.php?f=19&t=43383&p=370758#p370758
 2020-02-21 09:27:00 +01:00
donovaly
cc3b21fa0b improve code as suggested by Werner 
see https://forum.freecadweb.org/viewtopic.php?p=369921#p369921
 2020-02-18 23:16:48 +01:00
donovaly
69f97014e7 [PD] missing changed from commit d4be4a02 
(key event handling for more dialogs)
 2020-02-18 22:29:53 +01:00
donovaly
01e8e7f777 try to squash GCC compile error 2020-02-18 00:08:58 +01:00
donovaly
b86d97b9bc catch case that users tries to delete all items in the dialog list 2020-02-18 00:08:28 +01:00
donovaly
316a8840b4 remove unnecessary code and comment 2020-02-18 00:07:01 +01:00
donovaly
0a7d82b0bb enable selection in the dialog item list 
now the user can use the Ctrl and/or Shift key to select multiple items to be deleted
 2020-02-17 22:36:42 +01:00
donovaly
702b37aa06 improve fillet dialog logic 
- now also the case of only one item in the list is handled properly (single-click will highlight it, double-click will show the final fillet)
 2020-02-17 21:53:45 +01:00
wmayer
7aad85e9c8 PartDesign: [skip ci] workaround for ambiguous Delete key event 2020-02-17 00:46:17 +01:00
wmayer
177afc7b91 PartDesign: [skip ci] fix possible segmentation fault in destructors of dressup task panels 2020-02-16 20:58:44 +01:00
donovaly
d40eb2dbfc [PD] add feature to highlight references in some dialogs 
- also fix some logic issues and avoid to break the feature (deleting the last item is now no longer possible)
 2020-02-16 05:18:29 +01:00
donovaly
3877e18e06 [PD] enable to de/selecet several entities at once 
see https://forum.freecadweb.org/viewtopic.php?f=19&t=43383
 2020-02-15 04:07:09 +01:00
wmayer
88a60f91e9 PartDesign: use QKeySequence::Delete instead of a QString 2020-02-14 10:11:09 +01:00
donovaly
5ca8b490f0 [PD] add shortcut to context menus 
- people should be informed that there is a shortcut available (that was recently added)
- make the shortcut also translatable since "Del" means nothing in e.g. German
- minor code style fix in TaskDressUpParameters.h
 2020-02-14 09:59:46 +01:00
Zheng, Lei
11a93a0578 PartDesign changes 
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
 2019-08-17 15:15:47 +02:00
wmayer
10c745175f support Del shortcut in several PD task dialogs 2019-02-27 13:36:45 +01:00
sL1pKn07
018b41032a [For v018] Fix build with Qt5 beta 
Seems need add some headers for build with incoming Qt 5.11 (Tested with 5.11.0beta2)
 2018-04-10 12:59:41 +02:00
Stefan Tröger
4d12023f17 Prevent dressup crash due to multi command commit 
the same functionality is provided by upstream accept functions
 2016-04-12 18:12:21 +02:00
Alexander Golubev
c782a11aab PartDesign/Gui: Move various utility stuff from Workbench to a separate file 
Also do some header cleanup.
 2016-04-12 18:12:17 +02:00
Alexander Golubev
11a71d46e3 PartDesignGui: move signal connections in several parameter dialogs after ui initialization 2016-04-12 18:12:15 +02:00
Alexander Golubev
e586f55fb2 PartDesign/Gui: more old workflow support 
* remove an error message if adding a sketchbased feature without a body
* add champfer or fillet old workflow support

Also rework finishFeature() so at least champfer and fillet may be
inserted into any place of any apropriate body(not only the active one) of the body.
 2016-04-12 18:12:14 +02:00
Stefan Tröger
fc1e8b8d17 allow to add faces to fillet and chamfer 2016-04-12 18:12:07 +02:00
jrheinlaender
5376e3a3e5 Fixed bugs in various features that reversed the list of selections 2016-04-12 18:11:57 +02:00
jrheinlaender
ee7f50a554 Allow selecting and removing fillet and chamfer references in the dialog 2016-04-12 18:11:56 +02:00
jrheinlaender
7330d4357e Made the rest of the PartDesign features aware of the Body 2016-04-12 18:11:49 +02:00
Eivind Kvedalen
ddfbe349cf PartDesign: Added support for expressions. 2015-09-21 14:51:09 +02:00
wmayer
2608d0aaf2 + 0001849: Enable Spin Boxes support for Pad, Fillet and Chamfer 2014-12-07 00:38:02 +01:00
wmayer
107a7f50dc + fix bug in chamfer/fillet when aborting command 2014-07-22 11:02:45 +02:00
wmayer
4ae0d4db53 + do not allow negative numbers in fillet and chamfer panel 2014-07-18 15:23:36 +02:00
wmayer
30e8c12f54 + fixes #0001562: Add units to Fillet and Chamfer in PartDesign 2014-06-10 12:33:14 +02:00
wmayer
fb994e204c + fixes #0000854: Ability to change number of digits to the right of decimal place in spinboxes 2014-02-16 18:02:09 +01:00
jrheinlaender
8df84e76c4 PartDesign module moving float -> double 2013-03-25 17:42:29 +04:30
wmayer
6ec6ed601e + set focus on spin box for pocket, revolve and fillet task panel 
git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5217 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
 2011-12-04 16:15:36 +00:00
jriegel
c2fefaeff9 + fetched actual documentation 
+ icon for fillet dialog
+ small updates in wiki2qhelp.py

git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5115 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
 2011-11-11 07:21:00 +00:00
jriegel
72bfc3c74b + Add fillet dialog 
+ fix undo/redo bug in edit PartDesign features 
+ partially clean up module dependency in ViewProvider base class

git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5108 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
 2011-11-09 23:23:10 +00:00