kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
28,221 Commits 40 Branches 6 Tags
afb32621188a6ce91610204d6c11d5cec8710040
Commit Graph

2372 Commits

Author SHA1 Message Date
sliptonic
afb3262118 simpler way to filter roughly equal depth values 2022-03-20 14:25:16 -05:00
Russell Johnson
3e6d542cd7 Path: Fix roughly equal depth entries 
Add code block to remove first of any two consecutive, roughly equal depth values (twin values).

Add two unit tests to support new code block and use cases.
 2022-03-20 14:25:14 -05:00
luz paz
8939e3a2eb Path: remove superfluous 'pass' per LGTM 
ref: https://lgtm.com/rules/910088/
 2022-03-19 20:06:48 -04:00
sliptonic
06959ededb Merge pull request #6575 from Russ4262/fix/rebuild_empty_job_with_gui 
Path: Extend Job integrity check to GUI side, issue #6207 [Bug]
 2022-03-19 15:44:28 -05:00
Russell Johnson
b06389edb2 Path: Change action to warning with option for action. 2022-03-16 11:47:51 -05:00
Russell Johnson
70d5a422f7 Path: Correct comment spelling 2022-03-16 11:40:24 -05:00
Russell Johnson
e4286139db Path: Extend Job integrity check to GUI side, issue #6207 [Bug] 
This commit adds a simple `_jobIntegrityCheck()` method to verify that a model and tool exists within the Job object, when interacting with the Task Panel.  If either is missing, the appropriate tab is activated in the task window, and the appropriate edit window is opened for the user, with messages printed in the report view window.

Add check for existence of `SetupSheet` property of empty Job object.

These changes improve upon fixes in PR #5008 and related bug fixes.
 2022-03-16 11:40:23 -05:00
sliptonic
de94520d9b [Path] Warn user if enabling legacy tools 
Warn user if opening job that contains legacy tools
 2022-03-15 11:05:20 -05:00
sliptonic
b640a1d106 Merge pull request #6577 from Russ4262/fix/millface_removalshapes 
Path: Fix `self.removalshapes` declaration [Bug]
 2022-03-15 09:26:39 -05:00
sliptonic
a70adce220 Merge pull request #6576 from Russ4262/fix/cancel_new_dressup_cleanup 
Path: Fix automatic `commitTransaction()` calls, issue #6149 [Bug]
 2022-03-15 09:25:43 -05:00
sliptonic
75fee12d7b Merge pull request #6571 from Russ4262/fix/tag_dressup_radius_value 
Path: Fix inconsistent float type usage, issue #6170 [Bug]
 2022-03-14 09:26:24 -05:00
Russell Johnson
ac4c7bb954 Path: Fix self.removalshapes declaration [Bug] 
Prior to this fix, the `self.removalshapes` variable is not declared if `obj.Base` does not exist, or is empty.  This moves the declaration up in scope to the method level.
 2022-03-12 22:34:03 -06:00
Russell Johnson
20e3657125 Path: Fix automatic commitTransaction() calls, issue #6149 [Bug] 
This commit removes the automatic committal of transactions when activated with GUI command.  The committal of the transaction is executed with the `accept()` and `reject()` methods of the respective task panel.
 2022-03-12 22:05:04 -06:00
Russell Johnson
1fc468912c Path: Improve value assignment syntax for radius 2022-03-12 20:00:40 -06:00
sliptonic
b0d19d28d7 Merge pull request #6566 from Russ4262/fix/boundary_dressup_begin_safeheight_retraction 
Path: Correct beginning retraction to safe height in Boundary Dressup, issue #6279 [Bug]
 2022-03-12 19:05:39 -06:00
Russell Johnson
a2fb5b66fa Path: Fix radius type inconsistency, issue #6170 [Bug] 
Make `self.radius` a float type throughout since other methods and functions treat it as such.
 2022-03-12 18:29:21 -06:00
Matti Eiden
af8b6fba07 PathArray: Support applying PathArray on Dressups 2022-03-12 22:31:16 +02:00
Russell Johnson
dd76cabb34 Path: Correct beginning retraction to safe height feed rate, issue #6279 [Bug] 
This commit changes the feed rate of the beginning retraction from G1 at Feed to a G0 Rapid rate.  This initial command is causing a problem with the Tag Dressup due to the first move being a G1 to Safe Height.
 2022-03-12 12:18:09 -06:00
sliptonic
e1ce0c7695 Merge pull request #6552 from Russ4262/fix/leadin_leadout_simulation 
Path: Fix Leadin-Leadout dressup simulation related to arcs [Bug]
 2022-03-11 10:06:42 -06:00
sliptonic
0bc9edeb50 Merge pull request #6541 from Russ4262/fix/ramp_entry_dressup 
Path: Fix enumeration dictionary error [Bug]
 2022-03-11 10:04:53 -06:00
Russell Johnson
48e4622193 Path: Fix Leadin-Leadout dressup simulation related to arcs 
Add missing "Z" and "K" parameters for arc commands to appease Path simulator.
 2022-03-10 20:05:52 -06:00
Russell Johnson
6b8b870e21 Path: Fix enumeration dictionary error 
This commit corrects an incorrect dictionary key in the enumeration dictionary updated with recent translation fixes.
 2022-03-09 21:03:34 -06:00
sliptonic
faec9e36c2 fixes #5954 
Make headers less confusing and ambiguous
 2022-03-08 08:40:05 -06:00
sliptonic
51b9d40010 fixes 6114 
replaces DlgJobChooser with QInputDialog.
 2022-03-07 17:51:00 -06:00
sliptonic
693315755f Merge pull request #6485 from mlampert/feature/external-thread-milling 
Path: Feature/external thread milling
 2022-03-04 12:52:31 -06:00
sliptonic
0d98056384 Merge pull request #4911 from sliptonic/feature/nopathjob 
[Path] Make Job and Operation visibility more natural
 2022-03-04 12:51:25 -06:00
Markus Lampert
c0bb11384c Split out thread milling generator into its own file 2022-03-04 10:42:34 -08:00
sliptonic
228fce273b black format 2022-03-04 10:42:34 -08:00
Markus Lampert
d80c4ce399 Removed debugging gates 2022-03-04 10:42:34 -08:00
Markus Lampert
f082f40473 Fixed UI update upond changing the thread type 2022-03-04 10:42:34 -08:00
Markus Lampert
238bb7c2bb Fixed multi pass for external threads with proper lead in/out 2022-03-04 10:42:34 -08:00
Markus Lampert
46827df206 Changed passes for constant tool engagement 2022-03-04 10:42:34 -08:00
Markus Lampert
e00e1b3591 Disabled debugging comments 2022-03-04 10:42:34 -08:00
Markus Lampert
e4fb163cc1 Fixed lead in/out with elevator location. 2022-03-04 10:42:34 -08:00
Markus Lampert
de6ab3fc79 Added thread generation unit tests and fixed finishing the thread 2022-03-04 10:42:34 -08:00
Markus Lampert
fae7b96b3f Some code cleanup 2022-03-04 10:42:34 -08:00
Markus Lampert
eb48466724 Added imperial external and split data files according to tolerance classes 2022-03-04 10:42:34 -08:00
Markus Lampert
7c2a8a92fb First shot at external thread milling 2022-03-04 10:42:34 -08:00
sliptonic
b2f77797a7 Merge pull request #6480 from sliptonic/bug/velocitywarn 
[Path] Fix bug with velocity warning.
 2022-03-01 08:18:10 -06:00
Markus Lampert
934b0aaa07 Consistent black formatting of all Path python files 2022-02-28 21:06:16 -08:00
Markus Lampert
8583894284 Remove pylint annotations and script 2022-02-28 21:02:45 -08:00
sliptonic
13cd8d2c15 Fix bug with velocity warning. 
Add button to suppress
 2022-02-28 17:55:19 -06:00
sliptonic
155debae48 Merge pull request #5512 from luzpaz/Path-PathSelection-bug 
Path: Fix class 'KeyError' in PathSelection.py
 2022-02-23 08:40:45 -06:00
luz paz
7981752305 [Path] mark deprecated selections 
...and fix typos
 2022-02-22 19:07:54 -05:00
sliptonic
64b9841cb8 Update PathSelection.py 
The Opname changed as part of the translation cleanup.  Adding both names to the dictionary will support both existing operations and newly created ones.
 2022-02-22 14:56:00 -06:00
sliptonic
8e10ce07f9 Merge pull request #5424 from Russ4262/fix/3D_pocket_overcut 
Path: Fixes 3D Pocket overcut on underside of selected faces
 2022-02-22 08:52:12 -06:00
sliptonic
c50348697a Make job work more naturally 
Operations Group as document group
Make job claim children

[Path] Make Operations into a document group
 2022-02-19 09:12:41 -06:00
sliptonic
112bea9d5b [Path] Fix Path generation for forking wires 2022-02-18 17:05:42 -06:00
sliptonic
7b7b76f1ec Merge pull request #6373 from Russ4262/fix/3d_surface_property_enumerations 
Path: Correct restoration of 3D Surface property enumerations
 2022-02-18 10:57:11 -06:00
Russell Johnson
56f95bb4e8 Path: Remove waterline, outline, and avoid extensions 2022-02-17 23:39:44 -06:00