Commit Graph

3120 Commits

Author SHA1 Message Date
Eric Price
aba60775f6 Fix boolean operations (#17119)
* add BRepAlgoAPI wrapper files to CMakeList

* introduce wrapper for BRepAlgoAPI_BooleanOperation and derivatives, set sensible default Fuzzyness for boolean operations

* allow default fuzzyness to be set in settings - including off

* backwards compatibility with OCCT 7.3.3 - removed newer paramateres from wrapper

* added missing header

* reverted src/Mod/Part/App/OpenCascadeAll.h to original state

* implement some changes suggested by @wwmayer

* removed unneeded destructor definitions

* moved getDefaultFuzzyValue into its own helper class

* removed unneeded references to base class default constructor

* default to SetRunParallel(Standard_True) as suggested by @FlachyJoe

* fixed license header as requested

* Added new method to autocalculate fuzzyness to BooleanOperation base class and use it for those parts that do not call the obsolete constructor but also do not set precision

* implemented static variable solution as suggested by @wwmayer

* added helix for test case

* Refactoring FCRepAlgoAPI to FCBRepAlgoAPI

* Added Test Case (fuse cylinder with helix with different working and non-working Fuzzy values)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* increased default value of FuzzyBoolean and made tests more robust for compatibility with OCCT 7.3

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixes for FREECAD_USE_PCH - allow testing of FREECAD_USE_PCH on linux with cmake switch (default OFF)

* removed surplus line - wasn't needed after all

* included precompiled as instructed

* set anti-corruption flag in boolean operations, ensures source shape is not damaged in OCCT 7.1 and higher

* fix #17085

* disable subtests that were too specific for now

* fixed all CLI tests - see comments in Pull Request https://github.com/FreeCAD/FreeCAD/pull/17119#issuecomment-2420772452

* Update src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* remove surplus tests from github suggestion interface bug

* hide the BooleanFuzzy variable - can now be only set by manually editing the config file
i
in FCParamGroup "Boolean"
<FCFloat Name="BooleanFuzzy" Value="10.000000000000"/>

* Suggestion by @FlachyJoe - add validity checks to the base and tool shape in any direct boolean op

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>
2024-10-21 18:38:51 +02:00
wandererfan
b867a63038 [TD]Fix leader line style (fix #17307) 2024-10-21 17:57:52 +02:00
Syres916
fdb2bc4326 [TechDraw] Fix error for some compilers 2024-10-15 14:19:05 +02:00
Yorik van Havre
d79015a908 crowdin translations 2024-10-14 17:56:08 +02:00
Yorik van Havre
a698c75581 updated ts files 2024-10-14 17:56:08 +02:00
WandererFan
227cd14022 [TD]Fix bad circles (fix #16980) (#17182)
* [TD]fix spurious messages in GeometryMatcher

* [TD]fix closed circle test (fix #16980)
2024-10-14 17:47:04 +02:00
wandererfan
17e9f10ca7 [TD]throttle over aggressive dimension autocorrect 2024-10-14 17:45:53 +02:00
wmayer
a54a7862f4 TD: Fix compiler warnings
This fixes the compiler warning: unused parameter 'mode' [-Wunused-parameter]

It's a regression of #16889 to not initialize the class member m_createMode any more that causes UB,
i.e. whenever m_createMode is accessed it may return an unexpected value.
2024-10-07 17:40:32 +02:00
wandererfan
ddad57f20c [TD]fix parallel edge test (fix #16851)
- missing normalization before test
2024-10-07 17:34:11 +02:00
WandererFan
a2c3a1a542 [TD]Fix auto correct msg missing16892 (#16909)
* [TD]fix bad return code on auto-correct fail

* [TD]prevent changing references in property editor

- this is a "shoot yourself in the foot" practice
2024-09-30 18:20:47 +02:00
wandererfan
faad9fd432 [TD]fix no dim repair on area (fix #16894) 2024-09-30 18:13:28 +02:00
wandererfan
0d342c67a1 [TD]fix solid line detail highlight not shown 2024-09-30 18:01:43 +02:00
Yorik van Havre
eec3fe4c5d Merge pull request #16889 from WandererFan/fixProjConvention16788
[TD]Fix proj convention (fix #16788, fix #16785)
2024-09-30 18:00:43 +02:00
wandererfan
e1f5d3b8a5 [TD]fix bad default value (fix #16783) 2024-09-30 11:44:53 -04:00
Yorik van Havre
37857a8dad Merge pull request #16639 from WandererFan/balloonDrag15388
[TD]Balloon origin drag modifiers (fix #15388)
2024-09-30 17:40:23 +02:00
wandererfan
98906c5edf [TD]fix handling of projection convention (fix #16788 #16785) 2024-09-28 10:39:30 -04:00
wandererfan
d77ce6b78e [TD]add preference methods for Projection Group 2024-09-28 10:39:18 -04:00
wandererfan
1f825fb13c [TD]fix crash on bad selection (fix #16727) 2024-09-24 10:07:51 -05:00
Yorik van Havre
3395a8d4a7 Translations (#16754)
* Updated ts files

* merged crowdin translations

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-09-23 14:09:56 -04:00
3x380V
2443f3ebb4 TechDraw: Buggy Wayland custom cursors workaround (#16740)
* Gui: Minor polishing of cursor regression fix

* TD: Buggy Wayland custom cursors workaround

Until Qt v6.6 displaying custom cursors on Wayland is broken,
so add a workaround. See also QTBUG-95434.

Fix is the same as 094c1b10 ("Gui: Buggy Wayland custom cursors workaround")
plus subsequent fixes.
2024-09-23 17:43:10 +02:00
WandererFan
c9beae7ef3 [TD] Fix win file spec backslash (fix #16646) (#16689)
* [TD]add method to clean win filespecs

- '\' in strings passed to Python as filespecs is interpreted as
  an escape of the following character.
- replace '\' with '/'

* [TD]remove '\' from filespecs before use
2024-09-23 17:40:05 +02:00
wandererfan
8a4342e6e1 [TD]fix BrokenView selection (fix #16567) 2024-09-23 10:36:51 -05:00
wandererfan
a35ba33433 [TD]respect camera direction preference (fix #16593) 2024-09-23 09:23:42 -05:00
wandererfan
9ee4b6d5db [TD]fix torus render (fix #16646) 2024-09-23 09:21:00 -05:00
wandererfan
22a65908b9 [TD]fix double pdf file on win (fix #16538) 2024-09-23 09:18:47 -05:00
Roy-043
15cc47a11c Correct tree icon for TechDraw_AreaDimension 2024-09-22 16:58:52 -05:00
Yorik van Havre
b97362bf0a Translations (#16582)
* updated ts files

* merged crowdin translations

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-09-19 09:36:54 +02:00
wandererfan
ca2b9dc8d8 [TD]allow override of Balloon drag modifier (fix #15388) 2024-09-17 21:40:50 -04:00
wandererfan
d310876099 [TD]add preferences for Balloon drag modifiers 2024-09-17 17:17:15 -04:00
wandererfan
9e86a3558f [TD]allow SaveCopy from MDIViewPage (fix #16447) 2024-09-16 17:35:51 +02:00
hasecilu
2e7a04f4e2 Fix some typos on several files
- Missing spaces
- Missing commas
- 3D, G-code, Git, SPOOLES, Python capitalization
2024-09-14 12:07:51 -06:00
hasecilu
66e81e866b TechDraw: Fix capitalization of 2D and 3D 2024-09-14 12:07:50 -06:00
wandererfan
87da073f39 [TD]Use correct translate function (fix 335)
- another translation cycle will need to occur before the change is
  apparent.
2024-09-14 09:48:33 -04:00
wandererfan
b097779b53 [TD]Use correct translation function (fix #317)
- another translation cycle will have to run before the change is
  apparent.
2024-09-14 09:43:06 -04:00
luzpaz
cd7c56eda9 TechDraw: fix typo ballon->balloon 2024-09-12 09:25:40 -04:00
Benjamin Bræstrup Sayoc
fa6c81d23e [TechDraw] Fix uncentered balloon label 2024-09-11 20:04:30 -04:00
Yorik van Havre
e1823d25e8 Translations (#16389)
* Translations: Updated ts files

* Translations: Merged crowdin translations

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-09-09 18:25:52 +02:00
wandererfan
44b7c8e34b [TD]fix initial balloon placement on rotated view (fix #16234) 2024-09-09 17:41:51 +02:00
wmayer
1cbed2464a TD: Fix warnings 2024-09-03 17:27:00 +02:00
Benjamin Bræstrup Sayoc
66539741ac [TechDraw] Some refactoring of frame pen 2024-09-02 16:53:37 -04:00
Benjamin Bræstrup Sayoc
61a681de19 [TechDraw] Fix incorrect centering of dimension label
and improve rendering of frame
Fixes #15103
2024-09-02 16:53:37 -04:00
wandererfan
196b0ede16 [TD]fix outer torus edge not rendered (fix #16136) 2024-09-02 18:41:58 +02:00
WandererFan
140bcf605e [TD]Fix section snapping (fix #15961) (#15450)
* [TD]Add view snapping preferences

* [TD]fix section snapping algo

- snap sections to section normal line.
- snap views to other views in X&Y

* [TD]fix snapping to ProjectionGroups
2024-09-02 18:41:25 +02:00
Benjamin Bræstrup Sayoc
806284deda [TechDraw] Adjust widget positions to accomodate more themes 2024-09-02 18:27:01 +02:00
Benjamin Bræstrup Sayoc
64b64b4a0b [TechDraw] Make icons transparent and adaptable to theme color
...and center icons
2024-09-02 18:27:01 +02:00
Benjamin Bræstrup Sayoc
aed7e133b0 [TechDraw] Increase icon size for surface finish symbol buttons 2024-09-02 18:27:01 +02:00
wandererfan
3d0e22c489 [TD]fix dim text wrong side of dim line (fix #16172) 2024-09-02 18:24:16 +02:00
wandererfan
5c310d5046 [TD]fix projection group detection (fix #16179) 2024-09-02 18:23:37 +02:00
wandererfan
6678923486 [TD]fix page margins on pdf export (fix #15848) 2024-09-02 18:02:30 +02:00
wandererfan
042733d975 [TD]fix balloon drag on rotated view (fix #15726) 2024-09-02 17:47:40 +02:00