Commit Graph

27233 Commits

Author SHA1 Message Date
André Althaus
b1f9e9f805 Fix linter hints 2024-02-28 17:29:59 +01:00
André Althaus
b301816889 Refactor the apply function to be virtual public 2024-02-21 15:04:38 +01:00
André Althaus
7bbca2f00d Fix crash when canceling the MultiTransform panel while a newly cretated subfeature is edited
Before calling the closeSubTask() function from the dialog reject()
function, the slotDeletedObject() is called from the transaction being
aborted. This causes the subFeature pointer to be nullptr and subsequent
apply() functions from the SpinBox widgets to crash.

Before calling apply check if the subFeature is still there.
2024-02-21 14:56:23 +01:00
André Althaus
bb25074076 Reformat files with clang-format 2024-02-17 17:13:14 +01:00
André Althaus
fd4bea24b7 Fix apply() method not called consistently
The python console commands where not consistenly reported because
the apply function was not called or not implemented.

The function is now called from the base class and also when
a subfeature is closed in MultiTransform.

Some missing properties are also added.
2024-02-17 17:13:14 +01:00
André Althaus
48d9a8da86 Refactor: optimize member access specifiers
After refactoring many members have unnecessarily open access specifiers.
This changes as many members as possible to private or protected.
2024-02-17 17:12:59 +01:00
André Althaus
77bcd7e50f Refactor: remove unused functions 2024-02-17 17:12:59 +01:00
André Althaus
4ae184706d Refactor: add default member initializers 2024-02-17 17:12:59 +01:00
André Althaus
ab7dd607a5 Refactor: replace enum with enum class 2024-02-17 17:12:59 +01:00
André Althaus
24c138373c Move duplicated code to the base class
All pattern sublcasses contain the same code for handling the
feature list. This code is now moved into the base class that handles
the common ui.

The subclasses now only need to call the setupUI/setupParameterUI function
in their constructors and implement the setupParameterUI function
to create their parameter ui into the specified widget.

The MultiTransform also handles it's common ui and the subclasses
can reuse setupParameterUI without code duplication.
2024-02-17 17:12:32 +01:00
André Althaus
5139182dbe Refactor PD Pattern Tasks ui files
All files contain the same add/remove buttons and a feature list.

These common elements are moved into the TaskTransformedParameters.ui file.
The same goes for the common OK Button that is used in a MultiTransform.

The ui files for the patterns only contain their distinctive
parameters. And the common ui files contain an empy widget that will
be filled with the respective parameter widgets from the patterns.
2024-02-17 17:11:57 +01:00
Chris Hennes
c4daf256b2 Merge pull request #12460 from bgbsww/bgbsww-toponamingMakeElementPipeShell
Toponaming/Part:  make element pipe shell
2024-02-16 22:54:22 -06:00
bgbsww
abde135776 Toponaming/Part: Cleanup makeElementPipeShell, add tests, and some delinting 2024-02-16 22:16:58 -05:00
marioalexis
7262b0ecc8 Fem: Run option in examples open and run analysis - fixes #11056 2024-02-16 21:01:23 -06:00
Zheng, Lei
ac1d862a3e Toponaming/Part: Transfer makEPipeShell 2024-02-16 21:01:49 -05:00
bgbsww
921be4daaa Toponaming/Part: Clean and add tests 2024-02-16 14:01:12 -05:00
Zheng, Lei
d80758e882 Toponaming/Part: transfer in makELoft 2024-02-16 11:22:29 -05:00
bgbsww
044329ae82 TopoNaming/Part: cleanups and tests 2024-02-16 11:22:29 -05:00
Roy-043
ca1a10585a Draft: fix wrong selection after commands (improved)
The previous fix was not correct. Some commands would cause a crash and several files were missed.

Forum topic reporting a crash:
https://forum.freecad.org/viewtopic.php?t=85243
2024-02-16 10:56:10 +01:00
bgbsww
ac618d8ec5 TopoNaming/Part: cleanups and tests 2024-02-15 19:07:19 -05:00
Zheng, Lei
c0c16f684c TopoNaming/Part: transfer in MakERuledSurface 2024-02-15 19:05:55 -05:00
Chris Hennes
dd02306da0 Merge pull request #12417 from bgbsww/bgbsww-toponamingLinearize
Toponaming/Part: transfer in linearize
2024-02-15 18:02:08 -06:00
Roy-043
c02762cd31 Merge pull request #12430 from Roy-043/Draft-remove-reapply_diffuse_color-workaround-step-2
Draft: remove reapply_diffuse_color workaround step 2
2024-02-15 23:44:52 +01:00
bgbsww
61bcd553ee Toponaming/Part: Clean up linearize, add tests, and some delinting 2024-02-15 16:53:01 -05:00
Roy-043
faa9ad4c16 Draft: remove reapply_diffuse_color workaround step 2
Stuff that was missed in #11946
2024-02-15 22:28:37 +01:00
Roy-043
167b3846de Draft: gui_line_add_delete.py is obsolete 2024-02-15 22:20:53 +01:00
marioalexis
ea840bc3a3 Fem: Expose Constraint view provider symbol node to Python 2024-02-15 13:31:20 -06:00
marioalexis
c49c52716c Fem: Move Points and Normals properties to base class 2024-02-15 13:31:20 -06:00
Ladislav Michl
a489b095f0 Assembly: Add ${PYTHON_INCLUDE_DIRS} to CMakeLists.txt
Assembly Gui is including <Base/PyObjectBase.h> which in turn
includes <Python.h>, so path to Python includes is needed.
2024-02-15 13:24:15 -06:00
Zheng, Lei
964e15805a Toponaming/Part: transfer in linearize 2024-02-15 14:21:32 -05:00
Chris Hennes
779c63c2fd Merge pull request #12414 from bgbsww/bgbsww-toponamingSearchSubShape
Toponaming/Part: Add  searchSubShape as findSubShapesWithSharedVertex
2024-02-15 12:49:42 -06:00
bgbsww
6c3f250e4c Toponaming/Part: Add tests for searchSubShape 2024-02-15 12:36:23 -05:00
Zheng, Lei
db377c1854 Toponaming/Part: transfer in searchSubShape 2024-02-15 07:54:22 -05:00
Chris Hennes
9917565d95 Merge pull request #12405 from bgbsww/bgbsww-toponamingMakeElementDraft
Toponaming/Part: Transfer in MakeElementDraft
2024-02-14 21:10:56 -06:00
Chris Hennes
b075f7d5d6 Part/Toponaming: Apply clang-format to TopoShapeExpansion 2024-02-14 18:56:38 -06:00
Chris Hennes
66e29cbd79 Assembly: Add ${COIN3D_INCLUDE_DIRS} to CMakeLists.txt (#12407)
* Assembly: Add ${COIN3D_INCLUDE_DIRS} to CMakeLists.txt
2024-02-14 18:26:30 -06:00
bgbsww
6e9cd051f2 Toponaming/Part: Cleanup and test makeElementDraft 2024-02-14 12:20:10 -05:00
LemonBoy
7f5d89fa19 Part Attacher: Implement 1D intersection for attachments (#12328)
* PD: Implement 1D intersection for attachments

Extract a line from the intersection of two faces.

Closes #6870

* fixup! Use Handle macro

For some reason I don't fully understand yet the CI was failing, let's
see if this fixes the compilation errors.

* fixup! Add missing(?) header

Well, it compiles just fine on my system...

* fixup! Be more specific in error messages
2024-02-13 17:45:01 -03:00
LemonBoy
c0e318c6d0 Part Grid: Exclude the grid group from bbox computation (#12349)
Fixes the problem where View_FitAll would compute a huge bounding box
when the infinite grid is enabled.

Closes #11570

Co-authored-by: wwmayer <werner.wm.mayer@gmx.de>
2024-02-13 17:42:51 -03:00
Florian Foinant-Willig
74c52c9063 PD: handle null pointer in Feature::getBaseShape (#12385) 2024-02-13 17:41:25 -03:00
Chris Hennes
d89f4d7f29 Merge pull request #12366 from bgbsww/bgbsww-toponamingGetSubTopoShape
Toponaming/Part:  Move getSubTopoShape
2024-02-13 14:09:24 -06:00
Zheng, Lei
c5ba519470 Toponaming/Part: move in makeElementDraft 2024-02-13 13:41:56 -05:00
Chris Hennes
61ec050405 Merge pull request #10764 from Ondsel-Development/asm_card9
[Assembly] Solve the assembly (Card 9).
2024-02-13 10:13:08 -06:00
JULIEN MASNADA
eb468a34d9 Fixed invalid vector in distance calculation (#12364)
* Fixed invalid vector in distance calculation
2024-02-13 10:11:22 -06:00
bgbsww
ae4393978f Toponaming/Part: clean, doc, and test getSubTopoShape 2024-02-13 10:14:39 -05:00
Zheng, Lei
76df39e99d Toponaming/Part: transfer in getSubTopoShape 2024-02-13 10:01:17 -05:00
howetuft
b39d246c27 Release GIL while meshing in MeshPart.meshFromShape
This commit releases the Global Interpreter Lock around mesher call and
should enable multithreading use when exporting large quantities of
objects (for instance for external rendering).
2024-02-13 11:15:52 +01:00
Mark Peres
adf69f23f6 add subvolume property 2024-02-13 10:18:12 +01:00
Mark Peres
6717065a2b refactor getSubVolume method -> use early exit 2024-02-13 10:18:12 +01:00
Roy-043
0feb0143ee Arch: Arch_Window round values in getSolidSignature
Values in getSolidSignature must be rounded, else matching solids are often not found.
2024-02-13 10:16:23 +01:00