kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
30,853 Commits 40 Branches 6 Tags
b5bd12a069405cee89c218165fdb371d27efdf96
Commit Graph

2031 Commits

Author SHA1 Message Date
wmayer
b5bd12a069 PD: fixes #7629: Keep sketch visible during revolution tasks 2022-11-05 19:09:54 +01:00
wmayer
056abcd3d4 PD: unit test to check offset of sub-shape binder (PR #7445) 2022-11-05 16:58:51 +01:00
Paddle
657ddeae29 PartDesign: Remove unusable 'Leave sketch' 'viewSketch' commands from menu. 
Add 'EditSketch' 'MergeSketches' and 'mirrorSketch' usable commands to menu.
Add 'ValidateSketch' to toolbar.
 2022-11-04 16:18:41 -05:00
wmayer
4b08850edb Qt6 port: 
* QApplication::setFallbackSessionManagementEnabled has been removed
* QString::medRef() has been removed. Use QString::mid() again.
* QTextStream::setCodec has been removed
* Use operator QVariant of the QFont class to make code Qt5 and Qt6 compatible
* Signature of QTreeWidget::mimeData() has changed in Qt6. Remove TreeWidget::mimeData() because it doesn't change the implementation
* QLayout::setMargin() is deprecated in Qt5 and has been removed in Qt6. Use QLayout::setContentsMargins()
* QDateTime::toTime_t() is deprecated in Qt5 and has been removed in Qt6. Use QDateTime::toSecsSinceEpoch()
* QDesktopWidget is deprecated in Qt5 and has been removed in Qt6. Use QScreen
 2022-11-01 16:55:40 +01:00
Flachy Joe
c2c23169e6 [PartDesign] Improve Helix calculation for straight shape (#7674) 2022-10-31 23:26:10 +01:00
Chris Hennes
1fac3fead0 cMake: Add support for compiling against Qt6 (#7647) 
Removes the BUILD_QT5 flag and adds a new FREECAD_QT_VERSION option,
which can be set to either "Auto" (default), 5, or 6. Auto detects which
version of Qt is installed on the system and chooses it. If both version
are installed, Qt5 is used.

Note that this DOES NOT implement compiling against Qt6, it only adds
the necessary cMake infrastructure to begin work on the source code
changes that will be required.
 2022-10-31 09:24:09 -05:00
Uwe
6d889db9d7 [PD] remove deprecated holes 
- as discussed in https://github.com/FreeCAD/FreeCAD/pull/7642 the backwards compatibility for deprecated holes was already lost since FC 0.19
- this PR removes the deprecated types and transform holes created with FC 0.19 or 0.20 to the corresponding countersinks/counterbores.

- also add Counterdrill for translations
 2022-10-27 14:24:32 +02:00
Uwe
c31dc73e62 [PD] FeatureHole.cpp: sort counterdrill 
- will be necessary to push deprecated entries to the end of the combobox in the dialog (in a coming PR)
- also fix too long code line
 2022-10-25 01:09:37 +02:00
wmayer
316ce9f13b PD: [skip ci] disable undo/redo for the tmp. document created by the SubShapeBinder 2022-10-24 16:50:50 +02:00
Stefan Klug
673be545fd PartDesign: Add HoleCuteType "Counterdrill" 2022-10-24 15:19:24 +02:00
Stefan Klug
c077f75159 PartDesign: Refactor geometry creation of counersink/counterbore 
The counterbore is basically a special case of the countersink
with a countersink angle of 180 degrees and applied depth.
Handling it that way elimintaes some duplicate code and adds the ability to
combine countersinks and counterbore to form a counterdrill.

The sanity check on countersinkAngle can be safely dropped as it is ensured
by a constraint on the property itself.
 2022-10-24 03:42:02 +02:00
Stefan Klug
477726806f PartDesign: Remove duplicate comment 2022-10-23 09:15:17 -05:00
Stefan Klug
264d0bb890 [Bugfix] PartDesign: Fix HoleCutDepth not being recalculated correctly 
HoleCutDepth is reset to 0 to force a recalculation of te depth when
HoleCutType is set to a new value.
But the line
	pcHole->HoleCutCustomValues.setValue(false)
also forces a recalculation. So the depth was recalculated with the old
value in HoleCutType which was not expected behaviour.
 2022-10-23 04:10:18 +02:00
Yorik van Havre
1ae780d3b1 Merged crowdin translations 2022-10-17 15:12:16 +02:00
Uwe
a25bdf15b9 use explicit prefix std:: for vectors 
- also add potentially missing include
- this commit is an attempt to fix #7585
 2022-10-11 01:44:24 +02:00
Yorik van Havre
9c24f0f5b8 Merged crowdin translations 2022-10-10 11:06:08 +02:00
Yorik van Havre
4ba1b0e4dc Updated ts files 2022-10-10 10:19:30 +02:00
wmayer
840fc70106 Mod: replace QRegExp with QRegularExpression 2022-10-07 14:03:53 +02:00
Yorik van Havre
4ca1b838a9 Merged crowdin translations 2022-10-06 12:48:05 +02:00
Yorik van Havre
3d75b4fb74 Updated ts files 2022-10-06 12:16:32 +02:00
Uwe
6edcbcd367 [Part/PD] few clang formatting fixes 2022-09-18 13:33:41 +02:00
Uwe
769a575281 Revert "[PD] simplify code for wedges" 
This reverts commit ace31ffb213f27ab268cc508e748b4da7e615730.

On MSVC this compiled and works. I have no clue why not also with Clang. Reverting for now.
 2022-09-18 13:31:09 +02:00
Uwe
eb150bcfd4 [PD] simplify code for wedges 2022-09-18 12:32:14 +02:00
Ethan Chappel
31fa2de09f Gui: Add format parameter for wedgeXmin 2022-09-18 12:06:39 +02:00
0penBrain
611b86e4a9 PartDesign: improve offset handling of SubShapeBinder 2022-09-11 21:17:22 +02:00
wmayer
3e009e2693 PD: modernize C++: replace 'typedef' with 'using' 2022-08-29 22:20:49 +02:00
berniev
180edfa3cc Mod: Single arg ctors must be explicit 2022-08-24 16:55:20 +02:00
Jonas Bähr
46cee50bd5 Fix build on MacOS-X 10.14: missing Xerces include dir 
This undoes most of the Xerces related part of the commits listed below.
The issue resolved here is that the Xerces include dir *is* set in the
CMakeLists.txt of src/Base, but it got removed from various App and Gui
dirs in src/Mod. If those now include a header from src/Base, which
itself includes xercesc, the build fails using Apple clang version 11.0.0
(clang-1100.0.33.17) on Mojave, configured using cmake 3.22.1, with
errors like the following:

In file included from .../src/Mod/Part/App/FeaturePartBoolean.cpp:34:
In file included from .../src/App/Application.h:33:
.../src/Base/Parameter.h:54:10: fatal error: 'xercesc/util/XercesDefs.hpp' file not found
 #include <xercesc/util/XercesDefs.hpp>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Finally, a full list of the commits that introduced this spurious include
dir optimization for reference:
- Drawing: commit f4411478d106ba9f4827754a50efa53bd7767a66
- Image: commit e3476815c04c571199779bd1e444b950e6398025
- Import: commit b7b264e52c8fd97e83987c4ce42ce563170c8918
- Inspection: commit 1f64d8b1b8fcabe983c6e5e624d65766b4429ea0
- Mesh: commit 5a8fed0720d681cdbb9fedc840d2532c4f2f6042
- Part: commit 26bb65f11f4b51e5e47b65b2d6049ece10705a83
- PartDesign: commit f4e49f2aecf08f2337e84510ed019b7fa4b685a3
- Path: commit e3d9cc98577d2073297d55ffd8de28dd50f8444c
- Points: commit 09f3e867cdccd31294cced4e3c73015d3add3f4a
- Raytracing: commit 7b92dedc53f09e2ce8365408f3003e5700aebfc8
- ReverseEnginering: commit eeacc51ad0cd82e5f17d63207f78f79eb20bf9a9
- Robot: commit 4d06684cbd0328e4f43c78b5dab7e7fcebab148d
- Sketcher: commit 079125665495a08a7e2e2a4f01da406128dca625
- Spreadsheet: commit 514097954e95c04a7ec9d7e8ec1afc3aac3dd8d
- Start: commit 2ea2bb0dc393d7b8b41e9137c6d4ae40ce29719d
- Surface: commit 272268dd6c0b460ae9aeecdf371495ea26aa044d
- TechDraw: commit c70fdc3e0aa6b409626a6fa6b7266d05f3338c6d
- Test: commit 49a07b121e08e9bf3fef0f414a8da5602533592e
- Web: commit a93a23d7e4da13b2d5c37ac087b2dcf41aae197d
 2022-08-24 07:40:04 +02:00
luz paz
7b10713d6f Fix typos and whitespace 
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,ro,rougly,seperator,serie,sinc,siz,strack,substraction,te,technic,thist,thru,tread,uint,unter,uptodate,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./src/Base/StackWalker.cpp,./build/doc/SourceDocu`
 2022-08-23 18:49:47 +02:00
wmayer
3631f8481d PD: [skip ci] fix UTF-8 handling in Hole feature 2022-08-21 11:07:15 +02:00
wmayer
c87e1cc1c2 clang: fix warnings [-Winconsistent-missing-override] 2022-08-09 17:36:25 +02:00
berniev
71dc5ead2f Mod: Use override etc 2 2022-08-09 12:52:26 +02:00
berniev
5fa05ab83d Mod: Redundant_string_initialization 2022-08-08 16:52:42 +02:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
berniev
53ba98d636 Mod: use empty 2022-08-06 19:30:13 +02:00
berniev
47ac049e14 Mod: use emplace_back 2022-08-05 10:36:16 +02:00
Uwe
4dd623466d [PD] remove unnecessary Python check 
we only support Python 3
 2022-07-31 05:27:45 +02:00
luz paz
ca52b33763 PD: Remove unnecessary semicolons in FeatureHole.py 
Discovered through github action check.  
[skip ci]
 2022-07-30 13:17:18 +02:00
luzpaz
ef3324fa9e PD: Fix 'testing inequality to None' syntax (#7279) 
* PD: Fix 'testing inequality to None' syntax

- Substitute `is not None` for `!= None`
- Fix trailing whitespace
 2022-07-30 04:01:40 +02:00
Uwe
f38144c353 [PD] AppPartDesignGui: sort includes 2022-07-25 23:36:39 +02:00
wmayer
a93082bc06 PD: [skip ci] Fix several clazy issues: 
* Maybe you meant to call base method instead [-Wclazy-skipped-base-method]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* Mixing iterators with const_iterators [-Wclazy-strict-iterators]
* Unused QByteArray [-Wclazy-unused-non-trivial-variable]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
 2022-07-25 13:40:19 +02:00
Uwe
49c9541034 [PD] TaskExtrudeParameters: add missing simplification 
forgot this change in commit 8789c4a1
 2022-07-20 11:35:46 +02:00
Uwe
04e6414458 [PD] TaskExtrudeParameters: simplify code 
to avoid several time the same translatable string
 2022-07-20 03:16:56 +02:00
adrianinsaval
76f5c32574 [PD Pad/Pocket] Fix bug with midplane usage in TwoLengths mode (#7216) 
* [PD Pad/Pocket] Fix bug with midplane usage in TwoLengths mode
 2022-07-20 03:13:01 +02:00
Uwe
aca9973791 [PD] [skip CI] FeatureExtrude.cpp: fix a comment 2022-07-19 03:30:48 +02:00
Uwe
32ab100ed5 Mod: remove some superfluous Boolean checks (#7213) 
* Mod: remove some superfluous Python Boolean checks
 2022-07-19 01:35:12 +02:00
Uwe
24468b59ad re-add some nullptr 
to be safe since their removal within assert() or bools might have some impact I don't know
 2022-07-18 02:32:36 +02:00
Uwe
dfecb337e7 [PD] remove more superfluous nullptr checks 2022-07-18 01:33:28 +02:00
Uwe
b16f03ec02 [PD] add parameter enabling logic for pad/pocket 
- currently all parameters are always enabled and thus can lead to errors like the one reported here:
https://forum.freecadweb.org/viewtopic.php?f=3&t=70266
 2022-07-18 00:26:15 +02:00
Uwe
0eee9221f0 [PD] improve face selection for Pad/Pocket 
- this PR extends PR #7191 as described in this forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=70327
 2022-07-17 18:35:34 +02:00