kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
33,289 Commits 41 Branches 6 Tags
bcedfae7089b89c755b57fd55263daef9194cb38
Commit Graph

33289 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Abdullah Tahiri
bcedfae708 Sketcher: Command constraints error handling adaptation 
=======================================================

- Better handling for exceptions originating in Python addConstraint.
- Refactor to reuse code for handling of exceptions
 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
17f65d8746 Sketcher: Make Command Constraints show the severity of warning for typical user mistakes 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
1b59b75482 Base: Interpreter - Mark Exception reporting and stack as intended for developers 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
5e5d863968 Console: Remove Translated Notification message 
===============================================

With the new console extension, the translation state is coded separatedly.

Therefore, it is possible to code a Notification as translated without needing a specific type.

Additionally, any other message, such as Error of Warning can be translated.

It does not make sense to leave this message, if only for reasons of coherence and to simplify
maintainance of code.
 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
3b04601ade Gui: Adapt Notifications Framework 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
3097892d08 App: NotificationArea adaptation to the new messages 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
3b82bf62f7 Console: Extend the Python interface 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
125a6f7bc4 Console: Convenience dedicated functions 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
5f52885fbf Ilogger - Separate behaviour for user exposed and not exposed loggers 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
9d9f928b2d Console: Extend framework with intended recipient and content type metainformation 
==================================================================================

Limitations of the current framework:
- Codes the translated state only for TranslatedNotification as part of the type.
- Does not code the intended recipient (user, developer, ...)

Problems:
- Some errors are intended for developers, some errors may only be intended for users,
if, for example, there is another developer error which already contains all the information.
The current framework may lead to information duplication or to showing to the user developer
information, which is perceived as annoying.
- Logs shall be in English (report view), while every message to the user (UI) shall be translated.
The current framework can only differentiate where to report based on subscription (legacy logs do not
subscribe to notifications), and for notifications, whether it is translated or not depends on the type.
It is not possible to code errors or warnings that are already translated.

Solution:
- To extend the ILogger interface with additional metainformation, indicating the intended recipient
(User, Developer, All), and the content of the message (translated, untranslated, untranslatable). The latter
is useful for dynamic strings that won't find a match in the translation framework.

Bonus:
- This extended version allows to do away with translatednotification, as now any message can be independently
marked as translated or untranslated or untraslatable.
- It is now possible to provide the right icon of severity (error, warning, info), even when it is only user intended
and already translated.
 2023-05-23 14:24:45 +02:00
Jonas Bähr
f3595bce0b Sketcher: Add tests for Circle to Line distance constraint 
Note that support for secants currently only works for reference
constraints but not for driving ones. If and how this should be done
is still under discussion [1].

[1]: https://github.com/FreeCAD/FreeCAD/pull/9044#issuecomment-1548006842
 2023-05-23 14:19:51 +02:00
Yorik van Havre
4250d8f991 Merge pull request #9586 from yorikvanhavre/arch-ifc-export-fix 
Arch: Minor fix to IFC exporter
 2023-05-23 13:53:14 +02:00
Yorik van Havre
2751e92db5 Merge pull request #9585 from yorikvanhavre/arch-svg-fill 
Arch: Fixed SVG fill
 2023-05-23 13:52:33 +02:00
Chris Hennes
5ce3e83eac Merge pull request #9624 from wwmayer/fix_OpenSCAD_cmds 
OpenSCAD: Hull/Minkowski also work for a single selected object
 2023-05-22 13:45:31 -05:00
Chris Hennes
24a22f9635 Merge pull request #9381 from wwmayer/tweak_clang_format 
Set BreakConstructorInitializers to BeforeComma
 2023-05-22 09:01:12 -05:00
Chris Hennes
7e6fe6030f Merge pull request #9627 from chennes/addonManagerMiscBugs 
Addon Manager: Minor error handling cleanup
 2023-05-21 20:37:54 -05:00
Chris Hennes
9e45aa4e1b Merge pull request #9629 from chennes/updateTranslations20230521 
Update translations
 2023-05-21 19:58:00 -05:00
Chris Hennes
452067c43c Update translations 2023-05-21 19:13:11 -05:00
Chris Hennes
cb8f1a9baa Merge pull request #9628 from chennes/crowdInScriptTweak 
Tools: Modify CrowdIn to only generate QMs when needed
 2023-05-21 19:11:18 -05:00
Chris Hennes
b851452557 Tools: Modify CrowdIn to only generate QMs when needed 2023-05-21 19:01:42 -05:00
Chris Hennes
aae9334b7f Addon Manager: Minor error handling cleanup 2023-05-21 15:50:29 -05:00
wmayer
f5fef1c6db OpenSCAD: Hull/Minkowski also work for a single selected object 2023-05-21 16:42:09 +02:00
Roy-043
e1829be977 Draft: fix props_changed_placement_only for attached clones and similar (#9623) 
For an attached object whose Shape depends on one or more source objects props_changed_placement_only should always return False.
 2023-05-21 16:15:55 +02:00
Chris Hennes
38230171f4 Merge pull request #9614 from chennes/fixPrefPageContext 
Gui: Correct translation context of pref pages
 2023-05-20 19:53:32 -05:00
MaxiV
f1ab344881 Delete A4_IRAM4504.svg 
It is included in the AR_IRAM folder
 2023-05-20 10:31:00 -04:00
sliptonic
890979b3c3 Merge pull request #9608 from chennes/pathHTMLRemoval 
Path: Remove HTML where not needed
 2023-05-20 07:51:57 -05:00
Roy-043
6d69a65218 Draft: remove obsolete gui_array_simple.py (#9616) 2023-05-20 10:37:31 +02:00
Abdullah Tahiri
9dfbd6d24b Sketcher: Add App directory to pre-commit 2023-05-20 07:55:05 +02:00
Abdullah Tahiri
0f14065d0a Sketcher: App - Clang-format 2023-05-20 07:55:05 +02:00
Abdullah Tahiri
b34651e88e Sketcher: Add planeGCS directory to pre-commit 2023-05-20 07:55:05 +02:00
Abdullah Tahiri
4edd4fe935 Sketcher: PlaneGCS C-lang formatting 
====================================

As per:
https://forum.freecad.org/viewtopic.php?t=77205

Please use pre-commit as described in:
https://github.com/FreeCAD/DevelopersHandbook/blob/master/gettingstarted/index.md#setting-up-for-development
 2023-05-20 07:55:05 +02:00
Chris Hennes
37a7eef2ac Merge pull request #9215 from marioalexis84/gui-window_parameter 
Gui: Add function in WindowParameter class to connect slot to ParameterManager signal
 2023-05-19 22:45:48 -05:00
Chris Hennes
b8c15bdcaa Merge pull request #9603 from chennes/windowsVersionHack 
Gui: Hack to get Windows 11 version
 2023-05-19 21:12:19 -05:00
Chris Hennes
f7a4ce6928 Gui: Move C++ pref pages to QObject context 2023-05-19 20:54:27 -05:00
Chris Hennes
c0726b8481 Gui: Correct translation context of pref pages 
Preference page title strings must be in QObject
 2023-05-19 20:46:12 -05:00
Chris Hennes
9de87e8b75 Merge pull request #9612 from chennes/addonmanagerVersionErrorHandling 
Addon Manager: Improve error handling for Version
 2023-05-19 18:08:14 -05:00
wandererfan
3a2b02ba58 [TD]fix fail on bad selection (#9598) 2023-05-19 19:07:48 -04:00
wandererfan
ab5203de3d [TD]cleanup debug messages 2023-05-19 19:07:48 -04:00
Chris Hennes
89d8c57ee8 Addon Manager: Improve error handling for Version 2023-05-19 17:17:29 -05:00
Chris Hennes
19b5e8bce9 Gui: Hack to get Windows 11 version 2023-05-19 10:27:21 -05:00
Chris Hennes
e16ff3f320 Merge pull request #9610 from chennes/openscadWordingTweak 
OpenSCAD: Minor wording tweak in preferences
 2023-05-19 10:25:29 -05:00
Chris Hennes
eb2f1483ae Merge pull request #9609 from chennes/addonManagerTranslationIssues20230518 
Addon Manager: Minor linguistic fixes
 2023-05-19 10:25:17 -05:00
Chris Hennes
2a6cb77730 OpenSCAD: Minor wording tweak in preferences 2023-05-18 21:58:08 -05:00
Chris Hennes
650273dddc Addon Manager: Minor linguistic fixes 2023-05-18 21:49:41 -05:00
Chris Hennes
2c134268fa Path: Misc. minor string cleanup 2023-05-18 21:33:46 -05:00
Chris Hennes
fc52e1fa2d Merge pull request #9607 from chennes/translations20230518 
Update translations
 2023-05-18 20:53:47 -05:00
Chris Hennes
036b8cae10 Path: Remove HTML where not needed 2023-05-18 20:44:00 -05:00
Chris Hennes
2798528b8f Update translations 2023-05-18 07:49:08 -05:00
Chris Hennes
ba5e7b184d Merge pull request #9596 from chennes/macVersionInfoHack 
Gui: Mac version info hack
 2023-05-17 20:07:46 -05:00
Chris Hennes
c04ad8f3d3 Merge pull request #9601 from chennes/addonmanagerTypo 
Addon Manager: Fix typo
 2023-05-17 17:48:38 -05:00