Commit Graph

10881 Commits

Author SHA1 Message Date
Abdullah Tahiri
be09213bfb Sketcher: Fixes #3009 error with geompoints in sketcher
=======================================================

Introduction of construction points as fixed solver entities introduced this bug, as there was no specific code to check for points as they were by default construction.
2017-04-17 20:47:30 +02:00
Abdullah Tahiri
bcc3cb1fbb Sketcher: Basic symmetry for angle constraint
Fixes #0002804
2017-04-17 19:14:42 +02:00
wmayer
4866d3595f fix material binding of indexed lineset when highlighting an edge 2017-04-17 19:02:11 +02:00
wmayer
ceb519b737 fix unused variable warnings 2017-04-17 16:20:44 +02:00
wmayer
2692b7be92 set shortcut for deletion of items 2017-04-17 16:20:44 +02:00
wmayer
564d16d012 implement highlighting of references 2017-04-17 16:20:44 +02:00
wmayer
39d3fc2b69 rename SurfaceFeature to GeomFillSurface 2017-04-17 16:20:44 +02:00
wmayer
00a60a6b5b remove superfluous classes BezierSurface and BSplineSurface 2017-04-17 16:20:44 +02:00
wmayer
c7130b568c move handling of Bezier and BSpline surface creation into a common class to increase flexibility 2017-04-17 16:20:44 +02:00
wmayer
b697fed9f0 improve undo/redo handling 2017-04-17 16:20:44 +02:00
wmayer
15af69097e implement Remove command in context menu 2017-04-17 16:20:44 +02:00
wmayer
92393cfbfc remove superfluous FillType enum 2017-04-17 16:20:44 +02:00
wmayer
e106d8fede improve usability of surface function 2017-04-17 16:20:44 +02:00
wmayer
cda9eddc8c do not make property read-only in property editor 2017-04-17 16:20:44 +02:00
wmayer
5b77c9bfed fix edit mode of view provider 2017-04-17 16:20:44 +02:00
wmayer
e9225fa12a choose more comprehensive class and file names 2017-04-17 16:20:44 +02:00
wmayer
29cfb5a555 polish filling feature 2017-04-17 16:20:44 +02:00
wmayer
1005c5c765 polish sewing feature 2017-04-17 16:20:44 +02:00
wmayer
632c6e33db port Surface module to v0.17 2017-04-17 16:20:44 +02:00
wmayer
01c193f74b + fix bugs in edge checking 2017-04-17 16:20:44 +02:00
wmayer
c02c90adb2 + fix design flaw to reduce side effects 2017-04-17 16:20:44 +02:00
wmayer
cb434e517b + move FillType.h to App folder 2017-04-17 16:20:44 +02:00
wmayer
3bbedb1fd2 + make surface module compile with v0.17 and occ 7 2017-04-17 16:20:44 +02:00
wmayer
2b3c1595db + use PyCXX for module initialization 2017-04-17 16:20:44 +02:00
wmayer
40c5fef1d0 + delete superfluous files 2017-04-17 16:20:44 +02:00
balazs-bamer
bb6620aa85 Fix: edges of a solid can be used as surface input
Edges of a solid can be used as surface input. The real subName is
passed instead of the constant 'Edge1'
2017-04-17 16:20:44 +02:00
balazs-bamer
dd6775e0f2 Curve validation is done in a common ancestor of App and GUI
Curve validation is done in a common ancestor class of Surface::BSurf
and SurfaceGui::CmdSurfaceBSurf
2017-04-17 16:20:44 +02:00
balazs-bamer
e47e22e395 Check for null shape before calling ShapeType
Check for null shape before calling ShapeType
2017-04-17 16:20:44 +02:00
balazs-bamer
073749e931 Unhide surface props and set the filltype to read-only in data tab
I made the surface property (FillType and boundary) default again.
Status bit 2 is set on fill type to hide it in data tab.
2017-04-17 16:20:44 +02:00
balazs-bamer
ef27ba2c8a allow wires as surface input
Now an arbitrary mixture of edges and wires can be used as input.
However, the total count of edges together with the wire members
can only be 2, 3 or 4.

For some reason, wires do not work in Python script:
test1.BoundaryList = [(Draft.upgrade([bs1a, bs2a]), 'Wire1')]
yields an empty BoundaryList
2017-04-17 16:20:44 +02:00
balazs-bamer
4e2eede777 try to convert non-b-splines into b-splines; further parameter check
Non b-spline curves are converted into b-splines if possible.
This means circles, lines etc are allowed.

Further parameter checks prohibiting surfaces being accepted as input.
2017-04-17 16:20:44 +02:00
balazs-bamer
85c3aa10c1 Surface properties are hidden
Surface properties are now hidden. Read-only made creation
2017-04-17 16:20:44 +02:00
balazs-bamer
972e024174 PropertyEnumerator for fill type
Fill type is now of type PropertyEnumerator, allowing enumerated names
in the Data tab. However, it has 2 problems:
1. Invalid shows up
2. The user has the illusion to see the result after changing the value.
However, the result gets updated only
2017-04-17 16:20:44 +02:00
balazs-bamer
3d70ef9ab7 Corrected feature property names
aBList -> BoundaryList
filltype -> FillType
2017-04-17 16:20:44 +02:00
balazs-bamer
3bceb867b7 Surface icon in the object tree
Bezier- and b-spline surfaces now have a surface icon in the tree.
2017-04-17 16:20:44 +02:00
balazs-bamer
901ff4a211 Warning for surfaces with 2 edges only
If the user creates a surface from 2 edges, a warning dialog appears.
Some refactoring in Command.cpp to make it simpler.
2017-04-17 16:20:44 +02:00
balazs-bamer
f47dbb54da Cancelling the just created surface deletes it
Now if the user creates a surface, the cancel in the widget deletes it.
If an already existing one is opened for editing, cancel rejects the
user change in fill type, but the surface remains.
2017-04-17 16:20:44 +02:00
balazs-bamer
512671b1e2 Unified UI for Bezier and b-spline surfaces
I have unified the user interface for Bezier and b-spline surfaces.
Based on the selection contents the CmdSurfaceBSurf::isActive method
determines which one can be created, and marks it for the activate
method.

For any sort of inappropriate selection contents, including foreign
shapes or mixture of Bezier and b-spline curves, the tool remains
disabled.
2017-04-17 16:20:44 +02:00
balazs-bamer
23067d60f2 Cancel by fill type edit did not work
After clicking Apply the old fill type was overwritten and canceling the
whole edit did not revert the fill type into the original value.
2017-04-17 16:20:44 +02:00
blobfish
a7ff0786ea use taskbox in taskdialog 2017-04-17 16:20:44 +02:00
blobfish
ab37648977 header clean up 2017-04-17 16:20:44 +02:00
blobfish
7ae5dbde01 createFace function signature 2017-04-17 16:20:44 +02:00
blobfish
9c632cdf22 task widget based from qwidget instead of qdialog 2017-04-17 16:20:44 +02:00
blobfish
2ff65140e1 task flow
synchronize fill types on setEdit
    finishing up command
    make activate for commands similar
    don't call execute directly
    remove unneeded update calls
2017-04-17 16:20:44 +02:00
blobfish
9a11431b73 class hierarchy and macros 2017-04-17 16:20:44 +02:00
balazs-bamer
254aa167e4 Dialog with radio buttons for choosing Bezier and b-spline surface fill type
A regular common dialog with apply, cancel and OK buttons allowing
surface fill type selection for Bezier and b-spline surfaces.

The Bezier and b-spline surface functionality now seems to be complete.
2017-04-17 16:20:44 +02:00
balazs-bamer
06645251ad diagnostics
Some diagnostics to let me see what happens
2017-04-17 16:20:44 +02:00
balazs-bamer
c88fe0edc0 One more experiment
No success yet
2017-04-17 16:20:44 +02:00
balazs-bamer
6d35abbf74 One step towards the dialog
Problem registering the own ViewProvider
2017-04-17 16:20:44 +02:00
balazs-bamer
71e37ef75b Next try for showing dialog
Does not work yet.
2017-04-17 16:20:44 +02:00