Commit Graph

28168 Commits

Author SHA1 Message Date
Matthijs Kooijman
be69ec5e00 Draft: Fix mixup of TextAlignment vs Justification for Labels
TextAlignment is the vertical alignment, while Justification is the
horizontal alignment. here, get_text was passed the vertical, while it
expected the horizontal. This caused the alignment of a Label to be
wrong in the resulting SVG (e.g. in a TechDraw draft view).

This seems to have been broken since SVG support for Labels was first
introduced in commit 3391a5ea4b (Initial work, only text (no lines)).
2022-03-22 14:46:50 +01:00
Matthijs Kooijman
fd8475b1c6 Draft: Fix SVG generation for label objects
Label objects would produce invalid SVG XML, because the stroke-linecap
property was added as if it was a style (with : and ;), but it was
inserted in the XML tag directly, rather than inside the style attribute
value. The invalid SVG prevented for example a TechDraw draft view from
rendering when it contained a label.

This was added in commit d8c74c06fd (Draft: Using square endcaps for
lines in SVG output).

This stroke-linecap is supported both as a presentation attribute inside
the style or a XML attribute, so for consistency with the surrounding
attributes, it is made a normal attribute, rather than putting it inside
the style.

See also https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-linecap
2022-03-22 14:38:36 +01:00
Matthijs Kooijman
f49b38a595 Draft: Fix incorrect use of in operator
Looking at the surrounding code, this should be `==` rather than `in`.
The code does work as intended, because a string is always a substring
of itself, but better to fix it anyway.

Seems this was broken since this code was first introduced in commit
94b0fe1599 (Draft: clean up ViewProviderLabel class)
2022-03-20 14:45:52 +01:00
Wanderer Fan
c9f6aea463 [TD]fix default scale 2022-03-18 08:21:21 -04:00
Uwe
b98ada4c07 [Part] Section Cut: add missing handling of valueChanged
- when the user changed the value without moving the slider (e.g. by clicking), nothing happened
2022-03-18 06:26:12 +01:00
Uwe
88daed86ea [Gui] remove iisTaskPanel
as discussed here, it can be removed: https://forum.freecadweb.org/viewtopic.php?p=577413#p577413
2022-03-18 01:14:53 +01:00
Chris Hennes
1fb1524492 Test: Change Metadata exception tests to use assertRaises 2022-03-17 19:09:01 -05:00
Uwe
e3f6fa6661 [skip CI] [FEM] cleanup SVG code of new icon 2022-03-18 00:45:08 +01:00
Uwe
1293eb2116 [FEM] add icon for the new supported MYSTRAN solver 2022-03-18 00:18:25 +01:00
Uwe
5f5e5a4b35 [skip CI] [FEM] save an icon as plain SVG 2022-03-18 00:16:57 +01:00
Uwe
2cb9ddddae [FEM] task dialogs: remove unused includes
- also some code style fixes from MSVC
2022-03-17 23:31:17 +01:00
Uwe
7d692a82db [FEM] save new icon as plain SVG 2022-03-17 22:38:09 +01:00
Uwe
4e7b96d250 [FEM] add missing preferences settings
- since 0.19 we support to check meshes
- since 0.20 we support buckling

- also revise dialog to get rid of arbitrary limits etc.
2022-03-17 22:33:56 +01:00
Uwe
9590317cd9 [FEM] settings dialogs: uniform width
- some minor changes automatically done by Qt Designer
2022-03-17 21:47:58 +01:00
Uwe
d00e52c81d [FEM] settings dialogs: remove unused includes 2022-03-17 21:27:46 +01:00
Uwe
fe5f5bdda5 [Gui] only include the actually used inventor files 2022-03-17 21:12:19 +01:00
Uwe
00461a7aff [Gui] NavigationStyle: only include the actually used inventor files 2022-03-17 20:54:30 +01:00
Uwe
1ddb4d27e7 [FEM] remove unused headers from WBs main files
- also some code style fixes by MSVC
2022-03-17 20:33:33 +01:00
Uwe
568b752363 [Gui] add a necessary debug header
as reported: c4f5628899 (r68944028)
2022-03-17 20:30:25 +01:00
wmayer
89e4455057 Part: [skip ci] print warning only if eof bit is not set, i.e. ignore it for empty files 2022-03-17 20:24:06 +01:00
Uwe
2e084ed18a [FEM] remove some unused includes for some dialogs
- also some style fixes made by MSVC
2022-03-17 19:53:12 +01:00
Uwe
e30bc9976d [Gui] add 2 includes necessary for debug builds
- as reported: https://github.com/FreeCAD/FreeCAD/commit/c4f5628899 this is necessary e.g. on Manjaro
2022-03-17 18:23:18 +01:00
0penBrain
c164e2210d Gui: fix hot change of locale for QuantitySpinBox 2022-03-17 16:46:01 +01:00
0penBrain
e3bc06a341 Gui: add preference to use selected language number formatting, fixes #6330
If not enabled (default), will defaults to C/POSIX formatting
2022-03-17 16:46:01 +01:00
Yorik van Havre
4aec686c46 Merge branch 'master' of github.com:FreeCAD/FreeCAD 2022-03-17 16:11:30 +01:00
Yorik van Havre
f636ff9df4 Merge pull request #6544 from Roy-043/Draft-Fix-Angle-Lock-for-non-XY-workingplane
Draft: Fix Angle Lock for non-XY workingplane
2022-03-17 15:46:52 +01:00
Yorik van Havre
84a505287c Arch: Fixed export of texts and dimensions to IFC 2022-03-17 15:46:18 +01:00
Stefan Brüns
0a844f1ca3 [Test] Fix tkinter module name for python 3
The module name changed from uppercase Tkinter to tkinter.
2022-03-17 15:20:42 +01:00
wmayer
9160f06e1c Base: rename BaseExceptionFreeCADError to PyExc_FC_GeneralError 2022-03-17 14:45:48 +01:00
wmayer
d69defaa3c Py: replace BaseExceptionFreeCADError with more suitable exception types 2022-03-17 13:54:23 +01:00
Yorik van Havre
d84fd8a2df Merge pull request #6594 from FlachyJoe/draft_grid_FitAll
[Draft] Don't take grid into account when View_FitAll
2022-03-17 12:04:41 +01:00
wmayer
11895f8d59 App: change base types of some exceptions and raise XML exceptions in MetadataPy::PyInit 2022-03-17 11:43:59 +01:00
wmayer
10a13c6dbc Base: add more custom Python exception types 2022-03-17 11:29:09 +01:00
Uwe
c0ceecbcf6 [FEM] Contact and Displacement: remove unused headers 2022-03-17 03:46:41 +01:00
Uwe
dead2fc8f1 [FEM] Bearing and FluidBoundary: code improvements
- get rid of UI-coded limits
- fix layout issues
- code simplifications
- remove unused headers
2022-03-17 03:45:38 +01:00
Uwe
c6ac4affc8 [FEM] sanitize some dialogs
- uniform button layout
- uniform width
- fix layout issues reported by Qt Designer
2022-03-17 03:02:05 +01:00
Uwe
080e48f67f [Gui] DlgSettingsUnitsImp: add an include, compile fix 2022-03-17 00:34:07 +01:00
Uwe
21a31c0984 [Gui] Splashscreen: remove unused includes 2022-03-17 00:23:20 +01:00
Uwe
7196e8976c [Gui] DlgSettings etc.: remove unused includes 2022-03-17 00:17:32 +01:00
Uwe
5a95b71829 [Gui] DlgMacro etc.: remove unused includes 2022-03-16 23:41:14 +01:00
Uwe
eb0e8e215a [Gui] DlgEditor etc.: remove unused includes 2022-03-16 22:57:13 +01:00
flachyjoe
e6f3f4ba57 Don't take grid into account when View_FitAll 2022-03-16 17:30:25 +01:00
Wanderer Fan
aa4ba37a6c [TD]fix update suppression logic 2022-03-16 09:31:29 -04:00
chris
e7df102e22 macOS: [skip ci] update formatting to use 4 spaces for MacAppBundle CMakeLists.txt 2022-03-16 13:01:19 +01:00
wmayer
0347f6f91b Gui: fixes #6583: FreeCAD 0.20 crashes when attempting to change template in TechDraw
For more details see also: https://forum.freecadweb.org/viewtopic.php?p=579530#p579530
2022-03-16 08:47:56 +01:00
wmayer
67bbb3ba79 Mesh: [skip ci] replace some casts 2022-03-16 08:46:21 +01:00
Uwe
f6ef0d1095 [Gui] DlgWorkbenches etc.: remove unused includes and sort headers 2022-03-16 04:28:13 +01:00
Uwe
c7d6a507d3 [Gui] DlgActions etc.: remove unused includes and sort headers 2022-03-16 04:06:37 +01:00
Uwe
dba4f696b3 [Gui] a compile fix for precompiled headers
- also some sorting
2022-03-16 03:20:52 +01:00
Uwe
a12361b532 [Gui] SoFCSelectionContext: add missing header 2022-03-16 02:16:15 +01:00