kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
24,294 Commits 41 Branches 6 Tags
beb85522e400c1dd182a914e0df0367abb9660fc
Commit Graph

19010 Commits

Author SHA1 Message Date
David Osterberg
beb85522e4 PartDesign: Hole. Address Donovaly bugs 7 and 8 
bug 7: the update view checkbox should be enabled/disabled based on Model thread.
       the checked state should not change

bug 8: the Thread depth options should be disabled when Model thread is unchecked.
       because they don't do anything in the model it is confusing if they are enabled.
 2021-02-28 20:13:14 +01:00
David Osterberg
10f922613b PartDesign: Hole: Always update view if modelthread is disabled 
Also: Check the Update View checkbox and disable it, when turning off
model thread.
 2021-02-28 20:13:14 +01:00
David Osterberg
99215a9f9f PartDesign: Hole: Turn off keyboard tracking on model thread spinboxex 2021-02-28 20:13:14 +01:00
David Osterberg
41724cd29b PartDesign: Hole: Rename Automatic Tapped (DIN76) and change default to Hole depth. 2021-02-28 20:13:14 +01:00
David Osterberg
d7ae53d597 PartDesign: [Hole] Add Entire Depth thread depth mode 2021-02-28 20:13:14 +01:00
David Osterberg
d94946781e PartDesign: Add true threads to Hole 
- Thread runout according to DIN 76-1
- Through all length updated to be calculated based on bounding box
- New properties: ModelThread, ThreadDepthType, ThreadDepth,
                  UseCustomThreadClearance, CustomThreadClearance
- Rename Old but unused parameters related to thread modeling.
- Functionality exposed in UI
 2021-02-28 20:13:14 +01:00
luz paz
6f6c1deed7 Crowdin: Startpage - add whitespace to tooltip [skip ci] 2021-02-28 17:15:08 +01:00
luz paz
504cd1e7a5 Crowdin: Startpage: remove obsolete translation [skip ci] 2021-02-28 17:15:08 +01:00
luz paz
4e0fa6a736 Crowdin: StartPage - remove obsolete translation [skip ci] 
Ticket 0004578  
ref: https://crowdin.com/translate/freecad/7254/en-en?filter=basic&value=0#6572932
 2021-02-28 17:15:08 +01:00
wmayer
24b446c9f7 Sketcher: fixes #0004303: Three choices in a Sketcher menu each with the same Ctrl+Shift+E 'address' 2021-02-28 13:14:48 +01:00
wmayer
d6db4ee48f Image: fixes #0003959: Created image plane is not proportional to loaded image 2021-02-28 13:14:30 +01:00
wmayer
da4d9b64c0 Tux: fixes #0004565: Status bar text runs under Navigation Button 2021-02-28 13:14:05 +01:00
Chris Hennes
26ce308cf1 [DRAFT] Add call to super().__init__ where missing 
Identified by LGTM. The toplevel superclass does initialize one data
member to an empty array, but this didn't appear to cause any problems.
 2021-02-27 18:21:54 +01:00
Chris Hennes
1667c4d9f6 [Part] Fix signature of TempoVis dummy function 
If the import of TempoVis fails, TaskAttachmentEditor creates s dummy
function to replace the real TempoVis function. That function's
signature did not match the real TempoVis. Caught by LGTM.
 2021-02-27 18:21:05 +01:00
Chris Hennes
d5779d8c9b [PD] Fix minor static analysis issues in FCGear 
LGTM has identified a number of minor issues with the FCGear Part Design
scripts. This commit addresses each of them, and also corrects two minor
spelling errors in the dialog. None of the errors or their fixes are
expected to result in changes to the functionality of the script.
 2021-02-27 18:20:32 +01:00
David Osterberg
9d24f90dd7 PartDesign: Transformded. Align the "property category" of Refine with other PD commands 2021-02-27 18:19:14 +01:00
wmayer
fdbd84ec39 FEM: [skip ci] fix crash in Constraint::getDirection 2021-02-26 08:11:16 +01:00
helaslo
71fe41988b [OpenSCAD] Fix colors not working correctly when polygons are extruded 2021-02-25 15:08:19 +01:00
Yorik van Havre
162d5c578f Merge branch 'master' of github.com:FreeCAD/FreeCAD 2021-02-25 13:30:09 +01:00
Yorik van Havre
fa85db61f9 Merged crowdin translations 2021-02-25 13:27:48 +01:00
Aapo
505ba2e42f [TD] DrawViewPart.cpp: Fix a crash when user sets the PropertyVector Direction to zero. 2021-02-25 12:40:59 +01:00
wmayer
3ad1d8fccc TD: [skip ci] implement DrawView::recompute to handle all OCC exception types 2021-02-25 12:39:50 +01:00
wmayer
2de6a80bb4 TD: [skip ci] explicitly nullify geometryObject in DrawViewPart::partExec to avoid to leave it a dangling pointer in case makeGeometryForShape raises an exception 2021-02-25 11:34:29 +01:00
luz paz
755f4cf1be Crowdin: removing obsolete strings from PartDesign.ts [skip ci] 
Uncertain to why but lupdate is not removing obsolete strings from `PartDesign.ts`. This PR manually removes obsoletes strings from it.

ref:
https://crowdin.com/translate/freecad/564/en-de?filter=basic&value=0#6500474
https://crowdin.com/translate/freecad/564/en-en?filter=basic&value=0#6500475
 2021-02-25 10:41:58 +01:00
Aapo
e39ef22c1b [TD] Hotfix for Dimension label Arbitrary value regression in DrawViewDimension.cpp 2021-02-25 10:28:42 +01:00
wmayer
46e46a1466 FEM: [skip ci] fixes #0004405: Using PartDesign axis / plane as direction for constraints 2021-02-24 23:59:10 +01:00
wmayer
ab04719372 FEM: [skip ci] support Line and Plane objects in Constraint::getDirection() 2021-02-24 23:53:15 +01:00
wmayer
ec2dbecac4 FEM: [skip ci] connect onButtonDirection() slot with clicked() signal 2021-02-24 21:55:51 +01:00
wmayer
78a9a3c2a8 PD: [skip ci] remove invalid static_cast 2021-02-24 20:12:26 +01:00
Yorik van Havre
5c12afb5b5 Merged crowdin translations 2021-02-24 18:07:59 +01:00
wmayer
145eb8ea8c PD: fixes #0004567: Pattern from a feature type UpToFace and Offset > copy whole body 2021-02-24 17:08:20 +01:00
wmayer
4c18734d2e PD: [skip ci] code refactoring 
Move adding offset to face from getUpToFace() to addOffsetToFace()
 2021-02-24 16:08:03 +01:00
sliptonic
81a3b9693b Fix whitespace error 2021-02-23 19:14:49 -06:00
sliptonic
53bd6a2d77 fix trailing whitespace 2021-02-23 19:12:25 -06:00
sliptonic
90ec044cb4 fix bad string formatting 2021-02-23 19:06:08 -06:00
sliptonic
3d83e73549 Make string less ambiguous 2021-02-23 19:03:18 -06:00
sliptonic
8ab39462b7 typo in string 2021-02-23 19:01:29 -06:00
sliptonic
5c984dff6a fix string formatting 2021-02-23 18:59:04 -06:00
Yorik van Havre
5ab70fd1b6 AddonManager: Fixed missing WB icons 2021-02-23 18:01:04 +01:00
wmayer
45079ca2ac PD: [skip ci] AddressSanitizer: stack-use-after-scope 
Axis() returns a tmp. object and thus we cannot use a const reference to get its Location() method
 2021-02-23 13:57:51 +01:00
Yorik van Havre
74c280ae40 Merge branch 'master' into Draftutils_BugFixes_01 2021-02-23 11:45:23 +01:00
Yorik van Havre
6d9cd2f058 Merge pull request #4506 from berndhahnebach/bhbdev242 
Arch: ifc export, save guid to obj attribute
 2021-02-23 11:43:02 +01:00
Yorik van Havre
dcedcf8651 Merge pull request #4508 from donovaly/TD-BalloonHotfix 
[0.19] [TD] fix balloon dragging regression
 2021-02-23 11:41:58 +01:00
wmayer
48f56169de PD: [skip ci] fix regression caused by fdf7e6acbe120 
In the accept() method the view provider of the edited object must be made visible if it's valid as otherwise it can happen that the view is empty.

See https://forum.freecadweb.org/viewtopic.php?f=13&t=55915
 2021-02-23 11:20:45 +01:00
Abdullah Tahiri
88acd77442 Sketcher: Work-around for expression engine failure to calculate dependencies 
=============================================================================

THIS IS A WORK-AROUND NOT TO DELAY 0.19 RELEASE

depsAreTouched is not returning true in this case:
 https://forum.freecadweb.org/viewtopic.php?f=3&t=55633&p=481061#p478477

It appears related to a drastic change in how dependencies are calculated, see:
 https://forum.freecadweb.org/viewtopic.php?f=3&t=55633&p=481061#p481061

This is NOT the solution, as there is no point in systematically executing the ExpressionEngine
on every dimensional constraint change. Just a quick fix to avoid clearly unwanted behaviour in
absence of time to actually fix the root cause.
 2021-02-23 07:40:56 +01:00
luz paz
a7084b49dd Mesh: Crowdin: fix typo in translation [skip ci] 
ref: https://crowdin.com/translate/freecad/561/en-en?filter=basic&value=0#6585564
 2021-02-22 08:02:22 +01:00
David Osterberg
a243ce6346 Draft: Fix PathTwistedArray bug 2021-02-22 08:01:34 +01:00
donovaly
d208fc6ef0 [TD] fix balloon dragging 
Fixes bug that dragging while pressing CTRL did not work anymore, see https://forum.freecadweb.org/viewtopic.php?f=35&t=55863
 2021-02-22 02:17:05 +01:00
Bernd Hahnebach
486febf3dc Arch: ifc export, save guid to obj attribute 2021-02-22 01:50:47 +01:00
wmayer
0d18edc006 Sketcher: [skip ci] Fix coverity warning 
Coverity warnings fixed:

CID 129530 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member pixelScalingFactor is not initialized in this constructor nor in any functions that it calls.
 2021-02-21 16:59:57 +01:00