Commit Graph

37901 Commits

Author SHA1 Message Date
Ajinkya Dahale
bf649e2419 [Sketcher] Delete point-on-object on trimmed portion
This could cause undesirable shape change, especially in B-splines.
2024-06-24 21:56:58 +05:30
Ajinkya Dahale
ee2d324744 [Sketcher] Fix some issues with trimming splines
1. Transfer point-on-object to the correct resulting curve: Currently the
constraint remains on the "start" curve created after the trim.
2. Expose internal geometries of both resulting B-splines.
2024-06-24 21:56:58 +05:30
Ajinkya Dahale
dbef3747eb [Part] Do not assume default period in B-spline 2024-06-24 21:56:58 +05:30
Ajinkya Dahale
e1c3dd2fea [Part][test] Add tests for GeomBSplineCurve::Trim() 2024-06-24 21:56:58 +05:30
Ajinkya Dahale
1a6a7d07c2 [Sketcher] Rearrange directives to appease syntax highlight
Spacemacs doesn't handle the braces flow very well. This commit can be dropped
if necessary.
2024-06-24 21:56:58 +05:30
Chris Hennes
5e47f6804f Update for LibPack3 (#10337)
* cMake: Add base support for LibPack3

Minor changes to FreeCAD source code to support compiling with Qt 6.5 on MSVC,
and changes to cMake setup to support the new Libpack.

* NETGENPlugin: Fix compilation with MSVC and OCCT 7.8

* Material: Switch to Wrapped_ParseTupleAndKeywords for /fpermissive- on MSVC

* Base: Prevent accidental definition of MIN and MAX by MSVC

* cMake: Prevent accidentally finding an old LibPack

* Material: Wrap another ParseTuple call

* OCCT: Modify includes for 7.8.x

* Part: Change TNP code to use Wrapped_ParseTupleAndArgs

* Spreadsheet: Workaround for MSVC macro pollution

* Mesh: Workaround for MSVC macro pollution

* Base: Remove extra MSVC flag (moved to CMake)

* Tests: Fix compiling with /permissive-

* FEM: Fix Qt warnings about duplicate element names

* cMake: Ensure major version numbers are set

* Address review comments.

* cMake: Further tweaks for LibPack3

* cMake: Modify specification of compiler flags for MSVC

* Main: Remove QtQuick testing code

* cmake: Find Boost before SMESH (which uses it)

* Fixes for LibPack2

* cMake: Another try at importinhg VTK cleanly
2024-06-24 18:25:05 +02:00
Syres916
c06cbce42c [PartDesign] Fix thread depth level not enabled unless clicked 3 times 2024-06-24 11:19:06 -05:00
Chris Hennes
94360c706e FEM: Remove set but unused variable 2024-06-24 18:17:11 +02:00
Chris Hennes
2e85c4fd95 Addon Manager: Linter cleanup 2024-06-24 18:16:10 +02:00
marioalexis
7feb0c742c Fem: Clean up constraint view providers 2024-06-24 11:15:14 -05:00
Chris Hennes
d733fe0b34 Merge pull request #14766 from wwmayer/import_options
Import: Avoid modal dialog inside ImportGui.open()
2024-06-24 11:10:31 -05:00
Syres916
136da90645 [Sketcher] Correct default OVP and Geometry Creation colors... (#14763)
* [Sketcher] Correct default OVP and Geometry Creation colors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-06-24 11:08:28 -05:00
Patryk Skowroński
6c747178cf Spaceball settings tabs removal from the Customize panel (#14589)
* Removed Spaceball tabs for NavLib integration

* Added missing CMake variable for MacOS/Linux platform

---------

Co-authored-by: Patryk Skowroński <pskowronski@3dconnexion.com>
2024-06-24 11:06:25 -05:00
Robert Schiele
6572bbca01 implement FORCE_BOOST_PY_SUFFIX
On some systems the boost-python suffix is not exactly as the code
currently expects. To avoid getting even more guessing in the CMake
files about how exactly the python component is named in the boost
installation we introduce a variable FORCE_BOOST_PY_SUFFIX that can
enforce a specific suffix. If the variable is not set the behavior is as
before.
2024-06-24 11:02:41 -05:00
Chris Hennes
0cba55b854 Merge pull request #14833 from Jookia/RFC_testfixes
Tests: Fix some minor test failures
2024-06-24 11:01:29 -05:00
Chris Hennes
6ba32a7fef Merge pull request #14592 from kadet1090/tabbar-fixes
Gui: Workbench TabBar - fix scroll and icon-only paddings
2024-06-24 10:58:57 -05:00
Roy-043
682979d503 Fix EngineBlock.FCStd example file
The EngineBlock.FCStd example file contained a corrupt Points file. A new file was created by opening the V0.17 version of the FCStd file, saving that file, and then copying that Points file into the V0.22 FCStd file.

It's a very OLD example BTW. See also #14583.

To check the problem recompute the original V0.22 FCStd file.
Result:
```
pyException: Traceback (most recent call last):
  File "D:\BKG_Tmp\FreeCAD_0.22\Mod\Draft\draftobjects\bspline.py", line 113, in execute
    spline.interpolate(obj.Points, PeriodicFlag = True, Parameters = self.knotSeq)
<class 'Part.OCCError'>: Standard_ConstructionError
20:56:32  BSpline001: Standard_ConstructionError
2024-06-24 10:55:58 -05:00
Turan Furkan Topak
e96206db9c [Icons]Core Icon Revision (#14154)
* Core Icon Revision

Update utilities-terminal.svg

Update button_add_all.svg

pixel alignment

Pixel alignment was performed for the specified icons.

* Changes requested by Obelisk

* Return old icons
2024-06-24 10:54:58 -05:00
xtemp09
70d9fe38b0 Fix the crash when closing a document
Closes #14189. This commit partially reverts
626e6a1a70aeca40a3773f617a2cef0093991a75 and
95748f8f5eac02007b6f3def89f65fc2181aba09.
2024-06-24 10:49:27 -05:00
Chris Hennes
0740d9a006 Merge pull request #14386 from maxwxyz/sketcher-draw-style
Sketcher: Changes override draw style when entering sketch edit mode.
2024-06-24 10:48:19 -05:00
Adrián Insaurralde Avalos
7502f1f96d PD: improve hole dialog layout (#14031) 2024-06-24 10:44:13 -05:00
PaddleStroke
d8db937901 Core: Tree: Remove !vp->canDragAndDropObject(obj) that made no sense. And remove the auto switching to 'CopyAction' 2024-06-24 10:42:49 -05:00
mosfet80
5f38b52114 [MOD:PART] removed unused parameter (#14252)
d variable are never used

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-06-24 10:41:39 -05:00
Chris Hennes
3bf4f00092 Merge pull request #14079 from Ondsel-Development/sk_bspline_ovp
Sketcher: BSpline DSH: implement OVP/widget
2024-06-24 10:38:15 -05:00
CalligaroV
b8cf43424e Sketcher: fix external edges selection
* fix selection from Sketcher Task Panel
 * fix selection from 3D View
 * Synchronize selection between Task Panel and 3D View

Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com>
2024-06-24 10:35:54 -05:00
Roy-043
00fc3ec96a BIM: fix BIM_Setup unit system issue
Fixes #14675.

Note that I would prefer to use the FEM unit system (always mm). BIM_Setup does not support that, and this PR does not change that.
2024-06-24 15:42:27 +02:00
Yorik van Havre
2d231469ce BIM: Simplificed BimViews.getTreeViewItem - fixes #14321 2024-06-24 15:38:34 +02:00
Roy-043
f235513a49 BIM: fix SwitchWB preference by switching to BIM WB
Fixes #14680.
2024-06-24 10:43:08 +02:00
Roy-043
ee2652b550 Draft: remove code related to obsolete Std_MeasureDistance objects
The Draft_Dimension command could convert Std_MeasureDistance objects. These have recently become obsolete. This PR removes the related code.
2024-06-24 10:31:03 +02:00
Roy-043
e07c914f44 Draft: Remove Draft_Fillet chamfer recalculation
If two straight edges were selected the chamfer distance would be recalculated so that the length of the straight segment would be equal to `r` (the radius entered by the user). But this was, and is, not done if one or both edges are arcs.

By removing the recalculation code the endpoints of the straight chamfer edge now always match the endpoints of the fillet arc that would be created for the same radius. This also matches the fillet/chamfer behavior in for example Part and Sketcher.
2024-06-24 10:08:45 +02:00
Max Wilfinger
ce181eb15c Rename OVP preference options 2024-06-23 12:29:19 -05:00
wandererfan
55515b1e7f [TD]allow template fields to re-apply autofill 2024-06-23 09:48:25 -04:00
wandererfan
cb2573844f [TD]allow manual update of autofill fields 2024-06-23 09:48:25 -04:00
wandererfan
668a6ea010 [TD]correct source of autofill fields 2024-06-23 09:48:25 -04:00
wandererfan
1bc72ce3bb [TD]clean up editable field length and click area 2024-06-23 09:48:25 -04:00
wandererfan
1b669ee7b5 [TD]fix wrong xml namespace in some templates 2024-06-23 09:48:25 -04:00
bgbsww
8675aa87b4 Toponaming: Check for selection mapped element name 2024-06-22 17:10:54 -05:00
Chris Hennes
8432c65e21 Merge pull request #14771 from marioalexis84/fem-python_base_class
Fem: Create own base class for Python objects - fixes #14637
2024-06-22 13:13:14 -05:00
jffmichi
1c9d71502a Path: replace import of PySide2 with PySide 2024-06-22 08:17:16 -05:00
sliptonic
2c9b7db705 fix regression with adding TC to job 2024-06-22 08:16:33 -05:00
sliptonic
cb23383526 Fixing 'red ink' bugs in CAM
fixes:  https://github.com/Ondsel-Development/FreeCAD/issues/93
fixes https://github.com/Ondsel-Development/FreeCAD/issues/87
fixes https://github.com/Ondsel-Development/FreeCAD/issues/88


fix threadmilling error if not proper tool
fix vcarve error if no proper tool
fix probe error if no proper tool
fix deburr error if no base geometry
Fix adaptive op error if no base geometry
2024-06-22 08:16:33 -05:00
sliptonic
c9db224412 fixes #14765 (#14814) 2024-06-22 08:15:25 -05:00
Chris Hennes
f11af4f2a5 Gui: Silence unused variable 2024-06-22 08:29:27 +02:00
marioalexis
863668ecd4 Fem: Remove selection observer - fixes #14001 2024-06-21 19:28:12 -05:00
marioalexis
3a08324f92 Fem: Create own base class for Python Material objects 2024-06-21 19:26:18 -05:00
marioalexis
449f9b9be8 Fem: Create own base class for Python Mesh objects 2024-06-21 19:26:18 -05:00
marioalexis
2bb2160fa2 Fem: Create own base class for Python Element objects 2024-06-21 19:26:18 -05:00
marioalexis
b485c3fcd6 Fem: Avoid unnecessary method overriding 2024-06-21 19:26:18 -05:00
Chris Hennes
bac074e37d Addon Manager: Remember scroll position on Back (#14753)
* Addon Manager: Remember scroll position on Back

* Addon Manager: Linter cleanup
2024-06-21 14:53:56 -05:00
wmayer
06b464a9b0 Import: Simplify handling of Resource_FormatType
The type Resource_FormatType already exists since 2015. So, its usage doesn't require pre-processor macros everywhere.
2024-06-21 12:00:38 -05:00